13734 2007-05-15 11:06:53 -0700 svn-create-patch could check for most obvious mistakes in patches 2021-03-15 03:27:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) PC OS X 10.4 RESOLVED CONFIGURATION CHANGED P3 Enhancement --- 1 kkinnunen webkit-unassigned ddkilzer oldest_to_newest 9908 0 kkinnunen 2007-05-15 11:06:53 -0700 The svn-create-patch chould check for the most obvious mistakes in the patches it creates. The tool could for example warn the author for the mistakes. A warning could be printed on at least following mistakes: - Tabs present in the modifications - Modifying files in a directory which would require ChangeLog entry 9912 1 kkinnunen 2007-05-15 11:24:03 -0700 I don't know if it'd be useful to others, but I'll probably save following locally: Index: WebKitTools/Scripts/svn-create-patch =================================================================== --- WebKitTools/Scripts/svn-create-patch (revision 21458) +++ WebKitTools/Scripts/svn-create-patch (working copy) @@ -228,6 +228,10 @@ sub generateDiff($$$) close DIFF; $patch = fixChangeLogPatch($patch) if basename($file) eq "ChangeLog"; print $patch if $patch; + if ($patch =~ /^\+(\t|!\+.*\t)/mg ) { + print STDERR "Warning: changes in file '$file' contain tab characters.\n"; + } + if ($isBinary) { print "\n" if ($patch && $patch =~ m/\n\S+$/m); outputBinaryContent($file); 9863 2 ddkilzer 2007-05-15 22:45:06 -0700 Yes, that does make sense!