137332 2014-10-01 20:09:38 -0700 Clean up loops in CSSGradientValue.cpp 2014-10-02 11:35:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137171 1 cabanier cabanier commit-queue oldest_to_newest 1038764 0 cabanier 2014-10-01 20:09:38 -0700 Move a couple of routines to C++11 and fix the grammar in one of the comments 1038766 1 239081 cabanier 2014-10-01 20:18:02 -0700 Created attachment 239081 Patch 1038894 2 239081 kling 2014-10-02 10:35:03 -0700 Comment on attachment 239081 Patch Beautiful! r=me 1038900 3 cabanier 2014-10-02 10:59:58 -0700 (In reply to comment #2) > (From update of attachment 239081 [details]) > Beautiful! r=me Yeah! I need to read up on C++11. But this and the in-place initializers in a class are really nice. 1038911 4 239081 commit-queue 2014-10-02 11:35:33 -0700 Comment on attachment 239081 Patch Clearing flags on attachment: 239081 Committed r174222: <http://trac.webkit.org/changeset/174222> 1038912 5 commit-queue 2014-10-02 11:35:35 -0700 All reviewed patches have been landed. Closing bug. 239081 2014-10-01 20:18:02 -0700 2014-10-02 11:35:32 -0700 Patch bug-137332-20141001201803.patch text/plain 3461 cabanier SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDE5NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEwLTAxICBSaWsgQ2Fi YW5pZXIgIDxjYWJhbmllckBhZG9iZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAgbG9vcHMgaW4g Q1NTR3JhZGllbnRWYWx1ZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNzMzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcGF0Y2ggY2xlYW5zIHVwIGEgY291cGxlIG9mIGZvciBsb29wcyBi eSB1c2luZyBDKysxMSBzeW50YXggYW5kCisgICAgICAgIGZpeGVzIHNvbWUgZ3JhbW1hciBpbiBh IGNvbW1lbnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisK KyAgICAgICAgKiBjc3MvQ1NTR3JhZGllbnRWYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD U1NHcmFkaWVudFZhbHVlOjpncmFkaWVudFdpdGhTdHlsZXNSZXNvbHZlZCk6IE1vdmUgZm9yIGxv b3BzIHRvIEMrKzExLgorICAgICAgICAoV2ViQ29yZTo6Q1NTR3JhZGllbnRWYWx1ZTo6YWRkU3Rv cHMpOiBVcGRhdGUgZ3JhbW1hciBpbiBjb21tZW50IGZvciBncmFkaWVudCBtaWRwb2ludHMuCisK IDIwMTQtMTAtMDEgIFJpayBDYWJhbmllciAgPGNhYmFuaWVyQGFkb2JlLmNvbT4KIAogICAgICAg ICBBZGQgc3VwcG9ydCBmb3IgbWlkcG9pbnQgdG8gQ1NTIGdyYWRpZW50cwpJbmRleDogU291cmNl L1dlYkNvcmUvY3NzL0NTU0dyYWRpZW50VmFsdWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NHcmFkaWVudFZhbHVlLmNwcAkocmV2aXNpb24gMTc0MTk0KQorKysgU291 cmNlL1dlYkNvcmUvY3NzL0NTU0dyYWRpZW50VmFsdWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MDcsOSArMTA3LDkgQEAgc3RydWN0IEdyYWRpZW50U3RvcCB7CiBQYXNzUmVmUHRyPENTU0dyYWRp ZW50VmFsdWU+IENTU0dyYWRpZW50VmFsdWU6OmdyYWRpZW50V2l0aFN0eWxlc1Jlc29sdmVkKFN0 eWxlUmVzb2x2ZXIqIHN0eWxlUmVzb2x2ZXIpCiB7CiAgICAgYm9vbCBkZXJpdmVkID0gZmFsc2U7 Ci0gICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1fc3RvcHMuc2l6ZSgpOyBpKyspIHsKLSAg ICAgICAgaWYgKCFtX3N0b3BzW2ldLmlzTWlkcG9pbnQgJiYgc3R5bGVSZXNvbHZlci0+Y29sb3JG cm9tUHJpbWl0aXZlVmFsdWVJc0Rlcml2ZWRGcm9tRWxlbWVudChtX3N0b3BzW2ldLm1fY29sb3Iu Z2V0KCkpKSB7Ci0gICAgICAgICAgICBtX3N0b3BzW2ldLm1fY29sb3JJc0Rlcml2ZWRGcm9tRWxl bWVudCA9IHRydWU7CisgICAgZm9yIChhdXRvJiBzdG9wIDogbV9zdG9wcykgeworICAgICAgICBp ZiAoIXN0b3AuaXNNaWRwb2ludCAmJiBzdHlsZVJlc29sdmVyLT5jb2xvckZyb21QcmltaXRpdmVW YWx1ZUlzRGVyaXZlZEZyb21FbGVtZW50KHN0b3AubV9jb2xvci5nZXQoKSkpIHsKKyAgICAgICAg ICAgIHN0b3AubV9jb2xvcklzRGVyaXZlZEZyb21FbGVtZW50ID0gdHJ1ZTsKICAgICAgICAgICAg IGRlcml2ZWQgPSB0cnVlOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KQEAgLTEyNyw5 ICsxMjcsOSBAQCBQYXNzUmVmUHRyPENTU0dyYWRpZW50VmFsdWU+IENTU0dyYWRpZW50CiAgICAg ICAgIHJldHVybiAwOwogICAgIH0KIAotICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCByZXN1 bHQtPm1fc3RvcHMuc2l6ZSgpOyBpKyspIHsKLSAgICAgICAgaWYgKCFyZXN1bHQtPm1fc3RvcHNb aV0uaXNNaWRwb2ludCkKLSAgICAgICAgICAgIHJlc3VsdC0+bV9zdG9wc1tpXS5tX3Jlc29sdmVk Q29sb3IgPSBzdHlsZVJlc29sdmVyLT5jb2xvckZyb21QcmltaXRpdmVWYWx1ZShyZXN1bHQtPm1f c3RvcHNbaV0ubV9jb2xvci5nZXQoKSk7CisgICAgZm9yIChhdXRvJiBzdG9wIDogcmVzdWx0LT5t X3N0b3BzKSB7CisgICAgICAgIGlmICghc3RvcC5pc01pZHBvaW50KQorICAgICAgICAgICAgc3Rv cC5tX3Jlc29sdmVkQ29sb3IgPSBzdHlsZVJlc29sdmVyLT5jb2xvckZyb21QcmltaXRpdmVWYWx1 ZShzdG9wLm1fY29sb3IuZ2V0KCkpOwogICAgIH0KIAogICAgIHJldHVybiByZXN1bHQucmVsZWFz ZSgpOwpAQCAtMjc2LDkgKzI3Niw5IEBAIHZvaWQgQ1NTR3JhZGllbnRWYWx1ZTo6YWRkU3RvcHMo R3JhZGllbnQKICAgICAvLyBlbHNlIGFkZCA2IHN0b3BzIHRvIHRoZSBsZWZ0IGFuZCAyIHRvIHRo ZSByaWdodC4KICAgICAvLyBTdG9wcyBvbiB0aGUgc2lkZSB3aXRoIHRoZSBtb3N0IHN0b3BzIHN0 YXJ0IG1pZHdheSBiZWNhdXNlIHRoZSBjdXJ2ZSBhcHByb3hpbWF0ZXMKICAgICAvLyBhIGxpbmUg aW4gdGhhdCByZWdpb24uIFdlIHRoZW4gYWRkIDUgbW9yZSBjb2xvciBzdG9wcyBvbiB0aGF0IHNp ZGUgdG8gbWluaW1pemUgdGhlIGNoYW5nZQotICAgIC8vIGhvdyB0aGUgbHVtaW5hbmNlIGNoYW5n ZXMgYXQgZWFjaCBvZiB0aGUgY29sb3JzdG9wcy4gV2UgZG9uJ3QgaGF2ZSB0byBhZGQgYXMgbWFu eSBvbiB0aGUgb3RoZXIgc2lkZQotICAgIC8vIHNpbmNlIGl0IGJlY29tZXMgc21hbGwgd2hpY2gg aW5jcmVhc2VzIHRoZSBkaWZmZXJlbnRhdGlvbiBvZiBsdW1pbmFuY2Ugd2hpY2ggaGlkZXMgdGhl IGNvbG9yc3RvcHMuCi0gICAgLy8gRXZlbiB3aXRoIDQgZXh0cmEgY29sb3JzdG9wcywgaXQgKmlz KiBwb3NzaWJsZSB0byBkaXNjZXJuIHRoZSBzdGVwcyB3aGVuIHRoZSBncmFkaWVudCBpcyBsYXJn ZSBhbmQgaGFzCisgICAgLy8gaG93IHRoZSBsdW1pbmFuY2UgY2hhbmdlcyBhdCBlYWNoIG9mIHRo ZSBjb2xvciBzdG9wcy4gV2UgZG9uJ3QgaGF2ZSB0byBhZGQgYXMgbWFueSBvbiB0aGUgb3RoZXIg c2lkZQorICAgIC8vIHNpbmNlIGl0IGJlY29tZXMgc21hbGwgd2hpY2ggaW5jcmVhc2VzIHRoZSBk aWZmZXJlbnRhdGlvbiBvZiBsdW1pbmFuY2Ugd2hpY2ggaGlkZXMgdGhlIGNvbG9yIHN0b3BzLgor ICAgIC8vIEV2ZW4gd2l0aCA0IGV4dHJhIGNvbG9yIHN0b3BzLCBpdCAqaXMqIHBvc3NpYmxlIHRv IGRpc2Nlcm4gdGhlIHN0ZXBzIHdoZW4gdGhlIGdyYWRpZW50IGlzIGxhcmdlIGFuZCBoYXMKICAg ICAvLyBsYXJnZSBsdW1pbmFuY2UgZGlmZmVyZW5jZXMgYmV0d2VlbiBtaWRwb2ludCBhbmQgY29s b3Igc3RvcC4gSWYgdGhpcyBiZWNvbWVzIGFuIGlzc3VlLCB3ZSBjYW4gY29uc2lkZXIKICAgICAv LyBtYWtpbmcgdGhpcyBhbGdvcml0aG0gYSBiaXQgc21hcnRlci4KIAo=