137329 2014-10-01 18:48:56 -0700 REGRESSION(r174187): webkitpy failures, and thorton says the patch is wrong (Requested by dethbakin on #webkit). 2014-10-01 23:40:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 commit-queue commit-queue bdakin bfulgham dbates roger_fong thorton oldest_to_newest 1038748 0 commit-queue 2014-10-01 18:48:56 -0700 http://trac.webkit.org/changeset/174187 broke the build: webkitpy failures, and thorton says the patch is wrong (Requested by dethbakin on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1038749 1 239076 commit-queue 2014-10-01 18:49:15 -0700 Created attachment 239076 ROLLOUT of r174187 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1038750 2 239076 commit-queue 2014-10-01 18:58:46 -0700 Comment on attachment 239076 ROLLOUT of r174187 Clearing flags on attachment: 239076 Committed r174194: <http://trac.webkit.org/changeset/174194> 1038751 3 commit-queue 2014-10-01 18:58:48 -0700 All reviewed patches have been landed. Closing bug. 1038752 4 thorton 2014-10-01 18:59:33 -0700 Roger, please try again without the whole bit about WebKit2, which doesn't apply at all on Windows, and with rebaselined webkitpy tests. 1038771 5 ap 2014-10-01 21:34:53 -0700 This rollout broke a webkitpy test: <https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20(Tests)/builds/8355/steps/webkitpy-test/logs/stdio> 1038772 6 thorton 2014-10-01 21:41:21 -0700 What? That was the test that was failing that inspired this rollout... 1038775 7 dbates 2014-10-01 22:10:41 -0700 (In reply to comment #6) > What? That was the test that was failing that inspired this rollout... No, this isn't the same test. Prior to the landing of the rollout patch in <http://trac.webkit.org/changeset/174194>, the test PortTestCase.test_default_timeout_ms() was failing (*). At the time of writing the test WinPortTest. test_default_timeout_ms() is failing (see comment #5 for a hyperlink to the stdio log). Notice that Brent Fulgham committed <http://trac.webkit.org/changeset/174192> to fix the unit test that failed following <http://trac.webkit.org/changeset/174187>. And <http://trac.webkit.org/changeset/174194> only rolled out <http://trac.webkit.org/changeset/174187>. That is, it did not roll out <http://trac.webkit.org/changeset/174192>. Therefore, test WinPortTest. test_default_timeout_ms(), committed in <http://trac.webkit.org/changeset/174192>, is failing. (*) <https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29/builds/8347/steps/webkitpy-test/logs/stdio> 1038776 8 dbates 2014-10-01 22:15:41 -0700 I'll roll out <http://trac.webkit.org/changeset/174192> per Tim Horton's remark in comment #5 that there are correctness issue with the patch that landed <http://trac.webkit.org/changeset/174187> with regards to WebKit2 on Window. 1038779 9 dbates 2014-10-01 22:27:33 -0700 Rolled out <http://trac.webkit.org/changeset/174192> in <http://trac.webkit.org/changeset/174198>. 1038784 10 thorton 2014-10-01 22:56:42 -0700 Ah, I see. Nearly but not quite the same. Thanks for rolling out. 1038799 11 roger_fong 2014-10-01 23:36:02 -0700 Sorry about that. I've been in an over zealous rush mode trying to deal with these windows bots and then getting more failures thrown at my face as soon as I think I'm almost finally done being stomped on by them. I'll be more careful next time. 1038800 12 roger_fong 2014-10-01 23:40:40 -0700 Oddly, the test failures that inspired me to attempt to make this change in the first place no longer seem to be there...and the bots have already ran than the tests with the rollouts incorporated...so I guess I'll count that as a win... 239076 2014-10-01 18:49:15 -0700 2014-10-01 18:58:46 -0700 ROLLOUT of r174187 bug-137329-20141001184916.patch text/plain 1590 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MTkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWExMDdkMTMyNzI1MWMyMDZjZjZlMzQ3ZGI3ZWVjZWJl NTcyMmNmNS4uYzQwZDk0NzNlNTUxYmFhMGE0YzIyZjYxNTA4ZTc3MjRjNmQ1MDNmNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE0LTEwLTAxICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K KworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTc0MTg3LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3MzI5CisKKyAgICAgICAgd2Vi a2l0cHkgZmFpbHVyZXMsIGFuZCB0aG9ydG9uIHNheXMgdGhlIHBhdGNoIGlzIHdyb25nCisgICAg ICAgIChSZXF1ZXN0ZWQgYnkgZGV0aGJha2luIG9uICN3ZWJraXQpLgorCisgICAgICAgIFJldmVy dGVkIGNoYW5nZXNldDoKKworICAgICAgICAiW1dpbmRvd3NdIEluY3JlYXNlIGxheW91dCB0ZXN0 IHRpbWVvdXQgZm9yIFdpbmRvd3MgZm9sbG93aW5nCisgICAgICAgIHIxNzQxNjIuIgorICAgICAg ICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNzQxODcKKwogMjAxNC0xMC0wMSAg QnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBUZXN0IGZpeCBh ZnRlciByMTc0MTg3CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2lu LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQppbmRleCA0Yjk2NmNiYjlk MGVjMDZhY2JiZDdhMzhlMjg5MDJlYzQxYjQ1YWNhLi5jZmUyMWNkM2Y3M2MxMTM1NjljY2YzNjli MGVlYWJiZDI4MmQzYWJiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv d2luLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkKQEAgLTkwLDEz ICs5MCw2IEBAIGNsYXNzIFdpblBvcnQoQXBwbGVQb3J0KToKICAgICAgICAgZmFsbGJhY2tfbmFt ZXMuZXh0ZW5kKFsnbWFjLW1vdW50YWlubGlvbicsICdtYWMnXSkKICAgICAgICAgcmV0dXJuIG1h cChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCwgZmFsbGJhY2tfbmFtZXMpCiAKLSAgICBkZWYg ZGVmYXVsdF90aW1lb3V0X21zKHNlbGYpOgotICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oJ3dl YmtpdF90ZXN0X3J1bm5lcicpOgotICAgICAgICAgICAgIyBBZGQgc29tZSBtb3JlIHRpbWUgdG8g V2ViS2l0VGVzdFJ1bm5lciBiZWNhdXNlIGl0IG5lZWRzIHRvIHN5bmNyb25pc2UgdGhlIHN0YXRl Ci0gICAgICAgICAgICAjIHdpdGggdGhlIHdlYiBwcm9jZXNzIGFuZCB3ZSB3YW50IHRvIGRldGVj dCBpZiB0aGVyZSBpcyBhIHByb2JsZW0gd2l0aCB0aGF0IGluIHRoZSBkcml2ZXIuCi0gICAgICAg ICAgICByZXR1cm4gMTAwICogMTAwMAotICAgICAgICByZXR1cm4gNTAgKiAxMDAwCi0KICAgICBk ZWYgb3BlcmF0aW5nX3N5c3RlbShzZWxmKToKICAgICAgICAgcmV0dXJuICd3aW4nCiAK