137323 2014-10-01 16:35:05 -0700 Fail better when is<>() / downcast<>() is used for an unsupported type 2014-10-01 19:22:04 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin cmarcelo commit-queue gyuyoung.kim kling mmaxfield oldest_to_newest 1038712 0 cdumez 2014-10-01 16:35:05 -0700 We should fail better when is<>() / downcast<>() is used for an unsupported type (i.e. a type that doesn't have the needed TypeCastTraits template specialization). Currently, we get an obscure linking error, which is sub-optimal. 1038716 1 239067 cdumez 2014-10-01 16:52:17 -0700 Created attachment 239067 Patch 1038721 2 239067 cdumez 2014-10-01 16:56:09 -0700 Comment on attachment 239067 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239067&action=review > Source/WTF/wtf/TypeCasts.h:42 > + static_assert(std::is_void<ExpectedType>::value, "Missing TypeCastTraits specialization"); I cannot use a static_assert(false, ""); because the compiler would then evaluate it and fail the build even if this template was not instantiated. By having the static_assert() depend on the template parameter type, I avoid that issue and we hit the static_assert() only if this is actually instantiated. And this one is only instantiated if there is no specialization for the type. 1038744 3 239067 commit-queue 2014-10-01 18:18:51 -0700 Comment on attachment 239067 Patch Clearing flags on attachment: 239067 Committed r174193: <http://trac.webkit.org/changeset/174193> 1038745 4 commit-queue 2014-10-01 18:18:57 -0700 All reviewed patches have been landed. Closing bug. 1038753 5 gyuyoung.kim 2014-10-01 19:02:06 -0700 EFL port has been broken since r174193. https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/16694 1038755 6 cdumez 2014-10-01 19:22:04 -0700 (In reply to comment #5) > EFL port has been broken since r174193. > > https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/16694 Build fix landed in <http://trac.webkit.org/changeset/174195> 239067 2014-10-01 16:52:17 -0700 2014-10-01 18:18:51 -0700 Patch bug-137323-20141001165218.patch text/plain 2292 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNkZGEwNWNhYmUzZTRiMGYxODA5YTI2 MDc2MjQwNzExYjM5MWUyZTEuLjg3ZDkxNDc1MDAzYzczMjEyZmYzZmY4YjJhOWU0MGEzYWFhODQ3 YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTQtMTAtMDEgIENocmlzdG9waGUgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIEZhaWwgYmV0dGVyIHdoZW4gaXM8PigpIC8gZG93 bmNhc3Q8PigpIGlzIHVzZWQgZm9yIGFuIHVuc3VwcG9ydGVkIHR5cGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzMyMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBmYWlsIGJldHRlciB3 aGVuIGlzPD4oKSAvIGRvd25jYXN0PD4oKSBpcyB1c2VkIGZvciBhbgorICAgICAgICB1bnN1cHBv cnRlZCB0eXBlIChpLmUuIGEgdHlwZSB0aGF0IGRvZXNuJ3QgaGF2ZSB0aGUgbmVlZGVkCisgICAg ICAgIFR5cGVDYXN0VHJhaXRzIHRlbXBsYXRlIHNwZWNpYWxpemF0aW9uKS4gUHJldmlvdXNseSwg d2Ugd291bGQgZ2V0IGFuCisgICAgICAgIG9ic2N1cmUgbGlua2luZyBlcnJvciwgd2hpY2ggd2Fz IHN1Yi1vcHRpbWFsLgorCisgICAgICAgIFdpdGggdGhpcyBwYXRjaCwgeW91IHdvdWxkIG5vdyBo aXQgYSBzdGF0aWNfYXNzZXJ0KCkgYXQgYnVpbGQgdGltZSBpZgorICAgICAgICB5b3UgdHJpZWQg dG8gdXNlIGlzPD4oKSAvIGRvd25jYXN0PD4oKSBmb3IgYSB0eXBlIHRoYXQgZGlkIG5vdCBoYXZl IHRoZQorICAgICAgICBuZWVkZWQgdGVtcGxhdGUgc3BlY2lhbGl6YXRpb24uIFRoZXJlIGlzIGFs c28gYSBoZWxwZnVsIGNvbW1lbnQgYWJvdmUKKyAgICAgICAgdGhlIGFzc2VydGlvbiBsZXR0aW5n IHRoZSBkZXZlbG9wZXIga25vdyBob3cgdG8gYWRkIHRoZSBuZWVkZWQgdGVtcGxhdGUKKyAgICAg ICAgc3BlY2lhbGl6YXRpb24uCisKKyAgICAgICAgKiB3dGYvVHlwZUNhc3RzLmg6CisgICAgICAg IChXVEY6OlR5cGVDYXN0VHJhaXRzOjppc09mVHlwZSk6CisKIDIwMTQtMTAtMDEgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEF0dGVtcHQgdG8gZml4IHRoZSBi dWlsZCBhZnRlciA8aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE3NDE4MD4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1R5cGVDYXN0cy5oIGIvU291cmNlL1dURi93dGYvVHlw ZUNhc3RzLmgKaW5kZXggZTA1MGQxNzdlNWU5OTRkYWNhODk4MzYzNTY3OTE5MWJlNzg2YzE4MC4u MzNkYjZhZjJjNzIxOWNlOTQ0MGU1YjI3Y2M5N2M4MzZmNzczYWU1OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvVHlwZUNhc3RzLmgKKysrIGIvU291cmNlL1dURi93dGYvVHlwZUNhc3RzLmgK QEAgLTI2LDExICsyNiwyMSBAQAogI2lmbmRlZiBUeXBlQ2FzdHNfaAogI2RlZmluZSBUeXBlQ2Fz dHNfaAogCisjaW5jbHVkZSA8dHlwZV90cmFpdHM+CisKIG5hbWVzcGFjZSBXVEYgewogCiB0ZW1w bGF0ZSA8dHlwZW5hbWUgRXhwZWN0ZWRUeXBlLCB0eXBlbmFtZSBBcmdUeXBlPgogc3RydWN0IFR5 cGVDYXN0VHJhaXRzIHsKLSAgICBzdGF0aWMgYm9vbCBpc09mVHlwZShBcmdUeXBlJik7CisgICAg c3RhdGljIGJvb2wgaXNPZlR5cGUoQXJnVHlwZSYpCisgICAgeworICAgICAgICAvLyBJZiB5b3Un cmUgaGl0dGluZyB0aGlzIGFzc2VydGlvbiwgaXQgaXMgbGlrZWx5IGJlY2F1c2UgeW91IHVzZWQK KyAgICAgICAgLy8gaXM8PigpIG9yIGRvd25jYXN0PD4oKSB3aXRoIGEgdHlwZSB0aGF0IGRvZXNu J3QgaGF2ZSB0aGUgbmVlZGVkCisgICAgICAgIC8vIFR5cGVDYXN0VHJhaXRzIHNwZWNpYWxpemF0 aW9uLiBQbGVhc2UgdXNlIHRoZSBmb2xsb3dpbmcgbWFjcm8KKyAgICAgICAgLy8gdG8gYWRkIHRo YXQgc3BlY2lhbGl6YXRpb246CisgICAgICAgIC8vIFNQRUNJQUxJWkVfVFlQRV9UUkFJVFNfQkVH SU4oKSAvIFNQRUNJQUxJWkVfVFlQRV9UUkFJVFNfRU5EKCkKKyAgICAgICAgc3RhdGljX2Fzc2Vy dChzdGQ6OmlzX3ZvaWQ8RXhwZWN0ZWRUeXBlPjo6dmFsdWUsICJNaXNzaW5nIFR5cGVDYXN0VHJh aXRzIHNwZWNpYWxpemF0aW9uIik7CisgICAgfQogfTsKIAogdGVtcGxhdGUgPHR5cGVuYW1lIEV4 cGVjdGVkVHlwZT4K