137318 2014-10-01 15:29:41 -0700 Use is<>() / downcast<>() for File 2014-10-01 21:10:45 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137056 1 cdumez cdumez benjamin commit-queue kling rniwa oldest_to_newest 1038679 0 cdumez 2014-10-01 15:29:41 -0700 Use is<>() / downcast<>() for File instead of isFile() / toFile(). 1038681 1 239057 cdumez 2014-10-01 15:34:29 -0700 Created attachment 239057 Patch 1038767 2 239057 gyuyoung.kim 2014-10-01 20:34:37 -0700 Comment on attachment 239057 Patch LGTM. rs=me. 1038769 3 239057 commit-queue 2014-10-01 21:10:40 -0700 Comment on attachment 239057 Patch Clearing flags on attachment: 239057 Committed r174197: <http://trac.webkit.org/changeset/174197> 1038770 4 commit-queue 2014-10-01 21:10:45 -0700 All reviewed patches have been landed. Closing bug. 239057 2014-10-01 15:34:29 -0700 2014-10-01 21:10:40 -0700 Patch bug-137318-20141001153432.patch text/plain 6748 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWM4ZWIyNjY1ODQ0Y2Ux OTU4ZDM1NmQ4YzI0YTEyMzJkZDdlNWQ5NS4uYjI5ZGVkY2M4ODk5MmE2OTUyMGJiODM3N2QxMGZj OWVmN2NhM2MyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTEwLTAxICBDaHJp c3RvcGhlIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgaXM8PigpIC8g ZG93bmNhc3Q8PigpIGZvciBGaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzczMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVc2UgaXM8PigpIC8gZG93bmNhc3Q8PigpIGZvciBGaWxlIGluc3RlYWQg b2YgaXNGaWxlKCkgLyB0b0ZpbGUoKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2 aW9yIGNoYW5nZS4KKworICAgICAgICAqIGZpbGVhcGkvQmxvYi5oOgorICAgICAgICAqIGZpbGVh cGkvRmlsZS5oOgorICAgICAgICAoaXNUeXBlKToKKyAgICAgICAgKiBmaWxlYXBpL0ZpbGVSZWFk ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RmlsZVJlYWRlcjo6cmVhZEFzQXJyYXlCdWZmZXIp OgorICAgICAgICAoV2ViQ29yZTo6RmlsZVJlYWRlcjo6cmVhZEFzQmluYXJ5U3RyaW5nKToKKyAg ICAgICAgKFdlYkNvcmU6OkZpbGVSZWFkZXI6OnJlYWRBc1RleHQpOgorICAgICAgICAoV2ViQ29y ZTo6RmlsZVJlYWRlcjo6cmVhZEFzRGF0YVVSTCk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29y ay9Gb3JtRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb3JtRGF0YTo6YXBwZW5kS2V5VmFs dWVQYWlySXRlbXMpOgorCiAyMDE0LTEwLTAxICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdh bGlhLmNvbT4KIAogICAgICAgICBbVGV4TWFwXSBTcHJpbmtsZSByYW5nZS1iYXNlZCBmb3ItbG9v cHMgaW4gR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIsIFRleHR1cmVNYXBwZXJMYXllcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9CbG9iLmggYi9Tb3VyY2UvV2ViQ29yZS9m aWxlYXBpL0Jsb2IuaAppbmRleCAyODYwYzEyY2Y0MGQ1YTE2ZDZkMDE1OGIyMDBhNTQ4Y2NlZTlj Nzk5Li5kZmZjYWQ2MWU2MDM1NzAzYTM5NThjYjk1YzQ1ZTIxYjIxZTlkNmI2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0Jsb2IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9maWxl YXBpL0Jsb2IuaApAQCAtMTEyLDkgKzExMiw2IEBAIHByb3RlY3RlZDoKICAgICBtdXRhYmxlIGxv bmcgbG9uZyBtX3NpemU7CiB9OwogCi0jZGVmaW5lIEJMT0JfVFlQRV9DQVNUUyhUb1ZhbHVlVHlw ZU5hbWUsIHByZWRpY2F0ZSkgXAotICAgIFRZUEVfQ0FTVFNfQkFTRShUb1ZhbHVlVHlwZU5hbWUs IEJsb2IsIGJsb2IsIGJsb2ItPnByZWRpY2F0ZSwgYmxvYi5wcmVkaWNhdGUpCi0KIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIEJsb2JfaApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZmlsZWFwaS9GaWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0ZpbGUuaAppbmRl eCAxZjRiYmU3ODRhNjA1NDAwYmVhMTliYTlkOWI2YTdmODRhYzYwYWU1Li5iZDE2YTQ3ZmExYTZm Mzg3NTYwZjQxZjQzMTY4NTU0Yzg2MDJjNDNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9m aWxlYXBpL0ZpbGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0ZpbGUuaApAQCAtMjgs NiArMjgsNyBAQAogCiAjaW5jbHVkZSAiQmxvYi5oIgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRy Lmg+CisjaW5jbHVkZSA8d3RmL1R5cGVDYXN0cy5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0 cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC04Myw4ICs4NCwxMCBAQCBwcml2YXRl OgogICAgIFN0cmluZyBtX25hbWU7CiB9OwogCi1CTE9CX1RZUEVfQ0FTVFMoRmlsZSwgaXNGaWxl KCkpCi0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAorU1BFQ0lBTElaRV9UWVBFX1RSQUlUU19C RUdJTihXZWJDb3JlOjpGaWxlKQorICAgIHN0YXRpYyBib29sIGlzVHlwZShjb25zdCBXZWJDb3Jl OjpCbG9iJiBibG9iKSB7IHJldHVybiBibG9iLmlzRmlsZSgpOyB9CitTUEVDSUFMSVpFX1RZUEVf VFJBSVRTX0VORCgpCisKICNlbmRpZiAvLyBGaWxlX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2ZpbGVhcGkvRmlsZVJlYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0ZpbGVS ZWFkZXIuY3BwCmluZGV4IDZlZWZiNjI0MzJmNjA1MmNkZjA2OTBhMzY0MmRiMTk5MzE1MWQ0Y2Yu LjYxMzY2OGJkY2NiZGU3NDkzZGY0MThkZWZkY2I2ZjNiOGMwOWU3YzYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2ZpbGVhcGkvRmlsZVJlYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZmlsZWFwaS9GaWxlUmVhZGVyLmNwcApAQCAtODEsNyArODEsNyBAQCB2b2lkIEZpbGVSZWFkZXI6 OnJlYWRBc0FycmF5QnVmZmVyKEJsb2IqIGJsb2IsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgIGlm ICghYmxvYikKICAgICAgICAgcmV0dXJuOwogCi0gICAgTE9HKEZpbGVBUEksICJGaWxlUmVhZGVy OiByZWFkaW5nIGFzIGFycmF5IGJ1ZmZlcjogJXMgJXNcbiIsIGJsb2ItPnVybCgpLnN0cmluZygp LnV0ZjgoKS5kYXRhKCksIGJsb2ItPmlzRmlsZSgpID8gdG9GaWxlKGJsb2IpLT5wYXRoKCkudXRm OCgpLmRhdGEoKSA6ICIiKTsKKyAgICBMT0coRmlsZUFQSSwgIkZpbGVSZWFkZXI6IHJlYWRpbmcg YXMgYXJyYXkgYnVmZmVyOiAlcyAlc1xuIiwgYmxvYi0+dXJsKCkuc3RyaW5nKCkudXRmOCgpLmRh dGEoKSwgaXM8RmlsZT4oYmxvYikgPyBkb3duY2FzdDxGaWxlPigqYmxvYikucGF0aCgpLnV0Zjgo KS5kYXRhKCkgOiAiIik7CiAKICAgICByZWFkSW50ZXJuYWwoYmxvYiwgRmlsZVJlYWRlckxvYWRl cjo6UmVhZEFzQXJyYXlCdWZmZXIsIGVjKTsKIH0KQEAgLTkxLDcgKzkxLDcgQEAgdm9pZCBGaWxl UmVhZGVyOjpyZWFkQXNCaW5hcnlTdHJpbmcoQmxvYiogYmxvYiwgRXhjZXB0aW9uQ29kZSYgZWMp CiAgICAgaWYgKCFibG9iKQogICAgICAgICByZXR1cm47CiAKLSAgICBMT0coRmlsZUFQSSwgIkZp bGVSZWFkZXI6IHJlYWRpbmcgYXMgYmluYXJ5OiAlcyAlc1xuIiwgYmxvYi0+dXJsKCkuc3RyaW5n KCkudXRmOCgpLmRhdGEoKSwgYmxvYi0+aXNGaWxlKCkgPyB0b0ZpbGUoYmxvYiktPnBhdGgoKS51 dGY4KCkuZGF0YSgpIDogIiIpOworICAgIExPRyhGaWxlQVBJLCAiRmlsZVJlYWRlcjogcmVhZGlu ZyBhcyBiaW5hcnk6ICVzICVzXG4iLCBibG9iLT51cmwoKS5zdHJpbmcoKS51dGY4KCkuZGF0YSgp LCBpczxGaWxlPihibG9iKSA/IGRvd25jYXN0PEZpbGU+KCpibG9iKS5wYXRoKCkudXRmOCgpLmRh dGEoKSA6ICIiKTsKIAogICAgIHJlYWRJbnRlcm5hbChibG9iLCBGaWxlUmVhZGVyTG9hZGVyOjpS ZWFkQXNCaW5hcnlTdHJpbmcsIGVjKTsKIH0KQEAgLTEwMSw3ICsxMDEsNyBAQCB2b2lkIEZpbGVS ZWFkZXI6OnJlYWRBc1RleHQoQmxvYiogYmxvYiwgY29uc3QgU3RyaW5nJiBlbmNvZGluZywgRXhj ZXB0aW9uQ29kZSYgZQogICAgIGlmICghYmxvYikKICAgICAgICAgcmV0dXJuOwogCi0gICAgTE9H KEZpbGVBUEksICJGaWxlUmVhZGVyOiByZWFkaW5nIGFzIHRleHQ6ICVzICVzXG4iLCBibG9iLT51 cmwoKS5zdHJpbmcoKS51dGY4KCkuZGF0YSgpLCBibG9iLT5pc0ZpbGUoKSA/IHRvRmlsZShibG9i KS0+cGF0aCgpLnV0ZjgoKS5kYXRhKCkgOiAiIik7CisgICAgTE9HKEZpbGVBUEksICJGaWxlUmVh ZGVyOiByZWFkaW5nIGFzIHRleHQ6ICVzICVzXG4iLCBibG9iLT51cmwoKS5zdHJpbmcoKS51dGY4 KCkuZGF0YSgpLCBpczxGaWxlPihibG9iKSA/IGRvd25jYXN0PEZpbGU+KCpibG9iKS5wYXRoKCku dXRmOCgpLmRhdGEoKSA6ICIiKTsKIAogICAgIG1fZW5jb2RpbmcgPSBlbmNvZGluZzsKICAgICBy ZWFkSW50ZXJuYWwoYmxvYiwgRmlsZVJlYWRlckxvYWRlcjo6UmVhZEFzVGV4dCwgZWMpOwpAQCAt MTE3LDcgKzExNyw3IEBAIHZvaWQgRmlsZVJlYWRlcjo6cmVhZEFzRGF0YVVSTChCbG9iKiBibG9i LCBFeGNlcHRpb25Db2RlJiBlYykKICAgICBpZiAoIWJsb2IpCiAgICAgICAgIHJldHVybjsKIAot ICAgIExPRyhGaWxlQVBJLCAiRmlsZVJlYWRlcjogcmVhZGluZyBhcyBkYXRhIFVSTDogJXMgJXNc biIsIGJsb2ItPnVybCgpLnN0cmluZygpLnV0ZjgoKS5kYXRhKCksIGJsb2ItPmlzRmlsZSgpID8g dG9GaWxlKGJsb2IpLT5wYXRoKCkudXRmOCgpLmRhdGEoKSA6ICIiKTsKKyAgICBMT0coRmlsZUFQ SSwgIkZpbGVSZWFkZXI6IHJlYWRpbmcgYXMgZGF0YSBVUkw6ICVzICVzXG4iLCBibG9iLT51cmwo KS5zdHJpbmcoKS51dGY4KCkuZGF0YSgpLCBpczxGaWxlPihibG9iKSA/IGRvd25jYXN0PEZpbGU+ KCpibG9iKS5wYXRoKCkudXRmOCgpLmRhdGEoKSA6ICIiKTsKIAogICAgIHJlYWRJbnRlcm5hbChi bG9iLCBGaWxlUmVhZGVyTG9hZGVyOjpSZWFkQXNEYXRhVVJMLCBlYyk7CiB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRm9ybURhdGEuY3BwCmluZGV4IDI2M2FiMmFiN2ZiYmYy OWRmOWQ2ODg4NjQwY2Y4MmY2NjQxYjNiYWQuLjVmZDNiYjU0MGYwMzVmNjcyNjE1MTEyMTQ4ODgz YzQyZjE0YzBhYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Rm9ybURhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRm9ybURh dGEuY3BwCkBAIC0xODAsMTEgKzE4MCwxMSBAQCB2b2lkIEZvcm1EYXRhOjphcHBlbmRLZXlWYWx1 ZVBhaXJJdGVtcyhjb25zdCBGb3JtRGF0YUxpc3QmIGxpc3QsIGNvbnN0IFRleHRFbmNvZAogICAg ICAgICAgICAgLy8gSWYgdGhlIGN1cnJlbnQgdHlwZSBpcyBibG9iLCB0aGVuIHdlIGFsc28gbmVl ZCB0byBpbmNsdWRlIHRoZSBmaWxlbmFtZQogICAgICAgICAgICAgaWYgKHZhbHVlLmJsb2IoKSkg ewogICAgICAgICAgICAgICAgIFN0cmluZyBuYW1lOwotICAgICAgICAgICAgICAgIGlmICh2YWx1 ZS5ibG9iKCktPmlzRmlsZSgpKSB7Ci0gICAgICAgICAgICAgICAgICAgIEZpbGUqIGZpbGUgPSB0 b0ZpbGUodmFsdWUuYmxvYigpKTsKLSAgICAgICAgICAgICAgICAgICAgbmFtZSA9IGZpbGUtPm5h bWUoKTsKKyAgICAgICAgICAgICAgICBpZiAoaXM8RmlsZT4odmFsdWUuYmxvYigpKSkgeworICAg ICAgICAgICAgICAgICAgICBGaWxlJiBmaWxlID0gZG93bmNhc3Q8RmlsZT4oKnZhbHVlLmJsb2Io KSk7CisgICAgICAgICAgICAgICAgICAgIG5hbWUgPSBmaWxlLm5hbWUoKTsKICAgICAgICAgICAg ICAgICAgICAgLy8gTGV0IHRoZSBhcHBsaWNhdGlvbiBzcGVjaWZ5IGEgZmlsZW5hbWUgaWYgaXQn cyBnb2luZyB0byBnZW5lcmF0ZSBhIHJlcGxhY2VtZW50IGZpbGUgZm9yIHRoZSB1cGxvYWQuCi0g ICAgICAgICAgICAgICAgICAgIGNvbnN0IFN0cmluZyYgcGF0aCA9IGZpbGUtPnBhdGgoKTsKKyAg ICAgICAgICAgICAgICAgICAgY29uc3QgU3RyaW5nJiBwYXRoID0gZmlsZS5wYXRoKCk7CiAgICAg ICAgICAgICAgICAgICAgIGlmICghcGF0aC5pc0VtcHR5KCkpIHsKICAgICAgICAgICAgICAgICAg ICAgICAgIGlmIChQYWdlKiBwYWdlID0gZG9jdW1lbnQtPnBhZ2UoKSkgewogICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFN0cmluZyBnZW5lcmF0ZWRGaWxlTmFtZTsKQEAgLTIyMSwxMSArMjIx LDExIEBAIHZvaWQgRm9ybURhdGE6OmFwcGVuZEtleVZhbHVlUGFpckl0ZW1zKGNvbnN0IEZvcm1E YXRhTGlzdCYgbGlzdCwgY29uc3QgVGV4dEVuY29kCiAgICAgICAgICAgICAvLyBBcHBlbmQgYm9k eQogICAgICAgICAgICAgYXBwZW5kRGF0YShoZWFkZXIuZGF0YSgpLCBoZWFkZXIuc2l6ZSgpKTsK ICAgICAgICAgICAgIGlmICh2YWx1ZS5ibG9iKCkpIHsKLSAgICAgICAgICAgICAgICBpZiAodmFs dWUuYmxvYigpLT5pc0ZpbGUoKSkgewotICAgICAgICAgICAgICAgICAgICBGaWxlKiBmaWxlID0g dG9GaWxlKHZhbHVlLmJsb2IoKSk7CisgICAgICAgICAgICAgICAgaWYgKGlzPEZpbGU+KHZhbHVl LmJsb2IoKSkpIHsKKyAgICAgICAgICAgICAgICAgICAgRmlsZSYgZmlsZSA9IGRvd25jYXN0PEZp bGU+KCp2YWx1ZS5ibG9iKCkpOwogICAgICAgICAgICAgICAgICAgICAvLyBEbyBub3QgYWRkIHRo ZSBmaWxlIGlmIHRoZSBwYXRoIGlzIGVtcHR5LgotICAgICAgICAgICAgICAgICAgICBpZiAoIWZp bGUtPnBhdGgoKS5pc0VtcHR5KCkpCi0gICAgICAgICAgICAgICAgICAgICAgICBhcHBlbmRGaWxl KGZpbGUtPnBhdGgoKSwgc2hvdWxkR2VuZXJhdGVGaWxlKTsKKyAgICAgICAgICAgICAgICAgICAg aWYgKCFmaWxlLnBhdGgoKS5pc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgICAgICAgICBhcHBl bmRGaWxlKGZpbGUucGF0aCgpLCBzaG91bGRHZW5lcmF0ZUZpbGUpOwogICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgICAgIGFwcGVuZEJsb2Io dmFsdWUuYmxvYigpLT51cmwoKSk7Cg==