137271 2014-09-30 14:31:58 -0700 [TexMap] Sprinkle range-based for-loops in GraphicsLayerTextureMapper, TextureMapperLayer 2020-11-08 18:02:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cmarcelo commit-queue kondapallykalyan luiz mrobinson noam p.szymanski3 oldest_to_newest 1038350 0 zan 2014-09-30 14:31:58 -0700 [TexMap] Sprinkle range-based for-loops in GraphicsLayerTextureMapper, TextureMapperLayer 1038354 1 238963 zan 2014-09-30 14:33:53 -0700 Created attachment 238963 Patch 1038355 2 commit-queue 2014-09-30 14:35:34 -0700 Attachment 238963 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:642: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1038500 3 238963 svillar 2014-10-01 01:02:51 -0700 Comment on attachment 238963 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238963&action=review I love range based for loops. I guess the style issue is a false positive, time to report a bug? > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:644 > + }); Haven't seen this before in WK code. Is it an accepted C++11 feature? 1038524 4 238963 zan 2014-10-01 05:04:17 -0700 Comment on attachment 238963 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238963&action=review >> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:644 >> + }); > > Haven't seen this before in WK code. Is it an accepted C++11 feature? It's already used in a few places, for instance MediaSource.cpp. http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp I believe these utilities are an elegant replacement for manually writing out these idioms. The compilers are also smart enough to properly optimize the lambda expression. The only shortfall is the need to explicitly declare the start and end of the range, instead of being able to simply pass a range-like object to the function. 1038630 5 zan 2014-10-01 13:45:32 -0700 (In reply to comment #3) > (From update of attachment 238963 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238963&action=review > > I guess the style issue is a false positive, time to report a bug? > Reported bug #137309. 1038638 6 238963 zan 2014-10-01 13:53:30 -0700 Comment on attachment 238963 Patch Clearing flags on attachment: 238963 Committed r174168: <http://trac.webkit.org/changeset/174168> 1038639 7 zan 2014-10-01 13:53:39 -0700 All reviewed patches have been landed. Closing bug. 1705624 8 fujii 2020-11-08 18:02:53 -0800 *** Bug 124999 has been marked as a duplicate of this bug. *** 238963 2014-09-30 14:33:53 -0700 2014-10-01 13:53:30 -0700 Patch bug-137271-20140930143356.patch text/plain 7370 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDEyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE0LTA5LTMwICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbVGV4TWFwXSBTcHJpbmts ZSByYW5nZS1iYXNlZCBmb3ItbG9vcHMgaW4gR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIsIFRl eHR1cmVNYXBwZXJMYXllcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM3MjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgU3dpdGNoIHRvIHVzaW5nIEMrKzExIHJhbmdlLWJhc2VkIGZvci1sb29wcyBpbiB0 aGUKKyAgICAgICAgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIgYW5kIFRleHR1cmVNYXBwZXJM YXllciBjbGFzc2VzLgorCisgICAgICAgIFRoZSBmb3IgbG9vcHMgdGhhdCByZW1haW5lZCB1bmNo YW5nZWQgZWl0aGVyIGRvIGZ1cnRoZXIgY29tcHV0YXRpb24KKyAgICAgICAgd2l0aCB0aGUgbG9v cCBpbmRleCBvciBtdXN0IGl0ZXJhdGUgb3ZlciB0aGUgY29udGFpbmVyIGluIHJldmVyc2UuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVN YXBwZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dG9UZXh0dXJlTWFwcGVyTGF5ZXJWZWN0b3Ip OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OmZsdXNoQ29t cG9zaXRpbmdTdGF0ZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1 cmVNYXBwZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6 OmNvbXB1dGVUcmFuc2Zvcm1zUmVjdXJzaXZlKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVN YXBwZXJMYXllcjo6cGFpbnRTZWxmQW5kQ2hpbGRyZW4pOgorICAgICAgICAoV2ViQ29yZTo6VGV4 dHVyZU1hcHBlckxheWVyOjpjb21wdXRlT3ZlcmxhcFJlZ2lvbnMpOgorICAgICAgICAoV2ViQ29y ZTo6VGV4dHVyZU1hcHBlckxheWVyOjpwYWludFVzaW5nT3ZlcmxhcFJlZ2lvbnMpOgorICAgICAg ICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlckxheWVyOjp+VGV4dHVyZU1hcHBlckxheWVyKToKKyAg ICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6c2V0Q2hpbGRyZW4pOgorICAgICAg ICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlckxheWVyOjpkZXNjZW5kYW50c09yU2VsZkhhdmVSdW5u aW5nQW5pbWF0aW9ucyk6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OmFw cGx5QW5pbWF0aW9uc1JlY3Vyc2l2ZWx5KToKKwogMjAxNC0wOS0zMCAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBpczw+KCkgLyBkb3duY2FzdDw+KCkgZm9y IEVsZW1lbnQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9H cmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNw cAkocmV2aXNpb24gMTc0MTIwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDc3LDggKzQ3Nyw4IEBAIHZvaWQgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnNldERlYnUK IHN0YXRpYyB2b2lkIHRvVGV4dHVyZU1hcHBlckxheWVyVmVjdG9yKGNvbnN0IFZlY3RvcjxHcmFw aGljc0xheWVyKj4mIGxheWVycywgVmVjdG9yPFRleHR1cmVNYXBwZXJMYXllcio+JiB0ZXhtYXBM YXllcnMpCiB7CiAgICAgdGV4bWFwTGF5ZXJzLnJlc2VydmVDYXBhY2l0eShsYXllcnMuc2l6ZSgp KTsKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGxheWVycy5zaXplKCk7ICsraSkKLSAgICAg ICAgdGV4bWFwTGF5ZXJzLmFwcGVuZCh0b1RleHR1cmVNYXBwZXJMYXllcihsYXllcnNbaV0pKTsK KyAgICBmb3IgKGF1dG8qIGxheWVyIDogbGF5ZXJzKQorICAgICAgICB0ZXhtYXBMYXllcnMuYXBw ZW5kKHRvVGV4dHVyZU1hcHBlckxheWVyKGxheWVyKSk7CiB9CiAKIHZvaWQgR3JhcGhpY3NMYXll clRleHR1cmVNYXBwZXI6OmNvbW1pdExheWVyQ2hhbmdlcygpCkBAIC01ODYsOCArNTg2LDggQEAg dm9pZCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6Zmx1c2hDbwogICAgICAgICBtYXNrTGF5 ZXIoKS0+Zmx1c2hDb21wb3NpdGluZ1N0YXRlKHJlY3QpOwogICAgIGlmIChyZXBsaWNhTGF5ZXIo KSkKICAgICAgICAgcmVwbGljYUxheWVyKCktPmZsdXNoQ29tcG9zaXRpbmdTdGF0ZShyZWN0KTsK LSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGNoaWxkcmVuKCkuc2l6ZSgpOyArK2kpCi0gICAg ICAgIGNoaWxkcmVuKClbaV0tPmZsdXNoQ29tcG9zaXRpbmdTdGF0ZShyZWN0KTsKKyAgICBmb3Ig KGF1dG8qIGNoaWxkIDogY2hpbGRyZW4oKSkKKyAgICAgICAgY2hpbGQtPmZsdXNoQ29tcG9zaXRp bmdTdGF0ZShyZWN0KTsKIH0KIAogdm9pZCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6dXBk YXRlQmFja2luZ1N0b3JlSWZOZWVkZWQoKQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5j cHAJKHJldmlzaW9uIDE3NDEyMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Myw5ICs2 Myw5IEBAIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpjb21wdXRlVHJhbnNmb3IKICAgICAgICAg bV9zdGF0ZS5tYXNrTGF5ZXItPmNvbXB1dGVUcmFuc2Zvcm1zUmVjdXJzaXZlKCk7CiAgICAgaWYg KG1fc3RhdGUucmVwbGljYUxheWVyKQogICAgICAgICBtX3N0YXRlLnJlcGxpY2FMYXllci0+Y29t cHV0ZVRyYW5zZm9ybXNSZWN1cnNpdmUoKTsKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1f Y2hpbGRyZW4uc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgUkVMRUFTRV9BU1NFUlQobV9jaGlsZHJl bltpXS0+bV9wYXJlbnQgPT0gdGhpcyk7Ci0gICAgICAgIG1fY2hpbGRyZW5baV0tPmNvbXB1dGVU cmFuc2Zvcm1zUmVjdXJzaXZlKCk7CisgICAgZm9yIChhdXRvKiBjaGlsZCA6IG1fY2hpbGRyZW4p IHsKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQoY2hpbGQtPm1fcGFyZW50ID09IHRoaXMpOworICAg ICAgICBjaGlsZC0+Y29tcHV0ZVRyYW5zZm9ybXNSZWN1cnNpdmUoKTsKICAgICB9CiAKICAgICAv LyBSZW9yZGVyIGNoaWxkcmVuIGlmIG5lZWRlZCBvbiB0aGUgd2F5IGJhY2sgdXAuCkBAIC0xNzgs OCArMTc4LDggQEAgdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50U2VsZkFuZENoaQogICAg ICAgICBvcHRpb25zLnRleHR1cmVNYXBwZXItPmJlZ2luQ2xpcChjbGlwVHJhbnNmb3JtLCBsYXll clJlY3QoKSk7CiAgICAgfQogCi0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2NoaWxkcmVu LnNpemUoKTsgKytpKQotICAgICAgICBtX2NoaWxkcmVuW2ldLT5wYWludFJlY3Vyc2l2ZShvcHRp b25zKTsKKyAgICBmb3IgKGF1dG8qIGNoaWxkIDogbV9jaGlsZHJlbikKKyAgICAgICAgY2hpbGQt PnBhaW50UmVjdXJzaXZlKG9wdGlvbnMpOwogCiAgICAgaWYgKHNob3VsZENsaXApCiAgICAgICAg IG9wdGlvbnMudGV4dHVyZU1hcHBlci0+ZW5kQ2xpcCgpOwpAQCAtMjkxLDEwICsyOTEsOCBAQCB2 b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6Y29tcHV0ZU92ZXJsYXBSCiAgICAgUmVnaW9uIG5ld05v bk92ZXJsYXBSZWdpb24oZW5jbG9zaW5nSW50UmVjdChib3VuZGluZ1JlY3QpKTsKIAogICAgIGlm ICghbV9zdGF0ZS5tYXNrc1RvQm91bmRzKSB7Ci0gICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBp IDwgbV9jaGlsZHJlbi5zaXplKCk7ICsraSkgewotICAgICAgICAgICAgVGV4dHVyZU1hcHBlckxh eWVyKiBjaGlsZCA9IG1fY2hpbGRyZW5baV07CisgICAgICAgIGZvciAoYXV0byogY2hpbGQgOiBt X2NoaWxkcmVuKQogICAgICAgICAgICAgY2hpbGQtPmNvbXB1dGVPdmVybGFwUmVnaW9ucyhuZXdP dmVybGFwUmVnaW9uLCBuZXdOb25PdmVybGFwUmVnaW9uLCBSZXNvbHZlU2VsZk92ZXJsYXBJZk5l ZWRlZCk7Ci0gICAgICAgIH0KICAgICB9CiAKICAgICBpZiAobV9zdGF0ZS5yZXBsaWNhTGF5ZXIp IHsKQEAgLTMzMiwxMiArMzMwLDExIEBAIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpwYWludFVz aW5nT3ZlcmwKICAgICBub25PdmVybGFwUmVnaW9uLnRyYW5zbGF0ZShvcHRpb25zLm9mZnNldCk7 CiAgICAgVmVjdG9yPEludFJlY3Q+IHJlY3RzID0gbm9uT3ZlcmxhcFJlZ2lvbi5yZWN0cygpOwog Ci0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCByZWN0cy5zaXplKCk7ICsraSkgewotICAgICAg ICBJbnRSZWN0IHJlY3QgPSByZWN0c1tpXTsKKyAgICBmb3IgKGF1dG8mIHJlY3QgOiByZWN0cykg ewogICAgICAgICBpZiAoIXJlY3QuaW50ZXJzZWN0cyhvcHRpb25zLnRleHR1cmVNYXBwZXItPmNs aXBCb3VuZHMoKSkpCiAgICAgICAgICAgICBjb250aW51ZTsKIAotICAgICAgICBvcHRpb25zLnRl eHR1cmVNYXBwZXItPmJlZ2luQ2xpcChUcmFuc2Zvcm1hdGlvbk1hdHJpeCgpLCByZWN0c1tpXSk7 CisgICAgICAgIG9wdGlvbnMudGV4dHVyZU1hcHBlci0+YmVnaW5DbGlwKFRyYW5zZm9ybWF0aW9u TWF0cml4KCksIHJlY3QpOwogICAgICAgICBwYWludFNlbGZBbmRDaGlsZHJlbldpdGhSZXBsaWNh KG9wdGlvbnMpOwogICAgICAgICBvcHRpb25zLnRleHR1cmVNYXBwZXItPmVuZENsaXAoKTsKICAg ICB9CkBAIC0zNTIsOCArMzQ5LDcgQEAgdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50VXNp bmdPdmVybAogICAgIEludFNpemUgbWF4VGV4dHVyZVNpemUgPSBvcHRpb25zLnRleHR1cmVNYXBw ZXItPm1heFRleHR1cmVTaXplKCk7CiAgICAgSW50UmVjdCBhZGp1c3RlZENsaXBCb3VuZHMob3B0 aW9ucy50ZXh0dXJlTWFwcGVyLT5jbGlwQm91bmRzKCkpOwogICAgIGFkanVzdGVkQ2xpcEJvdW5k cy5tb3ZlKC1vcHRpb25zLm9mZnNldCk7Ci0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCByZWN0 cy5zaXplKCk7ICsraSkgewotICAgICAgICBJbnRSZWN0IHJlY3QgPSByZWN0c1tpXTsKKyAgICBm b3IgKGF1dG8mIHJlY3QgOiByZWN0cykgewogICAgICAgICBmb3IgKGludCB4ID0gcmVjdC54KCk7 IHggPCByZWN0Lm1heFgoKTsgeCArPSBtYXhUZXh0dXJlU2l6ZS53aWR0aCgpKSB7CiAgICAgICAg ICAgICBmb3IgKGludCB5ID0gcmVjdC55KCk7IHkgPCByZWN0Lm1heFkoKTsgeSArPSBtYXhUZXh0 dXJlU2l6ZS5oZWlnaHQoKSkgewogICAgICAgICAgICAgICAgIEludFJlY3QgdGlsZVJlY3QoSW50 UG9pbnQoeCwgeSksIG1heFRleHR1cmVTaXplKTsKQEAgLTQ0Niw4ICs0NDIsOCBAQCB2b2lkIFRl eHR1cmVNYXBwZXJMYXllcjo6cGFpbnRSZWN1cnNpdmUoCiAKIFRleHR1cmVNYXBwZXJMYXllcjo6 flRleHR1cmVNYXBwZXJMYXllcigpCiB7Ci0gICAgZm9yIChpbnQgaSA9IG1fY2hpbGRyZW4uc2l6 ZSgpIC0gMTsgaSA+PSAwOyAtLWkpCi0gICAgICAgIG1fY2hpbGRyZW5baV0tPm1fcGFyZW50ID0g bnVsbHB0cjsKKyAgICBmb3IgKGF1dG8qIGNoaWxkIDogbV9jaGlsZHJlbikKKyAgICAgICAgY2hp bGQtPm1fcGFyZW50ID0gbnVsbHB0cjsKIAogICAgIHJlbW92ZUZyb21QYXJlbnQoKTsKIH0KQEAg LTQ1NSw4ICs0NTEsOCBAQCBUZXh0dXJlTWFwcGVyTGF5ZXI6On5UZXh0dXJlTWFwcGVyTGF5ZXIo CiB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6c2V0Q2hpbGRyZW4oY29uc3QgVmVjdG9yPFRleHR1 cmVNYXBwZXJMYXllcio+JiBuZXdDaGlsZHJlbikKIHsKICAgICByZW1vdmVBbGxDaGlsZHJlbigp OwotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbmV3Q2hpbGRyZW4uc2l6ZSgpOyArK2kpCi0g ICAgICAgIGFkZENoaWxkKG5ld0NoaWxkcmVuW2ldKTsKKyAgICBmb3IgKGF1dG8qIGNoaWxkIDog bmV3Q2hpbGRyZW4pCisgICAgICAgIGFkZENoaWxkKGNoaWxkKTsKIH0KIAogdm9pZCBUZXh0dXJl TWFwcGVyTGF5ZXI6OmFkZENoaWxkKFRleHR1cmVNYXBwZXJMYXllciogY2hpbGRMYXllcikKQEAg LTY0MiwxOSArNjM4LDE3IEBAIGJvb2wgVGV4dHVyZU1hcHBlckxheWVyOjpkZXNjZW5kYW50c09y U2UKICAgICBpZiAobV9hbmltYXRpb25zLmhhc1J1bm5pbmdBbmltYXRpb25zKCkpCiAgICAgICAg IHJldHVybiB0cnVlOwogCi0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2NoaWxkcmVuLnNp emUoKTsgKytpKSB7Ci0gICAgICAgIGlmIChtX2NoaWxkcmVuW2ldLT5kZXNjZW5kYW50c09yU2Vs ZkhhdmVSdW5uaW5nQW5pbWF0aW9ucygpKQotICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAg fQotCi0gICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiBzdGQ6OmFueV9vZihtX2NoaWxkcmVu LmJlZ2luKCksIG1fY2hpbGRyZW4uZW5kKCksCisgICAgICAgIFtdKFRleHR1cmVNYXBwZXJMYXll ciogY2hpbGQpIHsKKyAgICAgICAgICAgIHJldHVybiBjaGlsZC0+ZGVzY2VuZGFudHNPclNlbGZI YXZlUnVubmluZ0FuaW1hdGlvbnMoKTsKKyAgICAgICAgfSk7CiB9CiAKIHZvaWQgVGV4dHVyZU1h cHBlckxheWVyOjphcHBseUFuaW1hdGlvbnNSZWN1cnNpdmVseSgpCiB7CiAgICAgc3luY0FuaW1h dGlvbnMoKTsKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fY2hpbGRyZW4uc2l6ZSgpOyAr K2kpCi0gICAgICAgIG1fY2hpbGRyZW5baV0tPmFwcGx5QW5pbWF0aW9uc1JlY3Vyc2l2ZWx5KCk7 CisgICAgZm9yIChhdXRvKiBjaGlsZCA6IG1fY2hpbGRyZW4pCisgICAgICAgIGNoaWxkLT5hcHBs eUFuaW1hdGlvbnNSZWN1cnNpdmVseSgpOwogfQogCiB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6 c3luY0FuaW1hdGlvbnMoKQo=