137262 2014-09-30 13:33:20 -0700 REGRESSION (r173423): [iOS] Sites with EV certificates appear as normal HTTPS sites 2015-01-01 18:37:46 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://ssl.apple.com InRadar, Regression P1 Normal --- 1 mitz mitz apavlov darin iloveo7 koivisto ossy oldest_to_newest 1038319 0 mitz 2014-09-30 13:33:20 -0700 <rdar://problem/18503318> When navigating to the a website that has an EV certificate, the browser UI doesn’t reflect the EV status of the site. This is happening because after <http://trac.webkit.org/r173423> (and its build fixes), ResourceResponse::platformCertificateInfo() in ResourceResponseCFNet.cpp returns an empty CertificateInfo. 1038320 1 238952 mitz 2014-09-30 13:38:05 -0700 Created attachment 238952 Return a CertificateInfo initialized Return a CertificateInfo initialized 1038540 2 mitz 2014-10-01 07:31:50 -0700 Fixed in <http://trac.webkit.org/r174156>. 1038549 3 238952 darin 2014-10-01 08:06:20 -0700 Comment on attachment 238952 Return a CertificateInfo initialized Return a CertificateInfo initialized View in context: https://bugs.webkit.org/attachment.cgi?id=238952&action=review > Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:122 > +#endif > return CertificateInfo(); #else? 1038565 4 ossy 2014-10-01 09:15:15 -0700 (In reply to comment #2) > Fixed in <http://trac.webkit.org/r174156>. It broke the Apple Windows build: 1>..\platform\network\cf\ResourceResponseCFNet.cpp(33): fatal error C1083: Cannot open include file: 'WebCoreSystemInterface.h': No such file or directory 1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj" (Build target(s)) -- FAILED. 1038566 5 mitz 2014-10-01 09:17:35 -0700 (In reply to comment #4) > (In reply to comment #2) > > Fixed in <http://trac.webkit.org/r174156>. > > It broke the Apple Windows build: > > 1>..\platform\network\cf\ResourceResponseCFNet.cpp(33): fatal error C1083: Cannot open include file: 'WebCoreSystemInterface.h': No such file or directory > 1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj" (Build target(s)) -- FAILED. Committed a build fix in <http://trac.webkit.org/r174157>. 1038567 6 mitz 2014-10-01 09:17:35 -0700 (In reply to comment #4) > (In reply to comment #2) > > Fixed in <http://trac.webkit.org/r174156>. > > It broke the Apple Windows build: > > 1>..\platform\network\cf\ResourceResponseCFNet.cpp(33): fatal error C1083: Cannot open include file: 'WebCoreSystemInterface.h': No such file or directory > 1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj" (Build target(s)) -- FAILED. Committed a build fix in <http://trac.webkit.org/r174157>. 238952 2014-09-30 13:38:05 -0700 2014-10-01 08:06:20 -0700 Return a CertificateInfo initialized Return a CertificateInfo initialized bug-137262-20140930133806.patch text/plain 1629 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDExOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA5LTMwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE3MzQyMyk6 IFtpT1NdIFNpdGVzIHdpdGggRVYgY2VydGlmaWNhdGVzIGFwcGVhciBhcyBub3JtYWwgSFRUUFMg c2l0ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NzI2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgYmVjYXVzZSB0aGUgQVBJIHRlc3QgaGFybmVzcyBkb2VzbuKAmXQgcnVuIGFu IEhUVFAgc2VydmVyIHRvIHRlc3QgYWdhaW5zdC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdv cmsvY2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291 cmNlUmVzcG9uc2U6OnBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvKTogUmV0dXJuIGEgQ2VydGlmaWNh dGVJbmZvIGluaXRpYWxpemVkCisgICAgICAgIHdpdGggdGhlIGNlcnRpZmljYXRlIGFycmF5IGZy b20gdGhlIHJlc3BvbnNlLgorCiAyMDE0LTA5LTMwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgVXNlIGlzPD4oKSAvIGRvd25jYXN0PD4oKSBmb3IgRWxlbWVudApJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZVJlc3BvbnNl Q0ZOZXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0LmNwcAkocmV2aXNpb24gMTc0MTA4KQorKysgU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZVJlc3BvbnNlQ0ZOZXQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zMCw2ICszMCw3IEBACiAKICNpbmNsdWRlICJIVFRQUGFyc2Vycy5o IgogI2luY2x1ZGUgIk1JTUVUeXBlUmVnaXN0cnkuaCIKKyNpbmNsdWRlICJXZWJDb3JlU3lzdGVt SW50ZXJmYWNlLmgiCiAjaW5jbHVkZSA8Q0ZOZXR3b3JrL0NGVVJMUmVzcG9uc2VQcml2Lmg+CiAj aW5jbHVkZSA8d3RmL1JldGFpblB0ci5oPgogCkBAIC0xMTUsNiArMTE2LDkgQEAgdm9pZCBSZXNv dXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUxhenlJbml0KAogCiBDZXJ0aWZpY2F0ZUluZm8gUmVzb3Vy Y2VSZXNwb25zZTo6cGxhdGZvcm1DZXJ0aWZpY2F0ZUluZm8oKSBjb25zdAogeworI2lmIFBMQVRG T1JNKENPQ09BKQorICAgIHJldHVybiBDZXJ0aWZpY2F0ZUluZm8oYWRvcHRDRih3a0NvcHlOU1VS TFJlc3BvbnNlQ2VydGlmaWNhdGVDaGFpbihuc1VSTFJlc3BvbnNlKCkpKSk7CisjZW5kaWYKICAg ICByZXR1cm4gQ2VydGlmaWNhdGVJbmZvKCk7CiB9CiAK