137256 2014-09-30 11:23:04 -0700 EWS doesn't need to show all the bubbles when a patch fails to apply 2014-09-30 12:44:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap cgarcia rniwa oldest_to_newest 1038267 0 ap 2014-09-30 11:23:04 -0700 When a patch fails to apply, it's usually failing in the same way on all queues. There is no need to show per-queue bubbles then. 1038268 1 238941 ap 2014-09-30 11:26:14 -0700 Created attachment 238941 proposed patch 1038281 2 238941 rniwa 2014-09-30 11:54:48 -0700 Comment on attachment 238941 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=238941&action=review > Tools/QueueStatusServer/app.yaml:2 > -version: 174192 # Bugzilla bug ID of last major change > +version: ap # Bugzilla bug ID of last major change Revert? > Tools/QueueStatusServer/handlers/statusbubble.py:194 > - return (bubbles, show_submit_to_ews) > + return (bubbles, show_submit_to_ews, failed_to_apply and not had_output and not show_submit_to_ews) I would have written this as: failed_to_apply = any(map(lambda bubble: 'failed_to_apply' in bubble, bubbles) had_output = all(map(lambda bubble: 'no_output_yet' in bubble, bubbles) return (bubbles, show_submit_to_ews, failed_to_apply and not had_output) instead of updating variables in the loop. It's much easier to understand. 1038300 3 ap 2014-09-30 12:44:17 -0700 Committed <http://trac.webkit.org/r174114>. 238941 2014-09-30 11:26:14 -0700 2014-09-30 11:54:48 -0700 proposed patch FailToApply.txt text/plain 5967 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NDEwOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE0LTA5LTMwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEVXUyBkb2Vzbid0IG5lZWQgdG8gc2hvdyBhbGwgdGhlIGJ1YmJsZXMgd2hl biBhIHBhdGNoIGZhaWxzIHRvIGFwcGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzcyNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL2FwcC55YW1sOiBVcGRhdGVkIGFw cCB2ZXJzaW9uLgorCisgICAgICAgICogUXVldWVTdGF0dXNTZXJ2ZXIvaGFuZGxlcnMvc3RhdHVz YnViYmxlLnB5OgorICAgICAgICAoU3RhdHVzQnViYmxlLl9idWlsZF9idWJibGUpOgorICAgICAg ICAoU3RhdHVzQnViYmxlLl9idWlsZF9idWJibGVzX2Zvcl9hdHRhY2htZW50KToKKyAgICAgICAg KFN0YXR1c0J1YmJsZS5nZXQpOgorICAgICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRl cy9zdGF0dXNidWJibGUuaHRtbDoKKyAgICAgICAgV2hlbiBzb21lIHF1ZXVlcyBmYWlsIHRvIGFw cGx5LCBhbmQgbm8gcXVldWVzIGhhZCBtZWFuaW5nZnVsIG91dHB1dCAobWVhbmluZyB0aGF0Cisg ICAgICAgIHRoZXkgd2lsbCBhbG1vc3QgY2VydGFpbmx5IGZhaWwgdG8gYXBwbHkgbGF0ZXIpLCB3 ZSBjYW4gc2hvdyBhIHNpbmdsZSBidWJibGUKKyAgICAgICAgdGVsbGluZyB0aGUgdXNlciBqdXN0 IHRoYXQuCisKIDIwMTQtMDktMzAgIFRpYm9yIE1lc3phcm9zICA8dG1lc3phcm9zLnUtc3plZ2Vk QHBhcnRuZXIuc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gQnVtcCBFRkwgdmVyc2lvbiB0 byAxLjExLjIKSW5kZXg6IFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2FwcC55YW1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2FwcC55YW1sCShyZXZpc2lvbiAxNzQwOTIp CisrKyBUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9hcHAueWFtbAkod29ya2luZyBjb3B5KQpAQCAt MSw1ICsxLDUgQEAKIGFwcGxpY2F0aW9uOiB3ZWJraXQtcXVldWVzCi12ZXJzaW9uOiAxNzQxOTIg IyBCdWd6aWxsYSBidWcgSUQgb2YgbGFzdCBtYWpvciBjaGFuZ2UKK3ZlcnNpb246IGFwICMgQnVn emlsbGEgYnVnIElEIG9mIGxhc3QgbWFqb3IgY2hhbmdlCiBydW50aW1lOiBweXRob24KIGFwaV92 ZXJzaW9uOiAxCiAKSW5kZXg6IFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2hhbmRsZXJzL3N0YXR1 c2J1YmJsZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVy cy9zdGF0dXNidWJibGUucHkJKHJldmlzaW9uIDE3NDA5MikKKysrIFRvb2xzL1F1ZXVlU3RhdHVz U2VydmVyL2hhbmRsZXJzL3N0YXR1c2J1YmJsZS5weQkod29ya2luZyBjb3B5KQpAQCAtMTE4LDEx ICsxMTgsMTMgQEAgY2xhc3MgU3RhdHVzQnViYmxlKHdlYmFwcC5SZXF1ZXN0SGFuZGxlcgogICAg ICAgICAgICAgaWYgYXR0YWNobWVudC5pZCBpbiBxdWV1ZS5hY3RpdmVfd29ya19pdGVtcygpLml0 ZW1faWRzOgogICAgICAgICAgICAgICAgIGJ1YmJsZVsic3RhdGUiXSA9ICJzdGFydGVkIgogICAg ICAgICAgICAgICAgIGJ1YmJsZVsiZGV0YWlsc19tZXNzYWdlIl0gPSAiU3RhcnRlZCBwcm9jZXNz aW5nLCBubyBvdXRwdXQgeWV0LlxuXG4iICsgc2VsZi5faXNvX3RpbWUocXVldWUuYWN0aXZlX3dv cmtfaXRlbXMoKS50aW1lX2Zvcl9pdGVtKGF0dGFjaG1lbnQuaWQpKQorICAgICAgICAgICAgICAg IGJ1YmJsZVsibm9fb3V0cHV0X3lldCJdID0gVHJ1ZQogICAgICAgICAgICAgZWxzZToKICAgICAg ICAgICAgICAgICByZWFsX3F1ZXVlX3Bvc2l0aW9uID0gc2VsZi5fcmVhbF9xdWV1ZV9wb3NpdGlv bihxdWV1ZSwgcXVldWVfcG9zaXRpb24pCiAgICAgICAgICAgICAgICAgYnViYmxlWyJzdGF0ZSJd ID0gIm5vbmUiCiAgICAgICAgICAgICAgICAgYnViYmxlWyJkZXRhaWxzX21lc3NhZ2UiXSA9ICJX YWl0aW5nIGluIHF1ZXVlLCBwcm9jZXNzaW5nIGhhcyBub3Qgc3RhcnRlZCB5ZXQuXG5cblBvc2l0 aW9uIGluIHF1ZXVlOiAiICsgc3RyKHJlYWxfcXVldWVfcG9zaXRpb24pCiAgICAgICAgICAgICAg ICAgYnViYmxlWyJxdWV1ZV9wb3NpdGlvbiJdID0gcmVhbF9xdWV1ZV9wb3NpdGlvbgorICAgICAg ICAgICAgICAgIGJ1YmJsZVsibm9fb3V0cHV0X3lldCJdID0gVHJ1ZQogICAgICAgICBlbHNlOgog ICAgICAgICAgICAgbGF0ZXN0X3Jlc3VsdGF0aXZlX3N0YXR1cyA9IHNlbGYuX2xhdGVzdF9yZXN1 bHRhdGl2ZV9zdGF0dXMoc3RhdHVzZXMpCiAgICAgICAgICAgICBpZiBub3QgbGF0ZXN0X3Jlc3Vs dGF0aXZlX3N0YXR1czoKQEAgLTE0Nyw2ICsxNDksNyBAQCBjbGFzcyBTdGF0dXNCdWJibGUod2Vi YXBwLlJlcXVlc3RIYW5kbGVyCiAgICAgICAgICAgICBlbGlmIHN0YXR1c2VzWzBdLm1lc3NhZ2Ug PT0gIkVycm9yOiAiICsgcXVldWUubmFtZSgpICsgIiB1bmFibGUgdG8gYXBwbHkgcGF0Y2guIjoK ICAgICAgICAgICAgICAgICBidWJibGVbInN0YXRlIl0gPSAiZmFpbCIKICAgICAgICAgICAgICAg ICBidWJibGVbImRldGFpbHNfbWVzc2FnZSJdID0gc3RhdHVzZXNbMV0ubWVzc2FnZSArICJcblxu IiArIHNlbGYuX2lzb190aW1lKHN0YXR1c2VzWzBdLmRhdGUpCisgICAgICAgICAgICAgICAgYnVi YmxlWyJmYWlsZWRfdG9fYXBwbHkiXSA9IFRydWUKICAgICAgICAgICAgIGVsaWYgc3RhdHVzZXNb MF0ubWVzc2FnZS5zdGFydHN3aXRoKCJFcnJvcjogIik6CiAgICAgICAgICAgICAgICAgYnViYmxl WyJzdGF0ZSJdID0gImVycm9yIgogICAgICAgICAgICAgICAgIGJ1YmJsZVsiZGV0YWlsc19tZXNz YWdlIl0gPSAiXG4iLmpvaW4oW3N0YXR1cy5tZXNzYWdlIGZvciBzdGF0dXMgaW4gc3RhdHVzZXNd KSArICJcblxuIiArIHNlbGYuX2lzb190aW1lKHN0YXR1c2VzWzBdLmRhdGUpCkBAIC0xNzMsNiAr MTc2LDggQEAgY2xhc3MgU3RhdHVzQnViYmxlKHdlYmFwcC5SZXF1ZXN0SGFuZGxlcgogICAgIGRl ZiBfYnVpbGRfYnViYmxlc19mb3JfYXR0YWNobWVudChzZWxmLCBhdHRhY2htZW50KToKICAgICAg ICAgc2hvd19zdWJtaXRfdG9fZXdzID0gVHJ1ZQogICAgICAgICBidWJibGVzID0gW10KKyAgICAg ICAgZmFpbGVkX3RvX2FwcGx5ID0gRmFsc2UKKyAgICAgICAgaGFkX291dHB1dCA9IEZhbHNlCiAg ICAgICAgIGZvciBxdWV1ZSBpbiBRdWV1ZS5hbGwoKToKICAgICAgICAgICAgIGlmIG5vdCBzZWxm Ll9zaG91bGRfc2hvd19idWJibGVfZm9yKGF0dGFjaG1lbnQsIHF1ZXVlKToKICAgICAgICAgICAg ICAgICBjb250aW51ZQpAQCAtMTgwLDIwICsxODUsMjMgQEAgY2xhc3MgU3RhdHVzQnViYmxlKHdl YmFwcC5SZXF1ZXN0SGFuZGxlcgogICAgICAgICAgICAgYnViYmxlID0gc2VsZi5fYnVpbGRfYnVi YmxlKHF1ZXVlLCBhdHRhY2htZW50LCBxdWV1ZV9wb3NpdGlvbikKICAgICAgICAgICAgIGlmIGJ1 YmJsZToKICAgICAgICAgICAgICAgICBidWJibGVzLmFwcGVuZChidWJibGUpCisgICAgICAgICAg ICAgICAgZmFpbGVkX3RvX2FwcGx5ID0gZmFpbGVkX3RvX2FwcGx5IG9yICJmYWlsZWRfdG9fYXBw bHkiIGluIGJ1YmJsZQorICAgICAgICAgICAgICAgIGhhZF9vdXRwdXQgPSBub3QgZmFpbGVkX3Rv X2FwcGx5IGFuZCAoaGFkX291dHB1dCBvciBub3QgIm5vX291dHB1dF95ZXQiIGluIGJ1YmJsZSkK ICAgICAgICAgICAgICMgSWYgYXQgbGVhc3Qgb25lIEVXUyBxdWV1ZSBoYXMgc3RhdHVzLCB3ZSBk b24ndCBzaG93IHRoZSBzdWJtaXQtdG8tZXdzIGJ1dHRvbi4KICAgICAgICAgICAgIGlmIHF1ZXVl LmlzX2V3cygpOgogICAgICAgICAgICAgICAgIHNob3dfc3VibWl0X3RvX2V3cyA9IEZhbHNlCiAK LSAgICAgICAgcmV0dXJuIChidWJibGVzLCBzaG93X3N1Ym1pdF90b19ld3MpCisgICAgICAgIHJl dHVybiAoYnViYmxlcywgc2hvd19zdWJtaXRfdG9fZXdzLCBmYWlsZWRfdG9fYXBwbHkgYW5kIG5v dCBoYWRfb3V0cHV0IGFuZCBub3Qgc2hvd19zdWJtaXRfdG9fZXdzKQogCiAgICAgZGVmIGdldChz ZWxmLCBhdHRhY2htZW50X2lkX3N0cmluZyk6CiAgICAgICAgIGF0dGFjaG1lbnRfaWQgPSBpbnQo YXR0YWNobWVudF9pZF9zdHJpbmcpCiAgICAgICAgIGF0dGFjaG1lbnQgPSBBdHRhY2htZW50KGF0 dGFjaG1lbnRfaWQpCi0gICAgICAgIGJ1YmJsZXMsIHNob3dfc3VibWl0X3RvX2V3cyA9IHNlbGYu X2J1aWxkX2J1YmJsZXNfZm9yX2F0dGFjaG1lbnQoYXR0YWNobWVudCkKKyAgICAgICAgYnViYmxl cywgc2hvd19zdWJtaXRfdG9fZXdzLCBzaG93X2ZhaWx1cmVfdG9fYXBwbHkgPSBzZWxmLl9idWls ZF9idWJibGVzX2Zvcl9hdHRhY2htZW50KGF0dGFjaG1lbnQpCiAKICAgICAgICAgdGVtcGxhdGVf dmFsdWVzID0gewogICAgICAgICAgICAgImJ1YmJsZXMiOiBidWJibGVzLAogICAgICAgICAgICAg ImF0dGFjaG1lbnRfaWQiOiBhdHRhY2htZW50X2lkLAogICAgICAgICAgICAgInNob3dfc3VibWl0 X3RvX2V3cyI6IHNob3dfc3VibWl0X3RvX2V3cywKKyAgICAgICAgICAgICJzaG93X2ZhaWx1cmVf dG9fYXBwbHkiOiBzaG93X2ZhaWx1cmVfdG9fYXBwbHksCiAgICAgICAgIH0KICAgICAgICAgc2Vs Zi5yZXNwb25zZS5vdXQud3JpdGUodGVtcGxhdGUucmVuZGVyKCJ0ZW1wbGF0ZXMvc3RhdHVzYnVi YmxlLmh0bWwiLCB0ZW1wbGF0ZV92YWx1ZXMpKQpJbmRleDogVG9vbHMvUXVldWVTdGF0dXNTZXJ2 ZXIvdGVtcGxhdGVzL3N0YXR1c2J1YmJsZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1F1ZXVl U3RhdHVzU2VydmVyL3RlbXBsYXRlcy9zdGF0dXNidWJibGUuaHRtbAkocmV2aXNpb24gMTc0MDkx KQorKysgVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvdGVtcGxhdGVzL3N0YXR1c2J1YmJsZS5odG1s CSh3b3JraW5nIGNvcHkpCkBAIC02Myw2ICs2MywxNCBAQCB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5l cigibWVzc2FnZSIsIGZ1bmN0CiA8L2hlYWQ+CiA8Ym9keT4KIDxkaXYgaWQ9ImJ1YmJsZUNvbnRh aW5lciI+CisgIHslIGlmIHNob3dfZmFpbHVyZV90b19hcHBseSAlfQorICA8YSBjbGFzcz0ic3Rh dHVzIGZhaWwiIHRhcmdldD0iX3RvcCIKKyAgICAgIGhyZWY9Ii9wYXRjaC97eyBidWJibGUuYXR0 YWNobWVudF9pZCB9fSIKKyAgICAgIHRpdGxlPSJOb25lIG9mIHRoZSBxdWV1ZXMgY291bGQgYXBw bHkgdGhlIHBhdGNoIgorICA+CisgICAgcGF0Y2ggZG9lcyBub3QgYXBwbHkgdG8gdHJ1bmsgb2Yg cmVwb3NpdG9yeQorICA8L2E+CisgIHslIGVsc2UgJX0KICAgeyUgZm9yIGJ1YmJsZSBpbiBidWJi bGVzICV9CiAgIDxhIGNsYXNzPSJzdGF0dXMge3sgYnViYmxlLnN0YXRlIH19IiB0YXJnZXQ9Il90 b3AiCiAgICAgICBocmVmPSIvcGF0Y2gve3sgYnViYmxlLmF0dGFjaG1lbnRfaWQgfX0iCkBAIC03 Niw2ICs4NCw3IEBAIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJtZXNzYWdlIiwgZnVuY3QKICAg ICB7JSBlbmRpZiAlfQogICA8L2E+CiAgIHslIGVuZGZvciAlfQorICB7JSBlbmRpZiAlfQogCiB7 JSBpZiBzaG93X3N1Ym1pdF90b19ld3MgJX0KICAgPGZvcm0gbmFtZT0ic3VibWl0X3RvX2V3cyIg bWV0aG9kPSJQT1NUIiBhY3Rpb249Ii9zdWJtaXQtdG8tZXdzIj4K