137246 2014-09-30 00:35:44 -0700 Avoid copying the iterated-over items in range-based for-loops in RenderGrid 2014-09-30 05:50:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue esprehn+autocc glenn jfernandez kondapallykalyan rego svillar oldest_to_newest 1038161 0 zan 2014-09-30 00:35:44 -0700 Avoid copying the iterated-over items in range-based for-loops in RenderGrid 1038163 1 238913 zan 2014-09-30 00:41:00 -0700 Created attachment 238913 Patch 1038164 2 commit-queue 2014-09-30 00:43:36 -0700 Attachment 238913 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1038187 3 238913 svillar 2014-09-30 03:36:04 -0700 Comment on attachment 238913 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238913&action=review > Source/WebCore/ChangeLog:9 > + of the items that are being iterated. Something wrong with the indentation here > Source/WebCore/rendering/RenderGrid.cpp:562 > + for (auto& trackIndex : sizingData.contentSizedTracksIndex) { This is just a size_t. I don't think we need this... 1038189 4 238913 zan 2014-09-30 04:31:27 -0700 Comment on attachment 238913 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238913&action=review >> Source/WebCore/ChangeLog:9 >> + of the items that are being iterated. > > Something wrong with the indentation here Tabs, somehow. >> Source/WebCore/rendering/RenderGrid.cpp:562 >> + for (auto& trackIndex : sizingData.contentSizedTracksIndex) { > > This is just a size_t. I don't think we need this... OK. 1038198 5 zan 2014-09-30 05:50:04 -0700 Committed r174101: <http://trac.webkit.org/changeset/174101> 238913 2014-09-30 00:41:00 -0700 2014-09-30 04:31:27 -0700 Patch bug-137246-20140930094100.patch text/plain 3350 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA3YzNlYTg0OTQ3MGY1 ZjkzNTljZDg1Nzg5N2ZkZDFjNDBmNjc0Yi4uY2MzMjdjZGY0ODJiNjM1ZWM3MGQxMmRhMzE3OTAx MGIxMDU0YTQ5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA5LTMwICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBBdm9pZCBjb3B5aW5n IHRoZSBpdGVyYXRlZC1vdmVyIGl0ZW1zIGluIHJhbmdlLWJhc2VkIGZvci1sb29wcyBpbiBSZW5k ZXJHcmlkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzcyNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCUFkanVzdCB0 aGUgcmFuZ2UtYmFzZWQgZm9yLWxvb3BzIGluIFJlbmRlckdyaWQgdG8gYXZvaWQgdGhlIHVubmVj ZXNzYXJ5IGNvcHlpbmcKKwlvZiB0aGUgaXRlbXMgdGhhdCBhcmUgYmVpbmcgaXRlcmF0ZWQuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJHcmlkOjpjb21wdXRlTm9ybWFsaXplZEZyYWN0aW9uQnJlYWR0aCk6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJHcmlkOjpyZXNvbHZlQ29udGVudEJhc2VkVHJhY2tTaXppbmdGdW5jdGlv bnMpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6aW5zZXJ0SXRlbUludG9HcmlkKToK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdyaWQ6OmdyaWRBcmVhQnJlYWR0aEZvckNoaWxkKToK KwogMjAxNC0wOS0yOSAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5qZWN0ZWRTY3JpcHRzIHNob3VsZCBub3QgYmUgcHJv ZmlsZWQgb3IgZGlzcGxheWVkIGluIFRpbWVsaW5lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyR3JpZC5jcHAKaW5kZXggZjhmZTI3NmNkMDM0ZWZmNmU5MGNlM2Q0ZTRiN2YxNjBiNzUwZjky Ny4uYzliODZmN2Y2N2ZlYzg2ZDA3MDRkNTJiNDYxYTRiMzRiZWUxOTQyZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcApAQCAtNDI0LDcgKzQyNCw3IEBAIGRvdWJsZSBS ZW5kZXJHcmlkOjpjb21wdXRlTm9ybWFsaXplZEZyYWN0aW9uQnJlYWR0aChWZWN0b3I8R3JpZFRy YWNrPiYgdHJhY2tzLCBjCiAgICAgLy8gfGF2YWlsYWJsZUxvZ2ljYWxTcGFjZXwgYWxyZWFkeSBh Y2NvdW50cyBmb3IgdGhlIHVzZWQgYnJlYWR0aHMgc28gbm8gbmVlZCB0byByZW1vdmUgaXQgaGVy ZS4KIAogICAgIFZlY3RvcjxHcmlkVHJhY2tGb3JOb3JtYWxpemF0aW9uPiB0cmFja3NGb3JOb3Jt YWxpemF0aW9uOwotICAgIGZvciAoYXV0byBwb3NpdGlvbiA6IHRyYWNrc1NwYW4pIHsKKyAgICBm b3IgKGF1dG8mIHBvc2l0aW9uIDogdHJhY2tzU3BhbikgewogICAgICAgICBjb25zdCBHcmlkVHJh Y2tTaXplJiB0cmFja1NpemUgPSBncmlkVHJhY2tTaXplKGRpcmVjdGlvbiwgcG9zaXRpb24udG9J bnQoKSk7CiAgICAgICAgIGlmICghdHJhY2tTaXplLm1heFRyYWNrQnJlYWR0aCgpLmlzRmxleCgp KQogICAgICAgICAgICAgY29udGludWU7CkBAIC01NTksNyArNTU5LDcgQEAgdm9pZCBSZW5kZXJH cmlkOjpyZXNvbHZlQ29udGVudEJhc2VkVHJhY2tTaXppbmdGdW5jdGlvbnMoR3JpZFRyYWNrU2l6 aW5nRGlyZWN0aW8KIHsKICAgICAvLyBGSVhNRTogU3BsaXQgdGhlIGdyaWQgdHJhY2tzIGludG8g Z3JvdXBzIHRoYXQgZG9lc24ndCBvdmVybGFwIGEgPGZsZXg+IGdyaWQgdHJhY2suCiAKLSAgICBm b3IgKGF1dG8gdHJhY2tJbmRleCA6IHNpemluZ0RhdGEuY29udGVudFNpemVkVHJhY2tzSW5kZXgp IHsKKyAgICBmb3IgKGF1dG8mIHRyYWNrSW5kZXggOiBzaXppbmdEYXRhLmNvbnRlbnRTaXplZFRy YWNrc0luZGV4KSB7CiAgICAgICAgIEdyaWRJdGVyYXRvciBpdGVyYXRvcihtX2dyaWQsIGRpcmVj dGlvbiwgdHJhY2tJbmRleCk7CiAgICAgICAgIEhhc2hTZXQ8UmVuZGVyQm94Kj4gaXRlbXNTZXQ7 CiAgICAgICAgIFZlY3RvcjxHcmlkSXRlbVdpdGhTcGFuPiBpdGVtc1NvcnRlZEJ5SW5jcmVhc2lu Z1NwYW47CkBAIC03MDEsOCArNzAxLDggQEAgdm9pZCBSZW5kZXJHcmlkOjppbnNlcnRJdGVtSW50 b0dyaWQoUmVuZGVyQm94JiBjaGlsZCwgY29uc3QgR3JpZENvb3JkaW5hdGUmIGNvb3IKIHsKICAg ICBlbnN1cmVHcmlkU2l6ZShjb29yZGluYXRlLnJvd3MucmVzb2x2ZWRGaW5hbFBvc2l0aW9uLnRv SW50KCksIGNvb3JkaW5hdGUuY29sdW1ucy5yZXNvbHZlZEZpbmFsUG9zaXRpb24udG9JbnQoKSk7 CiAKLSAgICBmb3IgKGF1dG8gcm93IDogY29vcmRpbmF0ZS5yb3dzKSB7Ci0gICAgICAgIGZvciAo YXV0byBjb2x1bW4gOiBjb29yZGluYXRlLmNvbHVtbnMpCisgICAgZm9yIChhdXRvJiByb3cgOiBj b29yZGluYXRlLnJvd3MpIHsKKyAgICAgICAgZm9yIChhdXRvJiBjb2x1bW4gOiBjb29yZGluYXRl LmNvbHVtbnMpCiAgICAgICAgICAgICBtX2dyaWRbcm93LnRvSW50KCldW2NvbHVtbi50b0ludCgp XS5hcHBlbmQoJmNoaWxkKTsKICAgICB9CiAgICAgbV9ncmlkSXRlbUNvb3JkaW5hdGUuc2V0KCZj aGlsZCwgY29vcmRpbmF0ZSk7CkBAIC05NTMsNyArOTUzLDcgQEAgTGF5b3V0VW5pdCBSZW5kZXJH cmlkOjpncmlkQXJlYUJyZWFkdGhGb3JDaGlsZChjb25zdCBSZW5kZXJCb3gmIGNoaWxkLCBHcmlk VHJhY2sKICAgICBjb25zdCBHcmlkQ29vcmRpbmF0ZSYgY29vcmRpbmF0ZSA9IGNhY2hlZEdyaWRD b29yZGluYXRlKGNoaWxkKTsKICAgICBjb25zdCBHcmlkU3BhbiYgc3BhbiA9IChkaXJlY3Rpb24g PT0gRm9yQ29sdW1ucykgPyBjb29yZGluYXRlLmNvbHVtbnMgOiBjb29yZGluYXRlLnJvd3M7CiAg ICAgTGF5b3V0VW5pdCBncmlkQXJlYUJyZWFkdGggPSAwOwotICAgIGZvciAoYXV0byB0cmFja1Bv c2l0aW9uIDogc3BhbikKKyAgICBmb3IgKGF1dG8mIHRyYWNrUG9zaXRpb24gOiBzcGFuKQogICAg ICAgICBncmlkQXJlYUJyZWFkdGggKz0gdHJhY2tzW3RyYWNrUG9zaXRpb24udG9JbnQoKV0ubV91 c2VkQnJlYWR0aDsKICAgICByZXR1cm4gZ3JpZEFyZWFCcmVhZHRoOwogfQo=