137239 2014-09-29 16:22:24 -0700 REGRESSION (r173272): Crash in ResourceResponse::platformSuggestedFilename() when called on the null response 2014-10-02 17:37:58 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz ap koivisto psolanki oldest_to_newest 1038104 0 mitz 2014-09-29 16:22:24 -0700 Networking crashed in ResourceResponse::platformSuggestedFilename(). Here’s the top of the backtrace * thread #1: tid = 0x299351, 0x000000010818463b CFNetwork`URLResponse::createFilenameFromResponseHeaders() + 7, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x60) frame #0: 0x000000010818463b CFNetwork`URLResponse::createFilenameFromResponseHeaders() + 7 frame #1: 0x00000001081846a0 CFNetwork`URLResponse::copySuggestedFilename() + 42 * frame #2: 0x000000010f93ed2e WebCore`WebCore::ResourceResponse::platformSuggestedFilename(this=0x00007fff58e577b8) const + 46 at ResourceResponseCFNet.cpp:123 frame #3: 0x000000010f93ab5c WebCore`WebCore::ResourceResponseBase::suggestedFilename(this=0x00007fff58e577b8) const + 28 at ResourceResponseBase.cpp:225 frame #4: 0x000000010f93d249 WebCore`WebCore::ResourceResponseBase::compare(a=0x00007fff58e577b8, b=0x00007f89bc00c290) + 313 at ResourceResponseBase.cpp:577 frame #5: 0x000000010de41e5d WebCore`WebCore::operator==(a=0x00007fff58e577b8, b=0x00007f89bc00c290) + 29 at ResourceResponseBase.h:196 frame #6: 0x000000010de41dcd WebCore`WebCore::operator!=(a=0x00007fff58e577b8, b=0x00007f89bc00c290) + 29 at ResourceResponseBase.h:197 frame #7: 0x000000010de41be8 WebCore`WebCore::AuthenticationChallengeBase::compare(a=0x00007fff58e57760, b=0x00007f89bc00c238) + 328 at AuthenticationChallengeBase.cpp:102 frame #8: 0x000000010f91c74d WebCore`WebCore::operator==(a=0x00007fff58e57760, b=0x00007f89bc00c238) + 29 at AuthenticationChallengeBase.h:65 frame #9: 0x000000010f919f5d WebCore`WebCore::operator!=(a=0x00007fff58e57760, b=0x00007f89bc00c238) + 29 at AuthenticationChallengeBase.h:66 frame #10: 0x000000010f918370 WebCore`WebCore::ResourceHandle::receivedCancellation(this=0x00007f89bb0101b0, The this object in frame #2 is the null ResourceResponse. This is new in http://trac.webkit.org/r173272, the fix for bug 136534. 1038233 1 mitz 2014-09-30 09:42:38 -0700 This is getting in the way of working with anything that requires authentication. Can it be easily fixed or should r173272 be reverted in the mean time? 1039055 2 mitz 2014-10-02 17:06:11 -0700 <rdar://problem/18531395> 1039062 3 239161 mitz 2014-10-02 17:21:00 -0700 Created attachment 239161 Add a null check 1039064 4 239161 psolanki 2014-10-02 17:22:32 -0700 Comment on attachment 239161 Add a null check View in context: https://bugs.webkit.org/attachment.cgi?id=239161&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=137239 Please add the radar link as well. 1039069 5 mitz 2014-10-02 17:34:38 -0700 (In reply to comment #4) > (From update of attachment 239161 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239161&action=review > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=137239 > > Please add the radar link as well. Radar link is there in the line above the bugs.webkit.org URL. Thanks for the review! 1039071 6 239161 psolanki 2014-10-02 17:36:42 -0700 Comment on attachment 239161 Add a null check View in context: https://bugs.webkit.org/attachment.cgi?id=239161&action=review >>> Source/WebCore/ChangeLog:4 >>> + https://bugs.webkit.org/show_bug.cgi?id=137239 >> >> Please add the radar link as well. > > Radar link is there in the line above the bugs.webkit.org URL. Thanks for the review! Oh wow. How did I miss that? So used to seeing 3 lines that I assumed the radar link wasn't there. 1039072 7 mitz 2014-10-02 17:37:58 -0700 Fixed in <http://trac.webkit.org/r174252>. 239161 2014-10-02 17:21:00 -0700 2014-10-02 17:36:42 -0700 Add a null check bug-137239-20141002172101.patch text/plain 1441 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDI1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEwLTAyICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4NTMx Mzk1PiBSRUdSRVNTSU9OIChyMTczMjcyKTogQ3Jhc2ggaW4gUmVzb3VyY2VSZXNwb25zZTo6cGxh dGZvcm1TdWdnZXN0ZWRGaWxlbmFtZSgpIHdoZW4gY2FsbGVkIG9uIHRoZSBudWxsIHJlc3BvbnNl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcyMzkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvY2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtU3VnZ2VzdGVkRmlsZW5hbWUpOiBSZXR1cm4g dGhlIG51bGwgU3RyaW5nIGlmCisgICAgICAgIG1fY2ZSZXNwb25zZSBpcyBudWxsLgorCiAyMDE0 LTEwLTAyICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBD cmVhdGUgYW4gU1BJIHdyYXBwZXIgZm9yIF9VSUhpZ2hsaWdodFZpZXcgYW5kIHVzZSBpdCBpbiBX S0NvbnRlbnRWaWV3CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jl c291cmNlUmVzcG9uc2VDRk5ldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZVJlc3BvbnNlQ0ZOZXQuY3BwCShyZXZpc2lvbiAxNzQy NTApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVzcG9u c2VDRk5ldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNyw2ICsxMjcsOSBAQCBDZXJ0aWZpY2F0 ZUluZm8gUmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvCiAKIFN0cmluZyBSZXNvdXJjZVJlc3BvbnNl OjpwbGF0Zm9ybVN1Z2dlc3RlZEZpbGVuYW1lKCkgY29uc3QKIHsKKyAgICBpZiAoIW1fY2ZSZXNw b25zZSkKKyAgICAgICAgcmV0dXJuIFN0cmluZygpOworCiAgICAgUmV0YWluUHRyPENGU3RyaW5n UmVmPiBzdWdnZXN0ZWRGaWxlbmFtZSA9IGFkb3B0Q0YoQ0ZVUkxSZXNwb25zZUNvcHlTdWdnZXN0 ZWRGaWxlbmFtZShtX2NmUmVzcG9uc2UuZ2V0KCkpKTsKICAgICByZXR1cm4gc3VnZ2VzdGVkRmls ZW5hbWUuZ2V0KCk7CiB9Cg==