137237 2014-09-29 16:12:34 -0700 Web Inspector: support better git diff of localizedStrings.js 2015-02-13 11:57:59 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 timothy timothy commit-queue ddkilzer graouts joepeck jonowells timothy webkit-bug-importer oldest_to_newest 1038095 0 timothy 2014-09-29 16:12:34 -0700 Git diffs localizedStrings.js as binary. We can improve that with a .gitattributes config file. 1038097 1 238893 timothy 2014-09-29 16:14:33 -0700 Created attachment 238893 Patch 1038100 2 timothy 2014-09-29 16:15:54 -0700 *** Bug 137238 has been marked as a duplicate of this bug. *** 1038117 3 joepeck 2014-09-29 17:57:54 -0700 Can we just make it a UTF-8 file like our .strings files? 1068088 4 timothy 2015-02-10 09:47:11 -0800 I don't know if the Apple tools support UTF-8 for JS Strings yet. 1068975 5 238893 joepeck 2015-02-13 11:13:27 -0800 Comment on attachment 238893 Patch r=me, but it would be great if we could just convert the file. 1068992 6 238893 commit-queue 2015-02-13 11:57:54 -0800 Comment on attachment 238893 Patch Clearing flags on attachment: 238893 Committed r180067: <http://trac.webkit.org/changeset/180067> 1068993 7 commit-queue 2015-02-13 11:57:59 -0800 All reviewed patches have been landed. Closing bug. 238893 2014-09-29 16:14:33 -0700 2015-02-13 11:57:54 -0800 Patch bug-137237-20140929161434.patch text/plain 1185 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj ZGZkNjVmM2E5NDdhZmEzYTcwZTdjMzAzZTgyNDNkZjAxZDI0NDQ3Li45MzI5Y2M5YzI1ZWE0YTkw MmY0MjEyYmNiYTVjMDYyNzBiMzllY2JmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNC0wOS0yOSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc3VwcG9ydCBiZXR0ZXIgZ2l0IGRpZmYgb2Yg bG9jYWxpemVkU3RyaW5ncy5qcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM3MjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiAuZ2l0YXR0cmlidXRlczogQWRkZWQuCisKIDIwMTQtMDktMjcgIEJyaWFu IEouIEJ1cmcgIDxidXJnQGNzLndhc2hpbmd0b24uZWR1PgogCiAgICAgICAgIFdlYiBSZXBsYXk6 IFBsYXliYWNrIHBvc2l0aW9uIHVwZGF0ZXMgc2hvdWxkIGJlIHNlbnQgYmVmb3JlIHRoZSBuZXh0 IGV2ZW50IGxvb3AgaW5wdXQgaXMgZGlzcGF0Y2hlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJLy5naXRhdHRyaWJ1dGVzIGIvU291cmNlL1dlYkluc3BlY3RvclVJLy5naXRhdHRy aWJ1dGVzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLmUyZmNjOGMzYmVlOTY5OGYwN2ZjYjBjZTY5OWRiZjQzNzgzNjQ5 MGUKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvLmdpdGF0dHJpYnV0 ZXMKQEAgLTAsMCArMSwzIEBACisjIFRvIGVuYWJsZSBzbWFydCBkaWZmaW5nIG9mIGxvY2FsaXpl ZFN0cmluZ3MuanMsIHJ1biB0aGUgZm9sbG93aW5nIGNvbW1hbmQ6CisjIGdpdCBjb25maWcgZGlm Zi5sb2NhbGl6YWJsZXN0cmluZ3MudGV4dGNvbnYgImljb252IC1mIHV0Zi0xNiAtdCB1dGYtOCIK K2xvY2FsaXplZFN0cmluZ3MuanMgZGlmZj1sb2NhbGl6YWJsZXN0cmluZ3MK