137223 2014-09-29 12:27:48 -0700 EWS is inconclusively spinning forever on a patch that breaks 500+ tests 2014-11-14 10:04:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=138743 P2 Normal --- 1 thorton jake.nielsen.webkit ap commit-queue glenn jake.nielsen.webkit thorton oldest_to_newest 1038009 0 thorton 2014-09-29 12:27:48 -0700 There's no way that EWS shouldn't be able to tell that the patch in https://bugs.webkit.org/show_bug.cgi?id=137164 breaks 500+ tests. But, it can't. See here: https://webkit-queues.appspot.com/patch/238809 1038625 1 239043 jake.nielsen.webkit 2014-10-01 13:15:51 -0700 Created attachment 239043 Adds a check to see whether the tests are hitting the test failure limit. If they are, code execution continues to see whether the tree is also red. 1038646 2 239043 commit-queue 2014-10-01 14:08:22 -0700 Comment on attachment 239043 Adds a check to see whether the tests are hitting the test failure limit. If they are, code execution continues to see whether the tree is also red. Clearing flags on attachment: 239043 Committed r174170: <http://trac.webkit.org/changeset/174170> 1038647 3 commit-queue 2014-10-01 14:08:28 -0700 All reviewed patches have been landed. Closing bug. 1038658 4 ap 2014-10-01 14:37:21 -0700 With this fix, will we have EWS spew the 500 failures into a Bugzilla comment? 1038703 5 jake.nielsen.webkit 2014-10-01 16:23:13 -0700 Crap, I forgot about that. Let me go check exactly what will happen. (In reply to comment #4) > With this fix, will we have EWS spew the 500 failures into a Bugzilla comment? 239043 2014-10-01 13:15:51 -0700 2014-10-01 14:08:21 -0700 Adds a check to see whether the tests are hitting the test failure limit. If they are, code execution continues to see whether the tree is also red. 0001-EWS-is-inconclusively-spinning-forever-on-a-patch-th.patch text/plain 2469 jake.nielsen.webkit RnJvbSBlMjBmMTQ3YzM1Njg1YzQxMWU3Yjc3MTk3MmYzYzBhN2U0MjcyYWE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtlIE5pZWxzZW4gPGphY29iX25pZWxzZW5AYXBwbGUuY29t PgpEYXRlOiBXZWQsIDEgT2N0IDIwMTQgMTM6MTM6NTkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBF V1MgaXMgaW5jb25jbHVzaXZlbHkgc3Bpbm5pbmcgZm9yZXZlciBvbiBhIHBhdGNoIHRoYXQgYnJl YWtzCiA1MDArIHRlc3RzIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzcyMjMKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBTY3JpcHRzL3dlYmtpdHB5L3Rv b2wvYm90L3BhdGNoYW5hbHlzaXN0YXNrLnB5OgpDaGVja3MgdG8gc2VlIHdoZXRoZXIgdGhlIHRl c3RzIGhhdmUgZXhjZWVkZWQgdGhlIGZhaWx1cmUgbGltaXQsIGFuZApvbmx5IHNwaW5zIG9mZiBh bm90aGVyIHRlc3QgaWYgdGhleSBoYXZlIG5vdCBleGNlZWRlZCB0aGUgbGltaXQuCihQYXRjaEFu YWx5c2lzVGFzay5fdGVzdF9wYXRjaCk6Ci0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEzICsrKysrKysrKysrKysKIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9ib3QvcGF0Y2hhbmFseXNpc3Rhc2sucHkgfCAgNSArKysrLQogMiBm aWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0 IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDBmMTRjMTYuLjZlMGU4 NzMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxNC0xMC0wMSAgSmFrZSBOaWVsc2VuICA8amFjb2JfbmllbHNlbkBh cHBsZS5jb20+CisKKyAgICAgICAgRVdTIGlzIGluY29uY2x1c2l2ZWx5IHNwaW5uaW5nIGZvcmV2 ZXIgb24gYSBwYXRjaCB0aGF0IGJyZWFrcyA1MDArCisgICAgICAgIHRlc3RzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcyMjMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv dG9vbC9ib3QvcGF0Y2hhbmFseXNpc3Rhc2sucHk6CisgICAgICAgIENoZWNrcyB0byBzZWUgd2hl dGhlciB0aGUgdGVzdHMgaGF2ZSBleGNlZWRlZCB0aGUgZmFpbHVyZSBsaW1pdCwgYW5kCisgICAg ICAgIG9ubHkgc3BpbnMgb2ZmIGFub3RoZXIgdGVzdCBpZiB0aGV5IGhhdmUgbm90IGV4Y2VlZGVk IHRoZSBsaW1pdC4KKyAgICAgICAgKFBhdGNoQW5hbHlzaXNUYXNrLl90ZXN0X3BhdGNoKToKKwog MjAxNC0xMC0wMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAg ICBFV1MgaXMgdG9vIGVhZ2VyIHRvIHNheSB0aGF0IGEgcGF0Y2ggZG9lcyBub3QgYXBwbHkgdG8g dHJ1bmsgb2YgcmVwb3NpdG9yeQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2JvdC9wYXRjaGFuYWx5c2lzdGFzay5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9ib3QvcGF0Y2hhbmFseXNpc3Rhc2sucHkKaW5kZXggYjAxYzZjNy4uYmE5NjU0ZCAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9wYXRjaGFuYWx5c2lzdGFzay5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3BhdGNoYW5hbHlzaXN0YXNr LnB5CkBAIC0xOTgsNyArMTk4LDEwIEBAIGNsYXNzIFBhdGNoQW5hbHlzaXNUYXNrKG9iamVjdCk6 CiAgICAgICAgICAgICByZXR1cm4gVHJ1ZQogCiAgICAgICAgIHNlY29uZF9yZXN1bHRzID0gc2Vs Zi5fZGVsZWdhdGUudGVzdF9yZXN1bHRzKCkKLSAgICAgICAgaWYgc2VsZi5fcmVzdWx0c19mYWls ZWRfZGlmZmVyZW50X3Rlc3RzKGZpcnN0X3Jlc3VsdHMsIHNlY29uZF9yZXN1bHRzKToKKworICAg ICAgICBpZiAobm90IGZpcnN0X3Jlc3VsdHMuZGlkX2V4Y2VlZF90ZXN0X2ZhaWx1cmVfbGltaXQo KSBhbmQKKyAgICAgICAgICAgIG5vdCBzZWNvbmRfcmVzdWx0cy5kaWRfZXhjZWVkX3Rlc3RfZmFp bHVyZV9saW1pdCgpIGFuZAorICAgICAgICAgICAgc2VsZi5fcmVzdWx0c19mYWlsZWRfZGlmZmVy ZW50X3Rlc3RzKGZpcnN0X3Jlc3VsdHMsIHNlY29uZF9yZXN1bHRzKSk6CiAgICAgICAgICAgICAj IFdlIGNvdWxkIHJlcG9ydCBmbGFreSB0ZXN0cyBoZXJlLCBidXQgd2Ugd291bGQgbmVlZCB0byBi ZSBjYXJlZnVsCiAgICAgICAgICAgICAjIHRvIHVzZSBzaW1pbGFyIGNoZWNrcyB0byBFeHBlY3Rl ZEZhaWx1cmVzLl9jYW5fdHJ1c3RfcmVzdWx0cwogICAgICAgICAgICAgIyB0byBtYWtlIHN1cmUg d2UgZG9uJ3QgcmVwb3J0IGNvbnN0YW50IGZhaWx1cmVzIGFzIGZsYWtlcyB3aGVuCi0tIAoxLjku MyAoQXBwbGUgR2l0LTUwKQoK