137220 2014-09-29 11:27:56 -0700 Add a ChromeClient API that gets called whenever the Page's audio playing state has changed 2014-10-06 14:37:08 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137050 1 adachan adachan eric.carlson jer.noble oldest_to_newest 1037998 0 adachan 2014-09-29 11:27:56 -0700 It'll most likely be: virtual void isPlayingAudioDidChange(bool) to match the bool isPlayingAudio() const; we are adding to WebCore::Page. See https://bugs.webkit.org/show_bug.cgi?id=137218. 1039775 1 239344 adachan 2014-10-06 11:45:31 -0700 Created attachment 239344 Patch 1039821 2 239344 jer.noble 2014-10-06 14:20:46 -0700 Comment on attachment 239344 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239344&action=review r=me, with nit. > Source/WebCore/page/ChromeClient.h:434 > + virtual void isPlayingAudioDidChange(bool /*newIsPlayingAudio*/) { } Nit: You don't need to include the (commented out) parameter name here. It's obvious from the function name. 1039823 3 adachan 2014-10-06 14:24:44 -0700 (In reply to comment #2) > (From update of attachment 239344 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239344&action=review > > r=me, with nit. > > > Source/WebCore/page/ChromeClient.h:434 > > + virtual void isPlayingAudioDidChange(bool /*newIsPlayingAudio*/) { } > > Nit: You don't need to include the (commented out) parameter name here. It's obvious from the function name. I'll remove it. Thanks for the review! 1039833 4 adachan 2014-10-06 14:37:08 -0700 Committed: https://trac.webkit.org/changeset/174365 239344 2014-10-06 11:45:31 -0700 2014-10-06 14:20:45 -0700 Patch 0001-Add-ChromeClient-isPlayingAudioDidChange.patch text/plain 2657 adachan RnJvbSBmYWQzYWZlMGJkZjNkMmVjMTIyMjhhNTA3NzY4MTk2OGYwZmE1NTAyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IE1v biwgNiBPY3QgMjAxNCAxMTo0NDoyNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBDaHJvbWVD bGllbnQ6OmlzUGxheWluZ0F1ZGlvRGlkQ2hhbmdlKCkuCiBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM3MjIwCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClRo aXMgaXMgY2FsbGVkIHdoZW4gdGhlIFBhZ2UncyBtX2lzUGxheWluZ0F1ZGlvIGNoYW5nZXMuCgpO byBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KCiogcGFnZS9DaHJvbWVDbGllbnQuaDoK KFdlYkNvcmU6OkNocm9tZUNsaWVudDo6aXNQbGF5aW5nQXVkaW9EaWRDaGFuZ2UpOgoqIHBhZ2Uv UGFnZS5jcHA6CihXZWJDb3JlOjpQYWdlOjp1cGRhdGVJc1BsYXlpbmdBdWRpbyk6Ci0tLQogU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICB8IDE2ICsrKysrKysrKysrKysrKysKIFNv dXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmggfCAgMiArKwogU291cmNlL1dlYkNvcmUv cGFnZS9QYWdlLmNwcCAgICAgICB8ICAzICstLQogMyBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiMDFjNDZjLi5iNDRlNmI5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTQtMTAtMDYgIEFkYSBDaGFuICA8YWRhY2hh bkBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIENocm9tZUNsaWVudDo6aXNQbGF5aW5nQXVkaW9E aWRDaGFuZ2UoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNzIyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgaXMgY2FsbGVkIHdoZW4gdGhlIFBhZ2UncyBtX2lzUGxheWluZ0F1ZGlvIGNoYW5n ZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAg ICAgKiBwYWdlL0Nocm9tZUNsaWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50 Ojppc1BsYXlpbmdBdWRpb0RpZENoYW5nZSk6CisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBhZ2U6OnVwZGF0ZUlzUGxheWluZ0F1ZGlvKToKKworMjAxNC0xMC0w NiAgQWRhIENoYW4gIDxhZGFjaGFuQGFwcGxlLmNvbT4KKwogICAgICAgICBJbXBsZW1lbnQgUGFn ZTo6aXNQbGF5aW5nQXVkaW8oKS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNzIxOAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0No cm9tZUNsaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAppbmRleCBi ZjU2MzRmLi5hZjBkNzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNs aWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgKQEAgLTQzMSw2 ICs0MzEsOCBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkVXNlVGlsZWRCYWNr aW5nRm9yRnJhbWVWaWV3KGNvbnN0IEZyYW1lVmlldyopIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 CiAKKyAgICB2aXJ0dWFsIHZvaWQgaXNQbGF5aW5nQXVkaW9EaWRDaGFuZ2UoYm9vbCAvKm5ld0lz UGxheWluZ0F1ZGlvKi8pIHsgfQorCiAjaWYgRU5BQkxFKFNVQlRMRV9DUllQVE8pCiAgICAgdmly dHVhbCBib29sIHdyYXBDcnlwdG9LZXkoY29uc3QgVmVjdG9yPHVpbnQ4X3Q+JiwgVmVjdG9yPHVp bnQ4X3Q+JikgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJvb2wgdW53cmFw Q3J5cHRvS2V5KGNvbnN0IFZlY3Rvcjx1aW50OF90PiYsIFZlY3Rvcjx1aW50OF90PiYpIGNvbnN0 IHsgcmV0dXJuIGZhbHNlOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAppbmRleCAxMTJlNjllLi5iY2FlMzYx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvUGFnZS5jcHAKQEAgLTEyMDgsOCArMTIwOCw3IEBAIHZvaWQgUGFnZTo6dXBk YXRlSXNQbGF5aW5nQXVkaW8oKQogCiAgICAgbV9pc1BsYXlpbmdBdWRpbyA9IGlzUGxheWluZ0F1 ZGlvOwogCi0gICAgLy8gRklYTUU6IE5vdGlmeSB0aGUgQ2hyb21lQ2xpZW50IHRoYXQgdGhlIGlz UGxheWluZ0F1ZGlvIHN0YXRlIGhhcyBjaGFuZ2VkLgotICAgIC8vIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcyMjAKKyAgICBjaHJvbWUoKS5jbGllbnQoKS5pc1Bs YXlpbmdBdWRpb0RpZENoYW5nZShtX2lzUGxheWluZ0F1ZGlvKTsKIH0KIAogI2lmICFBU1NFUlRf RElTQUJMRUQKLS0gCjEuOS4zIChBcHBsZSBHaXQtNTApCgo=