137214 2014-09-29 08:31:11 -0700 [CSS Grid Layout] Use modern for-loops in RenderGrid 2014-10-15 04:44:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 svillar svillar commit-queue darin esprehn+autocc glenn jfernandez kondapallykalyan rego svillar oldest_to_newest 1037937 0 svillar 2014-09-29 08:31:11 -0700 [CSS Grid Layout] Use modern for-loops in RenderGrid 1037940 1 238856 svillar 2014-09-29 08:34:38 -0700 Created attachment 238856 Patch 1038186 2 svillar 2014-09-30 03:30:46 -0700 Committed r174098: <http://trac.webkit.org/changeset/174098> 238856 2014-09-29 08:34:38 -0700 2014-09-29 09:29:06 -0700 Patch bug-137214-20140929173437.patch text/plain 7202 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDUwN2YzYmE0MDJhZjE5 NzZlYWU2YmQ0ODgxYTBmYjU2MGJkZmE5YS4uNGM4NzViNDk5ODM0YjQzMzQ3MGQ4MTMwZjVjNTUy OTA0Y2VjN2M0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA5LTI5ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3Jp ZCBMYXlvdXRdIFVzZSBtb2Rlcm4gZm9yLWxvb3BzIGluIFJlbmRlckdyaWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzIxNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyBjb2RlIGlzIGFscmVhZHkg dXNpbmcgbW9kZXJuIHJhbmdlIGJhc2VkIGZvciBsb29wcy4gV2UgaGFkIHNvbWUKKyAgICAgICAg Im9sZCIgY29kZSBwZW5kaW5nIHRvIGJlIG1pZ3JhdGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyBhcyB0aGVyZSBpcyBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJHcmlkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdyaWQ6OmNv bXB1dGVJbnRyaW5zaWNMb2dpY2FsV2lkdGhzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdy aWQ6OmNvbXB1dGVVc2VkQnJlYWR0aE9mR3JpZFRyYWNrcyk6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJHcmlkOjpjb21wdXRlTm9ybWFsaXplZEZyYWN0aW9uQnJlYWR0aCk6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJHcmlkOjpwb3B1bGF0ZUV4cGxpY2l0R3JpZEFuZE9yZGVySXRlcmF0b3Ip OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6bGF5b3V0R3JpZEl0ZW1zKToKKwogMjAx NC0wOS0yOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZC4gTW92ZSBzb3VyY2VzIG5vdCB1c2luZyBHVEsrIGZyb20gV2ViQ29y ZVBsYXRmb3JtR1RLX1NPVVJDRVMgdG8gV2ViQ29yZV9TT1VSQ0VTLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckdyaWQuY3BwCmluZGV4IDYxNmNiMDNlM2E0MjljZjFkNGViZGFkMzdiYjdm NWVmMjk5YWE0YTEuLjg0Njg4OWU4OWE2OWQ3YWQxMTkzN2JkYTkxYTAzNDQxOTQzMzAxOTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKQEAgLTI0Nyw5ICsyNDcsOSBA QCB2b2lkIFJlbmRlckdyaWQ6OmNvbXB1dGVJbnRyaW5zaWNMb2dpY2FsV2lkdGhzKExheW91dFVu aXQmIG1pbkxvZ2ljYWxXaWR0aCwgTGF5bwogICAgIExheW91dFVuaXQgYXZhaWxhYmxlTG9naWNh bFNwYWNlID0gMDsKICAgICBjb25zdF9jYXN0PFJlbmRlckdyaWQqPih0aGlzKS0+Y29tcHV0ZVVz ZWRCcmVhZHRoT2ZHcmlkVHJhY2tzKEZvckNvbHVtbnMsIHNpemluZ0RhdGEsIGF2YWlsYWJsZUxv Z2ljYWxTcGFjZSk7CiAKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHNpemluZ0RhdGEuY29s dW1uVHJhY2tzLnNpemUoKTsgKytpKSB7Ci0gICAgICAgIExheW91dFVuaXQgbWluVHJhY2tCcmVh ZHRoID0gc2l6aW5nRGF0YS5jb2x1bW5UcmFja3NbaV0ubV91c2VkQnJlYWR0aDsKLSAgICAgICAg TGF5b3V0VW5pdCBtYXhUcmFja0JyZWFkdGggPSBzaXppbmdEYXRhLmNvbHVtblRyYWNrc1tpXS5t X21heEJyZWFkdGg7CisgICAgZm9yIChhdXRvJiBjb2x1bW4gOiBzaXppbmdEYXRhLmNvbHVtblRy YWNrcykgeworICAgICAgICBMYXlvdXRVbml0IG1pblRyYWNrQnJlYWR0aCA9IGNvbHVtbi5tX3Vz ZWRCcmVhZHRoOworICAgICAgICBMYXlvdXRVbml0IG1heFRyYWNrQnJlYWR0aCA9IGNvbHVtbi5t X21heEJyZWFkdGg7CiAgICAgICAgIG1heFRyYWNrQnJlYWR0aCA9IHN0ZDo6bWF4KG1heFRyYWNr QnJlYWR0aCwgbWluVHJhY2tCcmVhZHRoKTsKIAogICAgICAgICBtaW5Mb2dpY2FsV2lkdGggKz0g bWluVHJhY2tCcmVhZHRoOwpAQCAtMzIwLDkgKzMyMCw5IEBAIHZvaWQgUmVuZGVyR3JpZDo6Y29t cHV0ZVVzZWRCcmVhZHRoT2ZHcmlkVHJhY2tzKEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbiBkaXJl Y3RpCiAgICAgaWYgKCFzaXppbmdEYXRhLmNvbnRlbnRTaXplZFRyYWNrc0luZGV4LmlzRW1wdHko KSkKICAgICAgICAgcmVzb2x2ZUNvbnRlbnRCYXNlZFRyYWNrU2l6aW5nRnVuY3Rpb25zKGRpcmVj dGlvbiwgc2l6aW5nRGF0YSk7CiAKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHRyYWNrcy5z aXplKCk7ICsraSkgewotICAgICAgICBBU1NFUlQodHJhY2tzW2ldLm1fbWF4QnJlYWR0aCAhPSBp bmZpbml0eSk7Ci0gICAgICAgIGF2YWlsYWJsZUxvZ2ljYWxTcGFjZSAtPSB0cmFja3NbaV0ubV91 c2VkQnJlYWR0aDsKKyAgICBmb3IgKGF1dG8mIHRyYWNrIDogdHJhY2tzKSB7CisgICAgICAgIEFT U0VSVCh0cmFjay5tX21heEJyZWFkdGggIT0gaW5maW5pdHkpOworICAgICAgICBhdmFpbGFibGVM b2dpY2FsU3BhY2UgLT0gdHJhY2subV91c2VkQnJlYWR0aDsKICAgICB9CiAKICAgICBjb25zdCBi b29sIGhhc1VuZGVmaW5lZFJlbWFpbmluZ1NwYWNlID0gKGRpcmVjdGlvbiA9PSBGb3JSb3dzKSA/ IHN0eWxlKCkubG9naWNhbEhlaWdodCgpLmlzQXV0bygpIDogZ3JpZEVsZW1lbnRJc1Nocmlua1Rv Rml0KCk7CkBAIC0zMzIsMTYgKzMzMiwxNiBAQCB2b2lkIFJlbmRlckdyaWQ6OmNvbXB1dGVVc2Vk QnJlYWR0aE9mR3JpZFRyYWNrcyhHcmlkVHJhY2tTaXppbmdEaXJlY3Rpb24gZGlyZWN0aQogCiAg ICAgLy8gMy4gR3JvdyBhbGwgR3JpZCB0cmFja3MgaW4gR3JpZFRyYWNrcyBmcm9tIHRoZWlyIFVz ZWRCcmVhZHRoIHVwIHRvIHRoZWlyIE1heEJyZWFkdGggdmFsdWUgdW50aWwKICAgICAvLyBhdmFp bGFibGVMb2dpY2FsU3BhY2UgKFJlbWFpbmluZ1NwYWNlIGluIHRoZSBzcGVjcykgaXMgZXhoYXVz dGVkLgotICAgIGNvbnN0IHNpemVfdCB0cmFja3NTaXplID0gdHJhY2tzLnNpemUoKTsKICAgICBp ZiAoIWhhc1VuZGVmaW5lZFJlbWFpbmluZ1NwYWNlKSB7CisgICAgICAgIGNvbnN0IHNpemVfdCB0 cmFja3NTaXplID0gdHJhY2tzLnNpemUoKTsKICAgICAgICAgVmVjdG9yPEdyaWRUcmFjayo+IHRy YWNrc0ZvckRpc3RyaWJ1dGlvbih0cmFja3NTaXplKTsKICAgICAgICAgZm9yIChzaXplX3QgaSA9 IDA7IGkgPCB0cmFja3NTaXplOyArK2kpCiAgICAgICAgICAgICB0cmFja3NGb3JEaXN0cmlidXRp b25baV0gPSB0cmFja3MuZGF0YSgpICsgaTsKIAogICAgICAgICBkaXN0cmlidXRlU3BhY2VUb1Ry YWNrcyh0cmFja3NGb3JEaXN0cmlidXRpb24sIDAsICZHcmlkVHJhY2s6OnVzZWRCcmVhZHRoLCAm R3JpZFRyYWNrOjpncm93VXNlZEJyZWFkdGgsIHNpemluZ0RhdGEsIGF2YWlsYWJsZUxvZ2ljYWxT cGFjZSk7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCB0cmFj a3NTaXplOyArK2kpCi0gICAgICAgICAgICB0cmFja3NbaV0ubV91c2VkQnJlYWR0aCA9IHRyYWNr c1tpXS5tX21heEJyZWFkdGg7CisgICAgICAgIGZvciAoYXV0byYgdHJhY2sgOiB0cmFja3MpCisg ICAgICAgICAgICB0cmFjay5tX3VzZWRCcmVhZHRoID0gdHJhY2subV9tYXhCcmVhZHRoOwogICAg IH0KIAogICAgIGlmIChmbGV4aWJsZVNpemVkVHJhY2tzSW5kZXguaXNFbXB0eSgpKQpAQCAtMzUy LDggKzM1Miw3IEBAIHZvaWQgUmVuZGVyR3JpZDo6Y29tcHV0ZVVzZWRCcmVhZHRoT2ZHcmlkVHJh Y2tzKEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbiBkaXJlY3RpCiAgICAgaWYgKCFoYXNVbmRlZmlu ZWRSZW1haW5pbmdTcGFjZSkKICAgICAgICAgbm9ybWFsaXplZEZyYWN0aW9uQnJlYWR0aCA9IGNv bXB1dGVOb3JtYWxpemVkRnJhY3Rpb25CcmVhZHRoKHRyYWNrcywgR3JpZFNwYW4oMCwgdHJhY2tz LnNpemUoKSAtIDEpLCBkaXJlY3Rpb24sIGF2YWlsYWJsZUxvZ2ljYWxTcGFjZSk7CiAgICAgZWxz ZSB7Ci0gICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgZmxleGlibGVTaXplZFRyYWNrc0lu ZGV4LnNpemUoKTsgKytpKSB7Ci0gICAgICAgICAgICBjb25zdCBzaXplX3QgdHJhY2tJbmRleCA9 IGZsZXhpYmxlU2l6ZWRUcmFja3NJbmRleFtpXTsKKyAgICAgICAgZm9yIChhdXRvIHRyYWNrSW5k ZXggOiBmbGV4aWJsZVNpemVkVHJhY2tzSW5kZXgpIHsKICAgICAgICAgICAgIGNvbnN0IEdyaWRU cmFja1NpemUmIHRyYWNrU2l6ZSA9IGdyaWRUcmFja1NpemUoZGlyZWN0aW9uLCB0cmFja0luZGV4 KTsKICAgICAgICAgICAgIG5vcm1hbGl6ZWRGcmFjdGlvbkJyZWFkdGggPSBzdGQ6Om1heChub3Jt YWxpemVkRnJhY3Rpb25CcmVhZHRoLCB0cmFja3NbdHJhY2tJbmRleF0ubV91c2VkQnJlYWR0aCAv IHRyYWNrU2l6ZS5tYXhUcmFja0JyZWFkdGgoKS5mbGV4KCkpOwogICAgICAgICB9CkBAIC0zNzQs MTEgKzM3MywxMCBAQCB2b2lkIFJlbmRlckdyaWQ6OmNvbXB1dGVVc2VkQnJlYWR0aE9mR3JpZFRy YWNrcyhHcmlkVHJhY2tTaXppbmdEaXJlY3Rpb24gZGlyZWN0aQogICAgICAgICB9CiAgICAgfQog Ci0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBmbGV4aWJsZVNpemVkVHJhY2tzSW5kZXguc2l6 ZSgpOyArK2kpIHsKLSAgICAgICAgY29uc3Qgc2l6ZV90IHRyYWNrSW5kZXggPSBmbGV4aWJsZVNp emVkVHJhY2tzSW5kZXhbaV07CisgICAgZm9yIChhdXRvIHRyYWNrSW5kZXggOiBmbGV4aWJsZVNp emVkVHJhY2tzSW5kZXgpIHsKICAgICAgICAgY29uc3QgR3JpZFRyYWNrU2l6ZSYgdHJhY2tTaXpl ID0gZ3JpZFRyYWNrU2l6ZShkaXJlY3Rpb24sIHRyYWNrSW5kZXgpOwotCi0gICAgICAgIHRyYWNr c1t0cmFja0luZGV4XS5tX3VzZWRCcmVhZHRoID0gc3RkOjptYXg8TGF5b3V0VW5pdD4odHJhY2tz W3RyYWNrSW5kZXhdLm1fdXNlZEJyZWFkdGgsIG5vcm1hbGl6ZWRGcmFjdGlvbkJyZWFkdGggKiB0 cmFja1NpemUubWF4VHJhY2tCcmVhZHRoKCkuZmxleCgpKTsKKyAgICAgICAgR3JpZFRyYWNrJiB0 cmFjayA9IHRyYWNrc1t0cmFja0luZGV4XTsKKyAgICAgICAgdHJhY2subV91c2VkQnJlYWR0aCA9 IHN0ZDo6bWF4PExheW91dFVuaXQ+KHRyYWNrLm1fdXNlZEJyZWFkdGgsIG5vcm1hbGl6ZWRGcmFj dGlvbkJyZWFkdGggKiB0cmFja1NpemUubWF4VHJhY2tCcmVhZHRoKCkuZmxleCgpKTsKICAgICB9 CiB9CiAKQEAgLTQ0Nyw4ICs0NDUsNyBAQCBkb3VibGUgUmVuZGVyR3JpZDo6Y29tcHV0ZU5vcm1h bGl6ZWRGcmFjdGlvbkJyZWFkdGgoVmVjdG9yPEdyaWRUcmFjaz4mIHRyYWNrcywgYwogICAgIExh eW91dFVuaXQgZnJhY3Rpb25WYWx1ZUJhc2VkT25HcmlkSXRlbXNSYXRpbyA9IDA7CiAgICAgTGF5 b3V0VW5pdCBhdmFpbGFibGVMb2dpY2FsU3BhY2VJZ25vcmluZ0ZyYWN0aW9uVHJhY2tzID0gYXZh aWxhYmxlTG9naWNhbFNwYWNlOwogCi0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCB0cmFja3NG b3JOb3JtYWxpemF0aW9uLnNpemUoKTsgKytpKSB7Ci0gICAgICAgIGNvbnN0IEdyaWRUcmFja0Zv ck5vcm1hbGl6YXRpb24mIHRyYWNrID0gdHJhY2tzRm9yTm9ybWFsaXphdGlvbltpXTsKKyAgICBm b3IgKGF1dG8mIHRyYWNrIDogdHJhY2tzRm9yTm9ybWFsaXphdGlvbikgewogICAgICAgICBpZiAo dHJhY2subV9ub3JtYWxpemVkRmxleFZhbHVlID4gZnJhY3Rpb25WYWx1ZUJhc2VkT25HcmlkSXRl bXNSYXRpbykgewogICAgICAgICAgICAgLy8gSWYgdGhlIG5vcm1hbGl6ZWQgZmxleCB2YWx1ZSAo d2Ugb3JkZXJlZCB8dHJhY2tzRm9yTm9ybWFsaXphdGlvbnwgYnkgaW5jcmVhc2luZyBub3JtYWxp emVkIGZsZXggdmFsdWUpCiAgICAgICAgICAgICAvLyB3aWxsIG1ha2UgdXMgb3ZlcmZsb3cgb3Vy IGNvbnRhaW5lciwgdGhlbiBzdG9wLiBXZSBoYXZlIHRoZSBwcmV2aW91cyBzdGVwJ3MgcmF0aW8g aXMgdGhlIGJlc3QgZml0LgpAQCAtNzgxLDggKzc3OCw4IEBAIHZvaWQgUmVuZGVyR3JpZDo6cG9w dWxhdGVFeHBsaWNpdEdyaWRBbmRPcmRlckl0ZXJhdG9yKCkKICAgICB9CiAKICAgICBtX2dyaWQu Z3JvdyhtYXhpbXVtUm93SW5kZXgpOwotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9ncmlk LnNpemUoKTsgKytpKQotICAgICAgICBtX2dyaWRbaV0uZ3JvdyhtYXhpbXVtQ29sdW1uSW5kZXgp OworICAgIGZvciAoYXV0byYgY29sdW1uIDogbV9ncmlkKQorICAgICAgICBjb2x1bW4uZ3Jvdyht YXhpbXVtQ29sdW1uSW5kZXgpOwogfQogCiBzdGQ6OnVuaXF1ZV9wdHI8R3JpZENvb3JkaW5hdGU+ IFJlbmRlckdyaWQ6OmNyZWF0ZUVtcHR5R3JpZEFyZWFBdFNwZWNpZmllZFBvc2l0aW9uc091dHNp ZGVHcmlkKGNvbnN0IFJlbmRlckJveCYgZ3JpZEl0ZW0sIEdyaWRUcmFja1NpemluZ0RpcmVjdGlv biBzcGVjaWZpZWREaXJlY3Rpb24sIGNvbnN0IEdyaWRTcGFuJiBzcGVjaWZpZWRQb3NpdGlvbnMp IGNvbnN0CkBAIC05MzUsOCArOTMyLDggQEAgdm9pZCBSZW5kZXJHcmlkOjpsYXlvdXRHcmlkSXRl bXMoKQogICAgICAgICAgICAgY2hpbGQtPnJlcGFpbnREdXJpbmdMYXlvdXRJZk1vdmVkKG9sZENo aWxkUmVjdCk7CiAgICAgfQogCi0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzaXppbmdEYXRh LnJvd1RyYWNrcy5zaXplKCk7ICsraSkKLSAgICAgICAgc2V0TG9naWNhbEhlaWdodChsb2dpY2Fs SGVpZ2h0KCkgKyBzaXppbmdEYXRhLnJvd1RyYWNrc1tpXS5tX3VzZWRCcmVhZHRoKTsKKyAgICBm b3IgKGF1dG8mIHJvdyA6IHNpemluZ0RhdGEucm93VHJhY2tzKQorICAgICAgICBzZXRMb2dpY2Fs SGVpZ2h0KGxvZ2ljYWxIZWlnaHQoKSArIHJvdy5tX3VzZWRCcmVhZHRoKTsKIAogICAgIC8vIG1p biAvIG1heCBsb2dpY2FsIGhlaWdodCBpcyBoYW5kbGVkIGluIHVwZGF0ZUxvZ2ljYWxIZWlnaHQo KS4KICAgICBzZXRMb2dpY2FsSGVpZ2h0KGxvZ2ljYWxIZWlnaHQoKSArIGJvcmRlckFuZFBhZGRp bmdMb2dpY2FsSGVpZ2h0KCkpOwo=