137213 2014-09-29 07:24:42 -0700 Minor bug in UIClient::exceededDatabaseQuota() 2015-08-31 21:35:16 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hur.ims hur.ims andersca ap commit-queue dbates oldest_to_newest 1037927 0 hur.ims 2014-09-29 07:24:42 -0700 completionHandler() should not be called more than once. 1037928 1 238853 hur.ims 2014-09-29 07:50:38 -0700 Created attachment 238853 Patch 1038023 2 238853 andersca 2014-09-29 13:12:04 -0700 Comment on attachment 238853 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238853&action=review > Source/WebKit2/ChangeLog:9 > + (WKPageSetPageUIClient): Patch looks great, but please fill in the ChangeLog, saying something like: "Make sure to not call the completion handler twice if exceededDatabaseQuota is null." 1038118 3 238898 hur.ims 2014-09-29 18:03:47 -0700 Created attachment 238898 Patch 1038805 4 238898 commit-queue 2014-10-02 01:01:17 -0700 Comment on attachment 238898 Patch Clearing flags on attachment: 238898 Committed r174204: <http://trac.webkit.org/changeset/174204> 1038806 5 commit-queue 2014-10-02 01:01:21 -0700 All reviewed patches have been landed. Closing bug. 238853 2014-09-29 07:50:38 -0700 2014-09-29 18:03:39 -0700 Patch bug-137213-20140929235038.patch text/plain 1966 hur.ims U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2E2YmNkOTEyMmIxOTUx ZTQzMDExZTI3YzkyNDY0NTE3OTc2NDYwOS4uYmUzNjM3ZGVmYjFiMjVkYTM4YThkMTk1Mzg5MDM2 YzA4YjY2OWUyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA5LTI5ICBKaW5Z b3VuZyBIdXIgIDxodXJpbXNAZ21haWwuY29tPgorCisgICAgICAgIE1pbm9yIGJ1ZyBpbiBVSUNs aWVudDo6ZXhjZWVkZWREYXRhYmFzZVF1b3RhKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzIxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHA6CisgICAg ICAgIChXS1BhZ2VTZXRQYWdlVUlDbGllbnQpOgorCiAyMDE0LTA5LTI5ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNzI5 MTkpOiBXZWJLaXRQbHVnaW5Qcm9jZXNzIGZhaWxzIHRvIHNjYW4gR1RLKzIgcGx1Z2lucyBhZnRl ciByMTcyOTE5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dL UGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAppbmRl eCAxM2M1ZTViMzI3NzViMzg4NzE4OWUxM2MwOTNhODc1MmIzYjNiMTczLi4yNWM3MjVlODU0ZGYx MWVlZTNiODJiNGIwMzRjNTNkYTJjMzRkMWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0MvV0tQYWdlLmNwcApAQCAtMTQ3Myw4ICsxNDczLDEwIEBAIHZvaWQgV0tQYWdlU2V0UGFn ZVVJQ2xpZW50KFdLUGFnZVJlZiBwYWdlUmVmLCBjb25zdCBXS1BhZ2VVSUNsaWVudEJhc2UqIHdr Q2xpZW50CiAKICAgICAgICAgdmlydHVhbCB2b2lkIGV4Y2VlZGVkRGF0YWJhc2VRdW90YShXZWJQ YWdlUHJveHkqIHBhZ2UsIFdlYkZyYW1lUHJveHkqIGZyYW1lLCBXZWJTZWN1cml0eU9yaWdpbiog b3JpZ2luLCBjb25zdCBTdHJpbmcmIGRhdGFiYXNlTmFtZSwgY29uc3QgU3RyaW5nJiBkYXRhYmFz ZURpc3BsYXlOYW1lLCB1bnNpZ25lZCBsb25nIGxvbmcgY3VycmVudFF1b3RhLCB1bnNpZ25lZCBs b25nIGxvbmcgY3VycmVudE9yaWdpblVzYWdlLCB1bnNpZ25lZCBsb25nIGxvbmcgY3VycmVudERh dGFiYXNlVXNhZ2UsIHVuc2lnbmVkIGxvbmcgbG9uZyBleHBlY3RlZFVzYWdlLCBzdGQ6OmZ1bmN0 aW9uPHZvaWQgKHVuc2lnbmVkIGxvbmcgbG9uZyk+IGNvbXBsZXRpb25IYW5kbGVyKSBvdmVycmlk ZQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIW1fY2xpZW50LmV4Y2VlZGVkRGF0YWJhc2VR dW90YSkKKyAgICAgICAgICAgIGlmICghbV9jbGllbnQuZXhjZWVkZWREYXRhYmFzZVF1b3RhKSB7 CiAgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoY3VycmVudFF1b3RhKTsKKyAgICAg ICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIGNvbXBsZXRp b25IYW5kbGVyKG1fY2xpZW50LmV4Y2VlZGVkRGF0YWJhc2VRdW90YSh0b0FQSShwYWdlKSwgdG9B UEkoZnJhbWUpLCB0b0FQSShvcmlnaW4pLCB0b0FQSShkYXRhYmFzZU5hbWUuaW1wbCgpKSwgdG9B UEkoZGF0YWJhc2VEaXNwbGF5TmFtZS5pbXBsKCkpLCBjdXJyZW50UXVvdGEsIGN1cnJlbnRPcmln aW5Vc2FnZSwgY3VycmVudERhdGFiYXNlVXNhZ2UsIGV4cGVjdGVkVXNhZ2UsIG1fY2xpZW50LmJh c2UuY2xpZW50SW5mbykpOwogICAgICAgICB9Cg== 238898 2014-09-29 18:03:47 -0700 2014-10-02 01:01:16 -0700 Patch bug-137213-20140930100347.patch text/plain 2062 hur.ims U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0MDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2E2YmNkOTEyMmIxOTUx ZTQzMDExZTI3YzkyNDY0NTE3OTc2NDYwOS4uMGUzNzYxYTkyYzEzNGIwYTg1M2QyNzk2MDlhNThm ZjQwMWY3N2E2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA5LTI5ICBKaW5Z b3VuZyBIdXIgIDxodXJpbXNAZ21haWwuY29tPgorCisgICAgICAgIE1pbm9yIGJ1ZyBpbiBVSUNs aWVudDo6ZXhjZWVkZWREYXRhYmFzZVF1b3RhKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzIxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSBub3QgdG8gY2FsbCB0aGUgY29tcGxldGlv biBoYW5kbGVyIHR3aWNlIGlmIGV4Y2VlZGVkRGF0YWJhc2VRdW90YSBpcyBudWxsLgorCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHA6CisgICAgICAgIChXS1BhZ2VTZXRQYWdl VUlDbGllbnQpOgorCiAyMDE0LTA5LTI5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNzI5MTkpOiBXZWJLaXRQbHVnaW5Q cm9jZXNzIGZhaWxzIHRvIHNjYW4gR1RLKzIgcGx1Z2lucyBhZnRlciByMTcyOTE5LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAppbmRleCAxM2M1ZTViMzI3NzViMzg4 NzE4OWUxM2MwOTNhODc1MmIzYjNiMTczLi4yNWM3MjVlODU0ZGYxMWVlZTNiODJiNGIwMzRjNTNk YTJjMzRkMWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQ YWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcApA QCAtMTQ3Myw4ICsxNDczLDEwIEBAIHZvaWQgV0tQYWdlU2V0UGFnZVVJQ2xpZW50KFdLUGFnZVJl ZiBwYWdlUmVmLCBjb25zdCBXS1BhZ2VVSUNsaWVudEJhc2UqIHdrQ2xpZW50CiAKICAgICAgICAg dmlydHVhbCB2b2lkIGV4Y2VlZGVkRGF0YWJhc2VRdW90YShXZWJQYWdlUHJveHkqIHBhZ2UsIFdl YkZyYW1lUHJveHkqIGZyYW1lLCBXZWJTZWN1cml0eU9yaWdpbiogb3JpZ2luLCBjb25zdCBTdHJp bmcmIGRhdGFiYXNlTmFtZSwgY29uc3QgU3RyaW5nJiBkYXRhYmFzZURpc3BsYXlOYW1lLCB1bnNp Z25lZCBsb25nIGxvbmcgY3VycmVudFF1b3RhLCB1bnNpZ25lZCBsb25nIGxvbmcgY3VycmVudE9y aWdpblVzYWdlLCB1bnNpZ25lZCBsb25nIGxvbmcgY3VycmVudERhdGFiYXNlVXNhZ2UsIHVuc2ln bmVkIGxvbmcgbG9uZyBleHBlY3RlZFVzYWdlLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKHVuc2lnbmVk IGxvbmcgbG9uZyk+IGNvbXBsZXRpb25IYW5kbGVyKSBvdmVycmlkZQogICAgICAgICB7Ci0gICAg ICAgICAgICBpZiAoIW1fY2xpZW50LmV4Y2VlZGVkRGF0YWJhc2VRdW90YSkKKyAgICAgICAgICAg IGlmICghbV9jbGllbnQuZXhjZWVkZWREYXRhYmFzZVF1b3RhKSB7CiAgICAgICAgICAgICAgICAg Y29tcGxldGlvbkhhbmRsZXIoY3VycmVudFF1b3RhKTsKKyAgICAgICAgICAgICAgICByZXR1cm47 CisgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKG1fY2xpZW50 LmV4Y2VlZGVkRGF0YWJhc2VRdW90YSh0b0FQSShwYWdlKSwgdG9BUEkoZnJhbWUpLCB0b0FQSShv cmlnaW4pLCB0b0FQSShkYXRhYmFzZU5hbWUuaW1wbCgpKSwgdG9BUEkoZGF0YWJhc2VEaXNwbGF5 TmFtZS5pbXBsKCkpLCBjdXJyZW50UXVvdGEsIGN1cnJlbnRPcmlnaW5Vc2FnZSwgY3VycmVudERh dGFiYXNlVXNhZ2UsIGV4cGVjdGVkVXNhZ2UsIG1fY2xpZW50LmJhc2UuY2xpZW50SW5mbykpOwog ICAgICAgICB9Cg==