137191 2014-09-28 02:07:32 -0700 REGRESSION(r172919): WebKitPluginProcess fails to scan GTK+2 plugins after r172919. 2014-09-29 01:52:04 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand svillar oldest_to_newest 1037769 0 cgarcia 2014-09-28 02:07:32 -0700 In r172919 I moved the GTK+ symbols mix check earlier, before the plugin is loaded and initialized. That made impossible to use the gtk3 plugin process to scan gtk2 plugins, because we need to load the plugin to get its metadata. $ bin/WebKitPluginProcess -scanPlugin /usr/lib/mozilla/plugins/flash-mozilla.so $ echo $? 1 $ bin/WebKitPluginProcess2 -scanPlugin /usr/lib/mozilla/plugins/flash-mozilla.so Shockwave Flash Shockwave Flash 11.2 r202 application/x-shockwave-flash:swf:Shockwave Flash;application/futuresplash:spl:FutureSplash Player requires-gtk2 We need to load and initialize the plugin to get its metadata, but not to check if it requires GTK2, so we can move that check to the UI process to decide also which plugin process to use when scanning a plugin. This problem hasn't been noticed earlier thanks to the plugins cache, but after a flash plugin upgrade of my distro, the cache forces a new scan of the plugin that always fails. 1037770 1 238810 cgarcia 2014-09-28 02:22:47 -0700 Created attachment 238810 Patch 1037894 2 cgarcia 2014-09-29 01:52:04 -0700 Committed r174054: <http://trac.webkit.org/changeset/174054> 238810 2014-09-28 02:22:47 -0700 2014-09-29 01:19:48 -0700 Patch wk2-scan-plugin-gtk2.diff text/plain 6894 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4ZmZlYTBhLi4wNTBhZTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEg QEAKKzIwMTQtMDktMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE3MjkxOSk6IFdlYktpdFBsdWdpblByb2Nlc3MgZmFp bHMgdG8gc2NhbiBHVEsrMiBwbHVnaW5zIGFmdGVyIHIxNzI5MTkuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcxOTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMTcyOTE5IEkgbW92ZWQgdGhlIEdU Sysgc3ltYm9scyBtaXggY2hlY2sgZWFybGllciwgYmVmb3JlIHRoZQorICAgICAgICBwbHVnaW4g aXMgbG9hZGVkIGFuZCBpbml0aWFsaXplZC4gVGhhdCBtYWRlIGltcG9zc2libGUgdG8gdXNlIHRo ZQorICAgICAgICBHVEszIHBsdWdpbiBwcm9jZXNzIHRvIHNjYW4gZ3RrMiBwbHVnaW5zLCBiZWNh dXNlIHdlIG5lZWQgdG8gbG9hZAorICAgICAgICB0aGUgcGx1Z2luIHRvIGdldCBpdHMgbWV0YWRh dGEuIEJ1dCB3ZSBkb24ndCBuZWVkIHRvIGluaXRpYWxpemUKKyAgICAgICAgdGhlIHBsdWdpbiB0 byBjaGVjayBpZiBpdCByZXF1aXJlcyBHVEsyLCBzbyB3ZSBjYW4gZG8gdGhhdCBjaGVjaworICAg ICAgICBpbiB0aGUgVUkgcHJvY2VzcyB0byBkZWNpZGUgd2hpY2ggcGx1Z2luIHByb2Nlc3MgdG8g dXNlLgorCisgICAgICAgICogU2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1 Z2luTW9kdWxlWDExLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW5Nb2R1bGU6 OmdldFBsdWdpbkluZm9Gb3JMb2FkZWRQbHVnaW4pOgorICAgICAgICBSZW1vdmUgdGhlIHJlcXVp cmVzIEdUSzIgY2hlY2suCisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luTW9kdWxlOjpz Y2FuUGx1Z2luKTogRG9uJ3Qgd3JpdGUKKyAgICAgICAgcmVxdWlyZXMtZ3RrMiB0byBzdGRvdXQu CisgICAgICAgICogVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6cGx1Z2luUmVxdWlyZXNHdGsyKTogSGVscGVyIGZ1bmN0 aW9uIHRvIGNoZWNrIGlmIHRoZQorICAgICAgICBnaXZlbiBwbHVnaW4gcGF0aCByZXF1aXJlcyBH VEsyLgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5Qcm9jZXNzUHJveHk6OnNjYW5QbHVnaW4pOiBD aGVjayBpZiB0aGUgcGx1Z2luIHBhdGgKKyAgICAgICAgcmVxdWlyZXMgR1RLMiBhbmQgdXNlIFdl YktpdFBsdWdpblByb2Nlc3MyIGluIHN1Y2ggY2FzZSwgb3IgcmV0dXJuCisgICAgICAgIGVhcmx5 IGlmIEdUSzIgcGx1Z2lucyBhcmUgbm90IGVuYWJsZWQuIExvZyBlcnJvciBtZXNzYWdlcyB3aGVu CisgICAgICAgIHNvbWV0aGluZyBmYWlscyBzY2FubmluZyB0aGUgcGx1Z2luIHRvIG1ha2UgaXQg ZWFzaWVydCB0byBkZWJ1ZworICAgICAgICBwcm9ibGVtcyBpbiB0aGUgZnV0dXJlLgorCiAyMDE0 LTA5LTI2ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBT dG9wIHVzaW5nIGxlZ2FjeSBOT0RFX1RZUEVfQ0FTVFMoKSBtYWNybyBmb3IgSFRNTCBFbGVtZW50 cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUveDEx L05ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9QbHVn aW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpbk1vZHVsZVgxMS5jcHAKaW5kZXggODU5MTIy Yi4uZWNlZDA1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTmV0 c2NhcGUveDExL05ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5Nb2R1bGVYMTEuY3Bw CkBAIC0xNTIsMTAgKzE1Miw2IEBAIGJvb2wgTmV0c2NhcGVQbHVnaW5Nb2R1bGU6OmdldFBsdWdp bkluZm9Gb3JMb2FkZWRQbHVnaW4oUmF3UGx1Z2luTWV0YURhdGEmIG1ldGFECiAKICAgICBtZXRh RGF0YS5taW1lRGVzY3JpcHRpb24gPSBtaW1lRGVzY3JpcHRpb247CiAKLSNpZiBQTEFURk9STShH VEspCi0gICAgbWV0YURhdGEucmVxdWlyZXNHdGsyID0gbW9kdWxlLT5mdW5jdGlvblBvaW50ZXI8 dm9pZCAoKikoKT4oImd0a19wcm9ncmVzc19nZXRfdHlwZSIpOwotI2VuZGlmCi0KICAgICByZXR1 cm4gdHJ1ZTsKIH0KIApAQCAtMjQ0LDEwICsyNDAsNiBAQCBib29sIE5ldHNjYXBlUGx1Z2luTW9k dWxlOjpzY2FuUGx1Z2luKGNvbnN0IFN0cmluZyYgcGx1Z2luUGF0aCkKICAgICB3cml0ZUxpbmUo bWV0YURhdGEubmFtZSk7CiAgICAgd3JpdGVMaW5lKG1ldGFEYXRhLmRlc2NyaXB0aW9uKTsKICAg ICB3cml0ZUxpbmUobWV0YURhdGEubWltZURlc2NyaXB0aW9uKTsKLSNpZiBQTEFURk9STShHVEsp Ci0gICAgaWYgKG1ldGFEYXRhLnJlcXVpcmVzR3RrMikKLSAgICAgICAgd3JpdGVMaW5lKCJyZXF1 aXJlcy1ndGsyIik7Ci0jZW5kaWYKIAogICAgIGZmbHVzaChzdGRvdXQpOwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpblByb2Nlc3NQcm94 eVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Q cm9jZXNzUHJveHlVbml4LmNwcAppbmRleCA1MzhkZDc5Li43MGQ4NzNkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVu aXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2lu UHJvY2Vzc1Byb3h5VW5peC5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChD KSAyMDExIElnYWxpYSBTLkwuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTEsIDIwMTQgSWdhbGlhIFMu TC4KICAqIENvcHlyaWdodCAoQykgMjAxMSBBcHBsZSBJbmMuCiAgKiBDb3B5cmlnaHQgKEMpIDIw MTIgU2Ftc3VuZyBFbGVjdHJvbmljcwogICoKQEAgLTMzLDE0ICszMywxOCBAQAogI2luY2x1ZGUg IlBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaCIKICNpbmNsdWRlICJQcm9jZXNzRXhl Y3V0YWJsZVBhdGguaCIKICNpbmNsdWRlIDxXZWJDb3JlL0ZpbGVTeXN0ZW0uaD4KKyNpbmNsdWRl IDxzeXMvd2FpdC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KICNpbmNsdWRlIDx3 dGYvdGV4dC9XVEZTdHJpbmcuaD4KKwogI2lmIFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oRUZM KQogI2luY2x1ZGUgPGdsaWIuaD4KICNpbmNsdWRlIDx3dGYvZ29iamVjdC9HVW5pcXVlUHRyLmg+ CiAjZW5kaWYKIAotI2luY2x1ZGUgPHN5cy93YWl0Lmg+CisjaWYgUExBVEZPUk0oR1RLKQorI2lu Y2x1ZGUgIk1vZHVsZS5oIgorI2VuZGlmCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBA IC02NSwyMCArNjksMzkgQEAgdm9pZCBQbHVnaW5Qcm9jZXNzUHJveHk6OnBsYXRmb3JtSW5pdGlh bGl6ZVBsdWdpblByb2Nlc3MoUGx1Z2luUHJvY2Vzc0NyZWF0aW9uUGEKIHsKIH0KIAorI2lmIFBM QVRGT1JNKEdUSykKK3N0YXRpYyBib29sIHBsdWdpblJlcXVpcmVzR3RrMihjb25zdCBTdHJpbmcm IHBsdWdpblBhdGgpCit7CisgICAgc3RkOjp1bmlxdWVfcHRyPE1vZHVsZT4gbW9kdWxlID0gc3Rk OjptYWtlX3VuaXF1ZTxNb2R1bGU+KHBsdWdpblBhdGgpOworICAgIGlmICghbW9kdWxlLT5sb2Fk KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gbW9kdWxlLT5mdW5jdGlvblBv aW50ZXI8Z3BvaW50ZXI+KCJndGtfb2JqZWN0X2dldF90eXBlIik7Cit9CisjZW5kaWYKKwogI2lm IFBMVUdJTl9BUkNISVRFQ1RVUkUoWDExKQogYm9vbCBQbHVnaW5Qcm9jZXNzUHJveHk6OnNjYW5Q bHVnaW4oY29uc3QgU3RyaW5nJiBwbHVnaW5QYXRoLCBSYXdQbHVnaW5NZXRhRGF0YSYgcmVzdWx0 KQogewogI2lmIFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oRUZMKQotICAgIENTdHJpbmcgYmlu YXJ5UGF0aCA9IGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihleGVjdXRhYmxlUGF0aE9mUGx1Z2lu UHJvY2VzcygpKTsKKyAgICBTdHJpbmcgcGx1Z2luUHJvY2Vzc1BhdGggPSBleGVjdXRhYmxlUGF0 aE9mUGx1Z2luUHJvY2VzcygpOworCisjaWYgUExBVEZPUk0oR1RLKQorICAgIGJvb2wgcmVxdWly ZXNHdGsyID0gcGx1Z2luUmVxdWlyZXNHdGsyKHBsdWdpblBhdGgpOworICAgIGlmIChyZXF1aXJl c0d0azIpCisjaWYgRU5BQkxFKFBMVUdJTl9QUk9DRVNTX0dUSzIpCisgICAgICAgIHBsdWdpblBy b2Nlc3NQYXRoLmFwcGVuZCgnMicpOworI2Vsc2UKKyAgICAgICAgcmV0dXJuIGZhbHNlOworI2Vu ZGlmCisjZW5kaWYKKworICAgIENTdHJpbmcgYmluYXJ5UGF0aCA9IGZpbGVTeXN0ZW1SZXByZXNl bnRhdGlvbihwbHVnaW5Qcm9jZXNzUGF0aCk7CiAgICAgQ1N0cmluZyBwbHVnaW5QYXRoQ1N0cmlu ZyA9IGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihwbHVnaW5QYXRoKTsKICAgICBjaGFyKiBhcmd2 WzRdOwogICAgIGFyZ3ZbMF0gPSBjb25zdF9jYXN0PGNoYXIqPihiaW5hcnlQYXRoLmRhdGEoKSk7 CiAgICAgYXJndlsxXSA9IGNvbnN0X2Nhc3Q8Y2hhcio+KCItc2NhblBsdWdpbiIpOwogICAgIGFy Z3ZbMl0gPSBjb25zdF9jYXN0PGNoYXIqPihwbHVnaW5QYXRoQ1N0cmluZy5kYXRhKCkpOwotICAg IGFyZ3ZbM10gPSAwOwotCi0gICAgaW50IHN0YXR1czsKLSAgICBHVW5pcXVlT3V0UHRyPGNoYXI+ IHN0ZE91dDsKKyAgICBhcmd2WzNdID0gbnVsbHB0cjsKIAogICAgIC8vIElmIHRoZSBkaXNwb3Np dGlvbiBvZiBTSUdDTEQgc2lnbmFsIGlzIHNldCB0byBTSUdfSUdOIChkZWZhdWx0KQogICAgIC8v IHRoZW4gdGhlIHNpZ25hbCB3aWxsIGJlIGlnbm9yZWQgYW5kIGdfc3Bhd25fc3luYygpIHdpbGwg bm90IGJlCkBAIC05NCwyNiArMTE3LDM3IEBAIGJvb2wgUGx1Z2luUHJvY2Vzc1Byb3h5OjpzY2Fu UGx1Z2luKGNvbnN0IFN0cmluZyYgcGx1Z2luUGF0aCwgUmF3UGx1Z2luTWV0YURhdGEmCiAgICAg fQogI2VuZGlmCiAKLSAgICBpZiAoIWdfc3Bhd25fc3luYygwLCBhcmd2LCAwLCBHX1NQQVdOX1NU REVSUl9UT19ERVZfTlVMTCwgMCwgMCwgJnN0ZE91dC5vdXRQdHIoKSwgMCwgJnN0YXR1cywgMCkp CisgICAgaW50IHN0YXR1czsKKyAgICBHVW5pcXVlT3V0UHRyPGNoYXI+IHN0ZE91dDsKKyAgICBH VW5pcXVlT3V0UHRyPEdFcnJvcj4gZXJyb3I7CisgICAgaWYgKCFnX3NwYXduX3N5bmMobnVsbHB0 ciwgYXJndiwgbnVsbHB0ciwgR19TUEFXTl9TVERFUlJfVE9fREVWX05VTEwsIG51bGxwdHIsIG51 bGxwdHIsICZzdGRPdXQub3V0UHRyKCksIG51bGxwdHIsICZzdGF0dXMsICZlcnJvci5vdXRQdHIo KSkpIHsKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJGYWlsZWQgdG8gbGF1bmNoICVzOiAlcyIsIGFy Z3ZbMF0sIGVycm9yLT5tZXNzYWdlKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KIAot ICAgIGlmICghV0lGRVhJVEVEKHN0YXR1cykgfHwgV0VYSVRTVEFUVVMoc3RhdHVzKSAhPSBFWElU X1NVQ0NFU1MgfHwgIXN0ZE91dCkKKyAgICBpZiAoIVdJRkVYSVRFRChzdGF0dXMpIHx8IFdFWElU U1RBVFVTKHN0YXR1cykgIT0gRVhJVF9TVUNDRVNTKSB7CisgICAgICAgIFdURkxvZ0Fsd2F5cygi RXJyb3Igc2Nhbm5pbmcgcGx1Z2luICVzLCAlcyByZXR1cm5lZCAlZCBleGl0IHN0YXR1cyIsIGFy Z3ZbMl0sIGFyZ3ZbMF0sIHN0YXR1cyk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CiAK LSAgICBTdHJpbmcgc3RkT3V0U3RyaW5nID0gU3RyaW5nOjpmcm9tVVRGOChzdGRPdXQuZ2V0KCkp OworICAgIGlmICghc3RkT3V0KSB7CisgICAgICAgIFdURkxvZ0Fsd2F5cygiRXJyb3Igc2Nhbm5p bmcgcGx1Z2luICVzLCAlcyBkaWRuJ3Qgd3JpdGUgYW55IG91dHB1dCB0byBzdGRvdXQiLCBhcmd2 WzJdLCBhcmd2WzBdKTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KIAogICAgIFZlY3Rv cjxTdHJpbmc+IGxpbmVzOwotICAgIHN0ZE91dFN0cmluZy5zcGxpdChVQ2hhcignXG4nKSwgdHJ1 ZSwgbGluZXMpOworICAgIFN0cmluZzo6ZnJvbVVURjgoc3RkT3V0LmdldCgpKS5zcGxpdChVQ2hh cignXG4nKSwgdHJ1ZSwgbGluZXMpOwogCi0gICAgaWYgKGxpbmVzLnNpemUoKSA8IDMpCisgICAg aWYgKGxpbmVzLnNpemUoKSA8IDMpIHsKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJFcnJvciBzY2Fu bmluZyBwbHVnaW4gJXMsIHRvbyBmZXcgbGluZXMgb2Ygb3V0cHV0IHByb3ZpZGVkIiwgYXJndlsy XSk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CiAKICAgICByZXN1bHQubmFtZS5zd2Fw KGxpbmVzWzBdKTsKICAgICByZXN1bHQuZGVzY3JpcHRpb24uc3dhcChsaW5lc1sxXSk7CiAgICAg cmVzdWx0Lm1pbWVEZXNjcmlwdGlvbi5zd2FwKGxpbmVzWzJdKTsKICNpZiBQTEFURk9STShHVEsp Ci0gICAgaWYgKGxpbmVzLnNpemUoKSA+IDMpCi0gICAgICAgIHJlc3VsdC5yZXF1aXJlc0d0azIg PSBsaW5lc1szXSA9PSAicmVxdWlyZXMtZ3RrMiI7CisgICAgcmVzdWx0LnJlcXVpcmVzR3RrMiA9 IHJlcXVpcmVzR3RrMjsKICNlbmRpZgogICAgIHJldHVybiAhcmVzdWx0Lm1pbWVEZXNjcmlwdGlv bi5pc0VtcHR5KCk7CiAjZWxzZSAvLyBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKEVGTCkK