137181 2014-09-27 12:41:11 -0700 Implement op_profile_type in the 32-bit baseline JIT 2014-10-03 15:20:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam fpizlo ggaren oldest_to_newest 1037693 0 saam 2014-09-27 12:41:11 -0700 Currently, the 32-bit version of op_profile_type just jumps to the slow path. Have it emit inline assembly for writing to TypeProfilerLog. 1039334 1 239232 saam 2014-10-03 14:05:33 -0700 Created attachment 239232 patch 1039348 2 239232 msaboff 2014-10-03 14:28:07 -0700 Comment on attachment 239232 patch View in context: https://bugs.webkit.org/attachment.cgi?id=239232&action=review r=me > Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1350 > + Jump skipClearLog = branchPtr(NotEqual, regT1, TrustedImmPtr(cachedTypeProfilerLog->logEndPtr())); This could be jumpToEnd.append(branchPtr(....)) to simplify the logic. 1039374 3 saam 2014-10-03 15:20:31 -0700 landed in: http://trac.webkit.org/changeset/174298 239232 2014-10-03 14:05:33 -0700 2014-10-03 14:28:07 -0700 patch patch.diff text/plain 4883 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc0Mjg5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTEwLTAzICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBJbXBsZW1lbnQgb3BfcHJvZmlsZV90eXBlIGluIHRoZSAzMi1iaXQgYmFzZWxpbmUgSklU CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcxODEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZW5lcmF0 ZSBpbmxpbmUgY29kZSB0byB3cml0ZSB0byB0aGUgVHlwZVByb2ZpbGVyTG9nIGluc2lkZSB0aGUg MzItYml0IAorICAgICAgICBiYXNlbGluZSBKSVQgaW5zdGVhZCBvZiB1bmNvbmRpdGlvbmFsbHkg YmFpbGluZyBvdXQgdG8gdGhlIHNsb3cgcGF0aCAKKyAgICAgICAgZm9yIG9wX3Byb2ZpbGVfdHlw ZS4KKworICAgICAgICAqIGppdC9KSVRPcGNvZGVzMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpK SVQ6OmVtaXRfb3BfcHJvZmlsZV90eXBlKToKKwogMjAxNC0xMC0wMiAgRmlsaXAgUGl6bG8gIDxm cGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEZUTCBzaG91bGQgc2luayBQdXRMb2NhbHMKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2RlczMyXzY0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMzMl82NC5jcHAJKHJl dmlzaW9uIDE3NDI1OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2RlczMy XzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiArNDIsNyBAQAogI2luY2x1ZGUgIk1heEZy YW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsLmgiCiAjaW5jbHVkZSAiUmVwYXRjaEJ1ZmZlci5oIgog I2luY2x1ZGUgIlNsb3dQYXRoQ2FsbC5oIgorI2luY2x1ZGUgIlR5cGVQcm9maWxlckxvZy5oIgog I2luY2x1ZGUgIlZpcnR1YWxSZWdpc3Rlci5oIgogCiBuYW1lc3BhY2UgSlNDIHsKQEAgLTEyOTEs OCArMTI5Miw2NyBAQCB2b2lkIEpJVDo6ZW1pdF9vcF90b19pbmRleF9zdHJpbmcoSW5zdHJ1CiAK IHZvaWQgSklUOjplbWl0X29wX3Byb2ZpbGVfdHlwZShJbnN0cnVjdGlvbiogY3VycmVudEluc3Ry dWN0aW9uKQogewotICAgIEpJVFNsb3dQYXRoQ2FsbCBzbG93UGF0aENhbGwodGhpcywgY3VycmVu dEluc3RydWN0aW9uLCBzbG93X3BhdGhfcHJvZmlsZV90eXBlKTsKLSAgICBzbG93UGF0aENhbGwu Y2FsbCgpOworICAgIFR5cGVMb2NhdGlvbiogY2FjaGVkVHlwZUxvY2F0aW9uID0gY3VycmVudElu c3RydWN0aW9uWzJdLnUubG9jYXRpb247CisgICAgaW50IHZhbHVlVG9Qcm9maWxlID0gY3VycmVu dEluc3RydWN0aW9uWzFdLnUub3BlcmFuZDsKKworICAgIC8vIExvYWQgcGF5bG9hZCBpbiBUMC4g TG9hZCB0YWcgaW4gVDMuCisgICAgZW1pdExvYWRQYXlsb2FkKHZhbHVlVG9Qcm9maWxlLCByZWdU MCk7CisgICAgZW1pdExvYWRUYWcodmFsdWVUb1Byb2ZpbGUsIHJlZ1QzKTsKKworICAgIEp1bXBM aXN0IGp1bXBUb0VuZDsKKworICAgIC8vIENvbXBpbGUgaW4gYSBwcmVkaWN0aXZlIHR5cGUgY2hl Y2ssIGlmIHBvc3NpYmxlLCB0byBzZWUgaWYgd2UgY2FuIHNraXAgd3JpdGluZyB0byB0aGUgbG9n LgorICAgIC8vIFRoZXNlIHR5cGVjaGVja3MgYXJlIGlubGluZWQgdG8gbWF0Y2ggdGhvc2Ugb2Yg dGhlIDMyLWJpdCBKU1ZhbHVlIHR5cGUgY2hlY2tzLgorICAgIGlmIChjYWNoZWRUeXBlTG9jYXRp b24tPm1fbGFzdFNlZW5UeXBlID09IFR5cGVVbmRlZmluZWQpCisgICAgICAgIGp1bXBUb0VuZC5h cHBlbmQoYnJhbmNoMzIoRXF1YWwsIHJlZ1QzLCBUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6VW5kZWZp bmVkVGFnKSkpOworICAgIGVsc2UgaWYgKGNhY2hlZFR5cGVMb2NhdGlvbi0+bV9sYXN0U2VlblR5 cGUgPT0gVHlwZU51bGwpCisgICAgICAgIGp1bXBUb0VuZC5hcHBlbmQoYnJhbmNoMzIoRXF1YWws IHJlZ1QzLCBUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6TnVsbFRhZykpKTsKKyAgICBlbHNlIGlmIChj YWNoZWRUeXBlTG9jYXRpb24tPm1fbGFzdFNlZW5UeXBlID09IFR5cGVCb29sZWFuKQorICAgICAg ICBqdW1wVG9FbmQuYXBwZW5kKGJyYW5jaDMyKEVxdWFsLCByZWdUMywgVHJ1c3RlZEltbTMyKEpT VmFsdWU6OkJvb2xlYW5UYWcpKSk7CisgICAgZWxzZSBpZiAoY2FjaGVkVHlwZUxvY2F0aW9uLT5t X2xhc3RTZWVuVHlwZSA9PSBUeXBlTWFjaGluZUludCkKKyAgICAgICAganVtcFRvRW5kLmFwcGVu ZChicmFuY2gzMihFcXVhbCwgcmVnVDMsIFRydXN0ZWRJbW0zMihKU1ZhbHVlOjpJbnQzMlRhZykp KTsKKyAgICBlbHNlIGlmIChjYWNoZWRUeXBlTG9jYXRpb24tPm1fbGFzdFNlZW5UeXBlID09IFR5 cGVOdW1iZXIpIHsKKyAgICAgICAganVtcFRvRW5kLmFwcGVuZChicmFuY2gzMihCZWxvdywgcmVn VDMsIFRydXN0ZWRJbW0zMihKU1ZhbHVlOjpMb3dlc3RUYWcpKSk7CisgICAgICAgIGp1bXBUb0Vu ZC5hcHBlbmQoYnJhbmNoMzIoRXF1YWwsIHJlZ1QzLCBUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6SW50 MzJUYWcpKSk7CisgICAgfSBlbHNlIGlmIChjYWNoZWRUeXBlTG9jYXRpb24tPm1fbGFzdFNlZW5U eXBlID09IFR5cGVTdHJpbmcpIHsKKyAgICAgICAgSnVtcCBpc05vdENlbGwgPSBicmFuY2gzMihO b3RFcXVhbCwgcmVnVDMsIFRydXN0ZWRJbW0zMihKU1ZhbHVlOjpDZWxsVGFnKSk7CisgICAgICAg IGp1bXBUb0VuZC5hcHBlbmQoYnJhbmNoOChFcXVhbCwgQWRkcmVzcyhyZWdUMCwgSlNDZWxsOjp0 eXBlSW5mb1R5cGVPZmZzZXQoKSksIFRydXN0ZWRJbW0zMihTdHJpbmdUeXBlKSkpOworICAgICAg ICBpc05vdENlbGwubGluayh0aGlzKTsKKyAgICB9CisKKyAgICAvLyBMb2FkIHRoZSB0eXBlIHBy b2ZpbGluZyBsb2cgaW50byBUMi4KKyAgICBUeXBlUHJvZmlsZXJMb2cqIGNhY2hlZFR5cGVQcm9m aWxlckxvZyA9IG1fdm0tPnR5cGVQcm9maWxlckxvZygpOworICAgIG1vdmUoVHJ1c3RlZEltbVB0 cihjYWNoZWRUeXBlUHJvZmlsZXJMb2cpLCByZWdUMik7CisKKyAgICAvLyBMb2FkIHRoZSBuZXh0 IGxvZyBlbnRyeSBpbnRvIFQxLgorICAgIGxvYWRQdHIoQWRkcmVzcyhyZWdUMiwgVHlwZVByb2Zp bGVyTG9nOjpjdXJyZW50TG9nRW50cnlPZmZzZXQoKSksIHJlZ1QxKTsKKworICAgIC8vIFN0b3Jl IHRoZSBKU1ZhbHVlIG9udG8gdGhlIGxvZyBlbnRyeS4KKyAgICBzdG9yZTMyKHJlZ1QwLCBBZGRy ZXNzKHJlZ1QxLCBUeXBlUHJvZmlsZXJMb2c6OkxvZ0VudHJ5Ojp2YWx1ZU9mZnNldCgpICsgT0JK RUNUX09GRlNFVE9GKEpTVmFsdWUsIHUuYXNCaXRzLnBheWxvYWQpKSk7CisgICAgc3RvcmUzMihy ZWdUMywgQWRkcmVzcyhyZWdUMSwgVHlwZVByb2ZpbGVyTG9nOjpMb2dFbnRyeTo6dmFsdWVPZmZz ZXQoKSArIE9CSkVDVF9PRkZTRVRPRihKU1ZhbHVlLCB1LmFzQml0cy50YWcpKSk7CisKKyAgICAv LyBTdG9yZSB0aGUgc3RydWN0dXJlSUQgb2YgdGhlIGNlbGwgaWYgYXJndW1lbnQgaXMgYSBjZWxs LCBvdGhlcndpc2UsIHN0b3JlIDAgb24gdGhlIGxvZyBlbnRyeS4KKyAgICBKdW1wIG5vdENlbGwg PSBicmFuY2gzMihOb3RFcXVhbCwgcmVnVDMsIFRydXN0ZWRJbW0zMihKU1ZhbHVlOjpDZWxsVGFn KSk7CisgICAgbG9hZDMyKEFkZHJlc3MocmVnVDAsIEpTQ2VsbDo6c3RydWN0dXJlSURPZmZzZXQo KSksIHJlZ1QwKTsKKyAgICBzdG9yZTMyKHJlZ1QwLCBBZGRyZXNzKHJlZ1QxLCBUeXBlUHJvZmls ZXJMb2c6OkxvZ0VudHJ5OjpzdHJ1Y3R1cmVJRE9mZnNldCgpKSk7CisgICAgSnVtcCBza2lwTm90 Q2VsbCA9IGp1bXAoKTsKKyAgICBub3RDZWxsLmxpbmsodGhpcyk7CisgICAgc3RvcmUzMihUcnVz dGVkSW1tMzIoMCksIEFkZHJlc3MocmVnVDEsIFR5cGVQcm9maWxlckxvZzo6TG9nRW50cnk6OnN0 cnVjdHVyZUlET2Zmc2V0KCkpKTsKKyAgICBza2lwTm90Q2VsbC5saW5rKHRoaXMpOworCisgICAg Ly8gU3RvcmUgdGhlIHR5cGVMb2NhdGlvbiBvbiB0aGUgbG9nIGVudHJ5LgorICAgIG1vdmUoVHJ1 c3RlZEltbVB0cihjYWNoZWRUeXBlTG9jYXRpb24pLCByZWdUMCk7CisgICAgc3RvcmUzMihyZWdU MCwgQWRkcmVzcyhyZWdUMSwgVHlwZVByb2ZpbGVyTG9nOjpMb2dFbnRyeTo6bG9jYXRpb25PZmZz ZXQoKSkpOworCisgICAgLy8gSW5jcmVtZW50IHRoZSBjdXJyZW50IGxvZyBlbnRyeS4KKyAgICBh ZGRQdHIoVHJ1c3RlZEltbTMyKHNpemVvZihUeXBlUHJvZmlsZXJMb2c6OkxvZ0VudHJ5KSksIHJl Z1QxKTsKKyAgICBzdG9yZTMyKHJlZ1QxLCBBZGRyZXNzKHJlZ1QyLCBUeXBlUHJvZmlsZXJMb2c6 OmN1cnJlbnRMb2dFbnRyeU9mZnNldCgpKSk7CisgICAgSnVtcCBza2lwQ2xlYXJMb2cgPSBicmFu Y2hQdHIoTm90RXF1YWwsIHJlZ1QxLCBUcnVzdGVkSW1tUHRyKGNhY2hlZFR5cGVQcm9maWxlckxv Zy0+bG9nRW5kUHRyKCkpKTsKKyAgICAvLyBDbGVhciB0aGUgbG9nIGlmIHdlJ3JlIGF0IHRoZSBl bmQgb2YgdGhlIGxvZy4KKyAgICBjYWxsT3BlcmF0aW9uKG9wZXJhdGlvblByb2Nlc3NUeXBlUHJv ZmlsZXJMb2cpOworICAgIHNraXBDbGVhckxvZy5saW5rKHRoaXMpOworCisgICAganVtcFRvRW5k LmxpbmsodGhpcyk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIEpTQwo=