137175 2014-09-27 03:56:03 -0700 [cairo] GraphicsContext should not depend on GTK+ 2014-09-28 01:06:27 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned commit-queue d-r gustavo gyuyoung.kim rakuco ryuan.choi sergio svillar oldest_to_newest 1037656 0 cgarcia 2014-09-27 03:56:03 -0700 There are some unused methods for GTK+2 and gdk_cairo_region() to render the focus ring. gdk_cairo_region iterates the rectangles of the region to call cairo_rectangle, so we can easily replace it. 1037657 1 238771 cgarcia 2014-09-27 03:59:02 -0700 Created attachment 238771 Patch 1037682 2 238771 mrobinson 2014-09-27 11:22:19 -0700 Comment on attachment 238771 Patch Very nice. 1037766 3 cgarcia 2014-09-28 01:06:27 -0700 Committed r174041: <http://trac.webkit.org/changeset/174041> 238771 2014-09-27 03:59:02 -0700 2014-09-27 11:22:18 -0700 Patch wcore-cairo-gtk.diff text/plain 6061 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMzQ4MWMwLi44ZjNiYzJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTQtMDktMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtjYWlyb10gR3JhcGhpY3NDb250ZXh0IHNob3VsZCBub3QgZGVwZW5kIG9u IEdUSysKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NzE3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl bW92ZSB0aGUgdW51c2VkIG1ldGhvZHMgZGVwZW5kaW5nIG9uIEdESyBhbmQgc2ltcGxpZnkKKyAg ICAgICAgR3JhcGhpY3NDb250ZXh0OjpkcmF3Rm9jdXNSaW5nKCkgdXNpbmcgb25seSBjYWlybyBB UEkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZTogTW92ZSBHcmFwaGljc0NvbnRleHRD YWlyby5jcHAgdG8gdGhlIHdlYmNvcmUgc291cmNlcy4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc0NvbnRleHQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWly by9HcmFwaGljc0NvbnRleHRDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0Nv bnRleHQ6OmRyYXdGb2N1c1JpbmcpOiBJdGVyYXRlIHRoZSByZWN0YW5nbGVzCisgICAgICAgIGlu c3RlYWQgb2YgY3JlYXRpbmcgYSByZWdpb24gZm9yIHRoZSByZWN0YW5nbGVzIGFuZCBjYWxsIGdk a19jYWlyb19yZWdpb24oKS4KKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6c2V0 R2RrRXhwb3NlRXZlbnQpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250 ZXh0OjpnZGtFeHBvc2VFdmVudCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHQ6Omdka1dpbmRvdyk6IERlbGV0ZWQuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlQ2Fpcm8uaDoKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZTo6R3JhcGhpY3NDb250ZXh0 UGxhdGZvcm1Qcml2YXRlKToKKwogMjAxNC0wOS0yNiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcCB1c2luZyBsZWdhY3kgTk9ERV9UWVBFX0NBU1RT KCkgbWFjcm8gZm9yIEhUTUwgRWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1Bs YXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXgg MWJiMWQ2NS4uMTIwZjk3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsu Y21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTU0LDYgKzU0 LDcgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mv Y2Fpcm8vRm9udENhaXJvSGFyZmJ1enpORy5jcHAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9jYWly by9HcmFkaWVudENhaXJvLmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNz Q29udGV4dDNEQ2Fpcm8uY3BwCisgICAgcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3ND b250ZXh0Q2Fpcm8uY3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJD YWlyby5jcHAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUNhaXJvLmNwcAogICAg IHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ludFJlY3RDYWlyby5jcHAKQEAgLTE5MSw4ICsxOTIs NiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlUGxhdGZvcm1HVEtfU09VUkNFUwogCiAgICAgcGxhdGZv cm0vZ3JhcGhpY3MvR0xDb250ZXh0LmNwcAogCi0gICAgcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v R3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCi0KICAgICBwbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xD b250ZXh0RUdMLmNwcAogCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRm b3JtRGF0YUZyZWVUeXBlLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9HcmFwaGljc0NvbnRleHQuaAppbmRleCBjNmY4NjFkLi43ZjJhMDMzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaApAQCAt NTM1LDEyICs1MzUsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIEdyYXBoaWNzQ29u dGV4dChjYWlyb190Kik7CiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKEdUSykKLSAgICAgICAgdm9p ZCBzZXRHZGtFeHBvc2VFdmVudChHZGtFdmVudEV4cG9zZSopOwotICAgICAgICBHZGtXaW5kb3cq IGdka1dpbmRvdygpIGNvbnN0OwotICAgICAgICBHZGtFdmVudEV4cG9zZSogZ2RrRXhwb3NlRXZl bnQoKSBjb25zdDsKLSNlbmRpZgotCiAgICAgICAgIHN0YXRpYyB2b2lkIGFkanVzdExpbmVUb1Bp eGVsQm91bmRhcmllcyhGbG9hdFBvaW50JiBwMSwgRmxvYXRQb2ludCYgcDIsIGZsb2F0IHN0cm9r ZVdpZHRoLCBTdHJva2VTdHlsZSk7CiAKICAgICBwcml2YXRlOgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0 Q2Fpcm8uY3BwCmluZGV4IDcxZWJkYjMuLjRiZTBhZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRD YWlyby5jcHAKQEAgLTU4LDkgKzU4LDcgQEAKICNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUg PHd0Zi9NYXRoRXh0cmFzLmg+CiAKLSNpZiBQTEFURk9STShHVEspCi0jaW5jbHVkZSA8Z2RrL2dk ay5oPgotI2VsaWYgUExBVEZPUk0oV0lOKQorI2lmIFBMQVRGT1JNKFdJTikKICNpbmNsdWRlIDxj YWlyby13aW4zMi5oPgogI2VuZGlmCiAKQEAgLTU2NSwyNyArNTYzLDggQEAgdm9pZCBHcmFwaGlj c0NvbnRleHQ6OmRyYXdGb2N1c1JpbmcoY29uc3QgVmVjdG9yPEludFJlY3Q+JiByZWN0cywgaW50 IHdpZHRoLCBpbnQKICAgICBjYWlyb19uZXdfcGF0aChjcik7CiAKICNpZiBQTEFURk9STShHVEsp Ci0jaWZkZWYgR1RLX0FQSV9WRVJTSU9OXzIKLSAgICBHZGtSZWdpb24qIHJlZyA9IGdka19yZWdp b25fbmV3KCk7Ci0jZWxzZQotICAgIGNhaXJvX3JlZ2lvbl90KiByZWcgPSBjYWlyb19yZWdpb25f Y3JlYXRlKCk7Ci0jZW5kaWYKLQotICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCByZWN0Q291 bnQ7IGkrKykgewotI2lmZGVmIEdUS19BUElfVkVSU0lPTl8yCi0gICAgICAgIEdka1JlY3Rhbmds ZSByZWN0ID0gcmVjdHNbaV07Ci0gICAgICAgIGdka19yZWdpb25fdW5pb25fd2l0aF9yZWN0KHJl ZywgJnJlY3QpOwotI2Vsc2UKLSAgICAgICAgY2Fpcm9fcmVjdGFuZ2xlX2ludF90IHJlY3QgPSBy ZWN0c1tpXTsKLSAgICAgICAgY2Fpcm9fcmVnaW9uX3VuaW9uX3JlY3RhbmdsZShyZWcsICZyZWN0 KTsKLSNlbmRpZgotICAgIH0KLSAgICBnZGtfY2Fpcm9fcmVnaW9uKGNyLCByZWcpOwotI2lmZGVm IEdUS19BUElfVkVSU0lPTl8yCi0gICAgZ2RrX3JlZ2lvbl9kZXN0cm95KHJlZyk7Ci0jZWxzZQot ICAgIGNhaXJvX3JlZ2lvbl9kZXN0cm95KHJlZyk7Ci0jZW5kaWYKKyAgICBmb3IgKGNvbnN0IGF1 dG8mIHJlY3QgOiByZWN0cykKKyAgICAgICAgY2Fpcm9fcmVjdGFuZ2xlKGNyLCByZWN0LngoKSwg cmVjdC55KCksIHJlY3Qud2lkdGgoKSwgcmVjdC5oZWlnaHQoKSk7CiAjZWxzZQogICAgIGludCBy YWRpdXMgPSAod2lkdGggLSAxKSAvIDI7CiAgICAgUGF0aCBwYXRoOwpAQCAtMTA4NiwyNiArMTA2 NSw2IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpmaWxsUmVjdFdpdGhSb3VuZGVkSG9sZShjb25z dCBGbG9hdFJlY3QmIHJlY3QsIGNvbnN0IEZsb2F0CiAgICAgY2Fpcm9fcmVzdG9yZShjcik7CiB9 CiAKLSNpZiBQTEFURk9STShHVEspCi12b2lkIEdyYXBoaWNzQ29udGV4dDo6c2V0R2RrRXhwb3Nl RXZlbnQoR2RrRXZlbnRFeHBvc2UqIGV4cG9zZSkKLXsKLSAgICBtX2RhdGEtPmV4cG9zZSA9IGV4 cG9zZTsKLX0KLQotR2RrRXZlbnRFeHBvc2UqIEdyYXBoaWNzQ29udGV4dDo6Z2RrRXhwb3NlRXZl bnQoKSBjb25zdAotewotICAgIHJldHVybiBtX2RhdGEtPmV4cG9zZTsKLX0KLQotR2RrV2luZG93 KiBHcmFwaGljc0NvbnRleHQ6Omdka1dpbmRvdygpIGNvbnN0Ci17Ci0gICAgaWYgKCFtX2RhdGEt PmV4cG9zZSkKLSAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICByZXR1cm4gbV9kYXRhLT5leHBvc2Ut PndpbmRvdzsKLX0KLSNlbmRpZgotCiB2b2lkIEdyYXBoaWNzQ29udGV4dDo6c2V0UGxhdGZvcm1T aG91bGRBbnRpYWxpYXMoYm9vbCBlbmFibGUpCiB7CiAgICAgaWYgKHBhaW50aW5nRGlzYWJsZWQo KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dy YXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZUNhaXJvLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGVDYWlyby5o CmluZGV4IDZiZmRlODMuLjllZGM5ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZUNhaXJvLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250 ZXh0UGxhdGZvcm1Qcml2YXRlQ2Fpcm8uaApAQCAtMzYsMTAgKzM2LDcgQEAKICNpbmNsdWRlIDxt YXRoLmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4KIAotI2lmIFBMQVRGT1JNKEdUSykKLSNpbmNsdWRl IDxwYW5nby9wYW5nby5oPgotdHlwZWRlZiBzdHJ1Y3QgX0dka0V4cG9zZUV2ZW50IEdka0V4cG9z ZUV2ZW50OwotI2VsaWYgUExBVEZPUk0oV0lOKQorI2lmIFBMQVRGT1JNKFdJTikKICNpbmNsdWRl IDxjYWlyby13aW4zMi5oPgogI2VuZGlmCiAKQEAgLTQ5LDkgKzQ2LDYgQEAgY2xhc3MgR3JhcGhp Y3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlIHsKIHB1YmxpYzoKICAgICBHcmFwaGljc0NvbnRleHRQ bGF0Zm9ybVByaXZhdGUoUGxhdGZvcm1Db250ZXh0Q2Fpcm8qIG5ld1BsYXRmb3JtQ29udGV4dCkK ICAgICAgICAgOiBwbGF0Zm9ybUNvbnRleHQobmV3UGxhdGZvcm1Db250ZXh0KQotI2lmIFBMQVRG T1JNKEdUSykKLSAgICAgICAgLCBleHBvc2UoMCkKLSNlbmRpZgogI2lmIFBMQVRGT1JNKFdJTikg fHwgKFBMQVRGT1JNKEdUSykgJiYgT1MoV0lORE9XUykpCiAgICAgICAgIC8vIE5PVEU6ICBUaGVz ZSBtYXkgbm90ZSBiZSBuZWVkZWQ6IHJldmlldyBhbmQgcmVtb3ZlIG9uY2UgQ2Fpcm8gaW1wbGVt ZW50YXRpb24gaXMgY29tcGxldGUKICAgICAgICAgLCBtX2hkYygwKQpAQCAtOTUsOSArODksNiBA QCBwdWJsaWM6CiAgICAgUGxhdGZvcm1Db250ZXh0Q2Fpcm8qIHBsYXRmb3JtQ29udGV4dDsKICAg ICBWZWN0b3I8ZmxvYXQ+IGxheWVyczsKIAotI2lmIFBMQVRGT1JNKEdUSykKLSAgICBHZGtFdmVu dEV4cG9zZSogZXhwb3NlOwotI2VuZGlmCiAjaWYgUExBVEZPUk0oV0lOKSB8fCAoUExBVEZPUk0o R1RLKSAmJiBPUyhXSU5ET1dTKSkKICAgICBIREMgbV9oZGM7CiAgICAgYm9vbCBtX3Nob3VsZElu Y2x1ZGVDaGlsZFdpbmRvd3M7Cg==