137161 2014-09-26 15:47:53 -0700 DFG shouldn't insert store barriers when it has it on good authority that we're not storing a cell 2014-10-13 17:43:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 137340 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenb msaboff oliver ossy sam oldest_to_newest 1037571 0 fpizlo 2014-09-26 15:47:53 -0700 Patch forthcoming. 1037572 1 238742 fpizlo 2014-09-26 15:48:57 -0700 Created attachment 238742 the patch 1037574 2 238742 mhahnenb 2014-09-26 15:51:03 -0700 Comment on attachment 238742 the patch r=me! 1037577 3 fpizlo 2014-09-26 15:54:06 -0700 Landed in http://trac.webkit.org/changeset/174025 1037672 4 ossy 2014-09-27 10:39:47 -0700 (In reply to comment #3) > Landed in http://trac.webkit.org/changeset/174025 It made 3-4 performance tests crash everywhere: - Apple Mountain Lion: https://build.webkit.org/builders/Apple%20MountainLion%20Release%20%28Perf%29/builds/10126 - Apple Mavericks: https://build.webkit.org/builders/Apple%20Mavericks%20Release%20%28Perf%29/builds/2663 - EFL: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/3310 1037679 5 fpizlo 2014-09-27 11:02:21 -0700 (In reply to comment #4) > (In reply to comment #3) > > Landed in http://trac.webkit.org/changeset/174025 > > It made 3-4 performance tests crash everywhere: > - Apple Mountain Lion: https://build.webkit.org/builders/Apple%20MountainLion%20Release%20%28Perf%29/builds/10126 > - Apple Mavericks: https://build.webkit.org/builders/Apple%20Mavericks%20Release%20%28Perf%29/builds/2663 > - EFL: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/3310 Ok, I will look. The consensus last us GC people chatted was that the barriers that this patch removed were merely masking the lack of barriers elsewhere. I'd rather fix those other barriers directly rather than rolling this out. 1041432 6 mark.lam 2014-10-13 17:43:27 -0700 For the record, there was a follow up fix to this patch. The fix was landed in r174121: <http://trac.webkit.org/r174121> by pizlo. 238742 2014-09-26 15:48:57 -0700 2014-09-26 15:51:03 -0700 the patch blah.patch text/plain 6128 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc0MDI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE0LTA5LTI2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHNob3VsZG4ndCBpbnNlcnQgc3RvcmUgYmFycmllcnMgd2hlbiBpdCBoYXMgaXQgb24gZ29v ZCBhdXRob3JpdHkgdGhhdCB3ZSdyZSBub3Qgc3RvcmluZyBhIGNlbGwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzE2MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhpcyBsb29rcyBsaWtl IGEgMSUgT2N0YW5lIHNwZWVkLXVwLgorCisgICAgICAgICogYnl0ZWNvZGUvU3BlY3VsYXRlZFR5 cGUuaDoKKyAgICAgICAgKEpTQzo6aXNOb3RDZWxsU3BlY3VsYXRpb24pOgorICAgICAgICAqIGRm Zy9ERkdGaXh1cFBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpGaXh1cFBoYXNlOjpmaXh1 cE5vZGUpOgorICAgICAgICAoSlNDOjpERkc6OkZpeHVwUGhhc2U6Omluc2VydFN0b3JlQmFycmll cik6CisgICAgICAgIChKU0M6OkRGRzo6Rml4dXBQaGFzZTo6aW5zZXJ0Q2hlY2spOgorICAgICAg ICAqIGRmZy9ERkdOb2RlLmg6CisgICAgICAgIChKU0M6OkRGRzo6Tm9kZTo6c2hvdWxkU3BlY3Vs YXRlTm90Q2VsbCk6CisKIDIwMTQtMDktMjYgIFBldGVyIFZhcmdhICA8cHZhcmdhQHdlYmtpdC5v cmc+CiAKICAgICAgICAgRml4IHR5cG8gaW4gWUFSUiBhdCBCT0wgY2hlY2sKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TcGVjdWxhdGVkVHlwZS5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TcGVjdWxhdGVkVHlwZS5oCShyZXZpc2lv biAxNzQwMTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU3BlY3VsYXRlZFR5 cGUuaAkod29ya2luZyBjb3B5KQpAQCAtOTgsNiArOTgsMTEgQEAgaW5saW5lIGJvb2wgaXNDZWxs U3BlY3VsYXRpb24oU3BlY3VsYXRlZAogICAgIHJldHVybiAhISh2YWx1ZSAmIFNwZWNDZWxsKSAm JiAhKHZhbHVlICYgflNwZWNDZWxsKTsKIH0KIAoraW5saW5lIGJvb2wgaXNOb3RDZWxsU3BlY3Vs YXRpb24oU3BlY3VsYXRlZFR5cGUgdmFsdWUpCit7CisgICAgcmV0dXJuICEodmFsdWUgJiBTcGVj Q2VsbCkgJiYgdmFsdWU7Cit9CisKIGlubGluZSBib29sIGlzT2JqZWN0U3BlY3VsYXRpb24oU3Bl Y3VsYXRlZFR5cGUgdmFsdWUpCiB7CiAgICAgcmV0dXJuICEhKHZhbHVlICYgU3BlY09iamVjdCkg JiYgISh2YWx1ZSAmIH5TcGVjT2JqZWN0KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHRml4dXBQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdGaXh1cFBoYXNlLmNwcAkocmV2aXNpb24gMTc0MDE2KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjQ0LDcg KzY0NCw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBjYXNlIEFycmF5OjpBcmd1bWVudHM6CiAg ICAgICAgICAgICAgICAgZml4RWRnZTxLbm93bkNlbGxVc2U+KGNoaWxkMSk7CiAgICAgICAgICAg ICAgICAgZml4RWRnZTxJbnQzMlVzZT4oY2hpbGQyKTsKLSAgICAgICAgICAgICAgICBpbnNlcnRT dG9yZUJhcnJpZXIobV9pbmRleEluQmxvY2ssIGNoaWxkMSk7CisgICAgICAgICAgICAgICAgaW5z ZXJ0U3RvcmVCYXJyaWVyKG1faW5kZXhJbkJsb2NrLCBjaGlsZDEsIGNoaWxkMyk7CiAgICAgICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgICAgIGZp eEVkZ2U8S25vd25DZWxsVXNlPihjaGlsZDEpOwpAQCAtNjgyLDcgKzY4Miw3IEBAIHByaXZhdGU6 CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIEFycmF5OjpDb250aWd1 b3VzOgogICAgICAgICAgICAgY2FzZSBBcnJheTo6QXJyYXlTdG9yYWdlOgotICAgICAgICAgICAg ICAgIGluc2VydFN0b3JlQmFycmllcihtX2luZGV4SW5CbG9jaywgbm9kZS0+Y2hpbGQxKCkpOwor ICAgICAgICAgICAgICAgIGluc2VydFN0b3JlQmFycmllcihtX2luZGV4SW5CbG9jaywgbm9kZS0+ Y2hpbGQxKCksIG5vZGUtPmNoaWxkMigpKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAgICAgYnJlYWs7CkBAIC04NTQsNyArODU0LDcg QEAgcHJpdmF0ZToKIAogICAgICAgICBjYXNlIFB1dENsb3N1cmVWYXI6IHsKICAgICAgICAgICAg IGZpeEVkZ2U8S25vd25DZWxsVXNlPihub2RlLT5jaGlsZDEoKSk7Ci0gICAgICAgICAgICBpbnNl cnRTdG9yZUJhcnJpZXIobV9pbmRleEluQmxvY2ssIG5vZGUtPmNoaWxkMSgpKTsKKyAgICAgICAg ICAgIGluc2VydFN0b3JlQmFycmllcihtX2luZGV4SW5CbG9jaywgbm9kZS0+Y2hpbGQxKCksIG5v ZGUtPmNoaWxkMigpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKQEAgLTg5OSw3 ICs4OTksNyBAQCBwcml2YXRlOgogICAgICAgICBjYXNlIFB1dEJ5SWRGbHVzaDoKICAgICAgICAg Y2FzZSBQdXRCeUlkRGlyZWN0OiB7CiAgICAgICAgICAgICBmaXhFZGdlPENlbGxVc2U+KG5vZGUt PmNoaWxkMSgpKTsKLSAgICAgICAgICAgIGluc2VydFN0b3JlQmFycmllcihtX2luZGV4SW5CbG9j aywgbm9kZS0+Y2hpbGQxKCkpOworICAgICAgICAgICAgaW5zZXJ0U3RvcmVCYXJyaWVyKG1faW5k ZXhJbkJsb2NrLCBub2RlLT5jaGlsZDEoKSwgbm9kZS0+Y2hpbGQyKCkpOwogICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIH0KIApAQCAtOTQyLDEzICs5NDIsMTMgQEAgcHJpdmF0ZToKICAgICAg ICAgICAgIGlmICghbm9kZS0+Y2hpbGQxKCktPmhhc1N0b3JhZ2VSZXN1bHQoKSkKICAgICAgICAg ICAgICAgICBmaXhFZGdlPEtub3duQ2VsbFVzZT4obm9kZS0+Y2hpbGQxKCkpOwogICAgICAgICAg ICAgZml4RWRnZTxLbm93bkNlbGxVc2U+KG5vZGUtPmNoaWxkMigpKTsKLSAgICAgICAgICAgIGlu c2VydFN0b3JlQmFycmllcihtX2luZGV4SW5CbG9jaywgbm9kZS0+Y2hpbGQyKCkpOworICAgICAg ICAgICAgaW5zZXJ0U3RvcmVCYXJyaWVyKG1faW5kZXhJbkJsb2NrLCBub2RlLT5jaGlsZDIoKSwg bm9kZS0+Y2hpbGQzKCkpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAg ICAgIAogICAgICAgICBjYXNlIE11bHRpUHV0QnlPZmZzZXQ6IHsKICAgICAgICAgICAgIGZpeEVk Z2U8Q2VsbFVzZT4obm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAgICAgaW5zZXJ0U3RvcmVCYXJy aWVyKG1faW5kZXhJbkJsb2NrLCBub2RlLT5jaGlsZDEoKSk7CisgICAgICAgICAgICBpbnNlcnRT dG9yZUJhcnJpZXIobV9pbmRleEluQmxvY2ssIG5vZGUtPmNoaWxkMSgpLCBub2RlLT5jaGlsZDIo KSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICAgICAgCkBAIC0xNjQw LDEwICsxNjQwLDQ1IEBAIHByaXZhdGU6CiAgICAgICAgIGVkZ2Uuc2V0VXNlS2luZCh1c2VLaW5k KTsKICAgICB9CiAgICAgCi0gICAgdm9pZCBpbnNlcnRTdG9yZUJhcnJpZXIodW5zaWduZWQgaW5k ZXhJbkJsb2NrLCBFZGdlIGNoaWxkMSkKKyAgICB2b2lkIGluc2VydFN0b3JlQmFycmllcih1bnNp Z25lZCBpbmRleEluQmxvY2ssIEVkZ2UgYmFzZSwgRWRnZSB2YWx1ZSA9IEVkZ2UoKSkKICAgICB7 Ci0gICAgICAgIE5vZGUqIGJhcnJpZXJOb2RlID0gbV9ncmFwaC5hZGROb2RlKFNwZWNOb25lLCBT dG9yZUJhcnJpZXIsIG1fY3VycmVudE5vZGUtPm9yaWdpbiwgY2hpbGQxKTsKLSAgICAgICAgbV9p bnNlcnRpb25TZXQuaW5zZXJ0KGluZGV4SW5CbG9jaywgYmFycmllck5vZGUpOworICAgICAgICBp ZiAoISF2YWx1ZSkgeworICAgICAgICAgICAgaWYgKHZhbHVlLT5zaG91bGRTcGVjdWxhdGVJbnQz MigpKSB7CisgICAgICAgICAgICAgICAgaW5zZXJ0Q2hlY2s8SW50MzJVc2U+KGluZGV4SW5CbG9j aywgdmFsdWUubm9kZSgpKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9 CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmICh2YWx1ZS0+c2hvdWxkU3BlY3VsYXRlQm9v bGVhbigpKSB7CisgICAgICAgICAgICAgICAgaW5zZXJ0Q2hlY2s8Qm9vbGVhblVzZT4oaW5kZXhJ bkJsb2NrLCB2YWx1ZS5ub2RlKCkpOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYgKHZhbHVlLT5zaG91bGRTcGVjdWxh dGVPdGhlcigpKSB7CisgICAgICAgICAgICAgICAgaW5zZXJ0Q2hlY2s8T3RoZXJVc2U+KGluZGV4 SW5CbG9jaywgdmFsdWUubm9kZSgpKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAg ICAgICB9CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmICh2YWx1ZS0+c2hvdWxkU3BlY3Vs YXRlTnVtYmVyKCkpIHsKKyAgICAgICAgICAgICAgICBpbnNlcnRDaGVjazxOdW1iZXJVc2U+KGlu ZGV4SW5CbG9jaywgdmFsdWUubm9kZSgpKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAg ICAgICAgICB9CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmICh2YWx1ZS0+c2hvdWxkU3Bl Y3VsYXRlTm90Q2VsbCgpKSB7CisgICAgICAgICAgICAgICAgaW5zZXJ0Q2hlY2s8Tm90Q2VsbFVz ZT4oaW5kZXhJbkJsb2NrLCB2YWx1ZS5ub2RlKCkpOworICAgICAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCisgICAgICAgIG1faW5zZXJ0aW9uU2V0Lmluc2Vy dE5vZGUoCisgICAgICAgICAgICBpbmRleEluQmxvY2ssIFNwZWNOb25lLCBTdG9yZUJhcnJpZXIs IG1fY3VycmVudE5vZGUtPm9yaWdpbiwgYmFzZSk7CisgICAgfQorICAgIAorICAgIHRlbXBsYXRl PFVzZUtpbmQgdXNlS2luZD4KKyAgICB2b2lkIGluc2VydENoZWNrKHVuc2lnbmVkIGluZGV4SW5C bG9jaywgTm9kZSogbm9kZSkKKyAgICB7CisgICAgICAgIG9ic2VydmVVc2VLaW5kT25Ob2RlPHVz ZUtpbmQ+KG5vZGUpOworICAgICAgICBtX2luc2VydGlvblNldC5pbnNlcnROb2RlKAorICAgICAg ICAgICAgaW5kZXhJbkJsb2NrLCBTcGVjTm9uZSwgQ2hlY2ssIG1fY3VycmVudE5vZGUtPm9yaWdp biwgRWRnZShub2RlLCB1c2VLaW5kKSk7CiAgICAgfQogCiAgICAgdm9pZCBmaXhJbnRDb252ZXJ0 aW5nRWRnZShFZGdlJiBlZGdlKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdO b2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlLmgJ KHJldmlzaW9uIDE3NDAxNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5o CSh3b3JraW5nIGNvcHkpCkBAIC0xNjgyLDYgKzE2ODIsMTEgQEAgc3RydWN0IE5vZGUgewogICAg ICAgICByZXR1cm4gaXNDZWxsU3BlY3VsYXRpb24ocHJlZGljdGlvbigpKTsKICAgICB9CiAgICAg CisgICAgYm9vbCBzaG91bGRTcGVjdWxhdGVOb3RDZWxsKCkKKyAgICB7CisgICAgICAgIHJldHVy biBpc05vdENlbGxTcGVjdWxhdGlvbihwcmVkaWN0aW9uKCkpOworICAgIH0KKyAgICAKICAgICBz dGF0aWMgYm9vbCBzaG91bGRTcGVjdWxhdGVCb29sZWFuKE5vZGUqIG9wMSwgTm9kZSogb3AyKQog ICAgIHsKICAgICAgICAgcmV0dXJuIG9wMS0+c2hvdWxkU3BlY3VsYXRlQm9vbGVhbigpICYmIG9w Mi0+c2hvdWxkU3BlY3VsYXRlQm9vbGVhbigpOwo=