137152 2014-09-26 10:56:49 -0700 Web Inspector: Type Token View shows type information on hover when it shouldn't 2014-09-26 14:40:31 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 saam saam graouts joepeck timothy webkit-bug-importer oldest_to_newest 1037518 0 saam 2014-09-26 10:56:49 -0700 TypeTokenView::_shouldShowPopover is broken: One of its conditions reads: if (this._types.structures && this._types.structures) { ... } But it should be written as: if (this._types.structures && this._types.structures.length > 1) { ... } 1037519 1 webkit-bug-importer 2014-09-26 10:57:02 -0700 <rdar://problem/18470483> 1037554 2 saam 2014-09-26 14:16:47 -0700 (In reply to comment #0) > TypeTokenView::_shouldShowPopover is broken: > > One of its conditions reads: > if (this._types.structures && this._types.structures) { ... } > > But it should be written as: > if (this._types.structures && this._types.structures.length > 1) { ... } This should actually be: if (this._types.structures && this._types.structures.length >= 1) { ... } because we care if there is only one object or more, not more than one. 1037555 3 238737 saam 2014-09-26 14:22:19 -0700 Created attachment 238737 patch 1037556 4 238737 burg 2014-09-26 14:25:16 -0700 Comment on attachment 238737 patch View in context: https://bugs.webkit.org/attachment.cgi?id=238737&action=review > Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js:135 > + if (this._types.structures && this._types.structures.length >= 1) I think you can drop the >= 1 here. 1037559 5 saam 2014-09-26 14:40:31 -0700 landed in: http://trac.webkit.org/changeset/174019 238737 2014-09-26 14:22:19 -0700 2014-09-26 14:25:16 -0700 patch patch.diff text/plain 1566 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTc0MDE4KQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTA5LTI2ICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiBUeXBlIFRva2VuIFZpZXcgc2hvd3MgdHlwZSBpbmZvcm1hdGlv biBvbiBob3ZlciB3aGVuIGl0IHNob3VsZG4ndAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3MTUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVHlwZVRva2VuVmlldyBzaG91bGQgb25seSBzaG93IHR5cGUg aW5mb3JtYXRpb24gd2hlbiB0aGVyZSBpcyAKKyAgICAgICAgbW9yZSB0aGFuIG9uZSBwcmltaXRp dmUgdHlwZSBvciBtb3JlIHRoYW4gemVybyBvYmplY3RzIHR5cGVzLiAKKyAgICAgICAgVGhpcyBm aXhlcyBhIGJ1ZyBpbiBjaGVja2luZyB0aGUgbGVuZ3RoIG9mIG9iamVjdCB0eXBlcy4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVHlwZVRva2VuVmlldy5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5UeXBlVG9rZW5WaWV3LnByb3RvdHlwZS5fc2hvdWxkU2hvd1BvcG92ZXIpOgor CiAyMDE0LTA5LTI1ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBTaG93IHR5cGUgaW5mbyBpY29uIGlzIGJsdXJyeQpJbmRleDog U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHlwZVRva2VuVmlldy5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UeXBlVG9rZW5WaWV3LmpzCShyZXZpc2lvbiAxNzQwMTgpCisrKyBTb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UeXBlVG9rZW5WaWV3LmpzCSh3b3JraW5nIGNvcHkp CkBAIC0xMzIsNyArMTMyLDcgQEAgV2ViSW5zcGVjdG9yLlR5cGVUb2tlblZpZXcucHJvdG90eXBl ID0gewogICAgICAgICBpZiAodGhpcy5fdHlwZXMucHJpbWl0aXZlVHlwZU5hbWVzICYmIHRoaXMu X3R5cGVzLnByaW1pdGl2ZVR5cGVOYW1lcy5sZW5ndGggPiAxKQogICAgICAgICAgICAgcmV0dXJu IHRydWU7CiAKLSAgICAgICAgaWYgKHRoaXMuX3R5cGVzLnN0cnVjdHVyZXMgJiYgdGhpcy5fdHlw ZXMuc3RydWN0dXJlcykKKyAgICAgICAgaWYgKHRoaXMuX3R5cGVzLnN0cnVjdHVyZXMgJiYgdGhp cy5fdHlwZXMuc3RydWN0dXJlcy5sZW5ndGggPj0gMSkKICAgICAgICAgICAgIHJldHVybiB0cnVl OwogCiAgICAgICAgIHJldHVybiBmYWxzZTsK