137148 2014-09-26 09:22:55 -0700 [GTK] Don't include full path names in WebKitEnumTypes.h 2014-09-26 09:57:59 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned cgarcia commit-queue gustavo mrobinson oldest_to_newest 1037490 0 berto 2014-09-26 09:22:55 -0700 In short, we should replace @filename@ with @basename@ here: /*** BEGIN file-production ***/ /* Enumerations from @filename@. */ /*** END file-production ***/ The former puts the full path of the compilation directory in the generated file, which should not be there, which among other things makes it more difficult to have a multiarch-compliant header. 1037491 1 238722 berto 2014-09-26 09:27:03 -0700 Created attachment 238722 Patch 1037492 2 commit-queue 2014-09-26 09:28:22 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1037493 3 cgarcia 2014-09-26 09:30:58 -0700 (In reply to comment #0) > In short, we should replace @filename@ with @basename@ here: > > /*** BEGIN file-production ***/ > /* Enumerations from @filename@. */ > /*** END file-production ***/ > > The former puts the full path of the compilation directory in the generated file, > which should not be there, which among other things makes it more difficult to > have a multiarch-compliant header. How does affect that multi-arch if it's just a comment? 1037494 4 berto 2014-09-26 09:48:22 -0700 (In reply to comment #3) > How does affect that multi-arch if it's just a comment? Multi-arch requires that all architecture-independent files are identical among different architectures. This file is architecture-indepent however it will be different among builds if those builds are made in different directories. 1037495 5 cgarcia 2014-09-26 09:51:20 -0700 (In reply to comment #4) > (In reply to comment #3) > > How does affect that multi-arch if it's just a comment? > > Multi-arch requires that all architecture-independent files are > identical among different architectures. > > This file is architecture-indepent however it will be different among > builds if those builds are made in different directories. Ah, I see, thanks! 1037497 6 berto 2014-09-26 09:57:59 -0700 Committed r174008: <http://trac.webkit.org/changeset/174008> 238722 2014-09-26 09:27:03 -0700 2014-09-26 09:31:22 -0700 Patch 137148.diff text/plain 1166 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4NzE5OTE0Li40MGJkMTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMDktMjYgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBbR1RLXSBEb24ndCBpbmNsdWRlIGZ1bGwgcGF0aCBuYW1lcyBpbiBXZWJLaXRFbnVtVHlw ZXMuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3 MTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVw bGFjZSBAZmlsZW5hbWVAIHdpdGggQGJhc2VuYW1lQCBpbiB0aGUgdGVtcGxhdGUsIHNpbmNlIHdl IGRvbid0CisgICAgICAgIHdhbnQgdG8gaW5jbHVkZSB0aGUgZnVsbCBwYXRoIG5hbWUgaW4gdGhl IGdlbmVyYXRlZCBoZWFkZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRF bnVtVHlwZXMuaC50ZW1wbGF0ZToKKwogMjAxNC0wOS0yNSAgWXVzdWtlIFN1enVraSAgPHV0YXRh bmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBDbGVhbiB1cCB1bnVzZWQgcGFyYW1ldGVyIHdh cm5pbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRFbnVtVHlwZXMuaC50ZW1wbGF0ZSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdEVudW1UeXBlcy5oLnRlbXBsYXRlCmluZGV4IDEyODNlMGIuLjdkNjU3MGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVudW1UeXBlcy5o LnRlbXBsYXRlCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEVu dW1UeXBlcy5oLnRlbXBsYXRlCkBAIC0zMyw3ICszMyw3IEBAIEdfQkVHSU5fREVDTFMKIAogCiAv KioqIEJFR0lOIGZpbGUtcHJvZHVjdGlvbiAqKiovCi0vKiBFbnVtZXJhdGlvbnMgZnJvbSBAZmls ZW5hbWVALiAqLworLyogRW51bWVyYXRpb25zIGZyb20gQGJhc2VuYW1lQC4gKi8KIC8qKiogRU5E IGZpbGUtcHJvZHVjdGlvbiAqKiovCiAKIAo=