137144 2014-09-26 00:28:38 -0700 Fix typo in YARR at BOL check 2014-09-26 10:50:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 1 dcb314 pvarga commit-queue msaboff ossy pvarga oldest_to_newest 1037436 0 dcb314 2014-09-26 00:28:38 -0700 webkitgtk-2.5.90/Source/JavaScriptCore/yarr/YarrPattern.cpp:300]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses. Source code is if (!m_alternative->m_terms.size() & !m_invertParentheticalAssertion) { Maybe if (!m_alternative->m_terms.size() && !m_invertParentheticalAssertion) { was intended. 1037453 1 ossy 2014-09-26 04:48:18 -0700 The code is still in trunk, cc-ing YARR experts. 1037454 2 238708 pvarga 2014-09-26 05:28:07 -0700 Created attachment 238708 proposed patch 1037503 3 238708 darin 2014-09-26 10:13:27 -0700 Comment on attachment 238708 proposed patch OK to make this change, but it was OK to use & here since both values were booleans and the second expression had no side effect. 1037515 4 238708 commit-queue 2014-09-26 10:50:02 -0700 Comment on attachment 238708 proposed patch Clearing flags on attachment: 238708 Committed r174012: <http://trac.webkit.org/changeset/174012> 1037516 5 commit-queue 2014-09-26 10:50:04 -0700 All reviewed patches have been landed. Closing bug. 238708 2014-09-26 05:28:07 -0700 2014-09-26 10:50:02 -0700 proposed patch yarr-typo-fix.patch text/plain 1237 pvarga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRmZGM3YjguLjJkYWQ3MTEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA5LTI2ICBQZXRlciBWYXJnYSAg PHB2YXJnYUB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCB0eXBvIGluIFlBUlIgYXQgQk9MIGNo ZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcx NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHlh cnIvWWFyclBhdHRlcm4uY3BwOiByZXBsYWNlIGJpdHdpc2UgYW5kIG9wZXJhdG9yIGJ5IGxvZ2lj YWwgYW5kCisgICAgICAgIChKU0M6OllhcnI6OllhcnJQYXR0ZXJuQ29uc3RydWN0b3I6OmFzc2Vy dGlvbkJPTCk6CisKIDIwMTQtMDktMjUgIFNhYW0gQmFyYXRpICA8c2FhbWJhcmF0aTFAZ21haWwu Y29tPgoKICAgICAgICAgV2ViIEluc3BlY3RvcjogY29uc29sZS5hc3NlcnQoYml0U3RyaW5nKSBU eXBlU2V0OjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJyUGF0 dGVybi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJyUGF0dGVybi5jcHAKaW5k ZXggNTZkZDVlNS4uYmU3MzI3ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3lh cnIvWWFyclBhdHRlcm4uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS95YXJyL1lhcnJQ YXR0ZXJuLmNwcApAQCAtMjk3LDcgKzI5Nyw3IEBAIHB1YmxpYzoKCiAgICAgdm9pZCBhc3NlcnRp b25CT0woKQogICAgIHsKLSAgICAgICAgaWYgKCFtX2FsdGVybmF0aXZlLT5tX3Rlcm1zLnNpemUo KSAmICFtX2ludmVydFBhcmVudGhldGljYWxBc3NlcnRpb24pIHsKKyAgICAgICAgaWYgKCFtX2Fs dGVybmF0aXZlLT5tX3Rlcm1zLnNpemUoKSAmJiAhbV9pbnZlcnRQYXJlbnRoZXRpY2FsQXNzZXJ0 aW9uKSB7CiAgICAgICAgICAgICBtX2FsdGVybmF0aXZlLT5tX3N0YXJ0c1dpdGhCT0wgPSB0cnVl OwogICAgICAgICAgICAgbV9hbHRlcm5hdGl2ZS0+bV9jb250YWluc0JPTCA9IHRydWU7CiAgICAg ICAgICAgICBtX3BhdHRlcm4ubV9jb250YWluc0JPTCA9IHRydWU7Cg==