137107 2014-09-24 23:16:08 -0700 Clean up unused parameter warnings 2014-09-25 18:09:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki commit-queue mrobinson ossy oldest_to_newest 1037163 0 ysuzuki 2014-09-24 23:16:08 -0700 [GTK] Clean up unused parameter warnings 1037164 1 238643 ysuzuki 2014-09-24 23:17:12 -0700 Created attachment 238643 Patch 1037200 2 238643 ossy 2014-09-25 03:19:03 -0700 Comment on attachment 238643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238643&action=review > Source/WebKit2/WebProcess/WebPage/WebInspector.h:62 > - void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) { close(); } > + void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) > + { > + UNUSED_PARAM(messageReceiverName); > + UNUSED_PARAM(messageName); > + close(); > + } In this case we should simple remove the name of the parameter. UNUSED_PARAM is used if the parameter is unused only if some ENABLE(FOO) guard is true or false. Otherwise it is already fixed in bug137105. > Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h:57 > - void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) { closeWindow(); } > + void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) > + { > + UNUSED_PARAM(messageReceiverName); > + UNUSED_PARAM(messageName); > + closeWindow(); > + } Already fixed in bug137105. 1037201 3 238643 ysuzuki 2014-09-25 03:22:23 -0700 Comment on attachment 238643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238643&action=review Thank you for your review, I'll upload the revised one. > Source/WebKit2/Scripts/webkit/messages.py:624 > result.append(' UNUSED_PARAM(connection);\n') In this case, we may use `connection` in the generated code. So using `UNUSED_PARAM`. It is aligned to the following `UNUSED_PARAM(decoder)` etc. > Source/WebKit2/UIProcess/API/C/WKPage.cpp:1885 > bool WKPageIsPlayingAudio(WKPageRef page) I'll drop `page` instead of adding `UNUSED_PARAM(page)`. >> Source/WebKit2/WebProcess/WebPage/WebInspector.h:62 >> + } > > In this case we should simple remove the name of the parameter. > UNUSED_PARAM is used if the parameter is unused only if > some ENABLE(FOO) guard is true or false. > > Otherwise it is already fixed in bug137105. Thanks! OK, so I'll drop this change from this patch. >> Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h:57 >> + } > > Already fixed in bug137105. ditto :) 1037202 4 238653 ysuzuki 2014-09-25 03:28:10 -0700 Created attachment 238653 Patch 1037372 5 238653 commit-queue 2014-09-25 18:09:47 -0700 Comment on attachment 238653 Patch Clearing flags on attachment: 238653 Committed r173990: <http://trac.webkit.org/changeset/173990> 1037373 6 commit-queue 2014-09-25 18:09:51 -0700 All reviewed patches have been landed. Closing bug. 238643 2014-09-24 23:17:12 -0700 2014-09-25 03:28:06 -0700 Patch bug-137107-20140925151811.patch text/plain 5265 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTczOTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmQ2ZjdmNGI1ZWVhMjNl ZDZiMDMyNGQwMmM1M2IyMmI3YjI4Y2UxNC4uM2ZkZGFiMjZmODkzZDNjYzBiODUwNTUzNjExMzNl NzcxMzdiMTNkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA5LTI0ICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIENsZWFu IHVwIHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzEwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHk6CisgICAg ICAgIChnZW5lcmF0ZV9tZXNzYWdlX2hhbmRsZXIpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv Qy9XS1BhZ2UuY3BwOgorICAgICAgICAoV0tQYWdlSXNQbGF5aW5nQXVkaW8pOgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3IuaDoKKyAgICAgICAgKFdlYktpdDo6V2Vi SW5zcGVjdG9yOjpkaWRSZWNlaXZlSW52YWxpZE1lc3NhZ2UpOgorICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUGFnZS9XZWJJbnNwZWN0b3JVSS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0 b3JVSTo6ZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlKToKKwogMjAxNC0wOS0yNCAgU2FtIFdlaW5p ZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBpbmNvcnJlY3QgdXNlIG9mIHRo ZSBCS1NQcm9jZXNzQXNzZXJ0aW9uQWxsb3dTdXNwZW5kT25TbGVlcCBmbGFnIGZvciBwcm9jZXNz IHN1c3BlbnNpb24gaW4gaU9TIFdlYktpdDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1Nj cmlwdHMvd2Via2l0L21lc3NhZ2VzLnB5IGIvU291cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQv bWVzc2FnZXMucHkKaW5kZXggZjQ0ODliMTczNGZiMzJiNGFkYThiYWNhOTI4YzhmOTZjYzdmZmFh NS4uMTkzNmE2ZWJmNDY0ZmI1ODFiMDQ4NGM1ZjQ4YWJmZjNlODk3N2Y3YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHkKKysrIGIvU291cmNlL1dl YktpdDIvU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHkKQEAgLTYxMSwxMyArNjExLDE2IEBAIGRl ZiBnZW5lcmF0ZV9tZXNzYWdlX2hhbmRsZXIoZmlsZSk6CiAKICAgICBpZiBzeW5jX21lc3NhZ2Vz OgogICAgICAgICByZXN1bHQuYXBwZW5kKCdcbicpCisgICAgICAgIHVzZV9jb25uZWN0aW9uID0g VHJ1ZQogICAgICAgICBpZiByZWNlaXZlci5oYXNfYXR0cmlidXRlKExFR0FDWV9SRUNFSVZFUl9B VFRSSUJVVEUpOgotICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgndm9pZCAlczo6ZGlkUmVjZWl2 ZVN5bmMlc01lc3NhZ2UoSVBDOjpDb25uZWN0aW9uKiVzLCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJiBk ZWNvZGVyLCBzdGQ6OnVuaXF1ZV9wdHI8SVBDOjpNZXNzYWdlRW5jb2Rlcj4mIHJlcGx5RW5jb2Rl cilcbicgJSAocmVjZWl2ZXIubmFtZSwgcmVjZWl2ZXIubmFtZSwgJyBjb25uZWN0aW9uJyBpZiBz eW5jX2RlbGF5ZWRfbWVzc2FnZXMgZWxzZSAnJykpCisgICAgICAgICAgICBpZiBub3Qgc3luY19k ZWxheWVkX21lc3NhZ2VzOgorICAgICAgICAgICAgICAgIHVzZV9jb25uZWN0aW9uID0gRmFsc2UK KyAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQoJ3ZvaWQgJXM6OmRpZFJlY2VpdmVTeW5jJXNNZXNz YWdlKElQQzo6Q29ubmVjdGlvbiolcywgSVBDOjpNZXNzYWdlRGVjb2RlciYgZGVjb2Rlciwgc3Rk Ojp1bmlxdWVfcHRyPElQQzo6TWVzc2FnZUVuY29kZXI+JiByZXBseUVuY29kZXIpXG4nICUgKHJl Y2VpdmVyLm5hbWUsIHJlY2VpdmVyLm5hbWUsICcgY29ubmVjdGlvbicgaWYgdXNlX2Nvbm5lY3Rp b24gZWxzZSAnJykpCiAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICByZXN1bHQuYXBwZW5kKCd2 b2lkICVzOjpkaWRSZWNlaXZlU3luY01lc3NhZ2UoSVBDOjpDb25uZWN0aW9uKiBjb25uZWN0aW9u LCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJiBkZWNvZGVyLCBzdGQ6OnVuaXF1ZV9wdHI8SVBDOjpNZXNz YWdlRW5jb2Rlcj4mIHJlcGx5RW5jb2RlcilcbicgJSAocmVjZWl2ZXIubmFtZSkpCiAgICAgICAg IHJlc3VsdC5hcHBlbmQoJ3tcbicpCiAgICAgICAgIHJlc3VsdCArPSBbc3luY19tZXNzYWdlX3N0 YXRlbWVudChyZWNlaXZlciwgbWVzc2FnZSkgZm9yIG1lc3NhZ2UgaW4gc3luY19tZXNzYWdlc10K LSAgICAgICAgaWYgbm90IHJlY2VpdmVyLmhhc19hdHRyaWJ1dGUoTEVHQUNZX1JFQ0VJVkVSX0FU VFJJQlVURSk6CisgICAgICAgIGlmIHVzZV9jb25uZWN0aW9uOgogICAgICAgICAgICAgcmVzdWx0 LmFwcGVuZCgnICAgIFVOVVNFRF9QQVJBTShjb25uZWN0aW9uKTtcbicpCiAgICAgICAgIHJlc3Vs dC5hcHBlbmQoJyAgICBVTlVTRURfUEFSQU0oZGVjb2Rlcik7XG4nKQogICAgICAgICByZXN1bHQu YXBwZW5kKCcgICAgVU5VU0VEX1BBUkFNKHJlcGx5RW5jb2Rlcik7XG4nKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAppbmRleCBiOGIwMmNiZWU1M2QzYWEzNjhiNzk3 ZDU3MmI1NTM0OTJjYWNjOTRjLi5mOTAyZmI2ZjIzNzRhNDQxMDRlNmFlYTk5NWZiY2EzMmJkM2Vm MGViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcApAQCAtMTg4 NSw2ICsxODg1LDcgQEAgdm9pZCBXS1BhZ2VTZXRBZGRzVmlzaXRlZExpbmtzKFdLUGFnZVJlZiBw YWdlLCBib29sIGFkZHNWaXNpdGVkTGlua3MpCiBib29sIFdLUGFnZUlzUGxheWluZ0F1ZGlvKFdL UGFnZVJlZiBwYWdlKQogewogICAgIC8vIEZJWE1FOiBUbyBiZSBpbXBsZW1lbnRlZCAoaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzA0OCkuCisgICAgVU5VU0VEX1BB UkFNKHBhZ2UpOwogICAgIHJldHVybiBmYWxzZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvci5oIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvci5oCmluZGV4IDNjMTliOWU4NWIyZmFjYWVk MzVmM2E0ZDBmZWJlZGY4MGE0MzQyYjEuLjljMzdmZjk2ZDkzNmJiN2YyNjNjZWJhMTQwZDVkNjlk N2VhNGU1ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9X ZWJJbnNwZWN0b3IuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi SW5zcGVjdG9yLmgKQEAgLTU0LDcgKzU0LDEyIEBAIGNsYXNzIFdlYkluc3BlY3RvciA6IHB1Ymxp YyBBUEk6Ok9iamVjdEltcGw8QVBJOjpPYmplY3Q6OlR5cGU6OkJ1bmRsZUluc3BlY3Rvcj4sCiAK ICAgICAvLyBJUEM6OkNvbm5lY3Rpb246OkNsaWVudAogICAgIHZvaWQgZGlkQ2xvc2UoSVBDOjpD b25uZWN0aW9uKikgeyBjbG9zZSgpOyB9Ci0gICAgdm9pZCBkaWRSZWNlaXZlSW52YWxpZE1lc3Nh Z2UoSVBDOjpDb25uZWN0aW9uKiwgSVBDOjpTdHJpbmdSZWZlcmVuY2UgbWVzc2FnZVJlY2VpdmVy TmFtZSwgSVBDOjpTdHJpbmdSZWZlcmVuY2UgbWVzc2FnZU5hbWUpIHsgY2xvc2UoKTsgfQorICAg IHZvaWQgZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiosIElQQzo6U3Ry aW5nUmVmZXJlbmNlIG1lc3NhZ2VSZWNlaXZlck5hbWUsIElQQzo6U3RyaW5nUmVmZXJlbmNlIG1l c3NhZ2VOYW1lKQorICAgIHsKKyAgICAgICAgVU5VU0VEX1BBUkFNKG1lc3NhZ2VSZWNlaXZlck5h bWUpOworICAgICAgICBVTlVTRURfUEFSQU0obWVzc2FnZU5hbWUpOworICAgICAgICBjbG9zZSgp OworICAgIH0KIAogICAgIC8vIENhbGxlZCBieSBXZWJJbnNwZWN0b3IgbWVzc2FnZXMKICAgICB2 b2lkIGNvbm5lY3Rpb25Fc3RhYmxpc2hlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3RvclVJLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yVUkuaAppbmRleCBiZGJmY2JlMzhkZjcyYTU4NGZk MTMwNDgxY2ZmYzA1ZDA4ZmFhNjNmLi4zYWIwZGUwZTViMDY1MzU3NGJhOWJjOGFjZTA3MjZlYTAx MjhkODIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi SW5zcGVjdG9yVUkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi SW5zcGVjdG9yVUkuaApAQCAtNDksNyArNDksMTIgQEAgY2xhc3MgV2ViSW5zcGVjdG9yVUkgOiBw dWJsaWMgQVBJOjpPYmplY3RJbXBsPEFQSTo6T2JqZWN0OjpUeXBlOjpCdW5kbGVJbnNwZWN0b3IK IAogICAgIC8vIElQQzo6Q29ubmVjdGlvbjo6Q2xpZW50CiAgICAgdm9pZCBkaWRDbG9zZShJUEM6 OkNvbm5lY3Rpb24qKSB7IGNsb3NlV2luZG93KCk7IH0KLSAgICB2b2lkIGRpZFJlY2VpdmVJbnZh bGlkTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24qLCBJUEM6OlN0cmluZ1JlZmVyZW5jZSBtZXNzYWdl UmVjZWl2ZXJOYW1lLCBJUEM6OlN0cmluZ1JlZmVyZW5jZSBtZXNzYWdlTmFtZSkgeyBjbG9zZVdp bmRvdygpOyB9CisgICAgdm9pZCBkaWRSZWNlaXZlSW52YWxpZE1lc3NhZ2UoSVBDOjpDb25uZWN0 aW9uKiwgSVBDOjpTdHJpbmdSZWZlcmVuY2UgbWVzc2FnZVJlY2VpdmVyTmFtZSwgSVBDOjpTdHJp bmdSZWZlcmVuY2UgbWVzc2FnZU5hbWUpCisgICAgeworICAgICAgICBVTlVTRURfUEFSQU0obWVz c2FnZVJlY2VpdmVyTmFtZSk7CisgICAgICAgIFVOVVNFRF9QQVJBTShtZXNzYWdlTmFtZSk7Cisg ICAgICAgIGNsb3NlV2luZG93KCk7CisgICAgfQogCiAgICAgLy8gQ2FsbGVkIGJ5IFdlYkluc3Bl Y3RvclVJIG1lc3NhZ2VzCiAgICAgdm9pZCBlc3RhYmxpc2hDb25uZWN0aW9uKElQQzo6QXR0YWNo bWVudCBjb25uZWN0aW9uSWRlbnRpZmllciwgdWludDY0X3QgaW5zcGVjdGVkUGFnZUlkZW50aWZp ZXIsIGJvb2wgdW5kZXJUZXN0KTsK 238653 2014-09-25 03:28:10 -0700 2014-09-25 18:09:47 -0700 Patch bug-137107-20140925192809.patch text/plain 3192 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTczOTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmQ2ZjdmNGI1ZWVhMjNl ZDZiMDMyNGQwMmM1M2IyMmI3YjI4Y2UxNC4uODIwYWY1N2ZhNDFlZjUyZDEzYjAzMDJiYzE2NDA1 ODIxOWUzMjQ3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA5LTI1ICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIENsZWFuIHVwIHVu dXNlZCBwYXJhbWV0ZXIgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNzEwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHk6CisgICAgICAgIChn ZW5lcmF0ZV9tZXNzYWdlX2hhbmRsZXIpOgorICAgICAgICBTb21ldGltZXMgZ2VuZXJhdGVkIGNv ZGUgZG9lc24ndCB1c2UgYGNvbm5lY3Rpb25gIHBhcmFtZXRlci4gU28gYFVOVVNFRF9QQVJBTShj b25uZWN0aW9uKWAgaXMgbmVjZXNzYXJ5LgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1Bh Z2UuY3BwOgorICAgICAgICAoV0tQYWdlSXNQbGF5aW5nQXVkaW8pOgorCiAyMDE0LTA5LTI0ICBT YW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIGluY29ycmVjdCB1 c2Ugb2YgdGhlIEJLU1Byb2Nlc3NBc3NlcnRpb25BbGxvd1N1c3BlbmRPblNsZWVwIGZsYWcgZm9y IHByb2Nlc3Mgc3VzcGVuc2lvbiBpbiBpT1MgV2ViS2l0MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHkgYi9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRz L3dlYmtpdC9tZXNzYWdlcy5weQppbmRleCBmNDQ4OWIxNzM0ZmIzMmI0YWRhOGJhY2E5MjhjOGY5 NmNjN2ZmYWE1Li4xOTM2YTZlYmY0NjRmYjU4MWIwNDg0YzVmNDhhYmZmM2U4OTc3ZjdhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdC9tZXNzYWdlcy5weQorKysgYi9T b3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdC9tZXNzYWdlcy5weQpAQCAtNjExLDEzICs2MTEs MTYgQEAgZGVmIGdlbmVyYXRlX21lc3NhZ2VfaGFuZGxlcihmaWxlKToKIAogICAgIGlmIHN5bmNf bWVzc2FnZXM6CiAgICAgICAgIHJlc3VsdC5hcHBlbmQoJ1xuJykKKyAgICAgICAgdXNlX2Nvbm5l Y3Rpb24gPSBUcnVlCiAgICAgICAgIGlmIHJlY2VpdmVyLmhhc19hdHRyaWJ1dGUoTEVHQUNZX1JF Q0VJVkVSX0FUVFJJQlVURSk6Ci0gICAgICAgICAgICByZXN1bHQuYXBwZW5kKCd2b2lkICVzOjpk aWRSZWNlaXZlU3luYyVzTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24qJXMsIElQQzo6TWVzc2FnZURl Y29kZXImIGRlY29kZXIsIHN0ZDo6dW5pcXVlX3B0cjxJUEM6Ok1lc3NhZ2VFbmNvZGVyPiYgcmVw bHlFbmNvZGVyKVxuJyAlIChyZWNlaXZlci5uYW1lLCByZWNlaXZlci5uYW1lLCAnIGNvbm5lY3Rp b24nIGlmIHN5bmNfZGVsYXllZF9tZXNzYWdlcyBlbHNlICcnKSkKKyAgICAgICAgICAgIGlmIG5v dCBzeW5jX2RlbGF5ZWRfbWVzc2FnZXM6CisgICAgICAgICAgICAgICAgdXNlX2Nvbm5lY3Rpb24g PSBGYWxzZQorICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgndm9pZCAlczo6ZGlkUmVjZWl2ZVN5 bmMlc01lc3NhZ2UoSVBDOjpDb25uZWN0aW9uKiVzLCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJiBkZWNv ZGVyLCBzdGQ6OnVuaXF1ZV9wdHI8SVBDOjpNZXNzYWdlRW5jb2Rlcj4mIHJlcGx5RW5jb2Rlcilc bicgJSAocmVjZWl2ZXIubmFtZSwgcmVjZWl2ZXIubmFtZSwgJyBjb25uZWN0aW9uJyBpZiB1c2Vf Y29ubmVjdGlvbiBlbHNlICcnKSkKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHJlc3VsdC5h cHBlbmQoJ3ZvaWQgJXM6OmRpZFJlY2VpdmVTeW5jTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24qIGNv bm5lY3Rpb24sIElQQzo6TWVzc2FnZURlY29kZXImIGRlY29kZXIsIHN0ZDo6dW5pcXVlX3B0cjxJ UEM6Ok1lc3NhZ2VFbmNvZGVyPiYgcmVwbHlFbmNvZGVyKVxuJyAlIChyZWNlaXZlci5uYW1lKSkK ICAgICAgICAgcmVzdWx0LmFwcGVuZCgne1xuJykKICAgICAgICAgcmVzdWx0ICs9IFtzeW5jX21l c3NhZ2Vfc3RhdGVtZW50KHJlY2VpdmVyLCBtZXNzYWdlKSBmb3IgbWVzc2FnZSBpbiBzeW5jX21l c3NhZ2VzXQotICAgICAgICBpZiBub3QgcmVjZWl2ZXIuaGFzX2F0dHJpYnV0ZShMRUdBQ1lfUkVD RUlWRVJfQVRUUklCVVRFKToKKyAgICAgICAgaWYgdXNlX2Nvbm5lY3Rpb246CiAgICAgICAgICAg ICByZXN1bHQuYXBwZW5kKCcgICAgVU5VU0VEX1BBUkFNKGNvbm5lY3Rpb24pO1xuJykKICAgICAg ICAgcmVzdWx0LmFwcGVuZCgnICAgIFVOVVNFRF9QQVJBTShkZWNvZGVyKTtcbicpCiAgICAgICAg IHJlc3VsdC5hcHBlbmQoJyAgICBVTlVTRURfUEFSQU0ocmVwbHlFbmNvZGVyKTtcbicpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCmluZGV4IGI4YjAyY2JlZTUzZDNh YTM2OGI3OTdkNTcyYjU1MzQ5MmNhY2M5NGMuLjEzYzVlNWIzMjc3NWIzODg3MTg5ZTEzYzA5M2E4 NzUyYjNiM2IxNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9X S1BhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3Bw CkBAIC0xODgyLDcgKzE4ODIsNyBAQCB2b2lkIFdLUGFnZVNldEFkZHNWaXNpdGVkTGlua3MoV0tQ YWdlUmVmIHBhZ2UsIGJvb2wgYWRkc1Zpc2l0ZWRMaW5rcykKICAgICB0b0ltcGwocGFnZSktPnNl dEFkZHNWaXNpdGVkTGlua3MoYWRkc1Zpc2l0ZWRMaW5rcyk7CiB9CiAKLWJvb2wgV0tQYWdlSXNQ bGF5aW5nQXVkaW8oV0tQYWdlUmVmIHBhZ2UpCitib29sIFdLUGFnZUlzUGxheWluZ0F1ZGlvKFdL UGFnZVJlZikKIHsKICAgICAvLyBGSVhNRTogVG8gYmUgaW1wbGVtZW50ZWQgKGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcwNDgpLgogICAgIHJldHVybiBmYWxzZTsK