137105 2014-09-24 22:20:54 -0700 [WebKit2] Fix build warning in WebKit2/WebProcess module 2014-09-25 03:51:40 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned andersca commit-queue gyuyoung.kim ossy ryuan.choi timothy oldest_to_newest 1037160 0 shiva.jm 2014-09-24 22:20:54 -0700 Getting below build warning error when built on latest WK2-EFL port. In file included from /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp:27:0: /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.h:57:10: warning: unused parameter ‘messageReceiverName’ [-Wunused-parameter] void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) { close(); } ^ /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.h:57:10: warning: unused parameter ‘messageName’ [-Wunused-parameter] In file included from /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp:27:0: /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h:52:10: warning: unused parameter ‘messageReceiverName’ [-Wunused-parameter] void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) { closeWindow(); } ^ /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h:52:10: warning: unused parameter ‘messageName’ [-Wunused-parameter] [ 90%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebPageGroupProxy.cpp.o [ 90%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/VisitedLinkTableController.cpp.o In file included from /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:80:0: /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.h:57:10: warning: unused parameter ‘messageReceiverName’ [-Wunused-parameter] void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) { close(); } ^ /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.h:57:10: warning: unused parameter ‘messageName’ [-Wunused-parameter] In file included from /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:83:0: /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h:52:10: warning: unused parameter ‘messageReceiverName’ [-Wunused-parameter] void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) { closeWindow(); } ^ /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h:52:10: warning: unused parameter ‘messageName’ [-Wunused-parameter] 1037161 1 238642 shiva.jm 2014-09-24 22:27:18 -0700 Created attachment 238642 Patch Fix build warning by removing unused parameter names 1037204 2 238642 commit-queue 2014-09-25 03:51:35 -0700 Comment on attachment 238642 Patch Clearing flags on attachment: 238642 Committed r173951: <http://trac.webkit.org/changeset/173951> 1037205 3 commit-queue 2014-09-25 03:51:40 -0700 All reviewed patches have been landed. Closing bug. 238642 2014-09-24 22:27:18 -0700 2014-09-25 03:51:34 -0700 Patch bug-137105.patch text/plain 2382 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mzk0NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA5LTI0ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dlYktpdDJdIEZpeCBi dWlsZCB3YXJuaW5nIGluIFdlYktpdDIvV2ViUHJvY2VzcyBtb2R1bGUuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcxMDUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYnVpbGQgd2FybmluZyBieSBy ZW1vdmluZyB1bnVzZWQgcGFyYW1ldGVyIG5hbWVzCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dl YlBhZ2UvV2ViSW5zcGVjdG9yLmg6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3Rvcjo6ZGlk UmVjZWl2ZUludmFsaWRNZXNzYWdlKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi SW5zcGVjdG9yVUkuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yVUk6OmRpZFJlY2Vp dmVJbnZhbGlkTWVzc2FnZSk6CisKIDIwMTQtMDktMjQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBSZW1vdmUgaW5jb3JyZWN0IHVzZSBvZiB0aGUgQktTUHJvY2Vzc0Fz c2VydGlvbkFsbG93U3VzcGVuZE9uU2xlZXAgZmxhZyBmb3IgcHJvY2VzcyBzdXNwZW5zaW9uIGlu IGlPUyBXZWJLaXQyCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi SW5zcGVjdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYkluc3BlY3Rvci5oCShyZXZpc2lvbiAxNzM5NDYpCisrKyBTb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTU0LDcg KzU0LDcgQEAgcHVibGljOgogCiAgICAgLy8gSVBDOjpDb25uZWN0aW9uOjpDbGllbnQKICAgICB2 b2lkIGRpZENsb3NlKElQQzo6Q29ubmVjdGlvbiopIHsgY2xvc2UoKTsgfQotICAgIHZvaWQgZGlk UmVjZWl2ZUludmFsaWRNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiosIElQQzo6U3RyaW5nUmVmZXJl bmNlIG1lc3NhZ2VSZWNlaXZlck5hbWUsIElQQzo6U3RyaW5nUmVmZXJlbmNlIG1lc3NhZ2VOYW1l KSB7IGNsb3NlKCk7IH0KKyAgICB2b2lkIGRpZFJlY2VpdmVJbnZhbGlkTWVzc2FnZShJUEM6OkNv bm5lY3Rpb24qLCBJUEM6OlN0cmluZ1JlZmVyZW5jZSwgSVBDOjpTdHJpbmdSZWZlcmVuY2UpIHsg Y2xvc2UoKTsgfQogCiAgICAgLy8gQ2FsbGVkIGJ5IFdlYkluc3BlY3RvciBtZXNzYWdlcwogICAg IHZvaWQgY29ubmVjdGlvbkVzdGFibGlzaGVkKCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yVUkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yVUkuaAkocmV2aXNpb24gMTczOTQ2 KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3RvclVJLmgJ KHdvcmtpbmcgY29weSkKQEAgLTQ5LDcgKzQ5LDcgQEAgcHVibGljOgogCiAgICAgLy8gSVBDOjpD b25uZWN0aW9uOjpDbGllbnQKICAgICB2b2lkIGRpZENsb3NlKElQQzo6Q29ubmVjdGlvbiopIHsg Y2xvc2VXaW5kb3coKTsgfQotICAgIHZvaWQgZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlKElQQzo6 Q29ubmVjdGlvbiosIElQQzo6U3RyaW5nUmVmZXJlbmNlIG1lc3NhZ2VSZWNlaXZlck5hbWUsIElQ Qzo6U3RyaW5nUmVmZXJlbmNlIG1lc3NhZ2VOYW1lKSB7IGNsb3NlV2luZG93KCk7IH0KKyAgICB2 b2lkIGRpZFJlY2VpdmVJbnZhbGlkTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24qLCBJUEM6OlN0cmlu Z1JlZmVyZW5jZSwgSVBDOjpTdHJpbmdSZWZlcmVuY2UpIHsgY2xvc2VXaW5kb3coKTsgfQogCiAg ICAgLy8gQ2FsbGVkIGJ5IFdlYkluc3BlY3RvclVJIG1lc3NhZ2VzCiAgICAgdm9pZCBlc3RhYmxp c2hDb25uZWN0aW9uKElQQzo6QXR0YWNobWVudCBjb25uZWN0aW9uSWRlbnRpZmllciwgdWludDY0 X3QgaW5zcGVjdGVkUGFnZUlkZW50aWZpZXIsIGJvb2wgdW5kZXJUZXN0KTsK