137101 2014-09-24 18:45:11 -0700 [iOS] Fix the iOS build; add case statements for kCLAuthorizationStatusAuthorized 2014-09-24 19:17:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates benjamin ddkilzer mmaxfield oldest_to_newest 1037116 0 dbates 2014-09-24 18:45:11 -0700 To satisfy clang, add case statement for kCLAuthorizationStatusAuthorized in -[WebGeolocationCoreLocationProvider requestGeolocationAuthorization], <http://trac.webkit.org/browser/trunk/Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm?rev=168555#L95> and -[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:, <http://trac.webkit.org/browser/trunk/Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm?rev=168555#L149>. 1037117 1 238635 dbates 2014-09-24 18:46:28 -0700 Created attachment 238635 Patch 1037118 2 238635 mark.lam 2014-09-24 18:56:21 -0700 Comment on attachment 238635 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238635&action=review r=me with indentation fix. > Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm:114 > + case kCLAuthorizationStatusAuthorized: Please fix this indentation. 1037120 3 dbates 2014-09-24 19:15:18 -0700 <rdar://problem/18449815> 1037121 4 dbates 2014-09-24 19:17:42 -0700 Committed r173940: <http://trac.webkit.org/changeset/173940> 238635 2014-09-24 18:46:28 -0700 2014-09-24 18:56:20 -0700 Patch bug-137101-20140924184628.patch text/plain 2216 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTczOTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2lv cy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2lvcy9DaGFuZ2VMb2cKaW5kZXggZDIyMzYxODlh NTMwNDQ1ZGU3MjE3ZjA5OTdmOTQ3ZDY1YjdkZmFhZC4uZDhhNDdlYTk3OThlMWE2M2U2ZDRiNTNl ZDFkOTQzZTdjOGE4MTVkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9pb3MvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvaW9zL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0 LTA5LTI0ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9T XSBGaXggdGhlIGlPUyBidWlsZDsgYWRkIGNhc2Ugc3RhdGVtZW50cyBmb3Iga0NMQXV0aG9yaXph dGlvblN0YXR1c0F1dGhvcml6ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNzEwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogTWlzYy9XZWJHZW9sb2NhdGlvbkNvcmVMb2NhdGlvblByb3ZpZGVyLm1t OgorICAgICAgICAoLVtXZWJHZW9sb2NhdGlvbkNvcmVMb2NhdGlvblByb3ZpZGVyIHJlcXVlc3RH ZW9sb2NhdGlvbkF1dGhvcml6YXRpb25dKToKKyAgICAgICAgKC1bV2ViR2VvbG9jYXRpb25Db3Jl TG9jYXRpb25Qcm92aWRlciBsb2NhdGlvbk1hbmFnZXI6ZGlkQ2hhbmdlQXV0aG9yaXphdGlvblN0 YXR1czpdKToKKwogMjAxNC0wOS0yNCAgQ2hyaXN0b3BoZSBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgVXNlIGlzPEhUTUwqRWxlbWVudD4oKSBpbnN0ZWFkIG9mIGlzSFRNTCpF bGVtZW50KCkgLSBQYXJ0IDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvaW9zL01pc2MvV2Vi R2VvbG9jYXRpb25Db3JlTG9jYXRpb25Qcm92aWRlci5tbSBiL1NvdXJjZS9XZWJLaXQvaW9zL01p c2MvV2ViR2VvbG9jYXRpb25Db3JlTG9jYXRpb25Qcm92aWRlci5tbQppbmRleCAxNzBiZDkyNzdi NGUwYTNhODc3ODFiODg2YjQ2MGRjNzQzOGYzNGM2Li45Y2JlMzE5ODljZTcxZjg5OTY0NDc1NzMz MmU2MDQwMTQ1NTEwMzZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2lvcy9NaXNjL1dlYkdl b2xvY2F0aW9uQ29yZUxvY2F0aW9uUHJvdmlkZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9pb3Mv TWlzYy9XZWJHZW9sb2NhdGlvbkNvcmVMb2NhdGlvblByb3ZpZGVyLm1tCkBAIC0xMDksNiArMTA5 LDEwIEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogICAgICAgICB9CiAgICAgICAgIGJyZWFr OwogICAgIH0KKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwdXNoCisjcHJhZ21hIGNsYW5nIGRp YWdub3N0aWMgaWdub3JlZCAiLVdkZXByZWNhdGVkLWRlY2xhcmF0aW9ucyIKKyAgICAgICAgY2Fz ZSBrQ0xBdXRob3JpemF0aW9uU3RhdHVzQXV0aG9yaXplZDoKKyNwcmFnbWEgY2xhbmcgZGlhZ25v c3RpYyBwb3AKICAgICBjYXNlIGtDTEF1dGhvcml6YXRpb25TdGF0dXNBdXRob3JpemVkQWx3YXlz OgogICAgIGNhc2Uga0NMQXV0aG9yaXphdGlvblN0YXR1c0F1dGhvcml6ZWRXaGVuSW5Vc2U6IHsK ICAgICAgICAgW19wb3NpdGlvbkxpc3RlbmVyIGdlb2xvY2F0aW9uQXV0aG9yaXphdGlvbkdyYW50 ZWRdOwpAQCAtMTU4LDYgKzE2MiwxMCBAQCBzdGF0aWMgYm9vbCBpc0F1dGhvcml6YXRpb25HcmFu dGVkKENMQXV0aG9yaXphdGlvblN0YXR1cyBhdXRob3JpemF0aW9uU3RhdHVzKQogICAgICAgICAg ICAgX2lzV2FpdGluZ0ZvckF1dGhvcml6YXRpb24gPSBOTzsKICAgICAgICAgICAgIFtfcG9zaXRp b25MaXN0ZW5lciBnZW9sb2NhdGlvbkF1dGhvcml6YXRpb25EZW5pZWRdOwogICAgICAgICAgICAg YnJlYWs7CisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBjbGFuZyBkaWFn bm9zdGljIGlnbm9yZWQgIi1XZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnMiCisgICAgICAgIGNhc2Ug a0NMQXV0aG9yaXphdGlvblN0YXR1c0F1dGhvcml6ZWQ6CisjcHJhZ21hIGNsYW5nIGRpYWdub3N0 aWMgcG9wCiAgICAgICAgIGNhc2Uga0NMQXV0aG9yaXphdGlvblN0YXR1c0F1dGhvcml6ZWRBbHdh eXM6CiAgICAgICAgIGNhc2Uga0NMQXV0aG9yaXphdGlvblN0YXR1c0F1dGhvcml6ZWRXaGVuSW5V c2U6CiAgICAgICAgICAgICBfaXNXYWl0aW5nRm9yQXV0aG9yaXphdGlvbiA9IE5POwo=