137060 2014-09-24 00:40:18 -0700 [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser 2014-10-15 00:33:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kumar.rohit webkit-unassigned commit-queue gustavo mrobinson pnormand oldest_to_newest 1036924 0 kumar.rohit 2014-09-24 00:40:18 -0700 Currently GTK MInibrowser supports zoom in and zoom out only using mouse clicks. Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively. 1036926 1 238588 kumar.rohit 2014-09-24 00:44:39 -0700 Created attachment 238588 Patch 1041809 2 238588 commit-queue 2014-10-15 00:33:45 -0700 Comment on attachment 238588 Patch Clearing flags on attachment: 238588 Committed r174724: <http://trac.webkit.org/changeset/174724> 1041810 3 commit-queue 2014-10-15 00:33:48 -0700 All reviewed patches have been landed. Closing bug. 238588 2014-09-24 00:44:39 -0700 2014-10-15 00:33:45 -0700 Patch bug-137060-20140924131543.patch text/plain 4258 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjMxZGQwOTNiYmJjZDcwNGVkZjZjN2U5MDRiNzI4ZTBi MmFkYjNkZC4uOTRmMGUyMThkZGIwMjIxNDdmZmEwZDkzZjA0MWY2Mjk4OThmODJjZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTA5LTI0ICBSb2hpdCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgor CisgICAgICAgIFtHVEtdIE1pbmlicm93c2VyIDogQWRkIGtleWJvYXJkIHN1cHBvcnQgZm9yIHpv b20gaW4gLCB6b29tIG91dCBhbmQgZGVmYXVsdCB6b29tIGluIEdUSyBNaW5pYnJvd3NlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3MDYwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGtleWJvYXJk IHN1cHBvcnQgZm9yIHpvb20gaW4gLCB6b29tIG91dCBhbmQgZGVmYXVsdCB6b29tIHVzaW5nICdD dHJsJyArICcrJywgJ0N0cmwnICsgJy0nIGFuZCAnQ3RybCcgKyAnMCcgcmVzcGVjdGl2ZWx5Lgor CisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYzoKKyAgICAgICAgKHpv b21JbkNhbGxiYWNrKToKKyAgICAgICAgKHpvb21PdXRDYWxsYmFjayk6CisgICAgICAgIChkZWZh dWx0Wm9vbUNhbGxiYWNrKTogQ2FsbGJhY2sgZm9yIGRlZmF1bHQgem9vbSBrZXlib2FyZCBzdXBw b3J0LgorICAgICAgICAoYnJvd3Nlcl93aW5kb3dfaW5pdCk6CisKIDIwMTQtMDktMjMgIFRpYm9y IE1lc3phcm9zICA8dG1lc3phcm9zLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgTWFrZSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC93YWl0LWZvci1TVk4tc2VydmVyLnB5 IGhhbmRsZSBzZXJ2ZXIgZG9ud3RpbWUKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0 ay9Ccm93c2VyV2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5j CmluZGV4IGQ2OTI0MWVlYzA3NWQ2YjcyMzEyMjJkZDc3YTM5N2Q0NTRlZTMzZDkuLjljZTljNWE1 ZTM1MGFlOTEwN2RhZDczN2ViYzRmZTg3ZGQ4MDgyYjIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlC cm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jy b3dzZXJXaW5kb3cuYwpAQCAtNzYsNiArNzYsNyBAQCBzdGF0aWMgY29uc3QgY2hhciAqZGVmYXVs dFdpbmRvd1RpdGxlID0gIldlYktpdEdUSysgTWluaUJyb3dzZXIiOwogc3RhdGljIGNvbnN0IGNo YXIgKm1pbmlCcm93c2VyQWJvdXRTY2hlbWUgPSAibWluaWJyb3dzZXItYWJvdXQiOwogc3RhdGlj IGNvbnN0IGdkb3VibGUgbWluaW11bVpvb21MZXZlbCA9IDAuNTsKIHN0YXRpYyBjb25zdCBnZG91 YmxlIG1heGltdW1ab29tTGV2ZWwgPSAzOworc3RhdGljIGNvbnN0IGdkb3VibGUgZGVmYXVsdFpv b21MZXZlbCA9IDE7CiBzdGF0aWMgY29uc3QgZ2RvdWJsZSB6b29tU3RlcCA9IDEuMjsKIHN0YXRp YyBnaW50IHdpbmRvd0NvdW50ID0gMDsKIApAQCAtNTAxLDE0ICs1MDIsMjMgQEAgc3RhdGljIGdi b29sZWFuIGluc3BlY3Rvcldhc0Nsb3NlZChXZWJLaXRXZWJJbnNwZWN0b3IgKmluc3BlY3Rvcldp bmRvdywgQnJvd3NlclcKIAogc3RhdGljIHZvaWQgem9vbUluQ2FsbGJhY2soQnJvd3NlcldpbmRv dyAqd2luZG93KQogewotICAgIGdkb3VibGUgem9vbUxldmVsID0gd2Via2l0X3dlYl92aWV3X2dl dF96b29tX2xldmVsKHdpbmRvdy0+d2ViVmlldykgKiB6b29tU3RlcDsKLSAgICB3ZWJraXRfd2Vi X3ZpZXdfc2V0X3pvb21fbGV2ZWwod2luZG93LT53ZWJWaWV3LCB6b29tTGV2ZWwpOworICAgIGlm IChicm93c2VyV2luZG93Q2FuWm9vbUluKHdpbmRvdykpIHsKKyAgICAgICAgZ2RvdWJsZSB6b29t TGV2ZWwgPSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3pvb21fbGV2ZWwod2luZG93LT53ZWJWaWV3KSAq IHpvb21TdGVwOworICAgICAgICB3ZWJraXRfd2ViX3ZpZXdfc2V0X3pvb21fbGV2ZWwod2luZG93 LT53ZWJWaWV3LCB6b29tTGV2ZWwpOworICAgIH0KIH0KIAogc3RhdGljIHZvaWQgem9vbU91dENh bGxiYWNrKEJyb3dzZXJXaW5kb3cgKndpbmRvdykKIHsKLSAgICBnZG91YmxlIHpvb21MZXZlbCA9 IHdlYmtpdF93ZWJfdmlld19nZXRfem9vbV9sZXZlbCh3aW5kb3ctPndlYlZpZXcpIC8gem9vbVN0 ZXA7Ci0gICAgd2Via2l0X3dlYl92aWV3X3NldF96b29tX2xldmVsKHdpbmRvdy0+d2ViVmlldywg em9vbUxldmVsKTsKKyAgICBpZiAoYnJvd3NlcldpbmRvd0Nhblpvb21PdXQod2luZG93KSkgewor ICAgICAgICBnZG91YmxlIHpvb21MZXZlbCA9IHdlYmtpdF93ZWJfdmlld19nZXRfem9vbV9sZXZl bCh3aW5kb3ctPndlYlZpZXcpIC8gem9vbVN0ZXA7CisgICAgICAgIHdlYmtpdF93ZWJfdmlld19z ZXRfem9vbV9sZXZlbCh3aW5kb3ctPndlYlZpZXcsIHpvb21MZXZlbCk7CisgICAgfQorfQorCitz dGF0aWMgdm9pZCBkZWZhdWx0Wm9vbUNhbGxiYWNrKEJyb3dzZXJXaW5kb3cgKndpbmRvdykKK3sK KyAgICB3ZWJraXRfd2ViX3ZpZXdfc2V0X3pvb21fbGV2ZWwod2luZG93LT53ZWJWaWV3LCBkZWZh dWx0Wm9vbUxldmVsKTsKIH0KIAogc3RhdGljIHZvaWQgc2VhcmNoQ2FsbGJhY2soQnJvd3Nlcldp bmRvdyAqd2luZG93KQpAQCAtNjM3LDYgKzY0NywyMCBAQCBzdGF0aWMgdm9pZCBicm93c2VyX3dp bmRvd19pbml0KEJyb3dzZXJXaW5kb3cgKndpbmRvdykKICAgICBndGtfYWNjZWxfZ3JvdXBfY29u bmVjdCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19LRVlfRXNjYXBlLCAwLCBHVEtfQUNDRUxfVklT SUJMRSwKICAgICAgICAgZ19jY2xvc3VyZV9uZXdfc3dhcChHX0NBTExCQUNLKHN0b3BQYWdlTG9h ZCksIHdpbmRvdywgTlVMTCkpOwogCisgICAgLyogWm9vbSBpbiwgem9vbSBvdXQgYW5kIGRlZmF1 bHQgem9vbSovCisgICAgZ3RrX2FjY2VsX2dyb3VwX2Nvbm5lY3Qod2luZG93LT5hY2NlbEdyb3Vw LCBHREtfS0VZX2VxdWFsLCBHREtfQ09OVFJPTF9NQVNLLCBHVEtfQUNDRUxfVklTSUJMRSwKKyAg ICAgICAgZ19jY2xvc3VyZV9uZXdfc3dhcChHX0NBTExCQUNLKHpvb21JbkNhbGxiYWNrKSwgd2lu ZG93LCBOVUxMKSk7CisgICAgZ3RrX2FjY2VsX2dyb3VwX2Nvbm5lY3Qod2luZG93LT5hY2NlbEdy b3VwLCBHREtfS0VZX0tQX0FkZCwgR0RLX0NPTlRST0xfTUFTSywgR1RLX0FDQ0VMX1ZJU0lCTEUs CisgICAgICAgIGdfY2Nsb3N1cmVfbmV3X3N3YXAoR19DQUxMQkFDSyh6b29tSW5DYWxsYmFjayks IHdpbmRvdywgTlVMTCkpOworICAgIGd0a19hY2NlbF9ncm91cF9jb25uZWN0KHdpbmRvdy0+YWNj ZWxHcm91cCwgR0RLX0tFWV9taW51cywgR0RLX0NPTlRST0xfTUFTSywgR1RLX0FDQ0VMX1ZJU0lC TEUsCisgICAgICAgIGdfY2Nsb3N1cmVfbmV3X3N3YXAoR19DQUxMQkFDSyh6b29tT3V0Q2FsbGJh Y2spLCB3aW5kb3csIE5VTEwpKTsKKyAgICBndGtfYWNjZWxfZ3JvdXBfY29ubmVjdCh3aW5kb3ct PmFjY2VsR3JvdXAsIEdES19LRVlfS1BfU3VidHJhY3QsIEdES19DT05UUk9MX01BU0ssIEdUS19B Q0NFTF9WSVNJQkxFLAorICAgICAgICBnX2NjbG9zdXJlX25ld19zd2FwKEdfQ0FMTEJBQ0soem9v bU91dENhbGxiYWNrKSwgd2luZG93LCBOVUxMKSk7CisgICAgZ3RrX2FjY2VsX2dyb3VwX2Nvbm5l Y3Qod2luZG93LT5hY2NlbEdyb3VwLCBHREtfS0VZXzAsIEdES19DT05UUk9MX01BU0ssIEdUS19B Q0NFTF9WSVNJQkxFLAorICAgICAgICBnX2NjbG9zdXJlX25ld19zd2FwKEdfQ0FMTEJBQ0soZGVm YXVsdFpvb21DYWxsYmFjayksIHdpbmRvdywgTlVMTCkpOworICAgIGd0a19hY2NlbF9ncm91cF9j b25uZWN0KHdpbmRvdy0+YWNjZWxHcm91cCwgR0RLX0tFWV9LUF8wLCBHREtfQ09OVFJPTF9NQVNL LCBHVEtfQUNDRUxfVklTSUJMRSwKKyAgICAgICAgZ19jY2xvc3VyZV9uZXdfc3dhcChHX0NBTExC QUNLKGRlZmF1bHRab29tQ2FsbGJhY2spLCB3aW5kb3csIE5VTEwpKTsKKwogICAgIEd0a1dpZGdl dCAqdG9vbGJhciA9IGd0a190b29sYmFyX25ldygpOwogICAgIHdpbmRvdy0+dG9vbGJhciA9IHRv b2xiYXI7CiAgICAgZ3RrX29yaWVudGFibGVfc2V0X29yaWVudGF0aW9uKEdUS19PUklFTlRBQkxF KHRvb2xiYXIpLCBHVEtfT1JJRU5UQVRJT05fSE9SSVpPTlRBTCk7Cg==