137054 2014-09-23 19:59:32 -0700 [Yosemite] Button text doesn't go white while pushing the button, like it does for real buttons 2014-09-25 22:23:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino oldest_to_newest 1036896 0 dino 2014-09-23 19:59:32 -0700 [Yosemite] Button text doesn't go white while pushing the button, like it does for real buttons 1036897 1 238581 dino 2014-09-23 20:07:50 -0700 Created attachment 238581 Patch 1036950 2 dino 2014-09-24 03:33:38 -0700 rdar://problem/17559038 1037012 3 dino 2014-09-24 12:57:39 -0700 Committed r173928: <http://trac.webkit.org/changeset/173928> 1037406 4 238581 darin 2014-09-25 22:23:37 -0700 Comment on attachment 238581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238581&action=review > Source/WebCore/rendering/RenderThemeMac.mm:523 > + case CSSValueActivebuttontext: > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000 > + color = 0xC0FFFFFF; > +#endif > + break; Don’t we want to set the color to something on pre-101000 systems instead of letting it call through to RenderTheme::systemColor? Maybe convertNSColorToColor([NSColor controlTextColor])? No FIXME about this being hardcoded? Same problem as with CSSValueInfobackground, I guess. 238581 2014-09-23 20:07:50 -0700 2014-09-25 22:23:37 -0700 Patch bug-137054-20140924130748.patch text/plain 4182 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmMzMTExYzFkMGQwNTg1 ZTVjZjMyZjEzOWM2YzUzY2JhYzE1ZmZiOS4uZDA3OGFjNWJmMjRmNWQ5MjgxMjNhNjY2MzcxYmRm NjlkNTBkNTI0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE0LTA5LTIzICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbWW9zZW1pdGVdIEJ1dHRvbiB0 ZXh0IGRvZXNuJ3QgZ28gd2hpdGUgd2hpbGUgcHVzaGluZyB0aGUgYnV0dG9uLCBsaWtlIGl0IGRv ZXMgZm9yIHJlYWwgYnV0dG9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM3MDU0CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzE3NTU5MDM4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT24gWW9zZW1pdGUg YW5kIGFib3ZlLCBzeXN0ZW0gYnV0dG9ucyBwYWludCB3aXRoIHdoaXRlLWlzaCB0ZXh0IHdoZW4g dGhleQorICAgICAgICBhcmUgcHJlc3NlZC4gU2luY2UgdGhpcyBpc24ndCBleHBvc2VkIGJ5IEFQ SSwgSSd2ZSBoYXJkY29kZWQgdGhlIHZhbHVlCisgICAgICAgIGludG8gUmVuZGVyVGhlbWVNYWMu CisKKyAgICAgICAgVGhlIGFjdHVhbCBzdGF0ZSBpcyBleHBvc2VkIGJ5IGFkZGluZyBhIDphY3Rp dmUgcnVsZSB0byBodG1sLmNzcyB0aGF0CisgICAgICAgIHVzZXMgYSBuZXcgQ1NTVmFsdWVLZXl3 b3JkOiBBY3RpdmVCdXR0b25UZXh0LgorCisgICAgICAgIFVuZm9ydHVuYXRlbHkgSSBjYW4ndCBm aW5kIGEgd2F5IHRvIHRlc3QgdGhpcywgYmVjYXVzZSB0aGUgYWN0aXZlIHN0YXRlIGlzbid0Cisg ICAgICAgIHRlc3RhYmxlLiBXZSBzaG91bGQgcmVhbGx5IGV4cG9zZSB0aGUgSW5zcGVjdG9yJ3Mg Zm9yY2VQc2V1ZG9TdGF0ZSBmdW5jdGlvbiBpbnRvCisgICAgICAgIHdpbmRvdy5pbnRlcm5hbHMu CisKKyAgICAgICAgKiBjc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbjogQWRkICJhY3RpdmVidXR0b250 ZXh0Ii4KKyAgICAgICAgKiBjc3MvaHRtbC5jc3M6CisgICAgICAgIChpbnB1dFt0eXBlPSJidXR0 b24iXTphY3RpdmUsIGlucHV0W3R5cGU9InN1Ym1pdCJdOmFjdGl2ZSwgaW5wdXRbdHlwZT0icmVz ZXQiXTphY3RpdmUsIGlucHV0W3R5cGU9ImZpbGUiXTo6LXdlYmtpdC1maWxlLXVwbG9hZC1idXR0 b246YWN0aXZlLCBidXR0b246YWN0aXZlKTogTmV3IHJ1bGUgZm9yIGFjdGl2ZQorICAgICAgICBi dXR0b24gZWxlbWVudHMuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lOjpzeXN0ZW1Db2xvcik6IEhhbmRsZSBDU1NWYWx1 ZUFjdGl2ZWJ1dHRvbnRleHQgYXMgYmxhY2suCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRo ZW1lTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVNYWM6OnN5c3RlbUNvbG9y KTogSGFuZGxlIENTU1ZhbHVlQWN0aXZlYnV0dG9udGV4dCBhcworICAgICAgICB3aGl0ZSB3aXRo IDc1JSBvcGFjaXR5LgorCiAyMDE0LTA5LTIzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgSGF2ZSBEb2N1bWVudDo6YWNjZXNzU1ZHRXh0ZW5zaW9ucygpIHJldHVy biBhIHJlZmVyZW5jZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlS2V5 d29yZHMuaW4gYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbgppbmRleCBl NjI3MjRlODhiZGY4MGJmOTI2MTA4ODQ2YTA5ZDFjZWUyMjU5OTJlLi4xYTNjYzJkNjk3ODZkMjY3 ZjA1Yzk0MDJhNzk1MWEzNDhiNjM3NmY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTVmFsdWVLZXl3b3Jkcy5pbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3 b3Jkcy5pbgpAQCAtMTYyLDYgKzE2Miw3IEBAIGJ1dHRvbmZhY2UKIGJ1dHRvbmhpZ2hsaWdodAog YnV0dG9uc2hhZG93CiBidXR0b250ZXh0CithY3RpdmVidXR0b250ZXh0CiBjYXB0aW9udGV4dAog Z3JheXRleHQKIGhpZ2hsaWdodApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL2h0bWwu Y3NzIGIvU291cmNlL1dlYkNvcmUvY3NzL2h0bWwuY3NzCmluZGV4IDg4Yjk2NmI3OTU3MjQ5MTgz NWRkZjgxNTc2MzI0YzEyNzY5ZDM2YWIuLjJmZWFhOTJhYjBlYTQyY2Y3NmYzNjVkZDVlZDk2MGIz NDU5NWNiOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9odG1sLmNzcworKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvaHRtbC5jc3MKQEAgLTY5MCw2ICs2OTAsMTAgQEAgaW5wdXRbdHlw ZT0iYnV0dG9uIl0sIGlucHV0W3R5cGU9InN1Ym1pdCJdLCBpbnB1dFt0eXBlPSJyZXNldCJdLCBp bnB1dFt0eXBlPSJmaWwKICAgICBib3gtc2l6aW5nOiBib3JkZXItYm94CiB9CiAKK2lucHV0W3R5 cGU9ImJ1dHRvbiJdOmFjdGl2ZSwgaW5wdXRbdHlwZT0ic3VibWl0Il06YWN0aXZlLCBpbnB1dFt0 eXBlPSJyZXNldCJdOmFjdGl2ZSwgaW5wdXRbdHlwZT0iZmlsZSJdOjotd2Via2l0LWZpbGUtdXBs b2FkLWJ1dHRvbjphY3RpdmUsIGJ1dHRvbjphY3RpdmUgeworICAgIGNvbG9yOiBBY3RpdmVCdXR0 b25UZXh0OworfQorCiBpbnB1dFt0eXBlPSJyYW5nZSJdIHsKICAgICAtd2Via2l0LWFwcGVhcmFu Y2U6IHNsaWRlci1ob3Jpem9udGFsOwogICAgIHBhZGRpbmc6IGluaXRpYWw7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcAppbmRleCBhMTUwOGI4OGJiODk5ZGYwNTgxZTJk NDYwZDRjODgwYWM1M2Q4MzBkLi42ODVmZmMyOTI1YjYzY2I5MGQ3MmRiZGFiZjlhOTFkMTQ2NmZi YzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAKQEAgLTExNTIs NiArMTE1Miw4IEBAIENvbG9yIFJlbmRlclRoZW1lOjpzeXN0ZW1Db2xvcihDU1NWYWx1ZUlEIGNz c1ZhbHVlSWQpIGNvbnN0CiAgICAgICAgIHJldHVybiAweEZGODg4ODg4OwogICAgIGNhc2UgQ1NT VmFsdWVCdXR0b250ZXh0OgogICAgICAgICByZXR1cm4gMHhGRjAwMDAwMDsKKyAgICBjYXNlIENT U1ZhbHVlQWN0aXZlYnV0dG9udGV4dDoKKyAgICAgICAgcmV0dXJuIDB4RkYwMDAwMDA7CiAgICAg Y2FzZSBDU1NWYWx1ZUNhcHRpb250ZXh0OgogICAgICAgICByZXR1cm4gMHhGRjAwMDAwMDsKICAg ICBjYXNlIENTU1ZhbHVlR3JheXRleHQ6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVNYWMubW0KaW5kZXggZDRjYWIyYjJjOTc2NWE4ZDRiZTllODU1MWVlMGM2YmIzNWE5NjY3 NC4uOTA2MTM4MzJkMTVhMGI2NzdjMWRkMmJlZTQ0YmJjYTFiMTk0Nzk5NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbQpAQCAtNTE2LDYgKzUxNiwxMSBAQCBD b2xvciBSZW5kZXJUaGVtZU1hYzo6c3lzdGVtQ29sb3IoQ1NTVmFsdWVJRCBjc3NWYWx1ZUlkKSBj b25zdAogICAgIGNhc2UgQ1NTVmFsdWVCdXR0b250ZXh0OgogICAgICAgICBjb2xvciA9IGNvbnZl cnROU0NvbG9yVG9Db2xvcihbTlNDb2xvciBjb250cm9sVGV4dENvbG9yXSk7CiAgICAgICAgIGJy ZWFrOworICAgIGNhc2UgQ1NTVmFsdWVBY3RpdmVidXR0b250ZXh0OgorI2lmIF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMDAwCisgICAgICAgIGNvbG9yID0gMHhDMEZGRkZG RjsKKyNlbmRpZgorICAgICAgICBicmVhazsKICAgICBjYXNlIENTU1ZhbHVlQ2FwdGlvbnRleHQ6 CiAgICAgICAgIGNvbG9yID0gY29udmVydE5TQ29sb3JUb0NvbG9yKFtOU0NvbG9yIHRleHRDb2xv cl0pOwogICAgICAgICBicmVhazsK