137045 2014-09-23 14:36:34 -0700 DebuggerCallFrame::invalidate() should invalidate all DebuggerScope chains 2014-09-23 15:29:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1036845 0 mark.lam 2014-09-23 14:36:34 -0700 DebuggerCallFrame::invalidate() currently invalidates all DebuggerCallFrames in the debugger stack, but only invalidates the DebuggerScope chain of the top most frame. We should also invalidate all the DebuggerScope chains of the other frames in the debugger stack. 1036848 1 238572 mark.lam 2014-09-23 14:41:30 -0700 Created attachment 238572 the patch. 1036854 2 238572 ggaren 2014-09-23 15:09:01 -0700 Comment on attachment 238572 the patch. r=me 1036858 3 238572 commit-queue 2014-09-23 15:29:40 -0700 Comment on attachment 238572 the patch. Clearing flags on attachment: 238572 Committed r173896: <http://trac.webkit.org/changeset/173896> 1036859 4 commit-queue 2014-09-23 15:29:42 -0700 All reviewed patches have been landed. Closing bug. 238572 2014-09-23 14:41:30 -0700 2014-09-23 15:29:40 -0700 the patch. bug-137045.patch text/plain 2609 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTczODkyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTA5LTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE ZWJ1Z2dlckNhbGxGcmFtZTo6aW52YWxpZGF0ZSgpIHNob3VsZCBpbnZhbGlkYXRlIGFsbCBEZWJ1 Z2dlclNjb3BlIGNoYWlucy4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzNzA0NT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWJ1Z2dl ckNhbGxGcmFtZTo6aW52YWxpZGF0ZSgpIGN1cnJlbnRseSBpbnZhbGlkYXRlcyBhbGwgRGVidWdn ZXJDYWxsRnJhbWVzCisgICAgICAgIGluIHRoZSBkZWJ1Z2dlciBzdGFjaywgYnV0IG9ubHkgaW52 YWxpZGF0ZXMgdGhlIERlYnVnZ2VyU2NvcGUgY2hhaW4gb2YgdGhlCisgICAgICAgIHRvcCBtb3N0 IGZyYW1lLiAgV2Ugc2hvdWxkIGFsc28gaW52YWxpZGF0ZSBhbGwgdGhlIERlYnVnZ2VyU2NvcGUg Y2hhaW5zIG9mCisgICAgICAgIHRoZSBvdGhlciBmcmFtZXMgaW4gdGhlIGRlYnVnZ2VyIHN0YWNr LgorCisgICAgICAgICogZGVidWdnZXIvRGVidWdnZXJDYWxsRnJhbWUuY3BwOgorICAgICAgICAo SlNDOjpEZWJ1Z2dlckNhbGxGcmFtZTo6aW52YWxpZGF0ZSk6CisgICAgICAgICogZGVidWdnZXIv RGVidWdnZXJTY29wZS5jcHA6CisgICAgICAgIChKU0M6OkRlYnVnZ2VyU2NvcGU6OmludmFsaWRh dGVDaGFpbik6CisKIDIwMTQtMDktMjMgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgog CiAgICAgICAgIFJlbmFtZWQgRGVidWdnZXJDYWxsRnJhbWVTY29wZSB0byBEZWJ1Z2dlclBhdXNl ZFNjb3BlLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyQ2Fs bEZyYW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIv RGVidWdnZXJDYWxsRnJhbWUuY3BwCShyZXZpc2lvbiAxNzM4OTIpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXJDYWxsRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yMDgsMTQgKzIwOCwxMyBAQCBKU1ZhbHVlIERlYnVnZ2VyQ2FsbEZyYW1lOjpldmFsdWF0ZShj b25zCiAKIHZvaWQgRGVidWdnZXJDYWxsRnJhbWU6OmludmFsaWRhdGUoKQogewotICAgIG1fY2Fs bEZyYW1lID0gbnVsbHB0cjsKLSAgICBpZiAobV9zY29wZSkgewotICAgICAgICBtX3Njb3BlLT5p bnZhbGlkYXRlQ2hhaW4oKTsKLSAgICAgICAgbV9zY29wZS5jbGVhcigpOwotICAgIH0KLSAgICBS ZWZQdHI8RGVidWdnZXJDYWxsRnJhbWU+IGZyYW1lID0gbV9jYWxsZXIucmVsZWFzZSgpOworICAg IFJlZlB0cjxEZWJ1Z2dlckNhbGxGcmFtZT4gZnJhbWUgPSB0aGlzOwogICAgIHdoaWxlIChmcmFt ZSkgewogICAgICAgICBmcmFtZS0+bV9jYWxsRnJhbWUgPSBudWxscHRyOworICAgICAgICBpZiAo ZnJhbWUtPm1fc2NvcGUpIHsKKyAgICAgICAgICAgIGZyYW1lLT5tX3Njb3BlLT5pbnZhbGlkYXRl Q2hhaW4oKTsKKyAgICAgICAgICAgIGZyYW1lLT5tX3Njb3BlLmNsZWFyKCk7CisgICAgICAgIH0K ICAgICAgICAgZnJhbWUgPSBmcmFtZS0+bV9jYWxsZXIucmVsZWFzZSgpOwogICAgIH0KIH0KSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlclNjb3BlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXJTY29wZS5j cHAJKHJldmlzaW9uIDE3Mzg5MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9E ZWJ1Z2dlclNjb3BlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQyLDEyICsxNDIsMTQgQEAgRGVi dWdnZXJTY29wZSogRGVidWdnZXJTY29wZTo6bmV4dCgpCiAKIHZvaWQgRGVidWdnZXJTY29wZTo6 aW52YWxpZGF0ZUNoYWluKCkKIHsKKyAgICBpZiAoIWlzVmFsaWQoKSkKKyAgICAgICAgcmV0dXJu OworCiAgICAgRGVidWdnZXJTY29wZSogc2NvcGUgPSB0aGlzOwogICAgIHdoaWxlIChzY29wZSkg ewotICAgICAgICBBU1NFUlQoc2NvcGUtPmlzVmFsaWQoKSk7CiAgICAgICAgIERlYnVnZ2VyU2Nv cGUqIG5leHRTY29wZSA9IHNjb3BlLT5tX25leHQuZ2V0KCk7CiAgICAgICAgIHNjb3BlLT5tX25l eHQuY2xlYXIoKTsKLSAgICAgICAgc2NvcGUtPm1fc2NvcGUuY2xlYXIoKTsKKyAgICAgICAgc2Nv cGUtPm1fc2NvcGUuY2xlYXIoKTsgLy8gVGhpcyBhbHNvIG1hcmtzIHRoaXMgc2NvcGUgYXMgaW52 YWxpZC4KICAgICAgICAgc2NvcGUgPSBuZXh0U2NvcGU7CiAgICAgfQogfQo=