137042 2014-09-23 13:42:14 -0700 Renamed DebuggerCallFrameScope to DebuggerPausedScope 2014-09-23 14:24:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1036819 0 mark.lam 2014-09-23 13:42:14 -0700 DebuggerPausedScope is a better name for this data structure because it is meant for tracking the period within which the debugger is paused, and doing clean ups after the pause ends. 1036822 1 238566 mark.lam 2014-09-23 13:49:06 -0700 Created attachment 238566 the patch. 1036832 2 238566 msaboff 2014-09-23 14:16:28 -0700 Comment on attachment 238566 the patch. rs=me 1036835 3 238566 mark.lam 2014-09-23 14:17:09 -0700 Comment on attachment 238566 the patch. Thanks for the review. 1036841 4 238566 commit-queue 2014-09-23 14:24:12 -0700 Comment on attachment 238566 the patch. Clearing flags on attachment: 238566 Committed r173892: <http://trac.webkit.org/changeset/173892> 1036842 5 commit-queue 2014-09-23 14:24:14 -0700 All reviewed patches have been landed. Closing bug. 238566 2014-09-23 13:49:06 -0700 2014-09-23 14:24:12 -0700 the patch. bug-137042.patch text/plain 3676 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTczODg2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE0LTA5LTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW5hbWVkIERlYnVnZ2VyQ2FsbEZyYW1lU2NvcGUgdG8gRGVidWdnZXJQYXVzZWRTY29wZS4KKyAg ICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzNzA0Mj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWJ1Z2dlclBhdXNlZFNjb3BlIGlzIGEgYmV0 dGVyIG5hbWUgZm9yIHRoaXMgZGF0YSBzdHJ1Y3R1cmUgYmVjYXVzZSBpdAorICAgICAgICBpcyBt ZWFudCBmb3IgdHJhY2tpbmcgdGhlIHBlcmlvZCB3aXRoaW4gd2hpY2ggdGhlIGRlYnVnZ2VyIGlz IHBhdXNlZCwKKyAgICAgICAgYW5kIGRvaW5nIGNsZWFuIHVwcyBhZnRlciB0aGUgcGF1c2UgZW5k cy4KKworICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmNwcDoKKyAgICAgICAgKEpTQzo6RGVi dWdnZXJQYXVzZWRTY29wZTo6RGVidWdnZXJQYXVzZWRTY29wZSk6CisgICAgICAgIChKU0M6OkRl YnVnZ2VyUGF1c2VkU2NvcGU6On5EZWJ1Z2dlclBhdXNlZFNjb3BlKToKKyAgICAgICAgKEpTQzo6 RGVidWdnZXI6OnBhdXNlSWZOZWVkZWQpOgorICAgICAgICAoSlNDOjpEZWJ1Z2dlckNhbGxGcmFt ZVNjb3BlOjpEZWJ1Z2dlckNhbGxGcmFtZVNjb3BlKTogRGVsZXRlZC4KKyAgICAgICAgKEpTQzo6 RGVidWdnZXJDYWxsRnJhbWVTY29wZTo6fkRlYnVnZ2VyQ2FsbEZyYW1lU2NvcGUpOiBEZWxldGVk LgorICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyLmg6CisgICAgICAgICogZGVidWdnZXIvRGVi dWdnZXJDYWxsRnJhbWUuaDoKKwogMjAxNC0wOS0yMyAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUBy ZWRoYXQuY29tPgogCiAgICAgICAgIFtDTG9vcF0gLSBGaXggQ0xvb3Agb24gdGhlIDMyLWJpdCBC aWctRW5kaWFucwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2Vy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdn ZXIuY3BwCShyZXZpc2lvbiAxNzM4ODYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdn ZXIvRGVidWdnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Niw5ICs5Niw5IEBAIGlubGluZSB2 b2lkIFJlY29tcGlsZXI6Om9wZXJhdG9yKCkoSlNDZWwKIAogbmFtZXNwYWNlIEpTQyB7CiAKLWNs YXNzIERlYnVnZ2VyQ2FsbEZyYW1lU2NvcGUgeworY2xhc3MgRGVidWdnZXJQYXVzZWRTY29wZSB7 CiBwdWJsaWM6Ci0gICAgRGVidWdnZXJDYWxsRnJhbWVTY29wZShEZWJ1Z2dlciYgZGVidWdnZXIp CisgICAgRGVidWdnZXJQYXVzZWRTY29wZShEZWJ1Z2dlciYgZGVidWdnZXIpCiAgICAgICAgIDog bV9kZWJ1Z2dlcihkZWJ1Z2dlcikKICAgICB7CiAgICAgICAgIEFTU0VSVCghbV9kZWJ1Z2dlci5t X2N1cnJlbnREZWJ1Z2dlckNhbGxGcmFtZSk7CkBAIC0xMDYsNyArMTA2LDcgQEAgcHVibGljOgog ICAgICAgICAgICAgbV9kZWJ1Z2dlci5tX2N1cnJlbnREZWJ1Z2dlckNhbGxGcmFtZSA9IERlYnVn Z2VyQ2FsbEZyYW1lOjpjcmVhdGUoZGVidWdnZXIubV9jdXJyZW50Q2FsbEZyYW1lKTsKICAgICB9 CiAKLSAgICB+RGVidWdnZXJDYWxsRnJhbWVTY29wZSgpCisgICAgfkRlYnVnZ2VyUGF1c2VkU2Nv cGUoKQogICAgIHsKICAgICAgICAgaWYgKG1fZGVidWdnZXIubV9jdXJyZW50RGVidWdnZXJDYWxs RnJhbWUpIHsKICAgICAgICAgICAgIG1fZGVidWdnZXIubV9jdXJyZW50RGVidWdnZXJDYWxsRnJh bWUtPmludmFsaWRhdGUoKTsKQEAgLTY0NCw3ICs2NDQsNyBAQCB2b2lkIERlYnVnZ2VyOjpwYXVz ZUlmTmVlZGVkKENhbGxGcmFtZSogCiAgICAgYm9vbCBwYXVzZU5vdyA9IG1fcGF1c2VPbk5leHRT dGF0ZW1lbnQ7CiAgICAgcGF1c2VOb3cgfD0gKG1fcGF1c2VPbkNhbGxGcmFtZSA9PSBtX2N1cnJl bnRDYWxsRnJhbWUpOwogCi0gICAgRGVidWdnZXJDYWxsRnJhbWVTY29wZSBkZWJ1Z2dlckNhbGxG cmFtZVNjb3BlKCp0aGlzKTsKKyAgICBEZWJ1Z2dlclBhdXNlZFNjb3BlIGRlYnVnZ2VyUGF1c2Vk U2NvcGUoKnRoaXMpOwogCiAgICAgaW50cHRyX3Qgc291cmNlSUQgPSBEZWJ1Z2dlckNhbGxGcmFt ZTo6c291cmNlSURGb3JDYWxsRnJhbWUobV9jdXJyZW50Q2FsbEZyYW1lKTsKICAgICBUZXh0UG9z aXRpb24gcG9zaXRpb24gPSBEZWJ1Z2dlckNhbGxGcmFtZTo6cG9zaXRpb25Gb3JDYWxsRnJhbWUo bV9jdXJyZW50Q2FsbEZyYW1lKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dl ci9EZWJ1Z2dlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dl ci9EZWJ1Z2dlci5oCShyZXZpc2lvbiAxNzM4ODYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGVidWdnZXIvRGVidWdnZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMjA3LDcgKzIwNyw3IEBAIHBy aXZhdGU6CiAKICAgICBSZWZQdHI8SlNDOjpEZWJ1Z2dlckNhbGxGcmFtZT4gbV9jdXJyZW50RGVi dWdnZXJDYWxsRnJhbWU7CiAKLSAgICBmcmllbmQgY2xhc3MgRGVidWdnZXJDYWxsRnJhbWVTY29w ZTsKKyAgICBmcmllbmQgY2xhc3MgRGVidWdnZXJQYXVzZWRTY29wZTsKICAgICBmcmllbmQgY2xh c3MgVGVtcG9yYXJ5UGF1c2VkU3RhdGU7CiAgICAgZnJpZW5kIGNsYXNzIExMSW50T2Zmc2V0c0V4 dHJhY3RvcjsKIH07CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdn ZXJDYWxsRnJhbWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdn ZXIvRGVidWdnZXJDYWxsRnJhbWUuaAkocmV2aXNpb24gMTczODg2KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyQ2FsbEZyYW1lLmgJKHdvcmtpbmcgY29weSkKQEAg LTgyLDcgKzgyLDcgQEAgcHJpdmF0ZToKICAgICBDYWxsRnJhbWUqIG1fY2FsbEZyYW1lOwogICAg IFJlZlB0cjxEZWJ1Z2dlckNhbGxGcmFtZT4gbV9jYWxsZXI7CiAgICAgVGV4dFBvc2l0aW9uIG1f cG9zaXRpb247Ci0gICAgLy8gVGhlIERlYnVnZ2VyQ2FsbEZyYW1lU2NvcGUgaXMgcmVzcG9uc2li bGUgZm9yIGNhbGxpbmcgaW52YWxpZGF0ZSgpIHdoaWNoLAorICAgIC8vIFRoZSBEZWJ1Z2dlclBh dXNlZFNjb3BlIGlzIHJlc3BvbnNpYmxlIGZvciBjYWxsaW5nIGludmFsaWRhdGUoKSB3aGljaCwK ICAgICAvLyBpbiB0dXJuLCB3aWxsIGNsZWFyIHRoaXMgc3Ryb25nIHJlZi4KICAgICBTdHJvbmc8 RGVidWdnZXJTY29wZT4gbV9zY29wZTsKIH07Cg==