137040 2014-09-23 13:05:11 -0700 Have NamedNodeMap::element() and DOMStringMap::element() return a reference 2014-09-23 14:17:39 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cmarcelo commit-queue esprehn+autocc kangil.han kling rniwa oldest_to_newest 1036805 0 cdumez 2014-09-23 13:05:11 -0700 Have NamedNodeMap::element() and DOMStringMap::element() return a reference instead of a pointer as they can never return null. 1036807 1 238562 cdumez 2014-09-23 13:07:14 -0700 Created attachment 238562 Patch 1036836 2 238562 commit-queue 2014-09-23 14:17:34 -0700 Comment on attachment 238562 Patch Clearing flags on attachment: 238562 Committed r173890: <http://trac.webkit.org/changeset/173890> 1036837 3 commit-queue 2014-09-23 14:17:39 -0700 All reviewed patches have been landed. Closing bug. 238562 2014-09-23 13:07:14 -0700 2014-09-23 14:17:34 -0700 Patch bug-137040-20140923130713.patch text/plain 2177 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODYxZmM0ZGJhYTcxOTYz NDMzMTVhYmU4OWU2OTY5NzExMTZhYjYzOC4uODg1MWNiZDEwNmY1MDU0ZDhmYmMzNzBkOWFlMjAz YWRlODEwNGUzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTA5LTIzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgSGF2ZSBOYW1lZE5vZGVNYXA6 OmVsZW1lbnQoKSBhbmQgRE9NU3RyaW5nTWFwOjplbGVtZW50KCkgcmV0dXJuIGEgcmVmZXJlbmNl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcwNDAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIYXZlIE5h bWVkTm9kZU1hcDo6ZWxlbWVudCgpIGFuZCBET01TdHJpbmdNYXA6OmVsZW1lbnQoKSByZXR1cm4g YQorICAgICAgICByZWZlcmVuY2UgaW5zdGVhZCBvZiBhIHBvaW50ZXIgYXMgdGhleSBjYW4gbmV2 ZXIgcmV0dXJuIG51bGwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFu Z2UuCisKKyAgICAgICAgKiBkb20vRGF0YXNldERPTVN0cmluZ01hcC5oOgorICAgICAgICAqIGRv bS9OYW1lZE5vZGVNYXAuaDoKKyAgICAgICAgKFdlYkNvcmU6Ok5hbWVkTm9kZU1hcDo6ZWxlbWVu dCk6CisKKzIwMTQtMDktMjMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAg ICAgICBIYXZlIERPTUltcGxlbWVudGF0aW9uOjpkb2N1bWVudCgpIGFuZCBFbGVtZW50OjphdHRy aWJ1dGVzKCkgcmV0dXJuIHJlZmVyZW5jZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNzAzNQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vRGF0YXNldERPTVN0cmluZ01hcC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0RhdGFzZXRET01T dHJpbmdNYXAuaAppbmRleCAzMzgzMzU1NjJkN2EwZDZlZmZhMGFiOGZiZDU5OTc2YWU1NDdkZmE0 Li5mMTlhMDUwMmVjMWM3ZWNkOWExM2M1NDc4OGVlZjNlYzMzNzVhZjIxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vRGF0YXNldERPTVN0cmluZ01hcC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9EYXRhc2V0RE9NU3RyaW5nTWFwLmgKQEAgLTUyLDcgKzUyLDcgQEAgcHVibGljOgog ICAgIHZvaWQgc2V0SXRlbShjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgdmFsdWUs IEV4Y2VwdGlvbkNvZGUmKTsKICAgICBib29sIGRlbGV0ZUl0ZW0oY29uc3QgU3RyaW5nJiBuYW1l KTsKIAotICAgIEVsZW1lbnQqIGVsZW1lbnQoKSB7IHJldHVybiAmbV9lbGVtZW50OyB9CisgICAg RWxlbWVudCYgZWxlbWVudCgpIHsgcmV0dXJuIG1fZWxlbWVudDsgfQogCiBwcml2YXRlOgogICAg IEVsZW1lbnQmIG1fZWxlbWVudDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1l ZE5vZGVNYXAuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZE5vZGVNYXAuaAppbmRleCBmYzhi ZmJlOGJiNTY3ZDdiMDQ4ZmM5YzkzNzRjMDUwMTcxMTljOGRhLi4xYzQ4Y2Y4YjIyOWY2YjNmMTVi NGQ5YWM5YTJlNWJmZGMyOTc3MWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTmFt ZWROb2RlTWFwLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05hbWVkTm9kZU1hcC5oCkBAIC02 Myw4ICs2Myw3IEBAIHB1YmxpYzoKICAgICBQYXNzUmVmUHRyPE5vZGU+IGl0ZW0odW5zaWduZWQg aW5kZXgpIGNvbnN0OwogICAgIHVuc2lnbmVkIGxlbmd0aCgpIGNvbnN0OwogCi0gICAgLy8gRklY TUU6IEl0J3MgbGFtZSB0aGF0IHRoZSBiaW5kaW5ncyBnZW5lcmF0b3IgY2hva2VzIGlmIHdlIHJl dHVybiBFbGVtZW50JiBoZXJlLgotICAgIEVsZW1lbnQqIGVsZW1lbnQoKSBjb25zdCB7IHJldHVy biAmbV9lbGVtZW50OyB9CisgICAgRWxlbWVudCYgZWxlbWVudCgpIGNvbnN0IHsgcmV0dXJuIG1f ZWxlbWVudDsgfQogCiBwcml2YXRlOgogICAgIGV4cGxpY2l0IE5hbWVkTm9kZU1hcChFbGVtZW50 JiBlbGVtZW50KQo=