137039 2014-09-23 12:53:19 -0700 Have DataTransfer::files() return a reference 2014-09-23 14:21:28 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue esprehn+autocc kangil.han kling rniwa oldest_to_newest 1036797 0 cdumez 2014-09-23 12:53:19 -0700 Have DataTransfer::files() return a reference instead of a pointer as it can never return null. 1036800 1 238560 cdumez 2014-09-23 12:54:54 -0700 Created attachment 238560 Patch 1036820 2 238560 rniwa 2014-09-23 13:43:03 -0700 Comment on attachment 238560 Patch r=me provided you fix Windows. 1036821 3 cdumez 2014-09-23 13:47:46 -0700 (In reply to comment #2) > (From update of attachment 238560 [details]) > r=me provided you fix Windows. It doesn't seem related to my patch? 1036823 4 238567 cdumez 2014-09-23 13:49:33 -0700 Created attachment 238567 Patch 1036833 5 238567 cdumez 2014-09-23 14:16:32 -0700 Comment on attachment 238567 Patch Yep, this was a flake. 1036839 6 238567 commit-queue 2014-09-23 14:21:23 -0700 Comment on attachment 238567 Patch Clearing flags on attachment: 238567 Committed r173891: <http://trac.webkit.org/changeset/173891> 1036840 7 commit-queue 2014-09-23 14:21:28 -0700 All reviewed patches have been landed. Closing bug. 238560 2014-09-23 12:54:54 -0700 2014-09-23 13:49:28 -0700 Patch bug-137039-20140923125453.patch text/plain 2592 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODI4ZGZlMTI4ZWI2ZDM3 ZTQ0NGE3YzM4Zjk4ZDcxYWFjZGFkYjQ2YS4uZWRjNzk4MzY5NjdlYmMzYTM0YTQ1YTZiYzE1MzI4 MTVlZmQ5ZjExZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTA5LTIzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgSGF2ZSBEYXRhVHJhbnNmZXI6 OmZpbGVzKCkgcmV0dXJuIGEgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcwMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBIYXZlIERhdGFUcmFuc2Zlcjo6ZmlsZXMoKSByZXR1cm4gYSBy ZWZlcmVuY2UgaW5zdGVhZCBvZiBhIHBvaW50ZXIgYXMKKyAgICAgICAgaXQgY2FuIG5ldmVyIHJl dHVybiBudWxsLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgor CisgICAgICAgICogZG9tL0RhdGFUcmFuc2Zlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEYXRh VHJhbnNmZXI6OmZpbGVzKToKKyAgICAgICAgKiBkb20vRGF0YVRyYW5zZmVyLmg6CisKKzIwMTQt MDktMjMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBIYXZlIERv Y3VtZW50OjplbnN1cmVUZW1wbGF0ZURvY3VtZW50KCkgcmV0dXJuIGEgcmVmZXJlbmNlCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcwMzMKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRGF0YVRyYW5zZmVyLmNwcAppbmRleCA0Y2JmYWYxMzUzNzZlNWNjOTliZWI5YmUw MmM2NDk3MjBlYjQ4ODBkLi4wZTJkYzZjYjY2NGU4MzYyZTg3NDRlZWRmOTI5OTJmYjk5MmE2MDc1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRGF0YVRyYW5zZmVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vRGF0YVRyYW5zZmVyLmNwcApAQCAtMTU5LDcgKzE1OSw3IEBAIFZl Y3RvcjxTdHJpbmc+IERhdGFUcmFuc2Zlcjo6dHlwZXMoKSBjb25zdAogICAgIHJldHVybiBtX3Bh c3RlYm9hcmQtPnR5cGVzKCk7CiB9CiAKLUZpbGVMaXN0KiBEYXRhVHJhbnNmZXI6OmZpbGVzKCkg Y29uc3QKK0ZpbGVMaXN0JiBEYXRhVHJhbnNmZXI6OmZpbGVzKCkgY29uc3QKIHsKICAgICBib29s IG5ld2x5Q3JlYXRlZEZpbGVMaXN0ID0gIW1fZmlsZUxpc3Q7CiAgICAgaWYgKCFtX2ZpbGVMaXN0 KQpAQCAtMTY3LDEzICsxNjcsMTMgQEAgRmlsZUxpc3QqIERhdGFUcmFuc2Zlcjo6ZmlsZXMoKSBj b25zdAogCiAgICAgaWYgKCFjYW5SZWFkRGF0YSgpKSB7CiAgICAgICAgIG1fZmlsZUxpc3QtPmNs ZWFyKCk7Ci0gICAgICAgIHJldHVybiBtX2ZpbGVMaXN0LmdldCgpOworICAgICAgICByZXR1cm4g Km1fZmlsZUxpc3Q7CiAgICAgfQogCiAjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkKICAgICBpZiAo bV9mb3JEcmFnICYmICFtX2ZvckZpbGVEcmFnKSB7CiAgICAgICAgIEFTU0VSVChtX2ZpbGVMaXN0 LT5pc0VtcHR5KCkpOwotICAgICAgICByZXR1cm4gbV9maWxlTGlzdC5nZXQoKTsKKyAgICAgICAg cmV0dXJuICptX2ZpbGVMaXN0OwogICAgIH0KICNlbmRpZgogCkBAIC0xODEsNyArMTgxLDcgQEAg RmlsZUxpc3QqIERhdGFUcmFuc2Zlcjo6ZmlsZXMoKSBjb25zdAogICAgICAgICBmb3IgKGNvbnN0 IFN0cmluZyYgZmlsZW5hbWUgOiBtX3Bhc3RlYm9hcmQtPnJlYWRGaWxlbmFtZXMoKSkKICAgICAg ICAgICAgIG1fZmlsZUxpc3QtPmFwcGVuZChGaWxlOjpjcmVhdGUoZmlsZW5hbWUpKTsKICAgICB9 Ci0gICAgcmV0dXJuIG1fZmlsZUxpc3QuZ2V0KCk7CisgICAgcmV0dXJuICptX2ZpbGVMaXN0Owog fQogCiBib29sIERhdGFUcmFuc2Zlcjo6aGFzRmlsZU9mVHlwZShjb25zdCBTdHJpbmcmIHR5cGUp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRGF0YVRyYW5zZmVyLmggYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRGF0YVRyYW5zZmVyLmgKaW5kZXggMWI3ZjIwZWI0MjcwZGRmMDgxMzZlNjVj MDgxMGIyZTQ3MWQzNjZmMC4uOWQ5NjdhNjUzNTkwYTdjNWY3MDk4MzAyZGZjZjE0ZmRlODhhNDEw ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9EYXRhVHJhbnNmZXIuaApAQCAtNTYsNyArNTYsNyBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKICAgICAgICAgVmVjdG9yPFN0cmluZz4gdHlwZXMoKSBjb25zdDsKIAot ICAgICAgICBGaWxlTGlzdCogZmlsZXMoKSBjb25zdDsKKyAgICAgICAgRmlsZUxpc3QmIGZpbGVz KCkgY29uc3Q7CiAKICAgICAgICAgdm9pZCBjbGVhckRhdGEoY29uc3QgU3RyaW5nJiB0eXBlKTsK ICAgICAgICAgdm9pZCBjbGVhckRhdGEoKTsK 238567 2014-09-23 13:49:33 -0700 2014-09-23 14:21:23 -0700 Patch bug-137039-20140923134932.patch text/plain 2610 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODYxZmM0ZGJhYTcxOTYz NDMzMTVhYmU4OWU2OTY5NzExMTZhYjYzOC4uZWRhMDRkNzBlMGExMjg5NzBmMGZiODkyZjI0MTky N2Q4ZTNlNmIzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTA5LTIzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgSGF2ZSBEYXRhVHJhbnNmZXI6 OmZpbGVzKCkgcmV0dXJuIGEgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcwMzkKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtl IE5pd2EuCisKKyAgICAgICAgSGF2ZSBEYXRhVHJhbnNmZXI6OmZpbGVzKCkgcmV0dXJuIGEgcmVm ZXJlbmNlIGluc3RlYWQgb2YgYSBwb2ludGVyIGFzCisgICAgICAgIGl0IGNhbiBuZXZlciByZXR1 cm4gbnVsbC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKwor ICAgICAgICAqIGRvbS9EYXRhVHJhbnNmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGF0YVRy YW5zZmVyOjpmaWxlcyk6CisgICAgICAgICogZG9tL0RhdGFUcmFuc2Zlci5oOgorCisyMDE0LTA5 LTIzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgSGF2ZSBET01J bXBsZW1lbnRhdGlvbjo6ZG9jdW1lbnQoKSBhbmQgRWxlbWVudDo6YXR0cmlidXRlcygpIHJldHVy biByZWZlcmVuY2VzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzcwMzUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RhdGFUcmFuc2Zl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRGF0YVRyYW5zZmVyLmNwcAppbmRleCA0Y2JmYWYx MzUzNzZlNWNjOTliZWI5YmUwMmM2NDk3MjBlYjQ4ODBkLi4wZTJkYzZjYjY2NGU4MzYyZTg3NDRl ZWRmOTI5OTJmYjk5MmE2MDc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRGF0YVRy YW5zZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRGF0YVRyYW5zZmVyLmNwcApAQCAt MTU5LDcgKzE1OSw3IEBAIFZlY3RvcjxTdHJpbmc+IERhdGFUcmFuc2Zlcjo6dHlwZXMoKSBjb25z dAogICAgIHJldHVybiBtX3Bhc3RlYm9hcmQtPnR5cGVzKCk7CiB9CiAKLUZpbGVMaXN0KiBEYXRh VHJhbnNmZXI6OmZpbGVzKCkgY29uc3QKK0ZpbGVMaXN0JiBEYXRhVHJhbnNmZXI6OmZpbGVzKCkg Y29uc3QKIHsKICAgICBib29sIG5ld2x5Q3JlYXRlZEZpbGVMaXN0ID0gIW1fZmlsZUxpc3Q7CiAg ICAgaWYgKCFtX2ZpbGVMaXN0KQpAQCAtMTY3LDEzICsxNjcsMTMgQEAgRmlsZUxpc3QqIERhdGFU cmFuc2Zlcjo6ZmlsZXMoKSBjb25zdAogCiAgICAgaWYgKCFjYW5SZWFkRGF0YSgpKSB7CiAgICAg ICAgIG1fZmlsZUxpc3QtPmNsZWFyKCk7Ci0gICAgICAgIHJldHVybiBtX2ZpbGVMaXN0LmdldCgp OworICAgICAgICByZXR1cm4gKm1fZmlsZUxpc3Q7CiAgICAgfQogCiAjaWYgRU5BQkxFKERSQUdf U1VQUE9SVCkKICAgICBpZiAobV9mb3JEcmFnICYmICFtX2ZvckZpbGVEcmFnKSB7CiAgICAgICAg IEFTU0VSVChtX2ZpbGVMaXN0LT5pc0VtcHR5KCkpOwotICAgICAgICByZXR1cm4gbV9maWxlTGlz dC5nZXQoKTsKKyAgICAgICAgcmV0dXJuICptX2ZpbGVMaXN0OwogICAgIH0KICNlbmRpZgogCkBA IC0xODEsNyArMTgxLDcgQEAgRmlsZUxpc3QqIERhdGFUcmFuc2Zlcjo6ZmlsZXMoKSBjb25zdAog ICAgICAgICBmb3IgKGNvbnN0IFN0cmluZyYgZmlsZW5hbWUgOiBtX3Bhc3RlYm9hcmQtPnJlYWRG aWxlbmFtZXMoKSkKICAgICAgICAgICAgIG1fZmlsZUxpc3QtPmFwcGVuZChGaWxlOjpjcmVhdGUo ZmlsZW5hbWUpKTsKICAgICB9Ci0gICAgcmV0dXJuIG1fZmlsZUxpc3QuZ2V0KCk7CisgICAgcmV0 dXJuICptX2ZpbGVMaXN0OwogfQogCiBib29sIERhdGFUcmFuc2Zlcjo6aGFzRmlsZU9mVHlwZShj b25zdCBTdHJpbmcmIHR5cGUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRGF0YVRy YW5zZmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRGF0YVRyYW5zZmVyLmgKaW5kZXggMWI3ZjIw ZWI0MjcwZGRmMDgxMzZlNjVjMDgxMGIyZTQ3MWQzNjZmMC4uOWQ5NjdhNjUzNTkwYTdjNWY3MDk4 MzAyZGZjZjE0ZmRlODhhNDEwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RhdGFU cmFuc2Zlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9EYXRhVHJhbnNmZXIuaApAQCAtNTYs NyArNTYsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgVmVjdG9yPFN0cmluZz4g dHlwZXMoKSBjb25zdDsKIAotICAgICAgICBGaWxlTGlzdCogZmlsZXMoKSBjb25zdDsKKyAgICAg ICAgRmlsZUxpc3QmIGZpbGVzKCkgY29uc3Q7CiAKICAgICAgICAgdm9pZCBjbGVhckRhdGEoY29u c3QgU3RyaW5nJiB0eXBlKTsKICAgICAgICAgdm9pZCBjbGVhckRhdGEoKTsK