137035 2014-09-23 11:46:10 -0700 Have DOMImplementation::document() and Element::attributes() return references 2014-09-23 12:53:20 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue kling rniwa oldest_to_newest 1036777 0 cdumez 2014-09-23 11:46:10 -0700 Have DOMImplementation::document() and Element::attributes() return references instead of pointers as they can never return null. 1036780 1 238556 cdumez 2014-09-23 12:00:32 -0700 Created attachment 238556 Patch 1036785 2 238556 kling 2014-09-23 12:16:19 -0700 Comment on attachment 238556 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238556&action=review Sweet! r=me > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2993 > - $rootString = " Frame* root = js${interfaceName}->impl().frame();\n"; > + $rootString = " Frame* root = WTF::getPtr(js${interfaceName}->impl().frame());\n"; > $rootString .= " if (!root)\n"; > $rootString .= " return false;\n"; It would be cool if we could avoid the null check if the root is a reference. Although maybe the compiler takes care of that anyway. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2997 > - $rootString = " Document* root = js${interfaceName}->impl().document();\n"; > + $rootString = " Document* root = WTF::getPtr(js${interfaceName}->impl().document());\n"; > $rootString .= " if (!root)\n"; > $rootString .= " return false;\n"; Same comment. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3003 > - $rootString = " Element* element = js${interfaceName}->impl().element();\n"; > + $rootString = " Element* element = WTF::getPtr(js${interfaceName}->impl().element());\n"; > $rootString .= " if (!element)\n"; > $rootString .= " return false;\n"; Same comment. 1036787 3 238556 cdumez 2014-09-23 12:19:12 -0700 Comment on attachment 238556 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238556&action=review >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2993 >> $rootString .= " return false;\n"; > > It would be cool if we could avoid the null check if the root is a reference. > Although maybe the compiler takes care of that anyway. Yes, I thought about this as well. I am hoping the compiler is being smart here but I'll try and take a look soon. 1036796 4 238556 commit-queue 2014-09-23 12:53:16 -0700 Comment on attachment 238556 Patch Clearing flags on attachment: 238556 Committed r173885: <http://trac.webkit.org/changeset/173885> 1036798 5 commit-queue 2014-09-23 12:53:20 -0700 All reviewed patches have been landed. Closing bug. 238556 2014-09-23 12:00:32 -0700 2014-09-23 12:53:16 -0700 Patch bug-137035-20140923120032.patch text/plain 5919 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkxMTgzYWFiNDcxYzI2 OWVmNTAzYzA4MzAyZTYyNDBlMTYzMWJhNy4uOTAxZGRlNjg0MTMyZjUwZTdiY2ZlOGMzYTZmODA4 ODc4NmM2M2M1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE0LTA5LTIzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSGF2ZSBET01JbXBsZW1lbnRh dGlvbjo6ZG9jdW1lbnQoKSBhbmQgRWxlbWVudDo6YXR0cmlidXRlcygpIHJldHVybiByZWZlcmVu Y2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcw MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIYXZl IERPTUltcGxlbWVudGF0aW9uOjpkb2N1bWVudCgpIGFuZCBFbGVtZW50OjphdHRyaWJ1dGVzKCkg cmV0dXJuCisgICAgICAgIHJlZmVyZW5jZXMgaW5zdGVhZCBvZiBwb2ludGVycyBhcyB0aGV5IGNh biBuZXZlciByZXR1cm4gbnVsbC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9y IGNoYW5nZS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBt OgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisgICAgICAgIFVwZGF0ZSB0aGUg SlMgQmluZGluZ3MgY29kZSBnZW5lcmF0b3IgdG8gdXNlIFdURjo6Z2V0UHRyKCkgaW4gYSBjb3Vw bGUKKyAgICAgICAgbW9yZSBwbGFjZXMgc28gdGhhdCB0aGUgaW1wbGVtZW50YXRpb24gY2FuIHJl dHVybiByZWZlcmVuY2VzIGluc3RlYWQKKyAgICAgICAgb2YgcG9pbnRlcnMgZXZlbiB3aGVuIFtH ZW5lcmF0ZUlzUmVhY2hhYmxlPXh4eF0gSURMIGV4dGVuZGVkIGF0dHJpYnV0ZQorICAgICAgICBp cyB1c2VkLgorCisgICAgICAgICogZG9tL0RPTUltcGxlbWVudGF0aW9uLmg6CisgICAgICAgIChX ZWJDb3JlOjpET01JbXBsZW1lbnRhdGlvbjo6ZG9jdW1lbnQpOgorICAgICAgICAqIGRvbS9FbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OmF0dHJpYnV0ZXMpOgorICAgICAg ICAqIGRvbS9FbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjphdHRyaWJ1dGVzKToK KwogMjAxNC0wOS0yMyAgRWR1YXJkbyBMaW1hIE1pdGV2ICA8ZWxpbWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBBZGRzIGltcGxlbWVudGF0aW9uIG9mIHN1YnRsZSBjcnlwdG8gSE1BQyBh bGdvcml0aG0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG0KaW5kZXggYmZlODFkODcxMTc2MGZhN2E1YTZiMDkzODA4MTc0NWVlNmQ1YmQ3 ZS4uYjFlYTFiMWEzZGExNDhjNWVjMWM2YzQ4ZmQ4Y2ZkMjJmZjNiZWZkNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTI5 ODYsMTkgKzI5ODYsMTkgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgICAg IGlmIChHZXRHZW5lcmF0ZUlzUmVhY2hhYmxlKCRpbnRlcmZhY2UpIGVxICJJbXBsIikgewogICAg ICAgICAgICAgICAgICRyb290U3RyaW5nICA9ICIgICAgJHtpbXBsVHlwZX0qIHJvb3QgPSAmanMk e2ludGVyZmFjZU5hbWV9LT5pbXBsKCk7XG4iOwogICAgICAgICAgICAgfSBlbHNpZiAoR2V0R2Vu ZXJhdGVJc1JlYWNoYWJsZSgkaW50ZXJmYWNlKSBlcSAiSW1wbFdlYkdMUmVuZGVyaW5nQ29udGV4 dCIpIHsKLSAgICAgICAgICAgICAgICAkcm9vdFN0cmluZyAgPSAiICAgIFdlYkdMUmVuZGVyaW5n Q29udGV4dCogcm9vdCA9IGpzJHtpbnRlcmZhY2VOYW1lfS0+aW1wbCgpLmNvbnRleHQoKTtcbiI7 CisgICAgICAgICAgICAgICAgJHJvb3RTdHJpbmcgID0gIiAgICBXZWJHTFJlbmRlcmluZ0NvbnRl eHQqIHJvb3QgPSBXVEY6OmdldFB0cihqcyR7aW50ZXJmYWNlTmFtZX0tPmltcGwoKS5jb250ZXh0 KCkpO1xuIjsKICAgICAgICAgICAgIH0gZWxzaWYgKEdldEdlbmVyYXRlSXNSZWFjaGFibGUoJGlu dGVyZmFjZSkgZXEgIkltcGxGcmFtZSIpIHsKLSAgICAgICAgICAgICAgICAkcm9vdFN0cmluZyAg PSAiICAgIEZyYW1lKiByb290ID0ganMke2ludGVyZmFjZU5hbWV9LT5pbXBsKCkuZnJhbWUoKTtc biI7CisgICAgICAgICAgICAgICAgJHJvb3RTdHJpbmcgID0gIiAgICBGcmFtZSogcm9vdCA9IFdU Rjo6Z2V0UHRyKGpzJHtpbnRlcmZhY2VOYW1lfS0+aW1wbCgpLmZyYW1lKCkpO1xuIjsKICAgICAg ICAgICAgICAgICAkcm9vdFN0cmluZyAuPSAiICAgIGlmICghcm9vdClcbiI7CiAgICAgICAgICAg ICAgICAgJHJvb3RTdHJpbmcgLj0gIiAgICAgICAgcmV0dXJuIGZhbHNlO1xuIjsKICAgICAgICAg ICAgIH0gZWxzaWYgKEdldEdlbmVyYXRlSXNSZWFjaGFibGUoJGludGVyZmFjZSkgZXEgIkltcGxE b2N1bWVudCIpIHsKLSAgICAgICAgICAgICAgICAkcm9vdFN0cmluZyAgPSAiICAgIERvY3VtZW50 KiByb290ID0ganMke2ludGVyZmFjZU5hbWV9LT5pbXBsKCkuZG9jdW1lbnQoKTtcbiI7CisgICAg ICAgICAgICAgICAgJHJvb3RTdHJpbmcgID0gIiAgICBEb2N1bWVudCogcm9vdCA9IFdURjo6Z2V0 UHRyKGpzJHtpbnRlcmZhY2VOYW1lfS0+aW1wbCgpLmRvY3VtZW50KCkpO1xuIjsKICAgICAgICAg ICAgICAgICAkcm9vdFN0cmluZyAuPSAiICAgIGlmICghcm9vdClcbiI7CiAgICAgICAgICAgICAg ICAgJHJvb3RTdHJpbmcgLj0gIiAgICAgICAgcmV0dXJuIGZhbHNlO1xuIjsKICAgICAgICAgICAg IH0gZWxzaWYgKEdldEdlbmVyYXRlSXNSZWFjaGFibGUoJGludGVyZmFjZSkgZXEgIkltcGxFbGVt ZW50Um9vdCIpIHsKICAgICAgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyJFbGVtZW50LmgifSA9 IDE7CiAgICAgICAgICAgICAgICAgJGltcGxJbmNsdWRlc3siSlNOb2RlQ3VzdG9tLmgifSA9IDE7 Ci0gICAgICAgICAgICAgICAgJHJvb3RTdHJpbmcgID0gIiAgICBFbGVtZW50KiBlbGVtZW50ID0g anMke2ludGVyZmFjZU5hbWV9LT5pbXBsKCkuZWxlbWVudCgpO1xuIjsKKyAgICAgICAgICAgICAg ICAkcm9vdFN0cmluZyAgPSAiICAgIEVsZW1lbnQqIGVsZW1lbnQgPSBXVEY6OmdldFB0cihqcyR7 aW50ZXJmYWNlTmFtZX0tPmltcGwoKS5lbGVtZW50KCkpO1xuIjsKICAgICAgICAgICAgICAgICAk cm9vdFN0cmluZyAuPSAiICAgIGlmICghZWxlbWVudClcbiI7CiAgICAgICAgICAgICAgICAgJHJv b3RTdHJpbmcgLj0gIiAgICAgICAgcmV0dXJuIGZhbHNlO1xuIjsKICAgICAgICAgICAgICAgICAk cm9vdFN0cmluZyAuPSAiICAgIHZvaWQqIHJvb3QgPSBXZWJDb3JlOjpyb290KGVsZW1lbnQpO1xu IjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9ET01JbXBsZW1lbnRhdGlvbi5oIGIv U291cmNlL1dlYkNvcmUvZG9tL0RPTUltcGxlbWVudGF0aW9uLmgKaW5kZXggN2Q4YjhlNzI5ZDIy MWU4MDU1NjZiMGM5ZWI3ZDNhMTg1ZDA3MmQxMy4uN2NhNThkNTZhYzVjZTNjM2E5MjJlYTMxNTUz ZmFlODMyMTY0YWI4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RPTUltcGxlbWVu dGF0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RPTUltcGxlbWVudGF0aW9uLmgKQEAg LTUwLDcgKzUwLDcgQEAgcHVibGljOgogICAgIAogICAgIHZvaWQgcmVmKCkgeyBtX2RvY3VtZW50 LnJlZigpOyB9CiAgICAgdm9pZCBkZXJlZigpIHsgbV9kb2N1bWVudC5kZXJlZigpOyB9Ci0gICAg RG9jdW1lbnQqIGRvY3VtZW50KCkgeyByZXR1cm4gJm1fZG9jdW1lbnQ7IH0KKyAgICBEb2N1bWVu dCYgZG9jdW1lbnQoKSB7IHJldHVybiBtX2RvY3VtZW50OyB9CiAKICAgICAvLyBET00gbWV0aG9k cyAmIGF0dHJpYnV0ZXMgZm9yIERPTUltcGxlbWVudGF0aW9uCiAgICAgc3RhdGljIGJvb2wgaGFz RmVhdHVyZShjb25zdCBTdHJpbmcmIGZlYXR1cmUsIGNvbnN0IFN0cmluZyYgdmVyc2lvbik7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5jcHAKaW5kZXggM2UwNmVkNzBjMjUxNWEyODU0YzU3N2EwYTYyNDdmMzNk N2IxNWVhNi4uN2FkYmMyM2VlYjUwZDg1MWZlYTk3M2M4MjAxMzE1ZWQwZjU1MzRlMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9FbGVtZW50LmNwcApAQCAtMzUyLDE0ICszNTIsMTQgQEAgdm9pZCBFbGVtZW50OjpzZXRC b29sZWFuQXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUsIGJvb2wgdmFsdWUpCiAg ICAgICAgIHJlbW92ZUF0dHJpYnV0ZShuYW1lKTsKIH0KIAotTmFtZWROb2RlTWFwKiBFbGVtZW50 OjphdHRyaWJ1dGVzKCkgY29uc3QKK05hbWVkTm9kZU1hcCYgRWxlbWVudDo6YXR0cmlidXRlcygp IGNvbnN0CiB7CiAgICAgRWxlbWVudFJhcmVEYXRhJiByYXJlRGF0YSA9IGNvbnN0X2Nhc3Q8RWxl bWVudCo+KHRoaXMpLT5lbnN1cmVFbGVtZW50UmFyZURhdGEoKTsKICAgICBpZiAoTmFtZWROb2Rl TWFwKiBhdHRyaWJ1dGVNYXAgPSByYXJlRGF0YS5hdHRyaWJ1dGVNYXAoKSkKLSAgICAgICAgcmV0 dXJuIGF0dHJpYnV0ZU1hcDsKKyAgICAgICAgcmV0dXJuICphdHRyaWJ1dGVNYXA7CiAKICAgICBy YXJlRGF0YS5zZXRBdHRyaWJ1dGVNYXAoTmFtZWROb2RlTWFwOjpjcmVhdGUoY29uc3RfY2FzdDxF bGVtZW50Jj4oKnRoaXMpKSk7Ci0gICAgcmV0dXJuIHJhcmVEYXRhLmF0dHJpYnV0ZU1hcCgpOwor ICAgIHJldHVybiAqcmFyZURhdGEuYXR0cmlidXRlTWFwKCk7CiB9CiAKIE5vZGU6Ok5vZGVUeXBl IEVsZW1lbnQ6Om5vZGVUeXBlKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCmluZGV4IDljOGIzNDA1 MTUxMzM5ZTcxOThkNmRiNmQ5NTY2OWRjYmMxN2RkNTEuLmY2NDIxNDlmNTQzYmMxZDkyZmY3MjU2 MzcwYzM5YWViZGMyZGU3NGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaApAQCAtMjg1LDcgKzI4NSw3IEBA IHB1YmxpYzoKICAgICB2b2lkIHNldEJvb2xlYW5BdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFt ZSYgbmFtZSwgYm9vbCk7CiAKICAgICAvLyBGb3IgZXhwb3NpbmcgdG8gRE9NIG9ubHkuCi0gICAg TmFtZWROb2RlTWFwKiBhdHRyaWJ1dGVzKCkgY29uc3Q7CisgICAgTmFtZWROb2RlTWFwJiBhdHRy aWJ1dGVzKCkgY29uc3Q7CiAKICAgICBlbnVtIEF0dHJpYnV0ZU1vZGlmaWNhdGlvblJlYXNvbiB7 CiAgICAgICAgIE1vZGlmaWVkRGlyZWN0bHksCkBAIC03MTEsNyArNzExLDcgQEAgaW5saW5lIGJv b2wgTm9kZTo6aGFzQXR0cmlidXRlcygpIGNvbnN0CiAKIGlubGluZSBOYW1lZE5vZGVNYXAqIE5v ZGU6OmF0dHJpYnV0ZXMoKSBjb25zdAogewotICAgIHJldHVybiBpc0VsZW1lbnROb2RlKCkgPyB0 b0VsZW1lbnQodGhpcyktPmF0dHJpYnV0ZXMoKSA6IG51bGxwdHI7CisgICAgcmV0dXJuIGlzRWxl bWVudE5vZGUoKSA/ICZ0b0VsZW1lbnQodGhpcyktPmF0dHJpYnV0ZXMoKSA6IG51bGxwdHI7CiB9 CiAKIGlubGluZSBFbGVtZW50KiBOb2RlOjpwYXJlbnRFbGVtZW50KCkgY29uc3QK