137033 2014-09-23 11:15:29 -0700 Have Document::ensureTemplateDocument() return a reference 2014-09-23 12:30:28 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue kling rniwa oldest_to_newest 1036766 0 cdumez 2014-09-23 11:15:29 -0700 Have Document::ensureTemplateDocument() return a reference instead of a pointer as it can never return null. 1036768 1 238552 cdumez 2014-09-23 11:18:42 -0700 Created attachment 238552 Patch 1036788 2 238552 commit-queue 2014-09-23 12:30:24 -0700 Comment on attachment 238552 Patch Clearing flags on attachment: 238552 Committed r173884: <http://trac.webkit.org/changeset/173884> 1036789 3 commit-queue 2014-09-23 12:30:28 -0700 All reviewed patches have been landed. Closing bug. 238552 2014-09-23 11:18:42 -0700 2014-09-23 12:30:24 -0700 Patch bug-137033-20140923111841.patch text/plain 4487 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkxMTgzYWFiNDcxYzI2 OWVmNTAzYzA4MzAyZTYyNDBlMTYzMWJhNy4uN2QzYmU3ZjExNTdmMzU1Y2MxODM4NzcwMzllZjBm OGY1OTNhYmY0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA5LTIzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSGF2ZSBEb2N1bWVudDo6ZW5z dXJlVGVtcGxhdGVEb2N1bWVudCgpIHJldHVybiBhIHJlZmVyZW5jZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3MDMzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGF2ZSBEb2N1bWVudDo6ZW5zdXJlVGVt cGxhdGVEb2N1bWVudCgpIHJldHVybiBhIHJlZmVyZW5jZSBpbnN0ZWFkIG9mCisgICAgICAgIGEg cG9pbnRlciBhcyBpdCBjYW4gbmV2ZXIgcmV0dXJuIG51bGwuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmVuc3VyZVRlbXBsYXRlRG9jdW1lbnQpOgorICAg ICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAgICAqIGVkaXRpbmcvbWFya3VwLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OmNyZWF0ZUZyYWdtZW50Rm9ySW5uZXJPdXRlckhUTUwpOgorICAgICAg ICAqIGh0bWwvSFRNTFRlbXBsYXRlRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1M VGVtcGxhdGVFbGVtZW50Ojpjb250ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUZW1wbGF0 ZUVsZW1lbnQ6OmRpZE1vdmVUb05ld0RvY3VtZW50KToKKwogMjAxNC0wOS0yMyAgRWR1YXJkbyBM aW1hIE1pdGV2ICA8ZWxpbWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGRzIGltcGxl bWVudGF0aW9uIG9mIHN1YnRsZSBjcnlwdG8gSE1BQyBhbGdvcml0aG0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnQuY3BwCmluZGV4IDQyZDBlMGRhZTIzOGRlMGE3ZjY3YTM5MzU0MWJiNjUzMjc4YTE4ZmMuLmM2 ODg1NGY2NzkzMmMwY2Y3MWNlZjgxZTlkZjhmNGMwYmU3ZDJmMTEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmNwcApAQCAtNjEyNiwxMCArNjEyNiwxMCBAQCBMb2NhbGUmIERvY3VtZW50OjpnZXRDYWNo ZWRMb2NhbGUoY29uc3QgQXRvbWljU3RyaW5nJiBsb2NhbGUpCiB9CiAKICNpZiBFTkFCTEUoVEVN UExBVEVfRUxFTUVOVCkKLURvY3VtZW50KiBEb2N1bWVudDo6ZW5zdXJlVGVtcGxhdGVEb2N1bWVu dCgpCitEb2N1bWVudCYgRG9jdW1lbnQ6OmVuc3VyZVRlbXBsYXRlRG9jdW1lbnQoKQogewogICAg IGlmIChjb25zdCBEb2N1bWVudCogZG9jdW1lbnQgPSB0ZW1wbGF0ZURvY3VtZW50KCkpCi0gICAg ICAgIHJldHVybiBjb25zdF9jYXN0PERvY3VtZW50Kj4oZG9jdW1lbnQpOworICAgICAgICByZXR1 cm4gY29uc3RfY2FzdDxEb2N1bWVudCY+KCpkb2N1bWVudCk7CiAKICAgICBpZiAoaXNIVE1MRG9j dW1lbnQoKSkKICAgICAgICAgbV90ZW1wbGF0ZURvY3VtZW50ID0gSFRNTERvY3VtZW50OjpjcmVh dGUobnVsbHB0ciwgYmxhbmtVUkwoKSk7CkBAIC02MTM4LDcgKzYxMzgsNyBAQCBEb2N1bWVudCog RG9jdW1lbnQ6OmVuc3VyZVRlbXBsYXRlRG9jdW1lbnQoKQogCiAgICAgbV90ZW1wbGF0ZURvY3Vt ZW50LT5zZXRUZW1wbGF0ZURvY3VtZW50SG9zdCh0aGlzKTsgLy8gYmFsYW5jZWQgaW4gZHRvci4K IAotICAgIHJldHVybiBtX3RlbXBsYXRlRG9jdW1lbnQuZ2V0KCk7CisgICAgcmV0dXJuICptX3Rl bXBsYXRlRG9jdW1lbnQ7CiB9CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAppbmRleCA5MGRm MDcwZjg1NzNiMGY3OWI1ZjYyMWM4MTA0YmVhMzQzMDM4ZjZkLi40NWU4YTUxM2Y4NjgzMWQwODU2 NTAwMDQ2ZDQ1MmI3NzY1OTEwYmM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaApAQCAtMTI1Nyw3ICsx MjU3LDcgQEAgcHVibGljOgogCiAjaWYgRU5BQkxFKFRFTVBMQVRFX0VMRU1FTlQpCiAgICAgY29u c3QgRG9jdW1lbnQqIHRlbXBsYXRlRG9jdW1lbnQoKSBjb25zdDsKLSAgICBEb2N1bWVudCogZW5z dXJlVGVtcGxhdGVEb2N1bWVudCgpOworICAgIERvY3VtZW50JiBlbnN1cmVUZW1wbGF0ZURvY3Vt ZW50KCk7CiAgICAgdm9pZCBzZXRUZW1wbGF0ZURvY3VtZW50SG9zdChEb2N1bWVudCogdGVtcGxh dGVEb2N1bWVudEhvc3QpIHsgbV90ZW1wbGF0ZURvY3VtZW50SG9zdCA9IHRlbXBsYXRlRG9jdW1l bnRIb3N0OyB9CiAgICAgRG9jdW1lbnQqIHRlbXBsYXRlRG9jdW1lbnRIb3N0KCkgeyByZXR1cm4g bV90ZW1wbGF0ZURvY3VtZW50SG9zdDsgfQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL21hcmt1cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5j cHAKaW5kZXggNmMyMmJmZTI4YTEwNGViYWYxNTQ2MDFkZmU4Yzk4ODliMmYyMWVkZC4uNThmMGZm NTYxMWUyNjFjNGI1MzMwMDQ3OWQ3NTI0ZDFlM2JjOTk4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFy a3VwLmNwcApAQCAtODg0LDcgKzg4NCw3IEBAIFBhc3NSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4g Y3JlYXRlRnJhZ21lbnRGb3JJbm5lck91dGVySFRNTChjb25zdCBTdHJpbmcmIG1hcmt1CiAgICAg RG9jdW1lbnQqIGRvY3VtZW50ID0gJmNvbnRleHRFbGVtZW50LT5kb2N1bWVudCgpOwogI2lmIEVO QUJMRShURU1QTEFURV9FTEVNRU5UKQogICAgIGlmIChjb250ZXh0RWxlbWVudC0+aGFzVGFnTmFt ZSh0ZW1wbGF0ZVRhZykpCi0gICAgICAgIGRvY3VtZW50ID0gZG9jdW1lbnQtPmVuc3VyZVRlbXBs YXRlRG9jdW1lbnQoKTsKKyAgICAgICAgZG9jdW1lbnQgPSAmZG9jdW1lbnQtPmVuc3VyZVRlbXBs YXRlRG9jdW1lbnQoKTsKICNlbmRpZgogICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBmcmFn bWVudCA9IERvY3VtZW50RnJhZ21lbnQ6OmNyZWF0ZSgqZG9jdW1lbnQpOwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZW1wbGF0ZUVsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MVGVtcGxhdGVFbGVtZW50LmNwcAppbmRleCAxN2U0YzA4MDc2MjI5Y2I3 MmYxYjAxMjUyYmQzYWRlNDM5NTA3YjM4Li42OTg5ZGZhNDU2MzVhYzI4N2Q3MGE1NjUwNTZkYWU2 OTFjMTBhMTQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZW1wbGF0ZUVs ZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRlbXBsYXRlRWxlbWVudC5j cHAKQEAgLTYzLDcgKzYzLDcgQEAgUGFzc1JlZlB0cjxIVE1MVGVtcGxhdGVFbGVtZW50PiBIVE1M VGVtcGxhdGVFbGVtZW50OjpjcmVhdGUoY29uc3QgUXVhbGlmaWVkTmFtZSYKIERvY3VtZW50RnJh Z21lbnQqIEhUTUxUZW1wbGF0ZUVsZW1lbnQ6OmNvbnRlbnQoKSBjb25zdAogewogICAgIGlmICgh bV9jb250ZW50KQotICAgICAgICBtX2NvbnRlbnQgPSBUZW1wbGF0ZUNvbnRlbnREb2N1bWVudEZy YWdtZW50OjpjcmVhdGUoKmRvY3VtZW50KCkuZW5zdXJlVGVtcGxhdGVEb2N1bWVudCgpLCB0aGlz KTsKKyAgICAgICAgbV9jb250ZW50ID0gVGVtcGxhdGVDb250ZW50RG9jdW1lbnRGcmFnbWVudDo6 Y3JlYXRlKGRvY3VtZW50KCkuZW5zdXJlVGVtcGxhdGVEb2N1bWVudCgpLCB0aGlzKTsKIAogICAg IHJldHVybiBtX2NvbnRlbnQuZ2V0KCk7CiB9CkBAIC04NCw3ICs4NCw3IEBAIHZvaWQgSFRNTFRl bXBsYXRlRWxlbWVudDo6ZGlkTW92ZVRvTmV3RG9jdW1lbnQoRG9jdW1lbnQqIG9sZERvY3VtZW50 KQogICAgIEhUTUxFbGVtZW50OjpkaWRNb3ZlVG9OZXdEb2N1bWVudChvbGREb2N1bWVudCk7CiAg ICAgaWYgKCFtX2NvbnRlbnQpCiAgICAgICAgIHJldHVybjsKLSAgICBkb2N1bWVudCgpLmVuc3Vy ZVRlbXBsYXRlRG9jdW1lbnQoKS0+YWRvcHRJZk5lZWRlZChtX2NvbnRlbnQuZ2V0KCkpOworICAg IGRvY3VtZW50KCkuZW5zdXJlVGVtcGxhdGVEb2N1bWVudCgpLmFkb3B0SWZOZWVkZWQobV9jb250 ZW50LmdldCgpKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=