137031 2014-09-23 11:05:39 -0700 [Tools] git-commit uses wrong ChangeLog when run from a subdirectory 2014-09-23 13:54:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble oldest_to_newest 1036759 0 jer.noble 2014-09-23 11:05:39 -0700 [Tools] git-commit uses wrong ChangeLog when run from a subdirectory 1036760 1 238548 jer.noble 2014-09-23 11:09:05 -0700 Created attachment 238548 Patch 1036763 2 238549 jer.noble 2014-09-23 11:11:19 -0700 Created attachment 238549 Patch 1036809 3 238548 joepeck 2014-09-23 13:10:43 -0700 Comment on attachment 238548 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238548&action=review r=me! > Tools/Scripts/commit-log-editor:155 > +@changeLogs = map { $ENV{GIT_PREFIX} . $_} @changeLogs if (isGit()); Nit: Should have a space at the end of the inside block Nit: Unnecessary parens around the if condition when it is at the end of the line: @changeLogs = map { $ENV{GIT_PREFIX} . $_ } @changeLogs if isGit(); 1036826 4 jer.noble 2014-09-23 13:54:28 -0700 Committed r173887: <http://trac.webkit.org/changeset/173887> 238548 2014-09-23 11:09:05 -0700 2014-09-23 13:10:42 -0700 Patch bug-137031-20140923110904.patch text/plain 1567 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNzkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYThlMmYyZjM1MjNiODc0NzUxMzAyMTc4YzQxZjZiYmVj NTQyZTQ1Yy4uNjJkYjc4MDFmM2QwMTE3ZWI5YmE5ZmQzZTQ4ODIxMTcyYTUwZjZjMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE0LTA5LTIzICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAg ICAgIFtUb29sc10gZ2l0LWNvbW1pdCB1c2VzIHdyb25nIENoYW5nZUxvZyB3aGVuIHJ1biBmcm9t IGEgc3ViZGlyZWN0b3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzcwMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBjb21taXQtbG9nLWVkaXRvciBpcyBydW4gZnJvbSB0aGUgdG9wIG9mIHRoZSBHaXQg Y2hlY2tvdXQsIGV2ZW4gd2hlbiBnaXQtY29tbWl0IGlzIGludm9rZWQKKyAgICAgICAgZnJvbSBh IHN1YmRpcmVjdG9yeSwgbWFraW5nIHRoZSBwYXJzZWQgbG9jYXRpb25zIG9mIENoYW5nZUxvZyBm aWxlcyBpbmNvcnJlY3QuIEdpdCBwcm92aWRlcworICAgICAgICBhIG1hcHBpbmcgcHJlZml4IGlu IHRoZSBHSVRfUFJFRklYIGVudmlyb25tZW50IHZhcmlhYmxlLCBzbyBhcHBseSB0aGlzIHByZWZp eCB0byB0aGUgcGFyc2VkCisgICAgICAgIENoYW5nZUxvZyBsb2NhdGlvbnMgYmVmb3JlIHBhc3Np bmcgdGhlbSB0byBjcmVhdGVDb21taXRNZXNzYWdlKCkuCisKKyAgICAgICAgKiBTY3JpcHRzL2Nv bW1pdC1sb2ctZWRpdG9yOgorCiAyMDE0LTA5LTE5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CiAKICAgICAgICAgSlNTdHJpbmdSZWYgbGVhayBvbiB0aGUgbGVha3MgYm90 IGFsbG9jYXRpb24gdW5kZXIgc2VsZWN0VGV4dFdpdGhDcml0ZXJpYUNhbGxiYWNrCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL2NvbW1pdC1sb2ctZWRpdG9yIGIvVG9vbHMvU2NyaXB0cy9jb21t aXQtbG9nLWVkaXRvcgppbmRleCA1NzBlZmFhMWU3OTZjMjQ2YzlkYzcwZTUzMzMwODM1OTNmYWEx NDM2Li42MmI4YzQ3MWU1ZDk4MThkMDdkZDFjMDY1NTA4YzFjYzI3MTZkMTYxIDEwMDc1NQotLS0g YS9Ub29scy9TY3JpcHRzL2NvbW1pdC1sb2ctZWRpdG9yCisrKyBiL1Rvb2xzL1NjcmlwdHMvY29t bWl0LWxvZy1lZGl0b3IKQEAgLTE1Miw2ICsxNTIsOCBAQCB3aGlsZSAobXkgJGN1ckxpbmUgPSA8 TE9HPikgewogfQogY2xvc2UgTE9HOwogCitAY2hhbmdlTG9ncyA9IG1hcCB7ICRFTlZ7R0lUX1BS RUZJWH0gLiAkX30gQGNoYW5nZUxvZ3MgaWYgKGlzR2l0KCkpOworCiAjIFdlIHdhbnQgdG8gbWF0 Y2ggdGhlIGxpbmUgZW5kaW5ncyBvZiB0aGUgZXhpc3RpbmcgbG9nIGZpbGUgaW4gY2FzZSB0aGV5 J3JlCiAjIGRpZmZlcmVudCBmcm9tIHBlcmwncyBsaW5lIGVuZGluZ3MuCiAkZW5kbCA9ICQxIGlm ICRsb2dDb250ZW50cyA9fiAvKFxyP1xuKS87Cg== 238549 2014-09-23 11:11:19 -0700 2014-09-23 12:28:16 -0700 Patch bug-137031-20140923111118.patch text/plain 3519 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2ZkZmVmMmM3NDYxMTI1 MzA4ZmMwNDhmN2RmMzcyY2YzNmRiNTA5Yi4uMDExM2ZjMWFjMjAyMGRjMGFjYWI2NjBjNjJlMzIw MzM0MDY2YTZlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE0LTA5LTIzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtUb29sc10gZ2l0LWNvbW1p dCB1c2VzIHdyb25nIENoYW5nZUxvZyB3aGVuIHJ1biBmcm9tIGEgc3ViZGlyZWN0b3J5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzcwMzEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9t YWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tGdWxsU2Ny ZWVuV2luZG93Q29udHJvbGxlciBiZWdhbkVudGVyRnVsbFNjcmVlbldpdGhJbml0aWFsRnJhbWU6 ZmluYWxGcmFtZTpdKToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBm aW5pc2hlZEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uOl0pOgorCisyMDE0LTA5LTIzICBKZXIgTm9i bGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNzExOTcp OiBDbGlwJ3MgY29udGVudCBpcyBkcmF3biBiZWhpbmQgU2FmYXJpIHdpbmRvdyB3aGVuIGVudGVy aW5nIEZ1bGwgU2NyZWVuIHlvdXR1YmUgaHRtbDUgZmlyc3QgdGltZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3MDI5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gcjE3MTE5Nywgd2Ugb3JkZXJlZCB0 aGUgZnVsbCBzY3JlZW4gd2luZG93IG9uLSBhbmQgb2ZmLXNjcmVlbiBzbyB0aGF0IHRoZSBmdWxs c2NyZWVuIGFuaW1hdGlvbiB3ZW50IHRvIHRoZQorICAgICAgICBjb3JyZWN0IHNjcmVlbiwgd2hp Y2ggaW50cm9kdWNlZCBhIHN1Ymx0bGUgZ2xpdGNoIGF0IHRoZSBiZWdpbm5pbmcgYW5kIGVuZCBv ZiBhbiBhbmltYXRpb24uIEZvciBlbnRlcmluZywgZW5zdXJlCisgICAgICAgIHRoYXQgdGhlIHdp bmRvdyBpcyBzY2FsZWQgdG8gaXRzIHN0YXJ0aW5nIHNpemUgYmVmb3JlIG9yZGVyaW5nIG9uLXNj cmVlbi4gRm9yIGV4aXRpbmcsIG9yZGVyIHRoZSB3aW5kb3cgb2ZmLQorICAgICAgICBzY3JlZW4g YmVmb3JlIHJlc2V0dGluZyBpdHMgY2xpcHBpbmcgcmVjdC4KKworICAgICAgICAqIFVJUHJvY2Vz cy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tGdWxs U2NyZWVuV2luZG93Q29udHJvbGxlciBiZWdhbkVudGVyRnVsbFNjcmVlbldpdGhJbml0aWFsRnJh bWU6ZmluYWxGcmFtZTpdKToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxl ciBmaW5pc2hlZEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uOl0pOgorCiAyMDE0LTA5LTE5ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFdlYkNvbnRlbnQgY3Jhc2gg aW4gV2ViS2l0OjpXZWJQYWdlOjpleHBhbmRlZFJhbmdlRnJvbUhhbmRsZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVy Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250 cm9sbGVyLm1tCmluZGV4IDBiMmM3ZGYxMWRiYmViZTU3NGZiYzE5YWU4NWVhMTJhY2MyZDA2YzEu LmFhOWMxOTFmODc4OGJiYjk3MzZlNzNlZjMwZTlhNmM1NTNmMzZmMzIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5t bQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0Nv bnRyb2xsZXIubW0KQEAgLTI2Nyw2ICsyNjcsMTIgQEAgc3RhdGljIFJldGFpblB0cjxDR0ltYWdl UmVmPiBjcmVhdGVJbWFnZVdpdGhDb3BpZWREYXRhKENHSW1hZ2VSZWYgc291cmNlSW1hZ2UpCiAg ICAgaWYgKCFfYmFja2dyb3VuZFdpbmRvdykKICAgICAgICAgX2JhY2tncm91bmRXaW5kb3cgPSBj cmVhdGVCYWNrZ3JvdW5kRnVsbHNjcmVlbldpbmRvdyhOU1plcm9SZWN0KTsKIAorICAgIC8vIFRo ZSAtb3JkZXJCYWNrOiBjYWxsIGJlbG93IGNhbiBjYXVzZSB0aGUgZnVsbCBzY3JlZW4gd2luZG93 J3MgY29udGVudHMgdG8gZHJhdyBvbiB0b3Agb2YKKyAgICAvLyBhbGwgb3RoZXIgdmlzaWJsZSB3 aW5kb3dzIG9uIHRoZSBzY3JlZW4sIGRlc3BpdGUgTlNEaXNhYmxlU2NyZWVuVXBkYXRlcyBoYXZp bmcgYmVlbiBzZXQsIGFuZAorICAgIC8vIGRlc3BpdGUgYmVpbmcgZXhwbGljaXRseSBvcmRlcmVk IGJlaGluZCBhbGwgb3RoZXIgd2luZG93cy4gU2V0IHRoZSBpbml0aWFsIHNjYWxlZCBmcmFtZSBo ZXJlCisgICAgLy8gYmVmb3JlIG9yZGVyaW5nIHRoZSB3aW5kb3cgb24tc2NyZWVuIHRvIGF2b2lk IHRoaXMgZmxhc2guIDxyZGFyOi8vcHJvYmxlbS8xODMyNTA2Mz4KKyAgICBXS1dpbmRvd1NldFNj YWxlZEZyYW1lKHNlbGYud2luZG93LCBpbml0aWFsRnJhbWUsIGZpbmFsRnJhbWUpOworCiAgICAg W3NlbGYud2luZG93IG9yZGVyQmFjazogc2VsZl07IC8vIE1ha2Ugc3VyZSB0aGUgZnVsbCBzY3Jl ZW4gd2luZG93IGlzIHBhcnQgb2YgdGhlIGNvcnJlY3QgU3BhY2UuCiAgICAgW1tzZWxmIHdpbmRv d10gZW50ZXJGdWxsU2NyZWVuTW9kZTpzZWxmXTsKIH0KQEAgLTM4MywxMSArMzg5LDExIEBAIHN0 YXRpYyBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gY3JlYXRlSW1hZ2VXaXRoQ29waWVkRGF0YShDR0lt YWdlUmVmIHNvdXJjZUltYWdlKQogICAgIFtzZWxmIF9yZXBsYWNlVmlldzpfd2ViVmlld1BsYWNl aG9sZGVyLmdldCgpIHdpdGg6X3dlYlZpZXddOwogICAgIG1ha2VSZXNwb25kZXJGaXJzdFJlc3Bv bmRlcklmRGVzY2VuZGFudE9mVmlldyhfd2ViVmlldy53aW5kb3csIGZpcnN0UmVzcG9uZGVyLCBf d2ViVmlldyk7CiAKKyAgICBbW3NlbGYgd2luZG93XSBvcmRlck91dDpzZWxmXTsKKwogICAgIE5T UmVjdCB3aW5kb3dCb3VuZHMgPSBbW3NlbGYgd2luZG93XSBmcmFtZV07CiAgICAgd2luZG93Qm91 bmRzLm9yaWdpbiA9IE5TWmVyb1BvaW50OwogICAgIFdLV2luZG93U2V0Q2xpcFJlY3QoW3NlbGYg d2luZG93XSwgd2luZG93Qm91bmRzKTsKLQotICAgIFtbc2VsZiB3aW5kb3ddIG9yZGVyT3V0OnNl bGZdOwogICAgIFtbc2VsZiB3aW5kb3ddIHNldEZyYW1lOk5TWmVyb1JlY3QgZGlzcGxheTpZRVNd OwogCiAgICAgW19zY2FsZUFuaW1hdGlvbiBzdG9wQW5pbWF0aW9uXTsK