137022 2014-09-23 05:03:41 -0700 [EFL] Fix the gst-libav build on ARM Thumb2 2014-09-26 07:14:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy akiss commit-queue gyuyoung.kim zherczeg oldest_to_newest 1036701 0 ossy 2014-09-23 05:03:41 -0700 Tools/Scripts/update-webkitefl-libs fails with GCC 4.8.3 if I would like to build to ARM Thumb2 instruction set: ../../gst-libs/ext/libav/libavcodec/libavcodec.a(videodsp_armv5te.o): In function `ff_prefetch_arm': /home/oszi/WebKit/WebKitBuild/Dependencies/Source/gst-libav-1.2.1/gst-libs/ext/libav /libavcodec/arm/videodsp_armv5te.S:29:(.text+0x8): relocation truncated to fit: R_ARM_THM_JUMP19 against symbol `ff_prefetch_arm' defined in .text section in ../../gst-libs/ext/libav/libavcodec/libavcodec.a(videodsp_armv5te.o) collect2: error: ld returned 1 exit status make[3]: *** [libgstlibav.la] Error 1 make[3]: Leaving directory `/home/oszi/WebKit/WebKitBuild/Dependencies/Source/gst-libav-1.2.1/ext/libav' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/oszi/WebKit/WebKitBuild/Dependencies/Source/gst-libav-1.2.1/ext' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/oszi/WebKit/WebKitBuild/Dependencies/Source/gst-libav-1.2.1' make: *** [all] Error 2 make -j 12 ESC[1m*** Error during phase build of gst-libav: ########## Error running make -j 12 *** [19/22]ESC(BESC[m The failure occurs in the "bne ff_prefetch_arm" line in gst-libs/ext/libav/libavcodec/arm/videodsp_armv5te.S , because ff_prefetch_arm is too far from here to use Thumb2 conditional branch. Here is a similar fix in Linux kernel: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a75e5248c51af1eaeed936be6bd3497b93f09685 We don't need forcing Thumb instruction set, because no code is generated for it if we use ARM instruction set. 1036702 1 238530 ossy 2014-09-23 05:05:42 -0700 Created attachment 238530 Patch 1037455 2 238530 zherczeg 2014-09-26 05:38:33 -0700 Comment on attachment 238530 Patch nice catch. r=me. 1037457 3 238530 commit-queue 2014-09-26 06:14:16 -0700 Comment on attachment 238530 Patch Clearing flags on attachment: 238530 Committed r174005: <http://trac.webkit.org/changeset/174005> 1037458 4 commit-queue 2014-09-26 06:14:19 -0700 All reviewed patches have been landed. Closing bug. 1037468 5 akiss 2014-09-26 07:14:12 -0700 GTK builds the very same version of gst-libav. Might be worth trying if the bug occurs there as well (it should IMHO) and then add the patch to that jhbuild.modules, too. 238530 2014-09-23 05:05:42 -0700 2014-09-26 06:14:15 -0700 Patch bug-137022-20140923140559.patch text/plain 1953 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmZmMGU0Y2YzNjdmNTlmMWEzNDMyMTJiMzA0NTE3ZWRk ZGMxYTBjYS4uZjVmYjVkODFhZWMwNDMwYzM2MGNmZmE3Zjk5NDM3MzJlYWMwODc3YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA5LTIzICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0VGTF0gRml4IHRoZSBnc3QtbGliYXYgYnVpbGQgb24gQVJNIFRodW1iMgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3MDIyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBlZmwvamhidWls ZC5tb2R1bGVzOgorICAgICAgICAqIGVmbC9wYXRjaGVzL2dzdC1saWJhdi5wYXRjaDogQWRkZWQu CisKIDIwMTQtMDktMjMgIFRpYm9yIE1lc3phcm9zICA8dG1lc3phcm9zLnUtc3plZ2VkQHBhcnRu ZXIuc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVubGlua1plcm9GaWxlcyBmcm9tIGJ1 aWxkLXdlYmtpdApkaWZmIC0tZ2l0IGEvVG9vbHMvZWZsL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xz L2VmbC9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggNjMyYTY2NjYwMGJiMDY4MDZlYzk2MzgxMTNjMjFm NzU2MDQ5Y2ZlNS4uNzg2NTU5NjE2YmE4YWU1OTcwYzJkMWU0Y2M1MjU2MGMxNGU2NjJmNyAxMDA2 NDQKLS0tIGEvVG9vbHMvZWZsL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9lZmwvamhidWls ZC5tb2R1bGVzCkBAIC0yNjIsNyArMjYyLDkgQEAKICAgICA8L2RlcGVuZGVuY2llcz4KICAgICA8 YnJhbmNoIHJlcG89ImdzdHJlYW1lciIKICAgICAgICAgICAgIG1vZHVsZT0iZ3N0LWxpYmF2L2dz dC1saWJhdi0xLjIuMS50YXIueHoiIHZlcnNpb249IjEuMi4xIgotICAgICAgICAgICAgaGFzaD0i c2hhMjU2OmZkMTUyYjdhZWM1NmFlNzZhZDU4Yjk3NTk5MTNhOGJmZTE3OTJiZGY2NGYyNjBkMGFj YWJhNzViNzUwNzY2NzYiLz4KKyAgICAgICAgICAgIGhhc2g9InNoYTI1NjpmZDE1MmI3YWVjNTZh ZTc2YWQ1OGI5NzU5OTEzYThiZmUxNzkyYmRmNjRmMjYwZDBhY2FiYTc1Yjc1MDc2Njc2Ij4KKyAg ICAgIDxwYXRjaCBmaWxlPSJnc3QtbGliYXYucGF0Y2giIHN0cmlwPSIxIi8+CisgICAgPC9icmFu Y2g+CiAgIDwvYXV0b3Rvb2xzPiAKIAogICA8YXV0b3Rvb2xzIGlkPSJsaWJzZWNjb21wIiBhdXRv Z2VuLXNoPSJjb25maWd1cmUiPgpkaWZmIC0tZ2l0IGEvVG9vbHMvZWZsL3BhdGNoZXMvZ3N0LWxp YmF2LnBhdGNoIGIvVG9vbHMvZWZsL3BhdGNoZXMvZ3N0LWxpYmF2LnBhdGNoCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjBjMzBlMTFmNTJlMDg1MDZhZjQ2Y2FjMzhkZjM5NjMxZGQyYTk5NjYKLS0tIC9kZXYvbnVsbAor KysgYi9Ub29scy9lZmwvcGF0Y2hlcy9nc3QtbGliYXYucGF0Y2gKQEAgLTAsMCArMSwxMCBAQAor LS0tIGEvZ3N0LWxpYnMvZXh0L2xpYmF2L2xpYmF2Y29kZWMvYXJtL3ZpZGVvZHNwX2FybXY1dGUu UworKysrIGIvZ3N0LWxpYnMvZXh0L2xpYmF2L2xpYmF2Y29kZWMvYXJtL3ZpZGVvZHNwX2FybXY1 dGUuUworQEAgLTI2LDYgKzI2LDcgQEAKKyAgICAgICAgIHN1YnMgICAgICAgICAgICByMiwgIHIy LCAgIzEKKyAgICAgICAgIHBsZCAgICAgICAgICAgICBbcjBdCisgICAgICAgICBhZGQgICAgICAg ICAgICAgcjAsICByMCwgIHIxCisrICAgICAgICBpdCAgICAgICAgICAgICAgbmUKKyAgICAgICAg IGJuZSAgICAgICAgICAgICBmZl9wcmVmZXRjaF9hcm0KKyAgICAgICAgIGJ4ICAgICAgICAgICAg ICBscgorIGVuZGZ1bmMK