137001 2014-09-22 06:57:16 -0700 [CSSRegions] Use nullptr in regions code 2014-09-22 07:48:04 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihnea webkit-unassigned commit-queue esprehn+autocc glenn kangil.han kondapallykalyan WebkitBugTracker oldest_to_newest 1036523 0 mihnea 2014-09-22 06:57:16 -0700 Use nullptr in regions code, following the missed nullptr in https://bugs.webkit.org/show_bug.cgi?id=136918. 1036525 1 238480 mihnea 2014-09-22 06:59:43 -0700 Created attachment 238480 Patch 1036526 2 238480 abucur 2014-09-22 07:03:47 -0700 Comment on attachment 238480 Patch r=me 1036529 3 238480 commit-queue 2014-09-22 07:47:59 -0700 Comment on attachment 238480 Patch Clearing flags on attachment: 238480 Committed r173835: <http://trac.webkit.org/changeset/173835> 1036530 4 commit-queue 2014-09-22 07:48:04 -0700 All reviewed patches have been landed. Closing bug. 238480 2014-09-22 06:59:43 -0700 2014-09-22 07:47:58 -0700 Patch 137001.patch text/plain 7564 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZmVkMTUyLi43NjVlMzcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTQtMDktMjIgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdIFVzZSBudWxscHRyIGluIHJlZ2lvbnMgY29kZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3MDAxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIG5v IG5ldyBmdW5jdGlvbmFsaXR5IGlzIGludHJvZHVjZWQuCisKKyAgICAgICAgKiBkb20vRE9NTmFt ZWRGbG93Q29sbGVjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01OYW1lZEZsb3dDb2xs ZWN0aW9uOjppdGVtKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTU5hbWVkRmxvd0NvbGxlY3Rpb246 Om5hbWVkSXRlbSk6CisgICAgICAgICogZG9tL05hbWVkRmxvd0NvbGxlY3Rpb24uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6TmFtZWRGbG93Q29sbGVjdGlvbjo6Zmxvd0J5TmFtZSk6CisgICAgICAg ICogZG9tL1dlYktpdE5hbWVkRmxvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJLaXROYW1l ZEZsb3c6OldlYktpdE5hbWVkRmxvdyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZsb3dU aHJlYWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxvd1RocmVhZDo6Z2V0TGF5ZXJM aXN0Rm9yUmVnaW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsb3dUaHJlYWQ6OnJlZ2lv bkZvckNvbXBvc2l0ZWRMYXllcik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbG93VGhyZWFk OjpyZWdpb25BdEJsb2NrT2Zmc2V0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsb3dUaHJl YWQ6Om1hcEZyb21GbG93VG9SZWdpb24pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxvd1Ro cmVhZDo6Zmlyc3RSZWdpb24pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxvd1RocmVhZDo6 bGFzdFJlZ2lvbik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbG93VGhyZWFkOjpjdXJyZW50 QWN0aXZlUmVuZGVyQm94KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTmFtZWRGbG93VGhy ZWFkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck5hbWVkRmxvd1RocmVhZDo6bmV4dFJl bmRlcmVyRm9yRWxlbWVudCk6CisKIDIwMTQtMDktMjEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBHZW5lcmF0ZSBFbGVtZW50IGNhc3RpbmcgaGVscGVyIGZ1bmN0 aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RPTU5hbWVkRmxvd0NvbGxlY3Rp b24uY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RPTU5hbWVkRmxvd0NvbGxlY3Rpb24uY3BwCmlu ZGV4IDM5YjM3ODQuLjVlZDhjZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9ET01O YW1lZEZsb3dDb2xsZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRE9NTmFtZWRG bG93Q29sbGVjdGlvbi5jcHAKQEAgLTQ2LDcgKzQ2LDcgQEAgdW5zaWduZWQgbG9uZyBET01OYW1l ZEZsb3dDb2xsZWN0aW9uOjpsZW5ndGgoKSBjb25zdAogUGFzc1JlZlB0cjxXZWJLaXROYW1lZEZs b3c+IERPTU5hbWVkRmxvd0NvbGxlY3Rpb246Oml0ZW0odW5zaWduZWQgbG9uZyBpbmRleCkgY29u c3QKIHsKICAgICBpZiAoaW5kZXggPj0gc3RhdGljX2Nhc3Q8dW5zaWduZWQgbG9uZz4obV9uYW1l ZEZsb3dzLnNpemUoKSkpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gbnVsbHB0 cjsKICAgICBET01OYW1lZEZsb3dTZXQ6OmNvbnN0X2l0ZXJhdG9yIGl0ID0gbV9uYW1lZEZsb3dz LmJlZ2luKCk7CiAgICAgZm9yICh1bnNpZ25lZCBsb25nIGkgPSAwOyBpIDwgaW5kZXg7ICsraSkK ICAgICAgICAgKytpdDsKQEAgLTU4LDcgKzU4LDcgQEAgUGFzc1JlZlB0cjxXZWJLaXROYW1lZEZs b3c+IERPTU5hbWVkRmxvd0NvbGxlY3Rpb246Om5hbWVkSXRlbShjb25zdCBBdG9taWNTdHJpbmcK ICAgICBET01OYW1lZEZsb3dTZXQ6OmNvbnN0X2l0ZXJhdG9yIGl0ID0gbV9uYW1lZEZsb3dzLmZp bmQ8U3RyaW5nLCBET01OYW1lZEZsb3dIYXNoVHJhbnNsYXRvcj4obmFtZSk7CiAgICAgaWYgKGl0 ICE9IG1fbmFtZWRGbG93cy5lbmQoKSkKICAgICAgICAgcmV0dXJuICppdDsKLSAgICByZXR1cm4g MDsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogYm9vbCBET01OYW1lZEZsb3dDb2xsZWN0aW9u OjpoYXNOYW1lZEl0ZW0oY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lKSBjb25zdApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL05hbWVkRmxvd0NvbGxlY3Rpb24uY3BwIGIvU291cmNlL1dl YkNvcmUvZG9tL05hbWVkRmxvd0NvbGxlY3Rpb24uY3BwCmluZGV4IGUxNDBlNGMuLmVlOTJmMDQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZEZsb3dDb2xsZWN0aW9uLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTmFtZWRGbG93Q29sbGVjdGlvbi5jcHAKQEAgLTYxLDcg KzYxLDcgQEAgV2ViS2l0TmFtZWRGbG93KiBOYW1lZEZsb3dDb2xsZWN0aW9uOjpmbG93QnlOYW1l KGNvbnN0IFN0cmluZyYgZmxvd05hbWUpCiB7CiAgICAgTmFtZWRGbG93U2V0OjppdGVyYXRvciBp dCA9IG1fbmFtZWRGbG93cy5maW5kPFN0cmluZywgTmFtZWRGbG93SGFzaFRyYW5zbGF0b3I+KGZs b3dOYW1lKTsKICAgICBpZiAoaXQgPT0gbV9uYW1lZEZsb3dzLmVuZCgpIHx8ICgqaXQpLT5mbG93 U3RhdGUoKSA9PSBXZWJLaXROYW1lZEZsb3c6OkZsb3dTdGF0ZU51bGwpCi0gICAgICAgIHJldHVy biAwOworICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIHJldHVybiAqaXQ7CiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0TmFtZWRGbG93LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9XZWJLaXROYW1lZEZsb3cuY3BwCmluZGV4IGFjMTRiMDguLjM5NWM4ODkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9XZWJLaXROYW1lZEZsb3cuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9XZWJLaXROYW1lZEZsb3cuY3BwCkBAIC00Miw3ICs0Miw3IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKIFdlYktpdE5hbWVkRmxvdzo6V2ViS2l0TmFtZWRGbG93KFBhc3NS ZWZQdHI8TmFtZWRGbG93Q29sbGVjdGlvbj4gbWFuYWdlciwgY29uc3QgQXRvbWljU3RyaW5nJiBm bG93VGhyZWFkTmFtZSkKICAgICA6IG1fZmxvd1RocmVhZE5hbWUoZmxvd1RocmVhZE5hbWUpCiAg ICAgLCBtX2Zsb3dNYW5hZ2VyKG1hbmFnZXIpCi0gICAgLCBtX3BhcmVudEZsb3dUaHJlYWQoMCkK KyAgICAsIG1fcGFyZW50Rmxvd1RocmVhZChudWxscHRyKQogewogfQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAKaW5kZXggMjQyMDE1Ni4uNTE5MWEy NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcApA QCAtMjI5LDEzICsyMjksMTMgQEAgY29uc3QgUmVuZGVyTGF5ZXJMaXN0KiBSZW5kZXJGbG93VGhy ZWFkOjpnZXRMYXllckxpc3RGb3JSZWdpb24oUmVuZGVyTmFtZWRGbG93RnIKIHsKICAgICBBU1NF UlQobV9yZWdpb25Ub0xheWVyTGlzdE1hcCk7CiAgICAgYXV0byBpdGVyYXRvciA9IG1fcmVnaW9u VG9MYXllckxpc3RNYXAtPmZpbmQocmVnaW9uKTsKLSAgICByZXR1cm4gaXRlcmF0b3IgPT0gbV9y ZWdpb25Ub0xheWVyTGlzdE1hcC0+ZW5kKCkgPyAwIDogJml0ZXJhdG9yLT52YWx1ZTsKKyAgICBy ZXR1cm4gaXRlcmF0b3IgPT0gbV9yZWdpb25Ub0xheWVyTGlzdE1hcC0+ZW5kKCkgPyBudWxscHRy IDogJml0ZXJhdG9yLT52YWx1ZTsKIH0KIAogUmVuZGVyTmFtZWRGbG93RnJhZ21lbnQqIFJlbmRl ckZsb3dUaHJlYWQ6OnJlZ2lvbkZvckNvbXBvc2l0ZWRMYXllcihSZW5kZXJMYXllciYgY2hpbGRM YXllcikKIHsKICAgICBpZiAoY2hpbGRMYXllci5yZW5kZXJlcigpLmZpeGVkUG9zaXRpb25lZFdp dGhOYW1lZEZsb3dDb250YWluaW5nQmxvY2soKSkKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAg IHJldHVybiBudWxscHRyOwogCiAgICAgaWYgKGNoaWxkTGF5ZXIucmVuZGVyQm94KCkpIHsKICAg ICAgICAgUmVuZGVyUmVnaW9uKiBzdGFydFJlZ2lvbiA9IG51bGxwdHI7CkBAIC0zOTksNyArMzk5 LDcgQEAgUmVuZGVyUmVnaW9uKiBSZW5kZXJGbG93VGhyZWFkOjpyZWdpb25BdEJsb2NrT2Zmc2V0 KGNvbnN0IFJlbmRlckJveCogY2xhbXBCb3gsIEwKICAgICAgICAgYXV0b0dlbmVyYXRlUmVnaW9u c1RvQmxvY2tPZmZzZXQob2Zmc2V0KTsKIAogICAgIGlmIChtX3JlZ2lvbkxpc3QuaXNFbXB0eSgp KQotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKICAgICBpZiAo bV9yZWdpb25MaXN0LnNpemUoKSA9PSAxICYmIGV4dGVuZExhc3RSZWdpb24pCiAgICAgICAgIHJl dHVybiBtX3JlZ2lvbkxpc3QuZmlyc3QoKTsKQEAgLTQxOCw3ICs0MTgsNyBAQCBSZW5kZXJSZWdp b24qIFJlbmRlckZsb3dUaHJlYWQ6OnJlZ2lvbkF0QmxvY2tPZmZzZXQoY29uc3QgUmVuZGVyQm94 KiBjbGFtcEJveCwgTAogICAgIFJlbmRlclJlZ2lvbiogcmVnaW9uID0gYWRhcHRlci5yZXN1bHQo KTsKICAgICBpZiAoIWNsYW1wQm94KQogICAgICAgICByZXR1cm4gcmVnaW9uOwotICAgIHJldHVy biByZWdpb24gPyBjbGFtcEJveC0+Y2xhbXBUb1N0YXJ0QW5kRW5kUmVnaW9ucyhyZWdpb24pIDog MDsKKyAgICByZXR1cm4gcmVnaW9uID8gY2xhbXBCb3gtPmNsYW1wVG9TdGFydEFuZEVuZFJlZ2lv bnMocmVnaW9uKSA6IG51bGxwdHI7CiB9CiAKIExheW91dFBvaW50IFJlbmRlckZsb3dUaHJlYWQ6 OmFkanVzdGVkUG9zaXRpb25SZWxhdGl2ZVRvT2Zmc2V0UGFyZW50KGNvbnN0IFJlbmRlckJveE1v ZGVsT2JqZWN0JiBib3hNb2RlbE9iamVjdCwgY29uc3QgTGF5b3V0UG9pbnQmIHN0YXJ0UG9pbnQp CkBAIC01NDQsNyArNTQ0LDcgQEAgTGF5b3V0VW5pdCBSZW5kZXJGbG93VGhyZWFkOjpwYWdlUmVt YWluaW5nTG9naWNhbEhlaWdodEZvck9mZnNldChMYXlvdXRVbml0IG9mZnMKIFJlbmRlclJlZ2lv biogUmVuZGVyRmxvd1RocmVhZDo6bWFwRnJvbUZsb3dUb1JlZ2lvbihUcmFuc2Zvcm1TdGF0ZSYg dHJhbnNmb3JtU3RhdGUpIGNvbnN0CiB7CiAgICAgaWYgKCFoYXNWYWxpZFJlZ2lvbkluZm8oKSkK LSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJldHVybiBudWxscHRyOwogCiAgICAgUmVuZGVy UmVnaW9uKiByZW5kZXJSZWdpb24gPSBjdXJyZW50UmVnaW9uKCk7CiAgICAgaWYgKCFyZW5kZXJS ZWdpb24pIHsKQEAgLTU1NCw3ICs1NTQsNyBAQCBSZW5kZXJSZWdpb24qIFJlbmRlckZsb3dUaHJl YWQ6Om1hcEZyb21GbG93VG9SZWdpb24oVHJhbnNmb3JtU3RhdGUmIHRyYW5zZm9ybVN0YQogICAg ICAgICBMYXlvdXRQb2ludCBjZW50ZXIgPSBib3hSZWN0LmNlbnRlcigpOwogICAgICAgICByZW5k ZXJSZWdpb24gPSBjb25zdF9jYXN0PFJlbmRlckZsb3dUaHJlYWQqPih0aGlzKS0+cmVnaW9uQXRC bG9ja09mZnNldCh0aGlzLCBpc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gY2VudGVyLnkoKSA6 IGNlbnRlci54KCksIHRydWUsIERpc2FsbG93UmVnaW9uQXV0b0dlbmVyYXRpb24pOwogICAgICAg ICBpZiAoIXJlbmRlclJlZ2lvbikKLSAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICAgICAg cmV0dXJuIG51bGxwdHI7CiAgICAgfQogCiAgICAgTGF5b3V0UmVjdCBmbGlwcGVkUmVnaW9uUmVj dChyZW5kZXJSZWdpb24tPmZsb3dUaHJlYWRQb3J0aW9uUmVjdCgpKTsKQEAgLTY5NCwxNCArNjk0 LDE0IEBAIExheW91dFVuaXQgUmVuZGVyRmxvd1RocmVhZDo6Y29udGVudExvZ2ljYWxMZWZ0T2ZG aXJzdFJlZ2lvbigpIGNvbnN0CiBSZW5kZXJSZWdpb24qIFJlbmRlckZsb3dUaHJlYWQ6OmZpcnN0 UmVnaW9uKCkgY29uc3QKIHsKICAgICBpZiAoIWhhc1JlZ2lvbnMoKSkKLSAgICAgICAgcmV0dXJu IDA7CisgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIHJldHVybiBtX3JlZ2lvbkxpc3QuZmly c3QoKTsKIH0KIAogUmVuZGVyUmVnaW9uKiBSZW5kZXJGbG93VGhyZWFkOjpsYXN0UmVnaW9uKCkg Y29uc3QKIHsKICAgICBpZiAoIWhhc1JlZ2lvbnMoKSkKLSAgICAgICAgcmV0dXJuIDA7CisgICAg ICAgIHJldHVybiBudWxscHRyOwogICAgIHJldHVybiBtX3JlZ2lvbkxpc3QubGFzdCgpOwogfQog CkBAIC0xMTkxLDEwICsxMTkxLDEwIEBAIHZvaWQgUmVuZGVyRmxvd1RocmVhZDo6Y2xlYXJPZmZz ZXRGcm9tTG9naWNhbFRvcE9mRmlyc3RSZWdpb24oY29uc3QgUmVuZGVyQm94KiBiCiBjb25zdCBS ZW5kZXJCb3gqIFJlbmRlckZsb3dUaHJlYWQ6OmN1cnJlbnRBY3RpdmVSZW5kZXJCb3goKSBjb25z dAogewogICAgIGlmIChtX2FjdGl2ZU9iamVjdHNTdGFjay5pc0VtcHR5KCkpCi0gICAgICAgIHJl dHVybiAwOworICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIGNvbnN0IFJlbmRlck9iamVj dCogY3VycmVudE9iamVjdCA9IG1fYWN0aXZlT2JqZWN0c1N0YWNrLmxhc3QoKTsKLSAgICByZXR1 cm4gY3VycmVudE9iamVjdC0+aXNCb3goKSA/IHRvUmVuZGVyQm94KGN1cnJlbnRPYmplY3QpIDog MDsKKyAgICByZXR1cm4gY3VycmVudE9iamVjdC0+aXNCb3goKSA/IHRvUmVuZGVyQm94KGN1cnJl bnRPYmplY3QpIDogbnVsbHB0cjsKIH0KIAogdm9pZCBSZW5kZXJGbG93VGhyZWFkOjpwdXNoRmxv d1RocmVhZExheW91dFN0YXRlKGNvbnN0IFJlbmRlck9iamVjdCYgb2JqZWN0KQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck5hbWVkRmxvd1RocmVhZC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTmFtZWRGbG93VGhyZWFkLmNwcAppbmRleCA5 ZDk0ZTBhLi43MDU3Y2FkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTmFtZWRGbG93VGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTmFtZWRGbG93VGhyZWFkLmNwcApAQCAtMTA2LDcgKzEwNiw3IEBAIFJlbmRlckVsZW1lbnQq IFJlbmRlck5hbWVkRmxvd1RocmVhZDo6bmV4dFJlbmRlcmVyRm9yRWxlbWVudChFbGVtZW50JiBl bGVtZW50KSBjCiAgICAgICAgICAgICByZXR1cm4gY2hpbGQ7CiAgICAgfQogCi0gICAgcmV0dXJu IDA7CisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIHZvaWQgUmVuZGVyTmFtZWRGbG93VGhyZWFk OjphZGRGbG93Q2hpbGQoUmVuZGVyRWxlbWVudCYgbmV3Q2hpbGQpCg==