136992 2014-09-21 21:14:30 -0700 FTL should store the four bytes of the cell header using a 32-bit store rather than four 8-bit stores 2014-09-22 08:35:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 136330 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver ossy sam oldest_to_newest 1036424 0 fpizlo 2014-09-21 21:14:30 -0700 It's totally possible that LLVM was combining these stores. But, I'm about to reorganize this code in a way that might make it harder for LLVM to infer this, so I'd rather make it explicit on the FTL side. 1036425 1 238448 fpizlo 2014-09-21 21:19:28 -0700 Created attachment 238448 the patch 1036426 2 238449 fpizlo 2014-09-21 21:20:34 -0700 Created attachment 238449 the patch For real this time. 1036427 3 238449 fpizlo 2014-09-21 21:21:17 -0700 Comment on attachment 238449 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=238449&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4867 > - > + Reverted locally. > Source/JavaScriptCore/runtime/Structure.h:342 > - > + Reverted locally. 1036434 4 ossy 2014-09-21 23:09:22 -0700 (In reply to comment #2) > Created an attachment (id=238449) [details] > the patch > > For real this time. Please add changelog entry for this patch. 1036435 5 fpizlo 2014-09-21 23:14:55 -0700 (In reply to comment #4) > (In reply to comment #2) > > Created an attachment (id=238449) [details] [details] > > the patch > > > > For real this time. > > Please add changelog entry for this patch. Oops. 1036436 6 238452 fpizlo 2014-09-21 23:17:33 -0700 Created attachment 238452 the patch Including ChangeLog. 1036537 7 fpizlo 2014-09-22 08:35:40 -0700 Landed in http://trac.webkit.org/changeset/173837 238448 2014-09-21 21:19:28 -0700 2014-09-21 21:20:34 -0700 the patch blah.patch text/plain 4813 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFwLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXAuaAkocmV2 aXNpb24gMTczNzk4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhl YXAuaAkod29ya2luZyBjb3B5KQpAQCAtNzIsNiArNzIsMTEgQEAgcHVibGljOgogICAgICAgICBt X3BhcmVudCA9IHBhcmVudDsKICAgICAgICAgbV9oZWFwTmFtZSA9IGhlYXBOYW1lOwogICAgIH0K KyAgICAKKyAgICB2b2lkIGNoYW5nZVBhcmVudChBYnN0cmFjdEhlYXAqIHBhcmVudCkKKyAgICB7 CisgICAgICAgIG1fcGFyZW50ID0gcGFyZW50OworICAgIH0KIAogICAgIEFic3RyYWN0SGVhcCog cGFyZW50KCkgY29uc3QKICAgICB7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFwUmVwb3NpdG9yeS5jcHAJKHJldmlzaW9uIDE3Mzc5 OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFwUmVwb3NpdG9y eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxLDYgKzYxLDE3IEBAIEFic3RyYWN0SGVhcFJlcG9z aXRvcnk6OkFic3RyYWN0SGVhcFJlcG8KICAgICAsIG1fY29udGV4dChjb250ZXh0KQogICAgICwg bV90YmFhS2luZChtZEtpbmRJRChtX2NvbnRleHQsICJ0YmFhIikpCiB7CisgICAgLy8gTWFrZSBz dXJlIHRoYXQgb3VyIGV4cGxpY2l0IGFzc3VtcHRpb25zIGFib3V0IHRoZSBTdHJ1Y3R1cmVJREJs b2IgbWF0Y2ggcmVhbGl0eS4KKyAgICBSRUxFQVNFX0FTU0VSVCghKEpTQ2VsbF9pbmRleGluZ1R5 cGUub2Zmc2V0KCkgJiAoc2l6ZW9mKGludDMyX3QpIC0gMSkpKTsKKyAgICBSRUxFQVNFX0FTU0VS VChKU0NlbGxfaW5kZXhpbmdUeXBlLm9mZnNldCgpICsgMSA9PSBKU0NlbGxfdHlwZUluZm9UeXBl Lm9mZnNldCgpKTsKKyAgICBSRUxFQVNFX0FTU0VSVChKU0NlbGxfaW5kZXhpbmdUeXBlLm9mZnNl dCgpICsgMiA9PSBKU0NlbGxfdHlwZUluZm9GbGFncy5vZmZzZXQoKSk7CisgICAgUkVMRUFTRV9B U1NFUlQoSlNDZWxsX2luZGV4aW5nVHlwZS5vZmZzZXQoKSArIDMgPT0gSlNDZWxsX2djRGF0YS5v ZmZzZXQoKSk7CisKKyAgICBKU0NlbGxfaW5kZXhpbmdUeXBlLmNoYW5nZVBhcmVudCgmSlNDZWxs X3VzZWZ1bEJ5dGVzKTsKKyAgICBKU0NlbGxfdHlwZUluZm9UeXBlLmNoYW5nZVBhcmVudCgmSlND ZWxsX3VzZWZ1bEJ5dGVzKTsKKyAgICBKU0NlbGxfdHlwZUluZm9GbGFncy5jaGFuZ2VQYXJlbnQo JkpTQ2VsbF91c2VmdWxCeXRlcyk7CisgICAgSlNDZWxsX2djRGF0YS5jaGFuZ2VQYXJlbnQoJkpT Q2VsbF91c2VmdWxCeXRlcyk7CisgICAgCiAgICAgcm9vdC5tX3RiYWFNZXRhZGF0YSA9IG1kTm9k ZShtX2NvbnRleHQsIG1kU3RyaW5nKG1fY29udGV4dCwgcm9vdC5tX2hlYXBOYW1lKSk7CiAgICAg CiAgICAgUkVMRUFTRV9BU1NFUlQobV90YmFhS2luZCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuaAkocmV2aXNp b24gMTczNzk4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBS ZXBvc2l0b3J5LmgJKHdvcmtpbmcgY29weSkKQEAgLTUyLDYgKzUyLDcgQEAgbmFtZXNwYWNlIEpT QyB7IG5hbWVzcGFjZSBGVEwgewogICAgIG1hY3JvKEpTQXJyYXlCdWZmZXJWaWV3X21vZGUsIEpT QXJyYXlCdWZmZXJWaWV3OjpvZmZzZXRPZk1vZGUoKSkgXAogICAgIG1hY3JvKEpTQXJyYXlCdWZm ZXJWaWV3X3ZlY3RvciwgSlNBcnJheUJ1ZmZlclZpZXc6Om9mZnNldE9mVmVjdG9yKCkpIFwKICAg ICBtYWNybyhKU0NlbGxfc3RydWN0dXJlSUQsIEpTQ2VsbDo6c3RydWN0dXJlSURPZmZzZXQoKSkg XAorICAgIG1hY3JvKEpTQ2VsbF91c2VmdWxCeXRlcywgSlNDZWxsOjppbmRleGluZ1R5cGVPZmZz ZXQoKSkgXAogICAgIG1hY3JvKEpTQ2VsbF90eXBlSW5mb0ZsYWdzLCBKU0NlbGw6OnR5cGVJbmZv RmxhZ3NPZmZzZXQoKSkgXAogICAgIG1hY3JvKEpTQ2VsbF90eXBlSW5mb1R5cGUsIEpTQ2VsbDo6 dHlwZUluZm9UeXBlT2Zmc2V0KCkpIFwKICAgICBtYWNybyhKU0NlbGxfaW5kZXhpbmdUeXBlLCBK U0NlbGw6OmluZGV4aW5nVHlwZU9mZnNldCgpKSBcCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTczNzk4KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ4NTcsMTMgKzQ4NTcsMzAgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIGFsbG9j YXRvciwgbV9oZWFwcy5NYXJrZWRBbGxvY2F0b3JfZnJlZUxpc3RIZWFkKTsKICAgICAgICAgCiAg ICAgICAgIG1fb3V0LnN0b3JlMzIobV9vdXQuY29uc3RJbnQzMihzdHJ1Y3R1cmUtPmlkKCkpLCBy ZXN1bHQsIG1faGVhcHMuSlNDZWxsX3N0cnVjdHVyZUlEKTsKLSAgICAgICAgbV9vdXQuc3RvcmU4 KG1fb3V0LmNvbnN0SW50OChzdHJ1Y3R1cmUtPmluZGV4aW5nVHlwZSgpKSwgcmVzdWx0LCBtX2hl YXBzLkpTQ2VsbF9pbmRleGluZ1R5cGUpOwotICAgICAgICBtX291dC5zdG9yZTgobV9vdXQuY29u c3RJbnQ4KHN0cnVjdHVyZS0+dHlwZUluZm8oKS50eXBlKCkpLCByZXN1bHQsIG1faGVhcHMuSlND ZWxsX3R5cGVJbmZvVHlwZSk7Ci0gICAgICAgIG1fb3V0LnN0b3JlOChtX291dC5jb25zdEludDgo c3RydWN0dXJlLT50eXBlSW5mbygpLmlubGluZVR5cGVGbGFncygpKSwgcmVzdWx0LCBtX2hlYXBz LkpTQ2VsbF90eXBlSW5mb0ZsYWdzKTsKLSAgICAgICAgbV9vdXQuc3RvcmU4KG1fb3V0LmNvbnN0 SW50OChKU0NlbGw6Ok5vdE1hcmtlZCksIHJlc3VsdCwgbV9oZWFwcy5KU0NlbGxfZ2NEYXRhKTsK KyAgICAgICAgCisgICAgICAgIG1fb3V0LnN0b3JlMzIoCisgICAgICAgICAgICBtX291dC5jb25z dEludDMyKHN0cnVjdHVyZS0+b2JqZWN0SW5pdGlhbGl6YXRpb25CbG9iKCkpLAorICAgICAgICAg ICAgcmVzdWx0LCBtX2hlYXBzLkpTQ2VsbF91c2VmdWxCeXRlcyk7CiAgICAgICAgIAogICAgICAg ICByZXR1cm4gcmVzdWx0OwogICAgIH0KKyAgICAKKyAgICB1aW50MzJfdCBidWlsZFVzZWZ1bENl bGxCeXRlcyhTdHJ1Y3R1cmUqIHN0cnVjdHVyZSkKKyAgICB7CisgICAgICAgIHVuaW9uIHsKKyAg ICAgICAgICAgIHVpbnQzMl90IHdvcmQ7CisgICAgICAgICAgICB1aW50OF90IGJ5dGVzWzRdOwor ICAgICAgICB9IHU7CisgICAgICAgIAorICAgICAgICBwdHJkaWZmX3QgYmFzZSA9IG1faGVhcHMu SlNDZWxsX3VzZWZ1bEJ5dGVzLm9mZnNldCgpOworICAgICAgICAKKyAgICAgICAgdS5ieXRlc1tt X2hlYXBzLkpTQ2VsbF9pbmRleGluZ1R5cGUub2Zmc2V0KCkgLSBiYXNlXSA9IHN0cnVjdHVyZS0+ aW5kZXhpbmdUeXBlKCk7CisgICAgICAgIHUuYnl0ZXNbbV9oZWFwcy5KU0NlbGxfdHlwZUluZm9U eXBlLm9mZnNldCgpIC0gYmFzZV0gPSBzdHJ1Y3R1cmUtPnR5cGVJbmZvKCkudHlwZSgpOworICAg ICAgICB1LmJ5dGVzW21faGVhcHMuSlNDZWxsX3R5cGVJbmZvRmxhZ3Mub2Zmc2V0KCkgLSBiYXNl XSA9IHN0cnVjdHVyZS0+dHlwZUluZm8oKS5pbmxpbmVUeXBlRmxhZ3MoKTsKKyAgICAgICAgdS5i eXRlc1ttX2hlYXBzLkpTQ2VsbF9nY0RhdGEub2Zmc2V0KCkgLSBiYXNlXSA9IEpTQ2VsbDo6Tm90 TWFya2VkOworICAgICAgICAKKyAgICAgICAgcmV0dXJuIHUud29yZDsKKyAgICB9CiAKICAgICBM VmFsdWUgYWxsb2NhdGVPYmplY3QoCiAgICAgICAgIExWYWx1ZSBhbGxvY2F0b3IsIFN0cnVjdHVy ZSogc3RydWN0dXJlLCBMVmFsdWUgYnV0dGVyZmx5LCBMQmFzaWNCbG9jayBzbG93UGF0aCkKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCShyZXZpc2lvbiAx NzM3OTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUuaAkod29y a2luZyBjb3B5KQpAQCAtMzM5LDcgKzMzOSw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgIGFsbG9j YXRlUmFyZURhdGEodm0pOwogICAgICAgICByYXJlRGF0YSgpLT5zZXRPYmplY3RUb1N0cmluZ1Zh bHVlKHZtLCB2YWx1ZSk7CiAgICAgfQotCisgICAgCiAgICAgY29uc3QgQ2xhc3NJbmZvKiBjbGFz c0luZm8oKSBjb25zdCB7IHJldHVybiBtX2NsYXNzSW5mbzsgfQogCiAgICAgc3RhdGljIHB0cmRp ZmZfdCBzdHJ1Y3R1cmVJRE9mZnNldCgpCg== 238449 2014-09-21 21:20:34 -0700 2014-09-21 23:17:33 -0700 the patch blah.patch text/plain 4174 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFwLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXAuaAkocmV2 aXNpb24gMTczNzk4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhl YXAuaAkod29ya2luZyBjb3B5KQpAQCAtNzIsNiArNzIsMTEgQEAgcHVibGljOgogICAgICAgICBt X3BhcmVudCA9IHBhcmVudDsKICAgICAgICAgbV9oZWFwTmFtZSA9IGhlYXBOYW1lOwogICAgIH0K KyAgICAKKyAgICB2b2lkIGNoYW5nZVBhcmVudChBYnN0cmFjdEhlYXAqIHBhcmVudCkKKyAgICB7 CisgICAgICAgIG1fcGFyZW50ID0gcGFyZW50OworICAgIH0KIAogICAgIEFic3RyYWN0SGVhcCog cGFyZW50KCkgY29uc3QKICAgICB7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFwUmVwb3NpdG9yeS5jcHAJKHJldmlzaW9uIDE3Mzc5 OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFwUmVwb3NpdG9y eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxLDYgKzYxLDE3IEBAIEFic3RyYWN0SGVhcFJlcG9z aXRvcnk6OkFic3RyYWN0SGVhcFJlcG8KICAgICAsIG1fY29udGV4dChjb250ZXh0KQogICAgICwg bV90YmFhS2luZChtZEtpbmRJRChtX2NvbnRleHQsICJ0YmFhIikpCiB7CisgICAgLy8gTWFrZSBz dXJlIHRoYXQgb3VyIGV4cGxpY2l0IGFzc3VtcHRpb25zIGFib3V0IHRoZSBTdHJ1Y3R1cmVJREJs b2IgbWF0Y2ggcmVhbGl0eS4KKyAgICBSRUxFQVNFX0FTU0VSVCghKEpTQ2VsbF9pbmRleGluZ1R5 cGUub2Zmc2V0KCkgJiAoc2l6ZW9mKGludDMyX3QpIC0gMSkpKTsKKyAgICBSRUxFQVNFX0FTU0VS VChKU0NlbGxfaW5kZXhpbmdUeXBlLm9mZnNldCgpICsgMSA9PSBKU0NlbGxfdHlwZUluZm9UeXBl Lm9mZnNldCgpKTsKKyAgICBSRUxFQVNFX0FTU0VSVChKU0NlbGxfaW5kZXhpbmdUeXBlLm9mZnNl dCgpICsgMiA9PSBKU0NlbGxfdHlwZUluZm9GbGFncy5vZmZzZXQoKSk7CisgICAgUkVMRUFTRV9B U1NFUlQoSlNDZWxsX2luZGV4aW5nVHlwZS5vZmZzZXQoKSArIDMgPT0gSlNDZWxsX2djRGF0YS5v ZmZzZXQoKSk7CisKKyAgICBKU0NlbGxfaW5kZXhpbmdUeXBlLmNoYW5nZVBhcmVudCgmSlNDZWxs X3VzZWZ1bEJ5dGVzKTsKKyAgICBKU0NlbGxfdHlwZUluZm9UeXBlLmNoYW5nZVBhcmVudCgmSlND ZWxsX3VzZWZ1bEJ5dGVzKTsKKyAgICBKU0NlbGxfdHlwZUluZm9GbGFncy5jaGFuZ2VQYXJlbnQo JkpTQ2VsbF91c2VmdWxCeXRlcyk7CisgICAgSlNDZWxsX2djRGF0YS5jaGFuZ2VQYXJlbnQoJkpT Q2VsbF91c2VmdWxCeXRlcyk7CisgICAgCiAgICAgcm9vdC5tX3RiYWFNZXRhZGF0YSA9IG1kTm9k ZShtX2NvbnRleHQsIG1kU3RyaW5nKG1fY29udGV4dCwgcm9vdC5tX2hlYXBOYW1lKSk7CiAgICAg CiAgICAgUkVMRUFTRV9BU1NFUlQobV90YmFhS2luZCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuaAkocmV2aXNp b24gMTczNzk4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBS ZXBvc2l0b3J5LmgJKHdvcmtpbmcgY29weSkKQEAgLTUyLDYgKzUyLDcgQEAgbmFtZXNwYWNlIEpT QyB7IG5hbWVzcGFjZSBGVEwgewogICAgIG1hY3JvKEpTQXJyYXlCdWZmZXJWaWV3X21vZGUsIEpT QXJyYXlCdWZmZXJWaWV3OjpvZmZzZXRPZk1vZGUoKSkgXAogICAgIG1hY3JvKEpTQXJyYXlCdWZm ZXJWaWV3X3ZlY3RvciwgSlNBcnJheUJ1ZmZlclZpZXc6Om9mZnNldE9mVmVjdG9yKCkpIFwKICAg ICBtYWNybyhKU0NlbGxfc3RydWN0dXJlSUQsIEpTQ2VsbDo6c3RydWN0dXJlSURPZmZzZXQoKSkg XAorICAgIG1hY3JvKEpTQ2VsbF91c2VmdWxCeXRlcywgSlNDZWxsOjppbmRleGluZ1R5cGVPZmZz ZXQoKSkgXAogICAgIG1hY3JvKEpTQ2VsbF90eXBlSW5mb0ZsYWdzLCBKU0NlbGw6OnR5cGVJbmZv RmxhZ3NPZmZzZXQoKSkgXAogICAgIG1hY3JvKEpTQ2VsbF90eXBlSW5mb1R5cGUsIEpTQ2VsbDo6 dHlwZUluZm9UeXBlT2Zmc2V0KCkpIFwKICAgICBtYWNybyhKU0NlbGxfaW5kZXhpbmdUeXBlLCBK U0NlbGw6OmluZGV4aW5nVHlwZU9mZnNldCgpKSBcCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTczNzk4KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ4NTcsMTQgKzQ4NTcsMTQgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIGFsbG9j YXRvciwgbV9oZWFwcy5NYXJrZWRBbGxvY2F0b3JfZnJlZUxpc3RIZWFkKTsKICAgICAgICAgCiAg ICAgICAgIG1fb3V0LnN0b3JlMzIobV9vdXQuY29uc3RJbnQzMihzdHJ1Y3R1cmUtPmlkKCkpLCBy ZXN1bHQsIG1faGVhcHMuSlNDZWxsX3N0cnVjdHVyZUlEKTsKLSAgICAgICAgbV9vdXQuc3RvcmU4 KG1fb3V0LmNvbnN0SW50OChzdHJ1Y3R1cmUtPmluZGV4aW5nVHlwZSgpKSwgcmVzdWx0LCBtX2hl YXBzLkpTQ2VsbF9pbmRleGluZ1R5cGUpOwotICAgICAgICBtX291dC5zdG9yZTgobV9vdXQuY29u c3RJbnQ4KHN0cnVjdHVyZS0+dHlwZUluZm8oKS50eXBlKCkpLCByZXN1bHQsIG1faGVhcHMuSlND ZWxsX3R5cGVJbmZvVHlwZSk7Ci0gICAgICAgIG1fb3V0LnN0b3JlOChtX291dC5jb25zdEludDgo c3RydWN0dXJlLT50eXBlSW5mbygpLmlubGluZVR5cGVGbGFncygpKSwgcmVzdWx0LCBtX2hlYXBz LkpTQ2VsbF90eXBlSW5mb0ZsYWdzKTsKLSAgICAgICAgbV9vdXQuc3RvcmU4KG1fb3V0LmNvbnN0 SW50OChKU0NlbGw6Ok5vdE1hcmtlZCksIHJlc3VsdCwgbV9oZWFwcy5KU0NlbGxfZ2NEYXRhKTsK KyAgICAgICAgCisgICAgICAgIG1fb3V0LnN0b3JlMzIoCisgICAgICAgICAgICBtX291dC5jb25z dEludDMyKHN0cnVjdHVyZS0+b2JqZWN0SW5pdGlhbGl6YXRpb25CbG9iKCkpLAorICAgICAgICAg ICAgcmVzdWx0LCBtX2hlYXBzLkpTQ2VsbF91c2VmdWxCeXRlcyk7CiAgICAgICAgIAogICAgICAg ICByZXR1cm4gcmVzdWx0OwogICAgIH0KLQorICAgIAogICAgIExWYWx1ZSBhbGxvY2F0ZU9iamVj dCgKICAgICAgICAgTFZhbHVlIGFsbG9jYXRvciwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIExWYWx1 ZSBidXR0ZXJmbHksIExCYXNpY0Jsb2NrIHNsb3dQYXRoKQogICAgIHsKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCShyZXZpc2lvbiAxNzM3OTkpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUuaAkod29ya2luZyBjb3B5KQpA QCAtMzM5LDcgKzMzOSw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgIGFsbG9jYXRlUmFyZURhdGEo dm0pOwogICAgICAgICByYXJlRGF0YSgpLT5zZXRPYmplY3RUb1N0cmluZ1ZhbHVlKHZtLCB2YWx1 ZSk7CiAgICAgfQotCisgICAgCiAgICAgY29uc3QgQ2xhc3NJbmZvKiBjbGFzc0luZm8oKSBjb25z dCB7IHJldHVybiBtX2NsYXNzSW5mbzsgfQogCiAgICAgc3RhdGljIHB0cmRpZmZfdCBzdHJ1Y3R1 cmVJRE9mZnNldCgpCg== 238452 2014-09-21 23:17:33 -0700 2014-09-21 23:51:47 -0700 the patch blah.patch text/plain 4956 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTczODA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE0LTA5LTIxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIHNob3VsZCBzdG9yZSB0aGUgZm91ciBieXRlcyBvZiB0aGUgY2VsbCBoZWFkZXIgdXNpbmcg YSAzMi1iaXQgc3RvcmUgcmF0aGVyIHRoYW4gZm91ciA4LWJpdCBzdG9yZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjk5MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgTExWTSBvdWdodCB0 byBiZSBhYmxlIHRvIGRvIHRoaXMgb3B0aW1pemF0aW9uIGZvciB1cyBnaXZlbiBob3cgdGhlIGNv ZGUgd2FzIHdyaXR0ZW4sIGJ1dAorICAgICAgICBhbnkgc3VjaCBsb3dlci1sZXZlbCBhdHRlbXB0 cyB0byBvcHRpbWl6ZSB0aGlzIHdvdWxkIGdldCBpbnRvIHRyb3VibGUgd2l0aCB0aGUgd2VpcmQK KyAgICAgICAgb2JqZWN0IG1hdGVyaWFsaXphdGlvbiBsb2dpYyBJJ2xsIGJlIGludHJvZHVjaW5n IGluIGJ1ZyAxMzYzMzAuIFNvLCB0aGlzIGJyaW5ncyB0aGUKKyAgICAgICAgbWVyZ2luZyBvZiB0 aGUgYnl0ZSBzdG9yZXMgaW50byB0aGUgRlRMIGxvd2VyaW5nIHNvIHRoYXQgd2UgY2FuIGNvbnRy b2wgaXQgZXhwbGljaXRseS4KKworICAgICAgICAqIGZ0bC9GVExBYnN0cmFjdEhlYXAuaDoKKyAg ICAgICAgKEpTQzo6RlRMOjpBYnN0cmFjdEhlYXA6OmNoYW5nZVBhcmVudCk6CisgICAgICAgICog ZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OkFi c3RyYWN0SGVhcFJlcG9zaXRvcnk6OkFic3RyYWN0SGVhcFJlcG9zaXRvcnkpOgorICAgICAgICAq IGZ0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5Lmg6CisgICAgICAgICogZnRsL0ZUTExvd2Vy REZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6YWxsb2Nh dGVDZWxsKToKKwogMjAxNC0wOS0yMSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgog CiAgICAgICAgIFN0cnVjdHVyZSBzaG91bGQgaGF2ZSBhIG1ldGhvZCBmb3IgY29uY3VycmVudGx5 IGdldHRpbmcgYWxsIG9mIHRoZSBwcm9wZXJ0eSBtYXAgZW50cmllcywgYW5kIHRoaXMgbWV0aG9k IHNob3VsZG4ndCBpbnZvbHZlIGNvcHktcGFzdGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9mdGwvRlRMQWJzdHJhY3RIZWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2Z0bC9GVExBYnN0cmFjdEhlYXAuaAkocmV2aXNpb24gMTczNzk4KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXAuaAkod29ya2luZyBjb3B5KQpAQCAtNzIs NiArNzIsMTEgQEAgcHVibGljOgogICAgICAgICBtX3BhcmVudCA9IHBhcmVudDsKICAgICAgICAg bV9oZWFwTmFtZSA9IGhlYXBOYW1lOwogICAgIH0KKyAgICAKKyAgICB2b2lkIGNoYW5nZVBhcmVu dChBYnN0cmFjdEhlYXAqIHBhcmVudCkKKyAgICB7CisgICAgICAgIG1fcGFyZW50ID0gcGFyZW50 OworICAgIH0KIAogICAgIEFic3RyYWN0SGVhcCogcGFyZW50KCkgY29uc3QKICAgICB7CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFw UmVwb3NpdG9yeS5jcHAJKHJldmlzaW9uIDE3Mzc5OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9mdGwvRlRMQWJzdHJhY3RIZWFwUmVwb3NpdG9yeS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYx LDYgKzYxLDE3IEBAIEFic3RyYWN0SGVhcFJlcG9zaXRvcnk6OkFic3RyYWN0SGVhcFJlcG8KICAg ICAsIG1fY29udGV4dChjb250ZXh0KQogICAgICwgbV90YmFhS2luZChtZEtpbmRJRChtX2NvbnRl eHQsICJ0YmFhIikpCiB7CisgICAgLy8gTWFrZSBzdXJlIHRoYXQgb3VyIGV4cGxpY2l0IGFzc3Vt cHRpb25zIGFib3V0IHRoZSBTdHJ1Y3R1cmVJREJsb2IgbWF0Y2ggcmVhbGl0eS4KKyAgICBSRUxF QVNFX0FTU0VSVCghKEpTQ2VsbF9pbmRleGluZ1R5cGUub2Zmc2V0KCkgJiAoc2l6ZW9mKGludDMy X3QpIC0gMSkpKTsKKyAgICBSRUxFQVNFX0FTU0VSVChKU0NlbGxfaW5kZXhpbmdUeXBlLm9mZnNl dCgpICsgMSA9PSBKU0NlbGxfdHlwZUluZm9UeXBlLm9mZnNldCgpKTsKKyAgICBSRUxFQVNFX0FT U0VSVChKU0NlbGxfaW5kZXhpbmdUeXBlLm9mZnNldCgpICsgMiA9PSBKU0NlbGxfdHlwZUluZm9G bGFncy5vZmZzZXQoKSk7CisgICAgUkVMRUFTRV9BU1NFUlQoSlNDZWxsX2luZGV4aW5nVHlwZS5v ZmZzZXQoKSArIDMgPT0gSlNDZWxsX2djRGF0YS5vZmZzZXQoKSk7CisKKyAgICBKU0NlbGxfaW5k ZXhpbmdUeXBlLmNoYW5nZVBhcmVudCgmSlNDZWxsX3VzZWZ1bEJ5dGVzKTsKKyAgICBKU0NlbGxf dHlwZUluZm9UeXBlLmNoYW5nZVBhcmVudCgmSlNDZWxsX3VzZWZ1bEJ5dGVzKTsKKyAgICBKU0Nl bGxfdHlwZUluZm9GbGFncy5jaGFuZ2VQYXJlbnQoJkpTQ2VsbF91c2VmdWxCeXRlcyk7CisgICAg SlNDZWxsX2djRGF0YS5jaGFuZ2VQYXJlbnQoJkpTQ2VsbF91c2VmdWxCeXRlcyk7CisgICAgCiAg ICAgcm9vdC5tX3RiYWFNZXRhZGF0YSA9IG1kTm9kZShtX2NvbnRleHQsIG1kU3RyaW5nKG1fY29u dGV4dCwgcm9vdC5tX2hlYXBOYW1lKSk7CiAgICAgCiAgICAgUkVMRUFTRV9BU1NFUlQobV90YmFh S2luZCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJl cG9zaXRvcnkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEFi c3RyYWN0SGVhcFJlcG9zaXRvcnkuaAkocmV2aXNpb24gMTczNzk4KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5LmgJKHdvcmtpbmcgY29weSkK QEAgLTUyLDYgKzUyLDcgQEAgbmFtZXNwYWNlIEpTQyB7IG5hbWVzcGFjZSBGVEwgewogICAgIG1h Y3JvKEpTQXJyYXlCdWZmZXJWaWV3X21vZGUsIEpTQXJyYXlCdWZmZXJWaWV3OjpvZmZzZXRPZk1v ZGUoKSkgXAogICAgIG1hY3JvKEpTQXJyYXlCdWZmZXJWaWV3X3ZlY3RvciwgSlNBcnJheUJ1ZmZl clZpZXc6Om9mZnNldE9mVmVjdG9yKCkpIFwKICAgICBtYWNybyhKU0NlbGxfc3RydWN0dXJlSUQs IEpTQ2VsbDo6c3RydWN0dXJlSURPZmZzZXQoKSkgXAorICAgIG1hY3JvKEpTQ2VsbF91c2VmdWxC eXRlcywgSlNDZWxsOjppbmRleGluZ1R5cGVPZmZzZXQoKSkgXAogICAgIG1hY3JvKEpTQ2VsbF90 eXBlSW5mb0ZsYWdzLCBKU0NlbGw6OnR5cGVJbmZvRmxhZ3NPZmZzZXQoKSkgXAogICAgIG1hY3Jv KEpTQ2VsbF90eXBlSW5mb1R5cGUsIEpTQ2VsbDo6dHlwZUluZm9UeXBlT2Zmc2V0KCkpIFwKICAg ICBtYWNybyhKU0NlbGxfaW5kZXhpbmdUeXBlLCBKU0NlbGw6OmluZGV4aW5nVHlwZU9mZnNldCgp KSBcCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9M TFZNLmNwcAkocmV2aXNpb24gMTczNzk4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9G VExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4NTcsMTAgKzQ4NTcsMTAg QEAgcHJpdmF0ZToKICAgICAgICAgICAgIGFsbG9jYXRvciwgbV9oZWFwcy5NYXJrZWRBbGxvY2F0 b3JfZnJlZUxpc3RIZWFkKTsKICAgICAgICAgCiAgICAgICAgIG1fb3V0LnN0b3JlMzIobV9vdXQu Y29uc3RJbnQzMihzdHJ1Y3R1cmUtPmlkKCkpLCByZXN1bHQsIG1faGVhcHMuSlNDZWxsX3N0cnVj dHVyZUlEKTsKLSAgICAgICAgbV9vdXQuc3RvcmU4KG1fb3V0LmNvbnN0SW50OChzdHJ1Y3R1cmUt PmluZGV4aW5nVHlwZSgpKSwgcmVzdWx0LCBtX2hlYXBzLkpTQ2VsbF9pbmRleGluZ1R5cGUpOwot ICAgICAgICBtX291dC5zdG9yZTgobV9vdXQuY29uc3RJbnQ4KHN0cnVjdHVyZS0+dHlwZUluZm8o KS50eXBlKCkpLCByZXN1bHQsIG1faGVhcHMuSlNDZWxsX3R5cGVJbmZvVHlwZSk7Ci0gICAgICAg IG1fb3V0LnN0b3JlOChtX291dC5jb25zdEludDgoc3RydWN0dXJlLT50eXBlSW5mbygpLmlubGlu ZVR5cGVGbGFncygpKSwgcmVzdWx0LCBtX2hlYXBzLkpTQ2VsbF90eXBlSW5mb0ZsYWdzKTsKLSAg ICAgICAgbV9vdXQuc3RvcmU4KG1fb3V0LmNvbnN0SW50OChKU0NlbGw6Ok5vdE1hcmtlZCksIHJl c3VsdCwgbV9oZWFwcy5KU0NlbGxfZ2NEYXRhKTsKKyAgICAgICAgCisgICAgICAgIG1fb3V0LnN0 b3JlMzIoCisgICAgICAgICAgICBtX291dC5jb25zdEludDMyKHN0cnVjdHVyZS0+b2JqZWN0SW5p dGlhbGl6YXRpb25CbG9iKCkpLAorICAgICAgICAgICAgcmVzdWx0LCBtX2hlYXBzLkpTQ2VsbF91 c2VmdWxCeXRlcyk7CiAgICAgICAgIAogICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgIH0K