136986 2014-09-21 14:52:27 -0700 Fix post-mortem nits for r173724 2014-09-21 17:19:03 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin commit-queue darin oldest_to_newest 1036378 0 cdumez 2014-09-21 14:52:27 -0700 Fix post-mortem nits for r173724: https://bugs.webkit.org/show_bug.cgi?id=136900#c7 1036379 1 238434 cdumez 2014-09-21 15:22:09 -0700 Created attachment 238434 Patch 1036398 2 238434 commit-queue 2014-09-21 17:18:58 -0700 Comment on attachment 238434 Patch Clearing flags on attachment: 238434 Committed r173800: <http://trac.webkit.org/changeset/173800> 1036399 3 commit-queue 2014-09-21 17:19:03 -0700 All reviewed patches have been landed. Closing bug. 238434 2014-09-21 15:22:09 -0700 2014-09-21 17:18:58 -0700 Patch bug-136986-20140921152208.patch text/plain 4996 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODdmNGYxNzQ4ZjU4MGE3 YjhmODViNjU1ZDQ4OWJmZDkxNWQ0N2NlNy4uOWJlMjhkY2Q2YWQzNmMzNmQ4NGQ1YWJlZGM0YjEx ZDAxMjE3YmZkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE0LTA5LTIxICBDaHJp c3RvcGhlIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggcG9zdC1tb3J0 ZW0gbml0cyBmb3IgcjE3MzcyNAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM2OTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4IHBvc3QtbW9ydGVtIG5pdHMgZm9yIHIxNzM3MjQuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBlZGl0aW5nL0Vk aXRpbmdTdHlsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQXR0cmlidXRlRXF1aXZhbGVu dDo6YXR0cmlidXRlVmFsdWVBc0NTU1ZhbHVlKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb250 U2l6ZUVxdWl2YWxlbnQ6OmF0dHJpYnV0ZVZhbHVlQXNDU1NWYWx1ZSk6CisgICAgICAgIFVzZSBu dWxscHRyIGluc3RlYWQgb2YgMC4KKworICAgICAgICAqIGVkaXRpbmcvU3BsaXRFbGVtZW50Q29t bWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTcGxpdEVsZW1lbnRDb21tYW5kOjpkb1VuYXBw bHkpOgorICAgICAgICBVc2UgZ2V0SWRBdHRyaWJ1dGUoKSAvIHNldElkQXR0cmlidXRlKCkuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclRhYmxlQ2VsbDo6Y29tcHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMpOgorICAg ICAgICBVc2UgZmFzdEhhc0F0dHJpYnV0ZSgpIGZvciBub3dyYXAgYW5kIGRvIGFuIGVhcmx5IHJl dHVybiB0byBhdm9pZAorICAgICAgICBjYWxsaW5nIHN0eWxlT3JDb2xMb2dpY2FsV2lkdGgoKSBp ZiB0aGUgbm93cmFwIGF0dHJpYnV0ZSBpcyBtaXNzaW5nLgorCiAyMDE0LTA5LTIxICBGaWxpcCBQ aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgc3BlY3VsYXRp dmUgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0aW5n U3R5bGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0aW5nU3R5bGUuY3BwCmluZGV4 IDA0NThjYTMxN2JlZmIyNzhlY2FkNmM5MDg4YzU0NWQ3MDE2NzEyZmEuLmE5ZDZlNjFmOTNhZTZj MDY0NjllYTg4OWQ1YmM4OWFkMDM4YmZmZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvRWRpdGluZ1N0eWxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRp bmdTdHlsZS5jcHAKQEAgLTI3OSw3ICsyNzksNyBAQCBQYXNzUmVmUHRyPENTU1ZhbHVlPiBIVE1M QXR0cmlidXRlRXF1aXZhbGVudDo6YXR0cmlidXRlVmFsdWVBc0NTU1ZhbHVlKEVsZW1lbnQqCiAg ICAgQVNTRVJUKGVsZW1lbnQpOwogICAgIGNvbnN0IEF0b21pY1N0cmluZyYgdmFsdWUgPSBlbGVt ZW50LT5nZXRBdHRyaWJ1dGUobV9hdHRyTmFtZSk7CiAgICAgaWYgKHZhbHVlLmlzTnVsbCgpKQot ICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgCiAgICAgUmVm UHRyPE11dGFibGVTdHlsZVByb3BlcnRpZXM+IGR1bW15U3R5bGU7CiAgICAgZHVtbXlTdHlsZSA9 IE11dGFibGVTdHlsZVByb3BlcnRpZXM6OmNyZWF0ZSgpOwpAQCAtMzA0LDEwICszMDQsMTAgQEAg UGFzc1JlZlB0cjxDU1NWYWx1ZT4gSFRNTEZvbnRTaXplRXF1aXZhbGVudDo6YXR0cmlidXRlVmFs dWVBc0NTU1ZhbHVlKEVsZW1lbnQqIGUKICAgICBBU1NFUlQoZWxlbWVudCk7CiAgICAgY29uc3Qg QXRvbWljU3RyaW5nJiB2YWx1ZSA9IGVsZW1lbnQtPmdldEF0dHJpYnV0ZShtX2F0dHJOYW1lKTsK ICAgICBpZiAodmFsdWUuaXNOdWxsKCkpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1 cm4gbnVsbHB0cjsKICAgICBDU1NWYWx1ZUlEIHNpemU7CiAgICAgaWYgKCFIVE1MRm9udEVsZW1l bnQ6OmNzc1ZhbHVlRnJvbUZvbnRTaXplTnVtYmVyKHZhbHVlLCBzaXplKSkKLSAgICAgICAgcmV0 dXJuIDA7CisgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIHJldHVybiBDU1NQcmltaXRpdmVW YWx1ZTo6Y3JlYXRlSWRlbnRpZmllcihzaXplKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZWRpdGluZy9TcGxpdEVsZW1lbnRDb21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvU3BsaXRFbGVtZW50Q29tbWFuZC5jcHAKaW5kZXggYTAzZWY4ODc4N2IwYWQ4NDY1OTU4 NjYxNWQ5MWRkYWI3MmIwNmNiNy4uOTJlM2I5MzA1MjM5ODdjMTQ5MmY0NWQ2ODgxZmJkYjAyNWE5 OGFiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9TcGxpdEVsZW1lbnRDb21t YW5kLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1NwbGl0RWxlbWVudENvbW1hbmQu Y3BwCkBAIC05MSw5ICs5MSw5IEBAIHZvaWQgU3BsaXRFbGVtZW50Q29tbWFuZDo6ZG9VbmFwcGx5 KCkKICAgICAgICAgbV9lbGVtZW50Mi0+aW5zZXJ0QmVmb3JlKGNoaWxkcmVuW2ldLmdldCgpLCBy ZWZDaGlsZC5nZXQoKSwgSUdOT1JFX0VYQ0VQVElPTik7CiAKICAgICAvLyBSZWNvdmVyIHRoZSBp ZCBhdHRyaWJ1dGUgb2YgdGhlIG9yaWdpbmFsIGVsZW1lbnQuCi0gICAgY29uc3QgQXRvbWljU3Ry aW5nJiBpZCA9IG1fZWxlbWVudDEtPmZhc3RHZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjppZEF0dHIp OworICAgIGNvbnN0IEF0b21pY1N0cmluZyYgaWQgPSBtX2VsZW1lbnQxLT5nZXRJZEF0dHJpYnV0 ZSgpOwogICAgIGlmICghaWQuaXNOdWxsKCkpCi0gICAgICAgIG1fZWxlbWVudDItPnNldEF0dHJp YnV0ZShIVE1MTmFtZXM6OmlkQXR0ciwgaWQpOworICAgICAgICBtX2VsZW1lbnQyLT5zZXRJZEF0 dHJpYnV0ZShpZCk7CiAKICAgICBtX2VsZW1lbnQxLT5yZW1vdmUoSUdOT1JFX0VYQ0VQVElPTik7 CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxs LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwCmluZGV4 IDY4OTYyMzQ4Y2M3OGE4ZjBiMmRkZjUwMzUzYzhlMTRjZWM5NDliMTAuLmJhZjNlMjZiMGExZWI0 MGM0NTgwN2E3Y2Y2MDg3ZWYzYWUyMTcyMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUYWJsZUNlbGwuY3BwCkBAIC0xNzUsMTcgKzE3NSwxNyBAQCB2b2lkIFJlbmRlclRh YmxlQ2VsbDo6Y29tcHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMoKQogICAgIHRhYmxlKCktPnJl Y2FsY1NlY3Rpb25zSWZOZWVkZWQoKTsKIAogICAgIFJlbmRlckJsb2NrRmxvdzo6Y29tcHV0ZVBy ZWZlcnJlZExvZ2ljYWxXaWR0aHMoKTsKLSAgICBpZiAoZWxlbWVudCgpICYmIHN0eWxlKCkuYXV0 b1dyYXAoKSkgewotICAgICAgICAvLyBTZWUgaWYgbm93cmFwIHdhcyBzZXQuCi0gICAgICAgIExl bmd0aCB3ID0gc3R5bGVPckNvbExvZ2ljYWxXaWR0aCgpOwotICAgICAgICBjb25zdCBBdG9taWNT dHJpbmcmIG5vd3JhcCA9IGVsZW1lbnQoKS0+ZmFzdEdldEF0dHJpYnV0ZShub3dyYXBBdHRyKTsK LSAgICAgICAgaWYgKCFub3dyYXAuaXNOdWxsKCkgJiYgdy5pc0ZpeGVkKCkpCi0gICAgICAgICAg ICAvLyBOb3dyYXAgaXMgc2V0LCBidXQgd2UgZGlkbid0IGFjdHVhbGx5IHVzZSBpdCBiZWNhdXNl IG9mIHRoZQotICAgICAgICAgICAgLy8gZml4ZWQgd2lkdGggc2V0IG9uIHRoZSBjZWxsLiAgRXZl biBzbywgaXQgaXMgYSBXaW5JRS9Nb3ogdHJhaXQKLSAgICAgICAgICAgIC8vIHRvIG1ha2UgdGhl IG1pbndpZHRoIG9mIHRoZSBjZWxsIGludG8gdGhlIGZpeGVkIHdpZHRoLiAgVGhleSBkbyB0aGlz Ci0gICAgICAgICAgICAvLyBldmVuIGluIHN0cmljdCBtb2RlLCBzbyBkbyBub3QgbWFrZSB0aGlz IGEgcXVpcmsuICBBZmZlY3RlZCB0aGUgdG9wCi0gICAgICAgICAgICAvLyBvZiBoaXB0b3AuY29t LgotICAgICAgICAgICAgbV9taW5QcmVmZXJyZWRMb2dpY2FsV2lkdGggPSBzdGQ6Om1heDxMYXlv dXRVbml0Pih3LnZhbHVlKCksIG1fbWluUHJlZmVycmVkTG9naWNhbFdpZHRoKTsKKyAgICBpZiAo IWVsZW1lbnQoKSB8fCAhc3R5bGUoKS5hdXRvV3JhcCgpIHx8ICFlbGVtZW50KCktPmZhc3RIYXNB dHRyaWJ1dGUobm93cmFwQXR0cikpCisgICAgICAgIHJldHVybjsKKworICAgIExlbmd0aCB3ID0g c3R5bGVPckNvbExvZ2ljYWxXaWR0aCgpOworICAgIGlmICh3LmlzRml4ZWQoKSkgeworICAgICAg ICAvLyBOb3dyYXAgaXMgc2V0LCBidXQgd2UgZGlkbid0IGFjdHVhbGx5IHVzZSBpdCBiZWNhdXNl IG9mIHRoZQorICAgICAgICAvLyBmaXhlZCB3aWR0aCBzZXQgb24gdGhlIGNlbGwuIEV2ZW4gc28s IGl0IGlzIGEgV2luSUUvTW96IHRyYWl0CisgICAgICAgIC8vIHRvIG1ha2UgdGhlIG1pbndpZHRo IG9mIHRoZSBjZWxsIGludG8gdGhlIGZpeGVkIHdpZHRoLiBUaGV5IGRvIHRoaXMKKyAgICAgICAg Ly8gZXZlbiBpbiBzdHJpY3QgbW9kZSwgc28gZG8gbm90IG1ha2UgdGhpcyBhIHF1aXJrLiBBZmZl Y3RlZCB0aGUgdG9wCisgICAgICAgIC8vIG9mIGhpcHRvcC5jb20uCisgICAgICAgIG1fbWluUHJl ZmVycmVkTG9naWNhbFdpZHRoID0gc3RkOjptYXg8TGF5b3V0VW5pdD4ody52YWx1ZSgpLCBtX21p blByZWZlcnJlZExvZ2ljYWxXaWR0aCk7CiAgICAgfQogfQogCg==