136980 2014-09-20 23:20:42 -0700 Web Inspector: unlocalized 'many' string in type profiler inline bubble 2014-09-21 20:42:44 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED http://www.nihilogic.dk/labs/tetris/ InRadar P2 Normal --- 1 burg saam commit-queue graouts joepeck saam timothy webkit-bug-importer oldest_to_newest 1036327 0 burg 2014-09-20 23:20:42 -0700 I think this is supposed to be localized, right? You can see this in action on tetris.js:284 1036328 1 webkit-bug-importer 2014-09-20 23:20:55 -0700 <rdar://problem/18405527> 1036329 2 timothy 2014-09-20 23:23:21 -0700 It is debatable if they should be localized. We don't localize things that match language keywords or names. (For example the padding, margin, etc. labels in the Style Metrics pane are not localized.) 1036335 3 saam 2014-09-21 00:16:38 -0700 I think Joe and I spoke about this in a previous bug or over IRC. I think it should be localized because many JavaScript programmers will be familiar with String, Null, etc, just by programming in JavaScript, even though they may not understand the English meaning of these words. But I don't think non-English speaking programmers will immediately understand "many". 1036336 4 saam 2014-09-21 00:19:13 -0700 I guess an argument against my previous point is: It might be weird from a user experience perspective to have all type tokens be in English except the "many" token. 1036337 5 238423 saam 2014-09-21 00:41:45 -0700 Created attachment 238423 patch 1036411 6 burg 2014-09-21 18:54:50 -0700 (In reply to comment #4) > I guess an argument against my previous point is: > > It might be weird from a user experience perspective to have > all type tokens be in English except the "many" token. My inclination would be to put it in parens: (many) or call it multiple. From reading Japanese + code, it's not going to be a big shocker. But this discussion is mostly hypothetical until we get some localizers in the loop. For now, I think this should land as-is so we can start getting feedback and get rid of LOCALIZED STRING NOT FOUND. 1036414 7 238444 saam 2014-09-21 19:34:47 -0700 Created attachment 238444 patch Including parenthesis in localizable string. 1036419 8 238444 commit-queue 2014-09-21 20:42:41 -0700 Comment on attachment 238444 patch Clearing flags on attachment: 238444 Committed r173803: <http://trac.webkit.org/changeset/173803> 1036420 9 commit-queue 2014-09-21 20:42:44 -0700 All reviewed patches have been landed. Closing bug. 238423 2014-09-21 00:41:45 -0700 2014-09-21 19:34:47 -0700 patch patch2.diff text/plain 1712 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTczNzk1KQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTA5LTIxICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiB1bmxvY2FsaXplZCAnbWFueScgc3RyaW5nIGluIHR5cGUgcHJv ZmlsZXIgaW5saW5lIGJ1YmJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM2OTgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgR2VuZXJhdGUgdGhlIGxvY2FsaXphYmxlIHN0cmluZyBmb3IgdGhlIHR5cGUg cHJvZmlsZXIncyAibWFueSIgaW5saW5lIGJ1YmJsZS4KKworICAgICAgICAqIExvY2FsaXphdGlv bnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoKKwogMjAxNC0wOS0yMCAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE9w dGlvbitDbGljayBvbiBDU1MgdXJsKC4uLikgc2hvdWxkIGp1bXAgdG8gcmVzb3VyY2UgdmlldwpJ bmRleDogU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxp emVkU3RyaW5ncy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxp emF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCShyZXZpc2lvbiAxNzM3OTUpCisr KyBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRT dHJpbmdzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC00NzIsNiArNDcyLDcgQEAKIABsAG8AYwBhAGwA aQB6AGUAZABTAHQAcgBpAG4AZwBzAFsAIgBYAEgAUgBzACIAXQAgAD0AIAAiAFgASABSAHMAIgA7 AAogAGwAbwBjAGEAbABpAHoAZQBkAFMAdAByAGkAbgBnAHMAWwAiAFkAZQBzACIAXQAgAD0AIAAi AFkAZQBzACIAOwAKIABsAG8AYwBhAGwAaQB6AGUAZABTAHQAcgBpAG4AZwBzAFsAIgBsAGkAbgBl ACAAIgBdACAAPQAgACIAbABpAG4AZQAgACIAOwAKKwBsAG8AYwBhAGwAaQB6AGUAZABTAHQAcgBp AG4AZwBzAFsAIgBtAGEAbgB5ACIAXQAgAD0AIAAiAG0AYQBuAHkAIgA7AAogAGwAbwBjAGEAbABp AHoAZQBkAFMAdAByAGkAbgBnAHMAWwAiAG8AcgBpAGcAaQBuAGEAbABsAHkAIAAlAHMAIgBdACAA PQAgACIAbwByAGkAZwBpAG4AYQBsAGwAeQAgACUAcwAiADsACiAAbABvAGMAYQBsAGkAegBlAGQA UwB0AHIAaQBuAGcAcwBbACIAdQBuAGQAZQBmAGkAbgBlAGQAIADXACAAJQBkACIAXQAgAD0AIAAi AHUAbgBkAGUAZgBpAG4AZQBkACAA1wAgACUAZAAiADsACiAAbABvAGMAYQBsAGkAegBlAGQAUwB0 AHIAaQBuAGcAcwBbACIgHAAlAHMgHQAgAFAAcgBvAGYAaQBsAGUAIABSAGUAYwBvAHIAZABlAGQA IgBdACAAPQAgACIgHAAlAHMgHQAgAFAAcgBvAGYAaQBsAGUAIABSAGUAYwBvAHIAZABlAGQAIgA7 AAo= 238444 2014-09-21 19:34:47 -0700 2014-09-21 20:42:41 -0700 patch patch2.diff text/plain 2535 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTczODAyKQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA5LTIxICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiB1bmxvY2FsaXplZCAnbWFueScgc3RyaW5nIGluIHR5cGUgcHJv ZmlsZXIgaW5saW5lIGJ1YmJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM2OTgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgR2VuZXJhdGUgdGhlIGxvY2FsaXphYmxlIHN0cmluZyBmb3IgdGhlIHR5cGUg cHJvZmlsZXIncyAibWFueSIgaW5saW5lIGJ1YmJsZS4KKworICAgICAgICAqIExvY2FsaXphdGlv bnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1R5cGVUb2tlblZpZXcuanM6CisKIDIwMTQtMDktMjAgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBPcHRpb24rQ2xp Y2sgb24gQ1NTIHVybCguLi4pIHNob3VsZCBqdW1wIHRvIHJlc291cmNlIHZpZXcKSW5kZXg6IFNv dXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmlu Z3MuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMv ZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwkocmV2aXNpb24gMTczODAyKQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5q cwkod29ya2luZyBjb3B5KQpAQCAtMjcsNiArMjcsNyBAQAogAGwAbwBjAGEAbABpAHoAZQBkAFMA dAByAGkAbgBnAHMAWwAiACUAcwAgACgAaABpAGQAZABlAG4AKQAiAF0AIAA9ACAAIgAlAHMAIAAo AGgAaQBkAGQAZQBuACkAIgA7AAogAGwAbwBjAGEAbABpAHoAZQBkAFMAdAByAGkAbgBnAHMAWwAi ACUAcwAgAEUAdgBlAG4AdAAgAEQAaQBzAHAAYQB0AGMAaABlAGQAIgBdACAAPQAgACIAJQBzACAA RQB2AGUAbgB0ACAARABpAHMAcABhAHQAYwBoAGUAZAAiADsACiAAbABvAGMAYQBsAGkAegBlAGQA UwB0AHIAaQBuAGcAcwBbACIAKABhAG4AbwBuAHkAbQBvAHUAcwAgAGYAdQBuAGMAdABpAG8AbgAp ACIAXQAgAD0AIAAiACgAYQBuAG8AbgB5AG0AbwB1AHMAIABmAHUAbgBjAHQAaQBvAG4AKQAiADsA CisAbABvAGMAYQBsAGkAegBlAGQAUwB0AHIAaQBuAGcAcwBbACIAKABtAGEAbgB5ACkAIgBdACAA PQAgACIAKABtAGEAbgB5ACkAIgA7AAogAGwAbwBjAGEAbABpAHoAZQBkAFMAdAByAGkAbgBnAHMA WwAiACgAcAByAG8AZwByAGEAbQApACIAXQAgAD0AIAAiACgAcAByAG8AZwByAGEAbQApACIAOwAK IABsAG8AYwBhAGwAaQB6AGUAZABTAHQAcgBpAG4AZwBzAFsAIgAoAHUAbgBpAG4AaQB0AGkAYQBs AGkAegBlAGQAKQAiAF0AIAA9ACAAIgAoAHUAbgBpAG4AaQB0AGkAYQBsAGkAegBlAGQAKQAiADsA CiAAbABvAGMAYQBsAGkAegBlAGQAUwB0AHIAaQBuAGcAcwBbACIALAAgACIAXQAgAD0AIAAiACwA IAAiADsACkluZGV4OiBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9U eXBlVG9rZW5WaWV3LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1R5cGVUb2tlblZpZXcuanMJKHJldmlzaW9uIDE3MzgwMikKKysrIFNv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1R5cGVUb2tlblZpZXcuanMJ KHdvcmtpbmcgY29weSkKQEAgLTE4OCw2ICsxODgsNiBAQCBXZWJJbnNwZWN0b3IuVHlwZVRva2Vu Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICh0eXBlU2V0LmlzQ29udGFpbmVkSW4oV2Vi SW5zcGVjdG9yLlR5cGVTZXQuVHlwZUJpdC5PYmplY3QgfCBXZWJJbnNwZWN0b3IuVHlwZVNldC5U eXBlQml0LkZ1bmN0aW9uIHwgV2ViSW5zcGVjdG9yLlR5cGVTZXQuVHlwZUJpdC5TdHJpbmcgfCBX ZWJJbnNwZWN0b3IuVHlwZVNldC5OdWxsT3JVbmRlZmluZWRUeXBlQml0cykpCiAgICAgICAgICAg ICByZXR1cm4gIk9iamVjdD8iOwogCi0gICAgICAgIHJldHVybiAiKCIgKyBXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIm1hbnkiKSArICIpIjsKKyAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0 cmluZygiKG1hbnkpIik7CiAgICAgfQogfTsK