136972 2014-09-19 19:07:02 -0700 Leak: WebNotificationPrivate ObjC leaks seen on leaks bot 2017-02-25 19:49:26 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168876 P2 Normal --- 1 joepeck joepeck commit-queue jonlee oldest_to_newest 1036268 0 joepeck 2014-09-19 19:07:02 -0700 Leaks bot it seeing WebNotificationPrivate ObjC leaks. <http://build.webkit.org/builders/Apple%20MountainLion%20%28Leaks%29/builds/11637/steps/layout-test/logs/stdio> Leak: 0x7fb36a28a570 size=32 zone: DefaultMallocZone_0x108dd9000 WebNotificationPrivate ObjC WebKitLegacy 0x15872998 0x00000001 0x6c4989c0 0x00007fb3 .)........Il.... 0x00000005 0x00000000 0x00000000 0x00000000 ................ Call stack: [thread 0x7fff782d9180]: | 0x2 | start | main DumpRenderTreeMain.mm:30 | DumpRenderTreeMain(int, char const**) DumpRenderTree.mm:1295 | dumpRenderTree(int, char const**) DumpRenderTree.mm:1164 | runTestingServerLoop() DumpRenderTree.mm:1073 | runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) DumpRenderTree.mm:1853 | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoTimer | __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ | WebCore::timerFired(__CFRunLoopTimer*, void*) SharedTimerMac.mm:125 | WebCore::ThreadTimers::sharedTimerFired() ThreadTimers.cpp:108 | WebCore::ThreadTimers::sharedTimerFiredInternal() ThreadTimers.cpp:135 | WebCore::Timer<WebCore::Notification>::fired() Timer.h:134 | std::__1::function<void ()>::operator()() const functional:1755 | std::__1::__function::__func<std::__1::__bind<void (WebCore::Notification::*)(WebCore::Timer<WebCore::Notification>&)&, WebCore::Notification*&, std::__1::reference_wrapper<WebCore::Timer<WebCore::Notification> > >, std::__1::allocator<std::__1::__bind<void (WebCore::Notification::*)(WebCore::Timer<WebCore::Notification>&)&, WebCore::Notification*&, std::__1::reference_wrapper<WebCore::Timer<WebCore::Notification> > > >, void ()>::operator()() functional:1370 | WebCore::Notification::taskTimerFired(WebCore::Timer<WebCore::Notification>&) Notification.cpp:209 | WebCore::Notification::show() Notification.cpp:145 | WebNotificationClient::show(WebCore::Notification*) WebNotificationClient.mm:90 | -[WebNotification(WebNotificationInternal) initWithCoreNotification:notificationID:] WebNotification.mm:70 | _objc_rootAllocWithZone | class_createInstance | calloc | malloc_zone_calloc Leak: 0x7fb36a3319a0 size=32 zone: DefaultMallocZone_0x108dd9000 WebNotificationPrivate ObjC WebKitLegacy 0x15872998 0x00000001 0x6a37a3c0 0x00007fb3 .)........7j.... 0x00000008 0x00000000 0x00000000 0x00000000 ................ Call stack: [thread 0x7fff782d9180]: | 0x2 | start | main DumpRenderTreeMain.mm:30 | DumpRenderTreeMain(int, char const**) DumpRenderTree.mm:1295 | dumpRenderTree(int, char const**) DumpRenderTree.mm:1164 | runTestingServerLoop() DumpRenderTree.mm:1073 | runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) DumpRenderTree.mm:1853 | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoTimer | __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ | WebCore::timerFired(__CFRunLoopTimer*, void*) SharedTimerMac.mm:125 | WebCore::ThreadTimers::sharedTimerFired() ThreadTimers.cpp:108 | WebCore::ThreadTimers::sharedTimerFiredInternal() ThreadTimers.cpp:135 | WebCore::DOMTimer::fired() DOMTimer.cpp:232 | WebCore::ScheduledAction::execute(WebCore::ScriptExecutionContext*) ScheduledAction.cpp:78 | WebCore::ScheduledAction::execute(WebCore::Document*) ScheduledAction.cpp:125 | WebCore::ScheduledAction::executeFunctionInContext(JSC::JSGlobalObject*, JSC::JSValue, WebCore::ScriptExecutionContext*) ScheduledAction.cpp:104 | WebCore::JSMainThreadExecState::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, JSC::JSValue*) JSMainThreadExecState.h:56 | JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, JSC::JSValue*) CallData.cpp:44 | JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) CallData.cpp:39 | JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) Interpreter.cpp:989 | JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) JITCode.cpp:56 | vmEntryToJavaScript | llint_entry | 0x5037fda01034 | WebCore::jsNotificationPrototypeFunctionShow(JSC::ExecState*) JSNotification.cpp:584 | WebCore::Notification::show() Notification.cpp:145 | WebNotificationClient::show(WebCore::Notification*) WebNotificationClient.mm:90 | -[WebNotification(WebNotificationInternal) initWithCoreNotification:notificationID:] WebNotification.mm:70 | _objc_rootAllocWithZone | class_createInstance | calloc | malloc_zone_calloc 1036269 1 238403 joepeck 2014-09-19 19:08:46 -0700 Created attachment 238403 [PATCH] Proposed Fix 1036403 2 238403 commit-queue 2014-09-21 17:31:21 -0700 Comment on attachment 238403 [PATCH] Proposed Fix Clearing flags on attachment: 238403 Committed r173802: <http://trac.webkit.org/changeset/173802> 1036404 3 commit-queue 2014-09-21 17:31:23 -0700 All reviewed patches have been landed. Closing bug. 238403 2014-09-19 19:08:46 -0700 2014-09-21 17:31:21 -0700 [PATCH] Proposed Fix notification.patch text/plain 2130 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCBjMGZkZWViLi5mOTg4NzA1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTQtMDktMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKworICAgICAgICBMZWFrOiBXZWJOb3RpZmljYXRpb25Qcml2YXRlIE9iakMgbGVh a3Mgc2VlbiBvbiBsZWFrcyBib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNjk3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViVmlldy9XZWJOb3RpZmljYXRpb24uaDoKKyAgICAgICAgKiBXZWJW aWV3L1dlYk5vdGlmaWNhdGlvbi5tbToKKyAgICAgICAgKC1bV2ViTm90aWZpY2F0aW9uIGluaXRX aXRoQ29yZU5vdGlmaWNhdGlvbjpub3RpZmljYXRpb25JRDpdKToKKyAgICAgICAgU3dpdGNoIHRv IFJldGFpblB0ciBhbmQgYWRvcHQgaW50byBfcHJpdmF0ZSB0byBlbnN1cmUgd2hlbiB3ZSBhcmUK KyAgICAgICAgZGVhbGxvY2F0ZWQgdGhhdCBfcHJpdmF0ZSB3aWxsIGdldCBkZWFsbG9jYXRlZC4K KwogMjAxNC0wOS0xNyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE3MzY5NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvbWFjL1dlYlZpZXcvV2ViTm90aWZpY2F0aW9uLmggYi9Tb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYk5vdGlmaWNhdGlvbi5oCmluZGV4IDFlNjA2MmYuLjFkODZjMTMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViTm90aWZpY2F0aW9uLmgKKysrIGIvU291 cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJOb3RpZmljYXRpb24uaApAQCAtMjYsMTIgKzI2LDE0 IEBACiAgKiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZ IE9GIFNVQ0ggREFNQUdFLgogICovCiAKKyNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+CisKIEBj bGFzcyBXZWJOb3RpZmljYXRpb25Qcml2YXRlOwogQGNsYXNzIFdlYlNlY3VyaXR5T3JpZ2luOwog CiBAaW50ZXJmYWNlIFdlYk5vdGlmaWNhdGlvbiA6IE5TT2JqZWN0CiB7Ci0gICAgV2ViTm90aWZp Y2F0aW9uUHJpdmF0ZSAqX3ByaXZhdGU7CisgICAgUmV0YWluUHRyPFdlYk5vdGlmaWNhdGlvblBy aXZhdGU+IF9wcml2YXRlOwogfQogCiAtIChOU1N0cmluZyAqKXRpdGxlOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJOb3RpZmljYXRpb24ubW0gYi9Tb3VyY2UvV2Vi S2l0L21hYy9XZWJWaWV3L1dlYk5vdGlmaWNhdGlvbi5tbQppbmRleCAxZWNkZTE3Li44ZDM1MTJj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYk5vdGlmaWNhdGlvbi5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYk5vdGlmaWNhdGlvbi5tbQpAQCAt MzksOCArMzksNiBAQAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAjZW5kaWYKIAotT0JKQ19D TEFTUyBXZWJOb3RpZmljYXRpb25JbnRlcm5hbDsKLQogQGludGVyZmFjZSBXZWJOb3RpZmljYXRp b25Qcml2YXRlIDogTlNPYmplY3QKIHsKIEBwdWJsaWMKQEAgLTY3LDcgKzY1LDcgQEAgLSAoaWQp aW5pdFdpdGhDb3JlTm90aWZpY2F0aW9uOihOb3RpZmljYXRpb24qKWNvcmVOb3RpZmljYXRpb24g bm90aWZpY2F0aW9uSUQ6KHUKIHsKICAgICBpZiAoIShzZWxmID0gW3N1cGVyIGluaXRdKSkKICAg ICAgICAgcmV0dXJuIG5pbDsKLSAgICBfcHJpdmF0ZSA9IFtbV2ViTm90aWZpY2F0aW9uUHJpdmF0 ZSBhbGxvY10gaW5pdF07CisgICAgX3ByaXZhdGUgPSBhZG9wdE5TKFtbV2ViTm90aWZpY2F0aW9u UHJpdmF0ZSBhbGxvY10gaW5pdF0pOwogICAgIF9wcml2YXRlLT5faW50ZXJuYWwgPSBjb3JlTm90 aWZpY2F0aW9uOwogICAgIF9wcml2YXRlLT5fbm90aWZpY2F0aW9uSUQgPSBub3RpZmljYXRpb25J RDsKICAgICByZXR1cm4gc2VsZjsK