136969 2014-09-19 18:46:28 -0700 WebContent crash in WebKit::WebPage::expandedRangeFromHandle 2014-09-19 20:08:24 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa benjamin darin ddkilzer enrica ggaren sam oldest_to_newest 1036264 0 rniwa 2014-09-19 18:46:28 -0700 Thread 0 Crashed: 0 WebKit 0x0000000187596328 WebKit::WebPage::expandedRangeFromHandle(WebCore::Range*, WebKit::SelectionHandlePosition) + 576 (Ref.h:60) 1 WebKit 0x0000000187596318 WebKit::WebPage::expandedRangeFromHandle(WebCore::Range*, WebKit::SelectionHandlePosition) + 560 (WebPageIOS.mm:1140) 2 WebKit 0x0000000187597084 WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle(WebCore::IntPoint const&, WebKit::SelectionHandlePosition, float&, float&) + 132 (WebPageIOS.mm:1330) 3 WebKit 0x000000018759750c WebKit::WebPage::updateBlockSelectionWithTouch(WebCore::IntPoint const&, unsigned int, unsigned int) + 160 (WebPageIOS.mm:1430) <rdar://problem/17878728> 1036266 1 238402 rniwa 2014-09-19 18:54:50 -0700 Created attachment 238402 Fixes the crash 1036270 2 238402 ddkilzer 2014-09-19 19:18:47 -0700 Comment on attachment 238402 Fixes the crash r=me 1036286 3 238402 rniwa 2014-09-19 20:08:21 -0700 Comment on attachment 238402 Fixes the crash Clearing flags on attachment: 238402 Committed r173788: <http://trac.webkit.org/changeset/173788> 1036287 4 rniwa 2014-09-19 20:08:24 -0700 All reviewed patches have been landed. Closing bug. 238402 2014-09-19 18:54:50 -0700 2014-09-19 20:08:20 -0700 Fixes the crash bug-136969-20140919185434.patch text/plain 2049 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mzc4NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA5LTE5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFdlYkNvbnRlbnQgY3Jhc2ggaW4g V2ViS2l0OjpXZWJQYWdlOjpleHBhbmRlZFJhbmdlRnJvbUhhbmRsZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2OTY5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNyYXNoIHdhcyBjYXVzZWQgYnkg bV9jdXJyZW50QmxvY2tTZWxlY3Rpb24gYW5kIGZyYW1lLnNlbGVjdGlvbigpLnNlbGVjdGlvbigp LnRvTm9ybWFsaXplZFJhbmdlKCkKKyAgICAgICAgYm90aCBiZWluZyBudWxsIGFuZCB0aGUgc3Vi c2VxdWVudCBsaW5lcyBvZiBjb2RlIGFzc3VtaW5nIGN1cnJlbnRSYW5nZSB0byBiZSBub3QgbnVs bC4KKworICAgICAgICBSZXBsYWNlIHRoZSBhc3NlcnRpb24gYnkgYW4gZWFybHkgZXhpdCBzaW5j ZSB0aGUgcmFuZ2UgY291bGQgYmUgbnVsbCBoZXJlLgorCisgICAgICAgIEluIHRoZSBmdXR1cmUs IHdlIHNob3VsZCBmaWd1cmUgb3V0IGlmIHRoZXJlIGFyZSBvdGhlciB0aGluZ3Mgd2UgbmVlZCB0 byBkbyBpbiBhZGRpdGlvbgorICAgICAgICB0byBjaGVja2luZyB0aGUgbnVsbGl0eSB3aGVuIHRo aXMgcmFjZSBjb25kaXRpb24gaXMgaGl0LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpjb21wdXRlRXhw YW5kQW5kU2hyaW5rVGhyZXNob2xkc0ZvckhhbmRsZSk6CisKIDIwMTQtMDctMjUgIE1hdHRoZXcg SGFuc29uICA8bWF0dGhld19oYW5zb25AYXBwbGUuY29tPgogCiAgICAgICAgIE1lcmdlIHIxNzE2 MjkuIDxyZGFyOi8vcHJvYmxlbS8xNzY1NDM2OT4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0JKHJldmlzaW9uIDE3Mzc3 NCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bQkod29ya2luZyBjb3B5KQpAQCAtMTMyNSw3ICsxMzI1LDExIEBAIHZvaWQgV2ViUGFnZTo6Y29t cHV0ZUV4cGFuZEFuZFNocmlua1RocmUKIHsKICAgICBGcmFtZSYgZnJhbWUgPSBtX3BhZ2UtPmZv Y3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpOwogICAgIFJlZlB0cjxSYW5nZT4g Y3VycmVudFJhbmdlID0gbV9jdXJyZW50QmxvY2tTZWxlY3Rpb24gPyBtX2N1cnJlbnRCbG9ja1Nl bGVjdGlvbi5nZXQoKSA6IGZyYW1lLnNlbGVjdGlvbigpLnNlbGVjdGlvbigpLnRvTm9ybWFsaXpl ZFJhbmdlKCk7Ci0gICAgQVNTRVJUKGN1cnJlbnRSYW5nZSk7CisKKyAgICAvLyBGSVhNRTogVGhp cyB1c2VkIHRvIGJlIGFuIGFzc2VydGlvbiBidXQgdGhlcmUgYXBwZWFycyB0byBiZSBzb21lIHJh Y2UgY29uZGl0aW9uIHVuZGVyIHdoaWNoIHdlIGdldCBhIG51bGwgcmFuZ2UuCisgICAgLy8gU2hv dWxkIHdlIGRvIG90aGVyIHRoaW5ncyBpbiBhZGRpdGlvbiB0byB0aGUgbnVsbCBjaGVjayBoZXJl PworICAgIGlmICghY3VycmVudFJhbmdlKQorICAgICAgICByZXR1cm47CiAKICAgICBSZWZQdHI8 UmFuZ2U+IGV4cGFuZGVkUmFuZ2UgPSBleHBhbmRlZFJhbmdlRnJvbUhhbmRsZShjdXJyZW50UmFu Z2UuZ2V0KCksIGhhbmRsZVBvc2l0aW9uKTsKICAgICBTZWxlY3Rpb25GbGFncyBmbGFnczsK