136966 2014-09-19 16:55:08 -0700 build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments 2014-09-19 19:44:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue thorton timothy oldest_to_newest 1036239 0 ap 2014-09-19 16:55:08 -0700 There is an exception raised when description is empty. 1036241 1 238399 ap 2014-09-19 16:59:24 -0700 Created attachment 238399 proposed fix 1036258 2 238399 dbates 2014-09-19 17:56:27 -0700 Comment on attachment 238399 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=238399&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:105 > - if (parsedDescription.firstChild.className === "changes") { > + if (parsedDescription.firstChild && parsedDescription.firstChild.className === "changes") { We may want to consider caching parsedDescription.firstChild in a local variable to avoid computing it again since we reference it four times in this function. 1036282 3 238399 commit-queue 2014-09-19 19:44:34 -0700 Comment on attachment 238399 proposed fix Clearing flags on attachment: 238399 Committed r173786: <http://trac.webkit.org/changeset/173786> 1036283 4 commit-queue 2014-09-19 19:44:37 -0700 All reviewed patches have been landed. Closing bug. 238399 2014-09-19 16:59:24 -0700 2014-09-19 19:44:34 -0700 proposed fix EmptyDescription.txt text/plain 2217 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3Mzc4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE0LTA5LTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkOiBQZW5kaW5nIGJ1aWxkcyBk b24ndCBzaG93IHVwIHdoZW4gdGhlcmUgaXMgYSBjb21taXQgd2l0aCBubyBjb21tZW50cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2OTY2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2Ny aXB0cy9UcmFjLmpzOgorICAgICAgICAoVHJhYy5wcm90b3R5cGUuX2NvbnZlcnRDb21taXRJbmZv RWxlbWVudFRvT2JqZWN0KTogVG9sZXJhdGUgdGhlc2UgaG9ycmlibGUgY29tbWl0cy4KKwogMjAx NC0wOS0xOSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgQWx3 YXlzIGFzc3VtZSBpbnRlcm5hbCBTREsgd2hlbiBidWlsZGluZyBjb25maWd1cmF0aW9uIFByb2R1 Y3Rpb24KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1RyYWMuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0 bWwvZGFzaGJvYXJkL1NjcmlwdHMvVHJhYy5qcwkocmV2aXNpb24gMTczNjIyKQorKysgVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFz aGJvYXJkL1NjcmlwdHMvVHJhYy5qcwkod29ya2luZyBjb3B5KQpAQCAtMTAyLDcgKzEwMiw3IEBA IFRyYWMucHJvdG90eXBlID0gewogICAgICAgICBwYXJzZWREZXNjcmlwdGlvbi5pbm5lckhUTUwg PSBkZXNjcmlwdGlvbjsKIAogICAgICAgICB2YXIgbG9jYXRpb24gPSAiIjsKLSAgICAgICAgaWYg KHBhcnNlZERlc2NyaXB0aW9uLmZpcnN0Q2hpbGQuY2xhc3NOYW1lID09PSAiY2hhbmdlcyIpIHsK KyAgICAgICAgaWYgKHBhcnNlZERlc2NyaXB0aW9uLmZpcnN0Q2hpbGQgJiYgcGFyc2VkRGVzY3Jp cHRpb24uZmlyc3RDaGlsZC5jbGFzc05hbWUgPT09ICJjaGFuZ2VzIikgewogICAgICAgICAgICAg Ly8gV2UgY2FuIGV4dHJhY3QgYnJhbmNoIGluZm9ybWF0aW9uIHdoZW4gdHJhYy5pbmkgY29udGFp bnMgImNoYW5nZXNldF9zaG93X2ZpbGVzPWxvY2F0aW9uIi4KICAgICAgICAgICAgIGxvY2F0aW9u ID0gZG9jLmV2YWx1YXRlKCIvL3N0cm9uZyIsIHBhcnNlZERlc2NyaXB0aW9uLmZpcnN0Q2hpbGQs IG51bGwsIFhQYXRoUmVzdWx0LlNUUklOR19UWVBFKS5zdHJpbmdWYWx1ZQogICAgICAgICAgICAg cGFyc2VkRGVzY3JpcHRpb24ucmVtb3ZlQ2hpbGQocGFyc2VkRGVzY3JpcHRpb24uZmlyc3RDaGls ZCk7CkBAIC0xMTAsNyArMTEwLDcgQEAgVHJhYy5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgLy8g VGhlIGZlZWQgY29udGFpbnMgYSA8dGl0bGU+LCBidXQgaXQncyBub3QgcGFyc2VkIGFzIHdlbGwg YXMgd2hhdCB3ZSBhcmUgZ2V0dGluZyBmcm9tIGRlc2NyaXB0aW9uLgogICAgICAgICB2YXIgdGl0 bGUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKLSAgICAgICAgdmFyIG5vZGUgPSBw YXJzZWREZXNjcmlwdGlvbi5maXJzdENoaWxkLmZpcnN0Q2hpbGQ7CisgICAgICAgIHZhciBub2Rl ID0gcGFyc2VkRGVzY3JpcHRpb24uZmlyc3RDaGlsZCA/IHBhcnNlZERlc2NyaXB0aW9uLmZpcnN0 Q2hpbGQuZmlyc3RDaGlsZCA6IG51bGw7CiAgICAgICAgIHdoaWxlIChub2RlICYmIG5vZGUudGFn TmFtZSAhPSAiQlIiKSB7CiAgICAgICAgICAgICB0aXRsZS5hcHBlbmRDaGlsZChub2RlLmNsb25l Tm9kZSh0cnVlKSk7CiAgICAgICAgICAgICBub2RlID0gbm9kZS5uZXh0U2libGluZzsK