136965 2014-09-19 15:40:09 -0700 Web Inspector: Option+Click on CSS url(...) should jump to resource view 2014-09-20 08:34:18 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells timothy webkit-bug-importer oldest_to_newest 1036231 0 joepeck 2014-09-19 15:40:09 -0700 Option+Click on CSS url(...) should jump to resource view. * TEST (test with an x.png) <style>body { background: url(x.png) }</style> <body>Test</body> * STEPS TO REPRODUCE 1. Inspect test page 2. Select <body> 3. Show Styles sidebar 4. Option+Click "x.png" => should go to x.png resource view 5. Open html source code 6. Option+Click "x.png" in the <style> => should go to x.png resource view 1036232 1 webkit-bug-importer 2014-09-19 15:40:48 -0700 <rdar://problem/18400129> 1036233 2 joepeck 2014-09-19 15:43:08 -0700 Tools/PrettyPrinting CSS test: Source/WebInspectorUI/Tools/PrettyPrinting/index.html?mode=text%2Fcss&content=body%20%7B%0A%20%20background%3A%20url(x.png)%3B%0A%20%20background%3A%20url(%22x.png%22)%3B%0A%7D The contents inside url(...) are "string" token types not "atom". --- body { background: url(x.png); background: url("x.png"); } --- Token: 'tag' Position: '0' Current: 'body' Token: null Position: '4' Current: ' ' Token: null Position: '5' Current: '{' Token: null Position: '0' Current: ' ' Token: 'property' Position: '2' Current: 'background' Token: null Position: '12' Current: ':' Token: null Position: '13' Current: ' ' > Token: 'atom' Position: '14' Current: 'url' Token: null Position: '17' Current: '(' > Token: 'string' Position: '18' Current: 'x.png' Token: null Position: '23' Current: ')' Token: null Position: '24' Current: ';' Token: null Position: '0' Current: ' ' Token: 'property' Position: '2' Current: 'background' Token: null Position: '12' Current: ':' Token: null Position: '13' Current: ' ' > Token: 'atom' Position: '14' Current: 'url' Token: null Position: '17' Current: '(' > Token: 'string' Position: '18' Current: '"x.png"' Token: null Position: '25' Current: ')' Token: null Position: '26' Current: ';' Token: null Position: '0' Current: '}' 1036234 3 238395 joepeck 2014-09-19 15:56:44 -0700 Created attachment 238395 [PATCH] Proposed Fix 1036304 4 238395 commit-queue 2014-09-20 08:34:16 -0700 Comment on attachment 238395 [PATCH] Proposed Fix Clearing flags on attachment: 238395 Committed r173792: <http://trac.webkit.org/changeset/173792> 1036305 5 commit-queue 2014-09-20 08:34:18 -0700 All reviewed patches have been landed. Closing bug. 238395 2014-09-19 15:56:44 -0700 2014-09-20 08:34:15 -0700 [PATCH] Proposed Fix link-fix.patch text/plain 3252 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU1ZTg5YTQuLmQyZGUyYjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA5LTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogT3B0aW9u K0NsaWNrIG9uIENTUyB1cmwoLi4uKSBzaG91bGQganVtcCB0byByZXNvdXJjZSB2aWV3CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY5NjUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvQ29kZU1pcnJvckFkZGl0aW9ucy5qczoKKyAgICAgICAgV2hlbiBwYXJzaW5nIENT UyB1cmwoLi4uKSB0b2tlbnMsIHRoZSBjb250ZW50cyBvZiB1cmwoLi4uKQorICAgICAgICBhcmUg YSAic3RyaW5nIiB0eXBlLCBub3QgImF0b20iLgorCiAyMDE0LTA5LTE3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IHVubmVjZXNzYXJ5IHByZWZpeGVzIGluIFdlYkluc3BlY3RvclVJIENTUwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvckFkZGl0 aW9ucy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVN aXJyb3JBZGRpdGlvbnMuanMKaW5kZXggZmNmYzM0OC4uMGJjNTg4MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvckFkZGl0aW9u cy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2Rl TWlycm9yQWRkaXRpb25zLmpzCkBAIC0xMDUsNyArMTA1LDcgQEAKIAogICAgICAgICAgICAgICAg IHN0YXRlLl9saW5rUXVvdGVDaGFyYWN0ZXIgPSBxdW90ZSA9PT0gIiciIHx8IHF1b3RlID09PSAi XCIiID8gcXVvdGUgOiBudWxsOwogCi0gICAgICAgICAgICAgICAgLy8gUmV3aW5kIHRoZSBzdGVh bSB0byB0aGUgc3RhcnQgb2YgdGhpcyB0b2tlbi4KKyAgICAgICAgICAgICAgICAvLyBSZXdpbmQg dGhlIHN0cmVhbSB0byB0aGUgc3RhcnQgb2YgdGhpcyB0b2tlbi4KICAgICAgICAgICAgICAgICBz dHJlYW0ucG9zID0gc3RhcnRQb3NpdGlvbjsKIAogICAgICAgICAgICAgICAgIC8vIEVhdCB0aGUg b3BlbiBxdW90ZSBvZiB0aGUgc3RyaW5nIHNvIHRoZSBzdHJpbmcgc3R5bGUKQEAgLTE5OSwxMCAr MTk5LDEyIEBACiAgICAgICAgICAgICAgICAgaWYgKHN0cmVhbS5jdXJyZW50KCkgPT09ICJ1cmwi KSB7CiAgICAgICAgICAgICAgICAgICAgIC8vIElmIHRoZSBjdXJyZW50IHRleHQgaXMgInVybCIg dGhlbiB3ZSBzaG91bGQgZXhwZWN0IHRoZSBuZXh0IHN0cmluZyB0b2tlbiB0byBiZSBhIGxpbmsu CiAgICAgICAgICAgICAgICAgICAgIHN0YXRlLl9leHBlY3RMaW5rID0gdHJ1ZTsKLSAgICAgICAg ICAgICAgICB9IGVsc2UgaWYgKHN0YXRlLl9leHBlY3RMaW5rKSB7Ci0gICAgICAgICAgICAgICAg ICAgIC8vIFdlIGV4cGVjdGVkIGEgc3RyaW5nIGFuZCBnb3QgaXQuIFRoaXMgaXMgYSBsaW5rLiBQ YXJzZSBpdCB0aGUgd2F5IHdlIHdhbnQgaXQuCi0gICAgICAgICAgICAgICAgICAgIGRlbGV0ZSBz dGF0ZS5fZXhwZWN0TGluazsKKyAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKGhleENvbG9yUmVn ZXgudGVzdChzdHJlYW0uY3VycmVudCgpKSkKKyAgICAgICAgICAgICAgICAgICAgc3R5bGUgPSBz dHlsZSArICIgaGV4LWNvbG9yIjsKKyAgICAgICAgICAgIH0gZWxzZSBpZiAoc3RhdGUuX2V4cGVj dExpbmspIHsKKyAgICAgICAgICAgICAgICBkZWxldGUgc3RhdGUuX2V4cGVjdExpbms7CiAKKyAg ICAgICAgICAgICAgICBpZiAoc3R5bGUgPT09ICJzdHJpbmciKSB7CiAgICAgICAgICAgICAgICAg ICAgIC8vIFRoaXMgaXMgYSBsaW5rLCBzbyBzZXR1cCB0aGUgc3RhdGUgdG8gcHJvY2VzcyBpdCBu ZXh0LgogICAgICAgICAgICAgICAgICAgICBzdGF0ZS5fdXJsVG9rZW5pemUgPSB0b2tlbml6ZUNT U1VSTFN0cmluZzsKICAgICAgICAgICAgICAgICAgICAgc3RhdGUuX3VybEJhc2VTdHlsZSA9IHN0 eWxlOwpAQCAtMjEyLDE4ICsyMTQsMTQgQEAKICAgICAgICAgICAgICAgICAgICAgc3RhdGUuX3Vy bFF1b3RlQ2hhcmFjdGVyID0gcXVvdGUgPT09ICInIiB8fCBxdW90ZSA9PT0gIlwiIiA/IHF1b3Rl IDogIikiOwogICAgICAgICAgICAgICAgICAgICBzdGF0ZS5fdW5xdW90ZWRVUkxTdHJpbmcgPSBz dGF0ZS5fdXJsUXVvdGVDaGFyYWN0ZXIgPT09ICIpIjsKIAotICAgICAgICAgICAgICAgICAgICAv LyBSZXdpbmQgdGhlIHN0ZWFtIHRvIHRoZSBzdGFydCBvZiB0aGlzIHRva2VuLgorICAgICAgICAg ICAgICAgICAgICAvLyBSZXdpbmQgdGhlIHN0cmVhbSB0byB0aGUgc3RhcnQgb2YgdGhpcyB0b2tl bi4KICAgICAgICAgICAgICAgICAgICAgc3RyZWFtLnBvcyA9IHN0YXJ0UG9zaXRpb247CiAKICAg ICAgICAgICAgICAgICAgICAgLy8gRWF0IHRoZSBvcGVuIHF1b3RlIG9mIHRoZSBzdHJpbmcgc28g dGhlIHN0cmluZyBzdHlsZQogICAgICAgICAgICAgICAgICAgICAvLyB3aWxsIGJlIHVzZWQgZm9y IHRoZSBxdW90ZSBjaGFyYWN0ZXIuCiAgICAgICAgICAgICAgICAgICAgIGlmICghc3RhdGUuX3Vu cXVvdGVkVVJMU3RyaW5nKQogICAgICAgICAgICAgICAgICAgICAgICAgc3RyZWFtLmVhdChzdGF0 ZS5fdXJsUXVvdGVDaGFyYWN0ZXIpOwotICAgICAgICAgICAgICAgIH0gZWxzZSBpZiAoaGV4Q29s b3JSZWdleC50ZXN0KHN0cmVhbS5jdXJyZW50KCkpKQotICAgICAgICAgICAgICAgICAgICBzdHls ZSA9IHN0eWxlICsgIiBoZXgtY29sb3IiOwotICAgICAgICAgICAgfSBlbHNlIGlmIChzdGF0ZS5f ZXhwZWN0TGluaykgewotICAgICAgICAgICAgICAgIC8vIFdlIGV4cGVjdGVkIGEgc3RyaW5nIGFu ZCBkaWRuJ3QgZ2V0IG9uZS4gQ2xlYW51cC4KLSAgICAgICAgICAgICAgICBkZWxldGUgc3RhdGUu X2V4cGVjdExpbms7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogICAgICAgICB9 CiAK