136958 2014-09-19 13:13:03 -0700 [MSE][Mac] work around AVSampleBufferRenderSynchronizer early callbacks 2014-09-19 16:00:09 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 1 eric.carlson eric.carlson cdumez jer.noble webkit-bug-importer oldest_to_newest 1036189 0 eric.carlson 2014-09-19 13:13:03 -0700 AVSampleBufferRenderSynchronizer can sometimes call a boundary time observer early. When this happens for the duration time observer, seek the synchronizer to to the duration so HTMLMediaElement sees that playback has stopped because currentTime is equal to duration. 1036190 1 eric.carlson 2014-09-19 13:13:26 -0700 <rdar://problem/17998261> 1036198 2 238386 eric.carlson 2014-09-19 13:19:39 -0700 Created attachment 238386 Proposed patch. 1036204 3 238387 eric.carlson 2014-09-19 13:29:07 -0700 Created attachment 238387 Rebased patch 1036207 4 eric.carlson 2014-09-19 13:55:17 -0700 Committed r173771 - http://trac.webkit.org/changeset/173771 1036225 5 cdumez 2014-09-19 15:24:53 -0700 I seem to be getting the following build error after this change: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:646:19: error: variable 'duration' cannot be implicitly captured in a lambda with no capture-default specified if (now < duration) { 1036235 6 jer.noble 2014-09-19 16:00:09 -0700 Landed a follow-up build fix in r173777 <http://trac.webkit.org/r173777>. 238386 2014-09-19 13:19:39 -0700 2014-09-19 13:29:07 -0700 Proposed patch. patch_3.txt text/plain 2807 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mzc2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA5LTE5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNU0VdW01hY10gd29y ayBhcm91bmQgQVZTYW1wbGVCdWZmZXJSZW5kZXJTeW5jaHJvbml6ZXIgZWFybHkgY2FsbGJhY2tz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY5NTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMsIHdlIGhhdmUgYmVlbiB1bmFibGUgdG8gY29tZSB1cCB3aXRoIGEgdGVzdCBjYXNlIHRo YXQgcmVwcm9kdWNlcworICAgICAgICB0aGlzIGlzc3VlIHJlbGlhYmx5LgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVk aWFTb3VyY2VBVkZPYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRl TWVkaWFTb3VyY2VBVkZPYmpDOjpkdXJhdGlvbkNoYW5nZWQpOiBTZXQgdGhlIHN5bmNocm9uaXpl cgorICAgICAgICAgICAgdGltZSB0byBkdXJhdGlvbiB3aGVuIHRoZSBkdXJhdGlvbiB0aW1lIG9i c2VydmVyIGlzIGNhbGxlZCBlYXJseS4gQWRkIG1vcmUgbG9nZ2luZy4KKwogMjAxNC0wOS0xOSAg RXZhIEJhbGF6c2ZhbHZpICA8ZXZhYi51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04ocjE3MzQ2NCk6IEl0IGJyb2tlIHRoZSAhRU5BQkxFKFBJQ1RVUkVf U0laRVMpIGJ1aWxkCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tCShyZXZpc2lvbiAx NzMzMTIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24v b2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMubW0JKHdvcmtpbmcgY29w eSkKQEAgLTYzNSwxMyArNjM1LDIzIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3Vy Y2VBVkZPYmoKICAgICAgICAgcmV0dXJuOwogCiAgICAgTWVkaWFUaW1lIGR1cmF0aW9uID0gbV9t ZWRpYVNvdXJjZVByaXZhdGUtPmR1cmF0aW9uKCk7CisgICAgTE9HKE1lZGlhU291cmNlLCAiTWVk aWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjpkdXJhdGlvbkNoYW5nZWQoJXApIC0g ZHVyYXRpb24gPSAlcyIsIHRoaXMsIHRvU3RyaW5nKGR1cmF0aW9uKS51dGY4KCkuZGF0YSgpKTsK ICAgICBhdXRvIHdlYWtUaGlzID0gY3JlYXRlV2Vha1B0cigpOwogICAgIE5TQXJyYXkqIHRpbWVz ID0gQFtbTlNWYWx1ZSB2YWx1ZVdpdGhDTVRpbWU6dG9DTVRpbWUoZHVyYXRpb24pXV07Ci0gICAg bV9kdXJhdGlvbk9ic2VydmVyID0gW21fc3luY2hyb25pemVyIGFkZEJvdW5kYXJ5VGltZU9ic2Vy dmVyRm9yVGltZXM6dGltZXMgcXVldWU6ZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSB1c2luZ0Js b2NrOlt3ZWFrVGhpc10gewotICAgICAgICBpZiAod2Vha1RoaXMpIHsKLSAgICAgICAgICAgIHdl YWtUaGlzLT5wYXVzZUludGVybmFsKCk7Ci0gICAgICAgICAgICB3ZWFrVGhpcy0+bV9wbGF5ZXIt PnRpbWVDaGFuZ2VkKCk7CisgICAgbV9kdXJhdGlvbk9ic2VydmVyID0gW21fc3luY2hyb25pemVy IGFkZEJvdW5kYXJ5VGltZU9ic2VydmVyRm9yVGltZXM6dGltZXMgcXVldWU6ZGlzcGF0Y2hfZ2V0 X21haW5fcXVldWUoKSB1c2luZ0Jsb2NrOlt3ZWFrVGhpcywgZHVyYXRpb25dIHsKKyAgICAgICAg aWYgKCF3ZWFrVGhpcykKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBNZWRpYVRpbWUg bm93ID0gd2Vha1RoaXMtPmN1cnJlbnRNZWRpYVRpbWUoKTsKKyAgICAgICAgTE9HKE1lZGlhU291 cmNlLCAiTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjpkdXJhdGlvbkNoYW5n ZWQoJXApIC0gYm91bmRhcnkgdGltZSBvYnNlcnZlciBjYWxsZWQsIG5vdyA9ICVzIiwgd2Vha1Ro aXMuZ2V0KCksIHRvU3RyaW5nKG5vdykudXRmOCgpLmRhdGEoKSk7CisKKyAgICAgICAgd2Vha1Ro aXMtPnBhdXNlSW50ZXJuYWwoKTsKKyAgICAgICAgaWYgKG5vdyA8IGR1cmF0aW9uKSB7CisgICAg ICAgICAgICBMT0coTWVkaWFTb3VyY2UsICIgICBFUlJPUjogYm91bmRhcnkgdGltZSBvYnNlcnZl ciBjYWxsZWQgYmVmb3JlIGR1cmF0aW9uISIsIHdlYWtUaGlzLmdldCgpKTsKKyAgICAgICAgICAg IFt3ZWFrVGhpcy0+bV9zeW5jaHJvbml6ZXIgc2V0UmF0ZTowIHRpbWU6dG9DTVRpbWUoZHVyYXRp b24pXTsKICAgICAgICAgfQorICAgICAgICB3ZWFrVGhpcy0+bV9wbGF5ZXItPnRpbWVDaGFuZ2Vk KCk7CisKICAgICB9XTsKIAogICAgIGlmIChtX3BsYXlpbmcgJiYgZHVyYXRpb24gPD0gY3VycmVu dE1lZGlhVGltZSgpKQo= 238387 2014-09-19 13:29:07 -0700 2014-09-19 13:55:31 -0700 Rebased patch patch_4.txt text/plain 2646 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mzc2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA5LTE5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNU0VdW01hY10gd29y ayBhcm91bmQgQVZTYW1wbGVCdWZmZXJSZW5kZXJTeW5jaHJvbml6ZXIgZWFybHkgY2FsbGJhY2tz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY5NTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMsIHdlIGhhdmUgYmVlbiB1bmFibGUgdG8gY29tZSB1cCB3aXRoIGEgdGVzdCBjYXNlIHRo YXQgcmVwcm9kdWNlcworICAgICAgICB0aGlzIGlzc3VlIHJlbGlhYmx5LgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVk aWFTb3VyY2VBVkZPYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRl TWVkaWFTb3VyY2VBVkZPYmpDOjpkdXJhdGlvbkNoYW5nZWQpOiBTZXQgdGhlIHN5bmNocm9uaXpl cgorICAgICAgICAgICAgdGltZSB0byBkdXJhdGlvbiB3aGVuIHRoZSBkdXJhdGlvbiB0aW1lIG9i c2VydmVyIGlzIGNhbGxlZCBlYXJseS4gQWRkIG1vcmUgbG9nZ2luZy4KKwogMjAxNC0wOS0xOSAg RXZhIEJhbGF6c2ZhbHZpICA8ZXZhYi51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04ocjE3MzQ2NCk6IEl0IGJyb2tlIHRoZSAhRU5BQkxFKFBJQ1RVUkVf U0laRVMpIGJ1aWxkCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tCShyZXZpc2lvbiAx NzM3NjgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24v b2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMubW0JKHdvcmtpbmcgY29w eSkKQEAgLTYzMiwxMSArNjMyLDIzIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3Vy Y2VBVkZPYmoKICAgICBNZWRpYVRpbWUgZHVyYXRpb24gPSBtX21lZGlhU291cmNlUHJpdmF0ZS0+ ZHVyYXRpb24oKTsKICAgICBhdXRvIHdlYWtUaGlzID0gY3JlYXRlV2Vha1B0cigpOwogICAgIE5T QXJyYXkqIHRpbWVzID0gQFtbTlNWYWx1ZSB2YWx1ZVdpdGhDTVRpbWU6dG9DTVRpbWUoZHVyYXRp b24pXV07CisKKyAgICBMT0coTWVkaWFTb3VyY2UsICJNZWRpYVBsYXllclByaXZhdGVNZWRpYVNv dXJjZUFWRk9iakM6OmR1cmF0aW9uQ2hhbmdlZCglcCkgLSBkdXJhdGlvbiA9ICVzIiwgdGhpcywg dG9TdHJpbmcoZHVyYXRpb24pLnV0ZjgoKS5kYXRhKCkpOworCiAgICAgbV9kdXJhdGlvbk9ic2Vy dmVyID0gW21fc3luY2hyb25pemVyIGFkZEJvdW5kYXJ5VGltZU9ic2VydmVyRm9yVGltZXM6dGlt ZXMgcXVldWU6ZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSB1c2luZ0Jsb2NrOlt3ZWFrVGhpc10g ewotICAgICAgICBpZiAod2Vha1RoaXMpIHsKLSAgICAgICAgICAgIHdlYWtUaGlzLT5wYXVzZUlu dGVybmFsKCk7Ci0gICAgICAgICAgICB3ZWFrVGhpcy0+bV9wbGF5ZXItPnRpbWVDaGFuZ2VkKCk7 CisgICAgICAgIGlmICghd2Vha1RoaXMpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAg TWVkaWFUaW1lIG5vdyA9IHdlYWtUaGlzLT5jdXJyZW50TWVkaWFUaW1lKCk7CisgICAgICAgIExP RyhNZWRpYVNvdXJjZSwgIk1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQzo6ZHVy YXRpb25DaGFuZ2VkKCVwKSAtIGJvdW5kYXJ5IHRpbWUgb2JzZXJ2ZXIgY2FsbGVkLCBub3cgPSAl cyIsIHdlYWtUaGlzLmdldCgpLCB0b1N0cmluZyhub3cpLnV0ZjgoKS5kYXRhKCkpOworCisgICAg ICAgIHdlYWtUaGlzLT5wYXVzZUludGVybmFsKCk7CisgICAgICAgIGlmIChub3cgPCBkdXJhdGlv bikgeworICAgICAgICAgICAgTE9HKE1lZGlhU291cmNlLCAiICAgRVJST1I6IGJvdW5kYXJ5IHRp bWUgb2JzZXJ2ZXIgY2FsbGVkIGJlZm9yZSBkdXJhdGlvbiEiLCB3ZWFrVGhpcy5nZXQoKSk7Cisg ICAgICAgICAgICBbd2Vha1RoaXMtPm1fc3luY2hyb25pemVyIHNldFJhdGU6MCB0aW1lOnRvQ01U aW1lKGR1cmF0aW9uKV07CiAgICAgICAgIH0KKyAgICAgICAgd2Vha1RoaXMtPm1fcGxheWVyLT50 aW1lQ2hhbmdlZCgpOworCiAgICAgfV07CiAKICAgICBpZiAobV9wbGF5aW5nICYmIGR1cmF0aW9u IDw9IGN1cnJlbnRNZWRpYVRpbWUoKSkK