136946 2014-09-19 02:22:39 -0700 REGRESSION(r173631): It broke the !ENABLE(VIDEO) build 2014-09-22 08:01:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136837 1 ossy webkit-unassigned commit-queue evab.u-szeged jer.noble ossy simon.fraser oldest_to_newest 1036097 0 ossy 2014-09-19 02:22:39 -0700 build log: /home/webkit/WebKit/Source/WebCore/page/DragController.cpp: In member function 'bool WebCore::DragController::startDrag(WebCore::Frame&, const WebCore::DragState&, WebCore::DragOperation, const WebCore::PlatformMouseEvent&, const WebCore::IntPoint&)': /home/webkit/WebKit/Source/WebCore/page/DragController.cpp:726:43: error: 'class WebCore::Element' has no member named 'isMediaElement' 1036105 1 238369 evab.u-szeged 2014-09-19 03:47:25 -0700 Created attachment 238369 Patch 1036130 2 238369 simon.fraser 2014-09-19 08:50:31 -0700 Comment on attachment 238369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238369&action=review > Source/WebCore/page/DragController.cpp:726 > + bool includeShadowDOM = true; Shouldn't this default to false? 1036511 3 238476 evab.u-szeged 2014-09-22 04:14:08 -0700 Created attachment 238476 Patch 1036531 4 238476 commit-queue 2014-09-22 08:01:04 -0700 Comment on attachment 238476 Patch Clearing flags on attachment: 238476 Committed r173836: <http://trac.webkit.org/changeset/173836> 1036532 5 commit-queue 2014-09-22 08:01:08 -0700 All reviewed patches have been landed. Closing bug. 238369 2014-09-19 03:47:25 -0700 2014-09-22 04:13:59 -0700 Patch bug-136946-20140919124721.patch text/plain 1727 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTkwOTZjM2UxYTcxZmMw NzFkMjJmZGM0ZGZiOTMxOWY5YzkyOGFkNy4uY2Y0YTk2M2ViMmQ2NWRmZGEyZGM5YTA5ODRmMWRj ZjgzYjU1Y2NjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA5LTE5ICBFdmEg QmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTihyMTczNjMxKTogSXQgYnJva2UgdGhlICFFTkFCTEUoVklERU8pIGJ1aWxk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY5NDYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgcmVxdWlyZWQsIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGFnZS9E cmFnQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6c3Rh cnREcmFnKToKKwogMjAxNC0wOS0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gRG90IG5vdCBhbGxvdyB0byBjcmVhdGUgZGVsZXRl LW9uLWRlc3Ryb3kgR01haW5Mb29wU291cmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9EcmFnQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9s bGVyLmNwcAppbmRleCAwMzRkZWVlYjdkNTI1MjgzNTU1ZWM4N2U0MzRjOWM4MTZiZDk2ZDA2Li42 ZDFmMTQ1NDkxNWM1NGIzMTY2ZmQwYjc1NGFjYjE0MjllOGEzYTU0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL0RyYWdDb250cm9sbGVyLmNwcApAQCAtNzIzLDcgKzcyMywxMCBAQCBib29sIERyYWdDb250 cm9sbGVyOjpzdGFydERyYWcoRnJhbWUmIHNyYywgY29uc3QgRHJhZ1N0YXRlJiBzdGF0ZSwgRHJh Z09wZXJhdGlvbgogICAgIEhpdFRlc3RSZXN1bHQgaGl0VGVzdFJlc3VsdCA9IHNyYy5ldmVudEhh bmRsZXIoKS5oaXRUZXN0UmVzdWx0QXRQb2ludChkcmFnT3JpZ2luLCBIaXRUZXN0UmVxdWVzdDo6 UmVhZE9ubHkgfCBIaXRUZXN0UmVxdWVzdDo6QWN0aXZlKTsKIAogICAgIC8vIEZJWE1FKDEzNjgz Nik6IEludmVzdGlnYXRlIHdoZXRoZXIgYWxsIGVsZW1lbnRzIHNob3VsZCB1c2UgdGhlIGNvbnRh aW5zSW5jbHVkaW5nU2hhZG93RE9NKCkgcGF0aCBoZXJlLgotICAgIGJvb2wgaW5jbHVkZVNoYWRv d0RPTSA9IHN0YXRlLnNvdXJjZS0+aXNNZWRpYUVsZW1lbnQoKTsKKyAgICBib29sIGluY2x1ZGVT aGFkb3dET00gPSB0cnVlOworI2lmIEVOQUJMRShWSURFTykKKyAgICBpbmNsdWRlU2hhZG93RE9N ID0gc3RhdGUuc291cmNlLT5pc01lZGlhRWxlbWVudCgpOworI2VuZGlmCiAgICAgYm9vbCBzb3Vy Y2VDb250YWluc0hpdE5vZGU7CiAgICAgaWYgKCFpbmNsdWRlU2hhZG93RE9NKQogICAgICAgICBz b3VyY2VDb250YWluc0hpdE5vZGUgPSBzdGF0ZS5zb3VyY2UtPmNvbnRhaW5zKGhpdFRlc3RSZXN1 bHQuaW5uZXJOb2RlKCkpOwo= 238476 2014-09-22 04:14:08 -0700 2014-09-22 08:01:04 -0700 Patch bug-136946-20140922131405.patch text/plain 1696 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTczODI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGY4MjZjMzliNjI3M2Qz YjE2OWEyZGE0OWZhNzY1ZjRmMThmYzgzMy4uYzEyMGZiYmE5YWM5YWU3MWNiOTYyZTU5YmIyZDJk M2E1NjJjMzI0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA5LTIyICBFdmEg QmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTihyMTczNjMxKTogSXQgYnJva2UgdGhlICFFTkFCTEUoVklERU8pIGJ1aWxk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY5NDYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgcmVxdWlyZWQsIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGFnZS9E cmFnQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6c3Rh cnREcmFnKToKKwogMjAxNC0wOS0xNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gQ2Fubm90IHBsYXkgVmltZW8gdmlkZW8KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKaW5kZXggNGZhMTkxZTIwOTMwZTA5ZTI0 ZTY3OGUyMDk2NjQ1YzNhYTcxMGMyZC4uNTE1OTYyNDZlN2Y4ZGRlYWM2YTYyZGI5NTFjMWVlMDFl MjE5ODQxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKQEAgLTcyMiw3 ICs3MjIsMTAgQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6c3RhcnREcmFnKEZyYW1lJiBzcmMsIGNv bnN0IERyYWdTdGF0ZSYgc3RhdGUsIERyYWdPcGVyYXRpb24KICAgICBIaXRUZXN0UmVzdWx0IGhp dFRlc3RSZXN1bHQgPSBzcmMuZXZlbnRIYW5kbGVyKCkuaGl0VGVzdFJlc3VsdEF0UG9pbnQoZHJh Z09yaWdpbiwgSGl0VGVzdFJlcXVlc3Q6OlJlYWRPbmx5IHwgSGl0VGVzdFJlcXVlc3Q6OkFjdGl2 ZSk7CiAKICAgICAvLyBGSVhNRSgxMzY4MzYpOiBJbnZlc3RpZ2F0ZSB3aGV0aGVyIGFsbCBlbGVt ZW50cyBzaG91bGQgdXNlIHRoZSBjb250YWluc0luY2x1ZGluZ1NoYWRvd0RPTSgpIHBhdGggaGVy ZS4KLSAgICBib29sIGluY2x1ZGVTaGFkb3dET00gPSBzdGF0ZS5zb3VyY2UtPmlzTWVkaWFFbGVt ZW50KCk7CisgICAgYm9vbCBpbmNsdWRlU2hhZG93RE9NID0gZmFsc2U7CisjaWYgRU5BQkxFKFZJ REVPKQorICAgIGluY2x1ZGVTaGFkb3dET00gPSBzdGF0ZS5zb3VyY2UtPmlzTWVkaWFFbGVtZW50 KCk7CisjZW5kaWYKICAgICBib29sIHNvdXJjZUNvbnRhaW5zSGl0Tm9kZTsKICAgICBpZiAoIWlu Y2x1ZGVTaGFkb3dET00pCiAgICAgICAgIHNvdXJjZUNvbnRhaW5zSGl0Tm9kZSA9IHN0YXRlLnNv dXJjZS0+Y29udGFpbnMoaGl0VGVzdFJlc3VsdC5pbm5lck5vZGUoKSk7Cg==