136942 2014-09-19 01:47:25 -0700 REGRESSION(r173464): It broke the !ENABLE(PICTURE_SIZES) build 2014-09-19 11:48:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136654 1 ossy webkit-unassigned commit-queue darin evab.u-szeged mtiborinf ossy simon.fraser oldest_to_newest 1036083 0 ossy 2014-09-19 01:47:25 -0700 build log: /home/webkit/WebKit/Source/WebCore/html/HTMLImageElement.cpp: In member function ‘virtual void WebCore::HTMLImageElement::parseAttribute(const WebCore::QualifiedName&, const WTF::AtomicString&)’: /home/webkit/WebKit/Source/WebCore/html/HTMLImageElement.cpp:150:9: error: too few arguments to function ‘WebCore::ImageCandidate WebCore::bestFitSourceForImageAttributes(float, const WTF::AtomicString&, const WTF::AtomicString&, unsigned int)’ ); ^ 1036093 1 238363 evab.u-szeged 2014-09-19 02:14:05 -0700 Created attachment 238363 Patch 1036177 2 238363 commit-queue 2014-09-19 11:48:47 -0700 Comment on attachment 238363 Patch Clearing flags on attachment: 238363 Committed r173767: <http://trac.webkit.org/changeset/173767> 1036178 3 commit-queue 2014-09-19 11:48:50 -0700 All reviewed patches have been landed. Closing bug. 238363 2014-09-19 02:14:05 -0700 2014-09-19 11:48:47 -0700 Patch bug-136942-20140919111400.patch text/plain 2118 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTkwOTZjM2UxYTcxZmMw NzFkMjJmZGM0ZGZiOTMxOWY5YzkyOGFkNy4uNDUxZjUxNzgxZjhkNjgzZWE2YWU4MGExNDdiYjhh YmU4NjBmOWJkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA5LTE5ICBFdmEg QmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTihyMTczNDY0KTogSXQgYnJva2UgdGhlICFFTkFCTEUoUElDVFVSRV9TSVpF UykgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNjk0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaHRtbC9IVE1MSW1hZ2VFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbWFn ZUVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToKKwogMjAxNC0wOS0xOCAgQ2FybG9zIEdhcmNpYSBD YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gRG90IG5vdCBhbGxv dyB0byBjcmVhdGUgZGVsZXRlLW9uLWRlc3Ryb3kgR01haW5Mb29wU291cmNlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW1hZ2VFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTEltYWdlRWxlbWVudC5jcHAKaW5kZXggYzAxMWZmNzkzYzc4ZWU1YjQ5NzQ4 ZDUzNGQ5YjZiYzBkNTkxNTk4MS4uNzM4YTkxOThlNzkxZjc5MWUyNGYyN2VmNmIwZGRmZDA0MmM1 OWEzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW1hZ2VFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbWFnZUVsZW1lbnQuY3BwCkBAIC0xNDMs MTEgKzE0MywxMSBAQCB2b2lkIEhUTUxJbWFnZUVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKGNvbnN0 IFF1YWxpZmllZE5hbWUmIG5hbWUsIGNvbnN0IEF0b21pY1N0cgogICAgICAgICBpZiAocmVuZGVy ZXIoKSAmJiByZW5kZXJlcigpLT5pc1JlbmRlckltYWdlKCkpCiAgICAgICAgICAgICB0b1JlbmRl ckltYWdlKHJlbmRlcmVyKCkpLT51cGRhdGVBbHRUZXh0KCk7CiAgICAgfSBlbHNlIGlmIChuYW1l ID09IHNyY0F0dHIgfHwgbmFtZSA9PSBzcmNzZXRBdHRyKSB7Ci0gICAgICAgIEltYWdlQ2FuZGlk YXRlIGNhbmRpZGF0ZSA9IGJlc3RGaXRTb3VyY2VGb3JJbWFnZUF0dHJpYnV0ZXMoZG9jdW1lbnQo KS5kZXZpY2VTY2FsZUZhY3RvcigpLCBmYXN0R2V0QXR0cmlidXRlKHNyY0F0dHIpLCBmYXN0R2V0 QXR0cmlidXRlKHNyY3NldEF0dHIpCisgICAgICAgIHVuc2lnbmVkIHNvdXJjZVNpemUgPSAwOwog I2lmIEVOQUJMRShQSUNUVVJFX1NJWkVTKQotICAgICAgICAgICAgLCBTb3VyY2VTaXplTGlzdDo6 cGFyc2VTaXplc0F0dHJpYnV0ZShmYXN0R2V0QXR0cmlidXRlKHNpemVzQXR0ciksIGRvY3VtZW50 KCkucmVuZGVyVmlldygpLCBkb2N1bWVudCgpLmZyYW1lKCkpCisgICAgICAgIHNvdXJjZVNpemUg PSBTb3VyY2VTaXplTGlzdDo6cGFyc2VTaXplc0F0dHJpYnV0ZShmYXN0R2V0QXR0cmlidXRlKHNp emVzQXR0ciksIGRvY3VtZW50KCkucmVuZGVyVmlldygpLCBkb2N1bWVudCgpLmZyYW1lKCkpOwog I2VuZGlmCi0gICAgICAgICk7CisgICAgICAgIEltYWdlQ2FuZGlkYXRlIGNhbmRpZGF0ZSA9IGJl c3RGaXRTb3VyY2VGb3JJbWFnZUF0dHJpYnV0ZXMoZG9jdW1lbnQoKS5kZXZpY2VTY2FsZUZhY3Rv cigpLCBmYXN0R2V0QXR0cmlidXRlKHNyY0F0dHIpLCBmYXN0R2V0QXR0cmlidXRlKHNyY3NldEF0 dHIpLCBzb3VyY2VTaXplKTsKICAgICAgICAgc2V0QmVzdEZpdFVSTEFuZERQUkZyb21JbWFnZUNh bmRpZGF0ZShjYW5kaWRhdGUpOwogICAgICAgICBtX2ltYWdlTG9hZGVyLnVwZGF0ZUZyb21FbGVt ZW50SWdub3JpbmdQcmV2aW91c0Vycm9yKCk7CiAgICAgfSBlbHNlIGlmIChuYW1lID09IHVzZW1h cEF0dHIpIHsK