136909 2014-09-18 00:04:49 -0700 Occasional unreproducible crashes in MessageReceiverMap::dispatchMessage 2014-09-18 09:26:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca darin mitz sam simon.fraser oldest_to_newest 1035853 0 thorton 2014-09-18 00:04:49 -0700 Occasional unreproducible crashes in MessageReceiverMap::dispatchMessage 1035854 1 238291 thorton 2014-09-18 00:05:16 -0700 Created attachment 238291 Patch 1035855 2 thorton 2014-09-18 00:08:15 -0700 Step 2: Make a API test, if possible. Prerequisites include getting TestWebKitAPI a Modern API bundle and ... causing the issue to reproduce at all. Going to try this now, but I want to keep it separate from the fix for mergability's sake (most likely going to change bundle loading code). Step 3: Fix a few less obviously bad but still confusing cases of message receivers not being removed before the object is destroyed. Step 4: Add some assertions that catch this and the other cases; Anders and I wrote some nice assertions today that catch all of these things. 1035923 3 darin 2014-09-18 08:40:06 -0700 <rdar://problem/17758325> 1035936 4 thorton 2014-09-18 09:26:49 -0700 http://trac.webkit.org/changeset/173722 238291 2014-09-18 00:05:16 -0700 2014-09-18 08:18:48 -0700 Patch bug-136909-20140918000515.patch text/plain 1709 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjM0NGJjYTBhZGYyYjJj NmM4N2I4ZjIzNzZhZmYwMzk0ZjQxNThiYy4uZjcwNGE1YTI4YTQ4OWI0NGMwYjRkODUwYjIyNDQ1 Yjg4Y2Q4NjU2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA5LTE3ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIE9jY2FzaW9uYWwg dW5yZXByb2R1Y2libGUgY3Jhc2hlcyBpbiBNZXNzYWdlUmVjZWl2ZXJNYXA6OmRpc3BhdGNoTWVz c2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2 OTA5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzc1ODMyNT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgZGVhbGxvY10pOgorICAgICAgICBXZSdy ZSBzZWVpbmcgc29tZSBtZXNzYWdlcyBkaXNwYXRjaGVkIG9uIHRoZSBXZWJDb250ZXh0IHRoYXQg ZW5kIHVwCisgICAgICAgIGF0dGVtcHRpbmcgdG8gY2FsbCBkaXNwYXRjaE1lc3NhZ2Ugb24gYSBm cmVlZCBNZXNzYWdlUmVjZWl2ZXIuCisgICAgICAgIFRoZSBXS1JlbW90ZU9iamVjdFJlZ2lzdHJ5 IG1lc3NhZ2UgcmVjZWl2ZXIgaXMgYWRkZWQgdG8gdGhlIFdlYkNvbnRleHQKKyAgICAgICAgbWVz c2FnZSByZWNlaXZlciBtYXAsIGJ1dCBuZXZlciByZW1vdmVkLCBkZXNwaXRlIHRoZSBXZWJDb250 ZXh0IGVhc2lseQorICAgICAgICBvdXRsaXZpbmcgdGhlIFdLV2ViVmlldyB0aGF0IG93bnMgdGhl IHJlbW90ZSBvYmplY3QgcmVnaXN0cnkuCisKIDIwMTQtMDktMTcgIERhbmllbCBCYXRlcyAgPGRh YmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNzM2 OTUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t CmluZGV4IDNhNmJjZDc1NDYwODFiN2U2NjlkZDBjNmMzNTFlMDc1NDQ1ZTFlN2YuLmNkZDljMTY1 YzAxNTNkODFmNjM2MjQ1ZjM2NWI2YjYxOTgwYmViMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC0zNTIsNiArMzUyLDkgQEAgc3Rh dGljIGludDMyX3QgZGV2aWNlT3JpZW50YXRpb24oKQogCiAtICh2b2lkKWRlYWxsb2MKIHsKKyAg ICBpZiAoX3JlbW90ZU9iamVjdFJlZ2lzdHJ5KQorICAgICAgICBfcGFnZS0+cHJvY2VzcygpLmNv bnRleHQoKS5yZW1vdmVNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OlJlbW90ZU9iamVjdFJlZ2lz dHJ5OjptZXNzYWdlUmVjZWl2ZXJOYW1lKCksIF9wYWdlLT5wYWdlSUQoKSk7CisKICAgICBfcGFn ZS0+Y2xvc2UoKTsKIAogICAgIFtfcmVtb3RlT2JqZWN0UmVnaXN0cnkgX2ludmFsaWRhdGVdOwo=