136904 2014-09-17 18:25:07 -0700 As of iOS 8.0 (12A365), all Mobify.js sites unexpectedly scroll down the page after load. Sometimes this happens on first load, and happens almost 100% of the time after navigating to another page on the website by clicking a link. 2022-05-22 10:38:21 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) iPhone / iPad Other NEW InRadar P2 Critical --- 1 shawnjan thorton benjamin bfulgham hussain justin mike.klemarewski mikek shawnjan skinnzz1806 steve.calvert stewart thorton webkit-bug-importer yoav zalan oldest_to_newest 1035809 0 238279 shawnjan 2014-09-17 18:25:07 -0700 Created attachment 238279 Minimal test case A minimal test case has been attached and can be found in ios8_bug.html. Steps to Reproduce: On an iOS device: 1. Open attached io8_bug.html on an iOS8 device or iOS8 Simulator. 2. Notice that the initial rendering of the page is scrolled down. 3. Refresh to repeat. or 1. Go to any of the sites listed in the Affected Sites list below and browse around. Expected Results: The initial rendering of the page should not be scrolled down. Actual Results: The initial rendering of the page is scrolled down. Version: iOS 8.0 [12A365] Notes: The minimal test case is attached. The minimal test case shows how the page is being scrolled after dynamically attaching the meta viewport tag. The reason this is related to mobify.js is because it uses a technique we call "capturing" - which does the following to the page: 1. Inserts a plaintext tag to capture the contents of the page in order to prevent resources from loading. 2. Creates an interstitial document that we use to query against in an effort to create a new HTML page for that specific route. 3. Creates the new page by rendering the mobile template chosen by the router using dust.js. 4. Renders that new page to the DOM by using document.open/write. Since the document string is being written later on, and that document string almost always has the meta viewport tag in it, we end up running into the same issue exhibited by the minimal test case. We believe whatever issue plaguing the test case is the same issue we are running into with websites running Mobify.js. Configuration: iPhone 5S (iOS8), and iOS8 Simulator Xcode 6.0.1 Sites affected: AnnTaylor.com BeyondTheRack.com Bosch-Home.com BT.com CallawayGolf.com Coastal.com Ideeli.com Loft.com Lululemon.com www.menshealth.com Neff.de Siemens-Home.com MyStarbucksIdea.force.com Techvibes.com Thermador.com Threadless.com TommyBahama.com TriaBeauty.com VirginWines.co.uk Wired.com WomensHealthMag.com WSJWine.com AICPA.org ArchitecturalDigest.com BET.com BurlingtonCoatFactory.com CTShirts.com Chewy.com Christies.com CoastHotels.com Crocs.co.uk Epicurious.com TravelNow.com css-tricks.com Foxhead.com Garmin.com GQ.com iOffer.com Ivivva.com LHW.com Outrigger.com Patheos.com Perfumania.com SharperImage.com StellaDot.com Style.com Superdry.com TeenVogue.com TheKnot.com Theory.com 1035944 1 webkit-bug-importer 2014-09-18 10:01:00 -0700 <rdar://problem/18381757> 1037347 2 benjamin 2014-09-25 16:50:57 -0700 I just tried the minimal test case on iPhone 5 and iPhone 6 and I could not reproduce the bug. What am I missing? Note that the use case you describe seems to go against all the guidelines for efficient page loading. 1037356 3 justin 2014-09-25 17:32:07 -0700 (In reply to comment #2) > I just tried the minimal test case on iPhone 5 and iPhone 6 and I could not reproduce the bug. What am I missing? > > Note that the use case you describe seems to go against all the guidelines for efficient page loading. Thanks for taking a look at this! Unfortunately the attached test case was saved using `File -> Save Page As` and already includes the injected meta viewport as a consequence. Sorry about that. Here is a link to the same, but correct test case: https://dl.dropboxusercontent.com/u/76629/ios8_bug.html 1037357 4 238687 justin 2014-09-25 17:33:28 -0700 Created attachment 238687 Correct iOS 8.0 scroll bug minimal test case. Also attached here. 1037376 5 benjamin 2014-09-25 18:57:21 -0700 Ok, I can reproduce with this test case. 1038034 6 shawnjan 2014-09-29 13:31:40 -0700 Hi Benjamin, great that you were able to reproduce! That was about 4 days ago - has any movement been made on fixing the issue? 1038042 7 benjamin 2014-09-29 13:54:43 -0700 (In reply to comment #6) > Hi Benjamin, great that you were able to reproduce! That was about 4 days ago - has any movement been made on fixing the issue? No, I am working on CSS at the moment. From the information I have, this seems to be low priority. Adding the viewport meta tag after the first layout is considered bad practice because it creates so much overhead. 1038061 8 shawnjan 2014-09-29 14:25:24 -0700 I would agree that the way we dynamically load the meta tag is non-standard, but I don't think priority of tickets should be defined by whether or not they are "considered bad practice", it should be defined by the number of sites this is effecting, and how badly it is effecting them. Currently, there are over 1000 sites using our framework - many of which are some very notable brands. You can see them in the list above. As an aside, I would love to have a chat with you outside of this ticket about how our technology works and why we've taken the approach we've taken, in order to see if you think there is a better approach. It may seem like bad practice, but it's the best we've come up with based on the current limitations of the web :). At the end of the day, we rely on our technique, and the issue that has arisen in iOS8 is a regression. 1038079 9 benjamin 2014-09-29 15:13:53 -0700 (In reply to comment #8) > I would agree that the way we dynamically load the meta tag is non-standard, but I don't think priority of tickets should be defined by whether or not they are "considered bad practice", it should be defined by the number of sites this is effecting, and how badly it is effecting them. > > Currently, there are over 1000 sites using our framework - many of which are some very notable brands. You can see them in the list above. Certainly, the technical aspect is only a part of it. So far I have received a total of 2 reports about this particular bug. As you can imagine, typical high priority bugs get hundreds of radars. I also did not receive any feedback on this during the 4 months of beta which is usually a strong sign this is not important. I'll probably look at this bug in the coming weeks to understand what is going on, but from the data I have at this very moment, this is not a "drop everything and fix this" situation. I have other bug reports that seems to have higher value for users. > As an aside, I would love to have a chat with you outside of this ticket about how our technology works and why we've taken the approach we've taken, in order to see if you think there is a better approach. It may seem like bad practice, but it's the best we've come up with based on the current limitations of the web :). Yep, please email me. Best case we can extend the engine to accommodate your use case, worst case I fix this bug :) > At the end of the day, we rely on our technique, and the issue that has arisen in iOS8 is a regression. Yep, that is an unfortunate bug in iOS 8, and it needs to be fixed. 1038809 10 shawnjan 2014-10-02 01:18:53 -0700 (In reply to comment #9) > So far I have received a total of 2 reports about this particular bug. As you can imagine, typical high priority bugs get hundreds of radars. I also did not receive any feedback on this during the 4 months of beta which is usually a strong sign this is not important. > > I'll probably look at this bug in the coming weeks to understand what is going on, but from the data I have at this very moment, this is not a "drop everything and fix this" situation. I have other bug reports that seems to have higher value for users. Yep fair enough. One thing I'd point out is that many developers using our framework have come talked to us about the issue, and as well, we've reached out to them, so they may not have felt the need to file the bug themselves. But yesh, I would agree that scrolling down the page is not a "drop everything and fix", but I also wouldn't consider it low priority either :) It's a strange experience for the user. > Yep, please email me. Best case we can extend the engine to accommodate your use case, worst case I fix this bug :) Will do! Looking forward to the dialog :) 1039196 11 yoav 2014-10-03 05:14:45 -0700 Hi Benjamin, Do you think that the bug is in code that's in the public repo? Is there something I can do to help resolve the issue quicker? I've tried to reproduce the issue with the latest WebKit trunc, while enabling as much IOS code around viewport handling as I can, but didn't have much luck with that. 1039515 12 benjamin 2014-10-04 11:41:15 -0700 (In reply to comment #11) > Do you think that the bug is in code that's in the public repo? Is there something I can do to help resolve the issue quicker? > > I've tried to reproduce the issue with the latest WebKit trunc, while enabling as much IOS code around viewport handling as I can, but didn't have much luck with that. It is very likely in the public repository. The other option is a bug in UIKit. I don't think you'll be able to reproduce by enabling the viewport on OS X, there are too many differences. You may be able to find the issue by code inspection of viewport update code. 1063821 13 245263 benjamin 2015-01-23 17:00:30 -0800 Created attachment 245263 Patch 1125209 14 shawnjan 2015-09-11 10:20:55 -0700 Hey Benjamin, any chance this patch could drop for iOS9 or an early update? Our fix for the issue specifically targets iOS8, as we thought this issue would be fixed for iOS9. Please let me know so I can plan accordingly! Thx :) 1125280 15 benjamin 2015-09-11 15:40:43 -0700 (In reply to comment #14) > Hey Benjamin, any chance this patch could drop for iOS9 or an early update? > Our fix for the issue specifically targets iOS8, as we thought this issue > would be fixed for iOS9. Please let me know so I can plan accordingly! Thx :) Adding Zalan. Zalan finished the patch and it is fixed in WebKit trunk. BUT, IIRC, the fix had to be removed from iOS 9 because it caused problems. Zalan, do you remember what happened to the top-edge snapping on viewport update? 1126706 16 zalan 2015-09-17 09:19:31 -0700 (In reply to comment #15) > (In reply to comment #14) > > Hey Benjamin, any chance this patch could drop for iOS9 or an early update? > > Our fix for the issue specifically targets iOS8, as we thought this issue > > would be fixed for iOS9. Please let me know so I can plan accordingly! Thx :) > > Adding Zalan. > > Zalan finished the patch and it is fixed in WebKit trunk. BUT, IIRC, the fix > had to be removed from iOS 9 because it caused problems. > > Zalan, do you remember what happened to the top-edge snapping on viewport > update? The proposed patch caused regression and we rolled it out. 1126715 17 shawnjan 2015-09-17 09:56:55 -0700 Are there any plans to address the regression and get the patch in? 1126770 18 zalan 2015-09-17 11:50:43 -0700 (In reply to comment #15) > (In reply to comment #14) > > Hey Benjamin, any chance this patch could drop for iOS9 or an early update? > > Our fix for the issue specifically targets iOS8, as we thought this issue > > would be fixed for iOS9. Please let me know so I can plan accordingly! Thx :) > > Adding Zalan. Adding Tim. 1840148 19 bfulgham 2022-02-10 20:06:45 -0800 This is actually: <rdar://problem/18381757> 238279 2014-09-17 18:25:07 -0700 2015-01-23 13:02:59 -0800 Minimal test case ios8_bug.html text/html 2436 shawnjan PCFET0NUWVBFIGh0bWw+CjwhLS0gc2F2ZWQgZnJvbSB1cmw9KDAwNTUpaHR0cHM6Ly9kbC5kcm9w Ym94dXNlcmNvbnRlbnQuY29tL3UvNzY2MjkvaW9zOF9idWcuaHRtbCAtLT4KPGh0bWw+PGhlYWQ+ PG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJz ZXQ9VVRGLTgiPgogICAgPHNjcmlwdD4KICAgICAgICAvLyBUaGlzIHdvcmtzIGZpbmUuCiAgICAg ICAgLy8gZG9jdW1lbnQud3JpdGUoJzxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0 aD1kZXZpY2Utd2lkdGgiPicpOwoKICAgICAgICAvLyBDaGFuZ2luZyB0aGUgdmlld3BvcnQgaW4g YSBuZXcgZG9jdW1lbnQgKHVzaW5nIGRvY3VtZW50Lm9wZW4sIGRvY3VtZW50LndyaXRlLCBkb2N1 bWVudC5jbG9zZSkKICAgICAgICAvLyBvciBhZnRlciB0aGUgaW5pdGlhbCBwYWludCBjYXVzZXMg dGhlIFNhZmFyaSB0byBzY3JvbGwgZG93biB0aGUgcGFnZS4KICAgICAgICB3aW5kb3cucmVxdWVz dEFuaW1hdGlvbkZyYW1lKGZ1bmN0aW9uKCkgewogICAgICAgICAgICB2YXIgbWV0YSA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoJ21ldGEnKTsKICAgICAgICAgICAgbWV0YS5zZXRBdHRyaWJ1dGUo J25hbWUnLCAndmlld3BvcnQnKTsKICAgICAgICAgICAgbWV0YS5zZXRBdHRyaWJ1dGUoJ2NvbnRl bnQnLCAnd2lkdGg9ZGV2aWNlLXdpZHRoJyk7CiAgICAgICAgICAgIGRvY3VtZW50LmhlYWQuYXBw ZW5kQ2hpbGQobWV0YSk7CiAgICAgICAgfSk7CiAgICA8L3NjcmlwdD4KPG1ldGEgbmFtZT0idmll d3BvcnQiIGNvbnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCI+PC9oZWFkPgo8Ym9keT4KICAgIDxw PlBlbGxlbnRlc3F1ZSBoYWJpdGFudCBtb3JiaSB0cmlzdGlxdWUgc2VuZWN0dXMgZXQgbmV0dXMg ZXQgbWFsZXN1YWRhIGZhbWVzIGFjIHR1cnBpcyBlZ2VzdGFzLiBWZXN0aWJ1bHVtIHRvcnRvciBx dWFtLCBmZXVnaWF0IHZpdGFlLCB1bHRyaWNpZXMgZWdldCwgdGVtcG9yIHNpdCBhbWV0LCBhbnRl LiBEb25lYyBldSBsaWJlcm8gc2l0IGFtZXQgcXVhbSBlZ2VzdGFzIHNlbXBlci4gQWVuZWFuIHVs dHJpY2llcyBtaSB2aXRhZSBlc3QuIE1hdXJpcyBwbGFjZXJhdCBlbGVpZmVuZCBsZW8uIFF1aXNx dWUgc2l0IGFtZXQgZXN0IGV0IHNhcGllbiB1bGxhbWNvcnBlciBwaGFyZXRyYS4gVmVzdGlidWx1 bSBlcmF0IHdpc2ksIGNvbmRpbWVudHVtIHNlZCwgY29tbW9kbyB2aXRhZSwgb3JuYXJlIHNpdCBh bWV0LCB3aXNpLiBBZW5lYW4gZmVybWVudHVtLCBlbGl0IGVnZXQgdGluY2lkdW50IGNvbmRpbWVu dHVtLCBlcm9zIGlwc3VtIHJ1dHJ1bSBvcmNpLCBzYWdpdHRpcyB0ZW1wdXMgbGFjdXMgZW5pbSBh YyBkdWkuIERvbmVjIG5vbiBlbmltIGluIHR1cnBpcyBwdWx2aW5hciBmYWNpbGlzaXMuIFV0IGZl bGlzLiBQcmFlc2VudCBkYXBpYnVzLCBuZXF1ZSBpZCBjdXJzdXMgZmF1Y2lidXMsIHRvcnRvciBu ZXF1ZSBlZ2VzdGFzIGF1Z3VlLCBldSB2dWxwdXRhdGUgbWFnbmEgZXJvcyBldSBlcmF0LiBBbGlx dWFtIGVyYXQgdm9sdXRwYXQuIE5hbSBkdWkgbWksIHRpbmNpZHVudCBxdWlzLCBhY2N1bXNhbiBw b3J0dGl0b3IsIGZhY2lsaXNpcyBsdWN0dXMsIG1ldHVzPC9wPgoKICAgIDxwPlBlbGxlbnRlc3F1 ZSBoYWJpdGFudCBtb3JiaSB0cmlzdGlxdWUgc2VuZWN0dXMgZXQgbmV0dXMgZXQgbWFsZXN1YWRh IGZhbWVzIGFjIHR1cnBpcyBlZ2VzdGFzLiBWZXN0aWJ1bHVtIHRvcnRvciBxdWFtLCBmZXVnaWF0 IHZpdGFlLCB1bHRyaWNpZXMgZWdldCwgdGVtcG9yIHNpdCBhbWV0LCBhbnRlLiBEb25lYyBldSBs aWJlcm8gc2l0IGFtZXQgcXVhbSBlZ2VzdGFzIHNlbXBlci4gQWVuZWFuIHVsdHJpY2llcyBtaSB2 aXRhZSBlc3QuIE1hdXJpcyBwbGFjZXJhdCBlbGVpZmVuZCBsZW8uIFF1aXNxdWUgc2l0IGFtZXQg ZXN0IGV0IHNhcGllbiB1bGxhbWNvcnBlciBwaGFyZXRyYS4gVmVzdGlidWx1bSBlcmF0IHdpc2ks IGNvbmRpbWVudHVtIHNlZCwgY29tbW9kbyB2aXRhZSwgb3JuYXJlIHNpdCBhbWV0LCB3aXNpLiBB ZW5lYW4gZmVybWVudHVtLCBlbGl0IGVnZXQgdGluY2lkdW50IGNvbmRpbWVudHVtLCBlcm9zIGlw c3VtIHJ1dHJ1bSBvcmNpLCBzYWdpdHRpcyB0ZW1wdXMgbGFjdXMgZW5pbSBhYyBkdWkuIERvbmVj IG5vbiBlbmltIGluIHR1cnBpcyBwdWx2aW5hciBmYWNpbGlzaXMuIFV0IGZlbGlzLiBQcmFlc2Vu dCBkYXBpYnVzLCBuZXF1ZSBpZCBjdXJzdXMgZmF1Y2lidXMsIHRvcnRvciBuZXF1ZSBlZ2VzdGFz IGF1Z3VlLCBldSB2dWxwdXRhdGUgbWFnbmEgZXJvcyBldSBlcmF0LiBBbGlxdWFtIGVyYXQgdm9s dXRwYXQuIE5hbSBkdWkgbWksIHRpbmNpZHVudCBxdWlzLCBhY2N1bXNhbiBwb3J0dGl0b3IsIGZh Y2lsaXNpcyBsdWN0dXMsIG1ldHVzPC9wPgoKCjwvYm9keT48L2h0bWw+ 238687 2014-09-25 17:33:28 -0700 2014-09-25 17:33:28 -0700 Correct iOS 8.0 scroll bug minimal test case. ios8_bug.html text/html 2233 justin PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxzY3JpcHQ+CiAgICAgICAgLy8gVGhp cyB3b3JrcyBmaW5lLgogICAgICAgIC8vIGRvY3VtZW50LndyaXRlKCc8bWV0YSBuYW1lPSJ2aWV3 cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNlLXdpZHRoIj4nKTsKCiAgICAgICAgLy8gQ2hhbmdp bmcgdGhlIHZpZXdwb3J0IGluIGEgbmV3IGRvY3VtZW50ICh1c2luZyBkb2N1bWVudC5vcGVuLCBk b2N1bWVudC53cml0ZSwgZG9jdW1lbnQuY2xvc2UpCiAgICAgICAgLy8gb3IgYWZ0ZXIgdGhlIGlu aXRpYWwgcGFpbnQgY2F1c2VzIHRoZSBTYWZhcmkgdG8gc2Nyb2xsIGRvd24gdGhlIHBhZ2UuCiAg ICAgICAgd2luZG93LnJlcXVlc3RBbmltYXRpb25GcmFtZShmdW5jdGlvbigpIHsKICAgICAgICAg ICAgdmFyIG1ldGEgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdtZXRhJyk7CiAgICAgICAgICAg IG1ldGEuc2V0QXR0cmlidXRlKCduYW1lJywgJ3ZpZXdwb3J0Jyk7CiAgICAgICAgICAgIG1ldGEu c2V0QXR0cmlidXRlKCdjb250ZW50JywgJ3dpZHRoPWRldmljZS13aWR0aCcpOwogICAgICAgICAg ICBkb2N1bWVudC5oZWFkLmFwcGVuZENoaWxkKG1ldGEpOwogICAgICAgIH0pOwogICAgPC9zY3Jp cHQ+CjwvaGVhZD4KPGJvZHk+CiAgICA8cD5QZWxsZW50ZXNxdWUgaGFiaXRhbnQgbW9yYmkgdHJp c3RpcXVlIHNlbmVjdHVzIGV0IG5ldHVzIGV0IG1hbGVzdWFkYSBmYW1lcyBhYyB0dXJwaXMgZWdl c3Rhcy4gVmVzdGlidWx1bSB0b3J0b3IgcXVhbSwgZmV1Z2lhdCB2aXRhZSwgdWx0cmljaWVzIGVn ZXQsIHRlbXBvciBzaXQgYW1ldCwgYW50ZS4gRG9uZWMgZXUgbGliZXJvIHNpdCBhbWV0IHF1YW0g ZWdlc3RhcyBzZW1wZXIuIEFlbmVhbiB1bHRyaWNpZXMgbWkgdml0YWUgZXN0LiBNYXVyaXMgcGxh Y2VyYXQgZWxlaWZlbmQgbGVvLiBRdWlzcXVlIHNpdCBhbWV0IGVzdCBldCBzYXBpZW4gdWxsYW1j b3JwZXIgcGhhcmV0cmEuIFZlc3RpYnVsdW0gZXJhdCB3aXNpLCBjb25kaW1lbnR1bSBzZWQsIGNv bW1vZG8gdml0YWUsIG9ybmFyZSBzaXQgYW1ldCwgd2lzaS4gQWVuZWFuIGZlcm1lbnR1bSwgZWxp dCBlZ2V0IHRpbmNpZHVudCBjb25kaW1lbnR1bSwgZXJvcyBpcHN1bSBydXRydW0gb3JjaSwgc2Fn aXR0aXMgdGVtcHVzIGxhY3VzIGVuaW0gYWMgZHVpLiBEb25lYyBub24gZW5pbSBpbiB0dXJwaXMg cHVsdmluYXIgZmFjaWxpc2lzLiBVdCBmZWxpcy4gUHJhZXNlbnQgZGFwaWJ1cywgbmVxdWUgaWQg Y3Vyc3VzIGZhdWNpYnVzLCB0b3J0b3IgbmVxdWUgZWdlc3RhcyBhdWd1ZSwgZXUgdnVscHV0YXRl IG1hZ25hIGVyb3MgZXUgZXJhdC4gQWxpcXVhbSBlcmF0IHZvbHV0cGF0LiBOYW0gZHVpIG1pLCB0 aW5jaWR1bnQgcXVpcywgYWNjdW1zYW4gcG9ydHRpdG9yLCBmYWNpbGlzaXMgbHVjdHVzLCBtZXR1 czwvcD4KCiAgICA8cD5QZWxsZW50ZXNxdWUgaGFiaXRhbnQgbW9yYmkgdHJpc3RpcXVlIHNlbmVj dHVzIGV0IG5ldHVzIGV0IG1hbGVzdWFkYSBmYW1lcyBhYyB0dXJwaXMgZWdlc3Rhcy4gVmVzdGli dWx1bSB0b3J0b3IgcXVhbSwgZmV1Z2lhdCB2aXRhZSwgdWx0cmljaWVzIGVnZXQsIHRlbXBvciBz aXQgYW1ldCwgYW50ZS4gRG9uZWMgZXUgbGliZXJvIHNpdCBhbWV0IHF1YW0gZWdlc3RhcyBzZW1w ZXIuIEFlbmVhbiB1bHRyaWNpZXMgbWkgdml0YWUgZXN0LiBNYXVyaXMgcGxhY2VyYXQgZWxlaWZl bmQgbGVvLiBRdWlzcXVlIHNpdCBhbWV0IGVzdCBldCBzYXBpZW4gdWxsYW1jb3JwZXIgcGhhcmV0 cmEuIFZlc3RpYnVsdW0gZXJhdCB3aXNpLCBjb25kaW1lbnR1bSBzZWQsIGNvbW1vZG8gdml0YWUs IG9ybmFyZSBzaXQgYW1ldCwgd2lzaS4gQWVuZWFuIGZlcm1lbnR1bSwgZWxpdCBlZ2V0IHRpbmNp ZHVudCBjb25kaW1lbnR1bSwgZXJvcyBpcHN1bSBydXRydW0gb3JjaSwgc2FnaXR0aXMgdGVtcHVz IGxhY3VzIGVuaW0gYWMgZHVpLiBEb25lYyBub24gZW5pbSBpbiB0dXJwaXMgcHVsdmluYXIgZmFj aWxpc2lzLiBVdCBmZWxpcy4gUHJhZXNlbnQgZGFwaWJ1cywgbmVxdWUgaWQgY3Vyc3VzIGZhdWNp YnVzLCB0b3J0b3IgbmVxdWUgZWdlc3RhcyBhdWd1ZSwgZXUgdnVscHV0YXRlIG1hZ25hIGVyb3Mg ZXUgZXJhdC4gQWxpcXVhbSBlcmF0IHZvbHV0cGF0LiBOYW0gZHVpIG1pLCB0aW5jaWR1bnQgcXVp cywgYWNjdW1zYW4gcG9ydHRpdG9yLCBmYWNpbGlzaXMgbHVjdHVzLCBtZXR1czwvcD4KPC9ib2R5 Pgo8L2h0bWw+Cg== 245263 2015-01-23 17:00:30 -0800 2015-01-23 17:00:30 -0800 Patch bug-136904-20150123170030.patch text/plain 3160 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4Nzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzJkODgyNTYyODcyYjRh ZDNhYjhmNjA0MzhlNDIwZTNiNGNjY2I1Ni4uNWUyOWE2MmM1OGJmZTMyNzdmOTBjMzY3NWU1ODlj NWM2NWJmMDhhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAxLTIzICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIEFzIG9mIGlPUyA4 LjAgKDEyQTM2NSksIGFsbCBNb2JpZnkuanMgc2l0ZXMgdW5leHBlY3RlZGx5IHNjcm9sbCBkb3du IHRoZSBwYWdlIGFmdGVyIGxvYWQuIFNvbWV0aW1lcyB0aGlzIGhhcHBlbnMgb24gZmlyc3QgbG9h ZCwgYW5kIGhhcHBlbnMgYWxtb3N0IDEwMCUgb2YgdGhlIHRpbWUgYWZ0ZXIgbmF2aWdhdGluZyB0 byBhbm90aGVyIHBhZ2Ugb24gdGhlIHdlYnNpdGUgYnkgY2xpY2tpbmcgYSBsaW5rLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2OTA0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVUlTY3JvbGxWaWV3IHBy ZXNlcnZlIHRoZSBjZW50ZXIgb2YgdGhlIGRvY3VtZW50IGNlbnRlcmVkIHdoZW4gY2hhbmdpbmcK KyAgICAgICAgdGhlIHpvb20uIFdlIHNob3VsZCBtYWludGFpbiBvdXIgcG9saWN5IG9mIHN0aWNr IHRvIHRvcC9ib3R0b20uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9kaWRDb21taXRMYXllclRyZWU6XSk6CisKIDIw MTUtMDEtMjAgIE1hcnRpbiBIb2NrICA8bWhvY2tAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1Nd W1dLMl0gUmVkcmF3IGZpbmQtaW4tcGFnZSBpbmRpY2F0b3Igb24gcm90YXRpb24KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggODMyMDY5 NTA4NWU2OWU0MWQ4M2VkYjlmNjAyNWU5MmM4OWU5OGJiMi4uMWExNDIyOWJiMTlmN2M3MjI4MjJl OTQwYTA3NDE0NjJjNTg5Mjk0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTg4Nyw4ICs4ODcsMjMgQEAgc3RhdGljIGlubGluZSBi b29sIGFyZUVzc2VudGlhbGx5RXF1YWxBc0Zsb2F0KGZsb2F0IGEsIGZsb2F0IGIpCiAgICAgW19z Y3JvbGxWaWV3IHNldE1pbmltdW1ab29tU2NhbGU6bGF5ZXJUcmVlVHJhbnNhY3Rpb24ubWluaW11 bVNjYWxlRmFjdG9yKCldOwogICAgIFtfc2Nyb2xsVmlldyBzZXRNYXhpbXVtWm9vbVNjYWxlOmxh eWVyVHJlZVRyYW5zYWN0aW9uLm1heGltdW1TY2FsZUZhY3RvcigpXTsKICAgICBbX3Njcm9sbFZp ZXcgc2V0Wm9vbUVuYWJsZWQ6bGF5ZXJUcmVlVHJhbnNhY3Rpb24uYWxsb3dzVXNlclNjYWxpbmco KV07Ci0gICAgaWYgKCFsYXllclRyZWVUcmFuc2FjdGlvbi5zY2FsZVdhc1NldEJ5VUlQcm9jZXNz KCkgJiYgIVtfc2Nyb2xsVmlldyBpc1pvb21pbmddICYmICFbX3Njcm9sbFZpZXcgaXNab29tQm91 bmNpbmddICYmICFbX3Njcm9sbFZpZXcgX2lzQW5pbWF0aW5nWm9vbV0pCi0gICAgICAgIFtfc2Ny b2xsVmlldyBzZXRab29tU2NhbGU6bGF5ZXJUcmVlVHJhbnNhY3Rpb24ucGFnZVNjYWxlRmFjdG9y KCldOworICAgIGlmICghbGF5ZXJUcmVlVHJhbnNhY3Rpb24uc2NhbGVXYXNTZXRCeVVJUHJvY2Vz cygpICYmICFbX3Njcm9sbFZpZXcgaXNab29taW5nXSAmJiAhW19zY3JvbGxWaWV3IGlzWm9vbUJv dW5jaW5nXSAmJiAhW19zY3JvbGxWaWV3IF9pc0FuaW1hdGluZ1pvb21dKSB7CisgICAgICAgIGZs b2F0IG5ld1BhZ2VTY2FsZUZhY3RvciA9IGxheWVyVHJlZVRyYW5zYWN0aW9uLnBhZ2VTY2FsZUZh Y3RvcigpOworCisgICAgICAgIGlmIChhcmVFc3NlbnRpYWxseUVxdWFsQXNGbG9hdChjb250ZW50 Wm9vbVNjYWxlKHNlbGYpLCBuZXdQYWdlU2NhbGVGYWN0b3IpKSB7CisgICAgICAgICAgICAvLyBG SVhNRTogV2UgbmVlZCB0byBoYW5kbGUgc3RpY2sgdG8gYm90dG9tLgorICAgICAgICAgICAgLy8g RklYTUU6IFdlIG5lZWQgdG8gc3VwcG9ydCBwcm9ncmFtbWF0aWMgc2Nyb2xsLWFmdGVyLXZpZXdw b3J0IHVwZGF0ZS4KKyAgICAgICAgICAgIFdlYkNvcmU6OkZsb2F0UmVjdCBvbGRVbm9ic2N1cmVk Q29udGVudFJlY3QgPSBfcGFnZS0+dW5vYnNjdXJlZENvbnRlbnRSZWN0KCk7CisgICAgICAgICAg ICBpZiAob2xkVW5vYnNjdXJlZENvbnRlbnRSZWN0LnkoKSA8IDEpIHsKKyAgICAgICAgICAgICAg ICBDR0Zsb2F0IHJlbGF0aXZlSG9yaXpvbnRhbFBvc2l0aW9uID0gb2xkVW5vYnNjdXJlZENvbnRl bnRSZWN0LngoKSAvIG9sZFVub2JzY3VyZWRDb250ZW50UmVjdC53aWR0aCgpOworICAgICAgICAg ICAgICAgIENHUG9pbnQgbmV3VG9wTGVmdCA9IFtzZWxmIF9hZGp1c3RlZENvbnRlbnRPZmZzZXQ6 eyByZWxhdGl2ZUhvcml6b250YWxQb3NpdGlvbiAqIG5ld0NvbnRlbnRTaXplLndpZHRoLCAwIH1d OworICAgICAgICAgICAgICAgIENHUmVjdCBib3VuZHMgPSBbX3Njcm9sbFZpZXcgYm91bmRzXTsK KyAgICAgICAgICAgICAgICBDR1NpemUgcmVjdFRvWm9vbVNpemUgPSBDR1NpemVNYWtlKGJvdW5k cy5zaXplLndpZHRoICogbmV3UGFnZVNjYWxlRmFjdG9yLCBib3VuZHMuc2l6ZS5oZWlnaHQgKiBu ZXdQYWdlU2NhbGVGYWN0b3IpOworICAgICAgICAgICAgICAgIFtfc2Nyb2xsVmlldyB6b29tVG9S ZWN0OnsgbmV3VG9wTGVmdCwgcmVjdFRvWm9vbVNpemUgfSBhbmltYXRlZDpOT107CisgICAgICAg ICAgICB9IGVsc2UKKyAgICAgICAgICAgICAgICBbX3Njcm9sbFZpZXcgc2V0Wm9vbVNjYWxlOm5l d1BhZ2VTY2FsZUZhY3Rvcl07CisgICAgICAgIH0KKyAgICB9CiAKICAgICBbc2VsZiBfdXBkYXRl U2Nyb2xsVmlld0JhY2tncm91bmRdOwogCg==