136891 2014-09-17 09:01:10 -0700 [GTK] Fix runtime critical warnings when writing to the clipboard after r173687 2014-09-17 09:13:07 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned darin gustavo pnormand svillar oldest_to_newest 1035718 0 cgarcia 2014-09-17 09:01:10 -0700 TEST: bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor... (pid=4979) /webkit2/WebKitWebView/cut-copy-paste/non-editable: (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed OK /webkit2/WebKitWebView/cut-copy-paste/editable: (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed OK /webkit2/WebKitWebView/select-all/non-editable: (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed OK /webkit2/WebKitWebView/select-all/editable: (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed (WebKitWebProcess:4985): GLib-GObject-CRITICAL **: g_closure_ref: assertion 'closure != NULL' failed OK PASS: bin/TestWebKitAPI/WebKit2Gtk/TestWebViewEditor 1035719 1 238254 cgarcia 2014-09-17 09:03:52 -0700 Created attachment 238254 Patch 1035720 2 238254 pnormand 2014-09-17 09:07:49 -0700 Comment on attachment 238254 Patch LGTM! 1035722 3 cgarcia 2014-09-17 09:13:07 -0700 Committed r173692: <http://trac.webkit.org/changeset/173692> 238254 2014-09-17 09:03:52 -0700 2014-09-17 09:07:48 -0700 Patch wkcore-runtime-warnings.diff text/plain 1988 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyNTBiYjE3Li4zNTY2ZTI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMDktMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEZpeCBydW50aW1lIGNyaXRpY2FsIHdhcm5pbmdzIHdoZW4gd3Jp dGluZyB0byB0aGUgY2xpcGJvYXJkIGFmdGVyIHIxNzM2ODcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjg5MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRIZWxw ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFzdGVib2FyZEhlbHBlcjo6d3JpdGVDbGlwYm9h cmRDb250ZW50cyk6IENoZWNrIHBhc3NlZAorICAgICAgICBjYWxsYmFjayBpcyBub3QgbnVsbCBi ZWZvcmUgdHJ5aW5nIHRvIHJlZi91bnJlZiBpdCBzaW5jZQorICAgICAgICBnX2Nsb3N1cmVfcmVm L3VucmVmIGFyZSBub3QgbnVsbCBzYWZlLgorCiAyMDE0LTA5LTE2ICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBGaXggbGF5ZXJpbmcg dmlvbGF0aW9ucyBpbiBQYXN0ZWJvYXJkR3RrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvUGFzdGVib2FyZEhlbHBlci5jcHAKaW5kZXggMjg2OWQyNS4uNjg0NGE4MCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRIZWxwZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkSGVscGVyLmNwcApAQCAt MzExLDExICszMTEsMTIgQEAgdm9pZCBQYXN0ZWJvYXJkSGVscGVyOjp3cml0ZUNsaXBib2FyZENv bnRlbnRzKEd0a0NsaXBib2FyZCogY2xpcGJvYXJkLCBTbWFydFBhc3QKICAgICBpZiAobnVtYmVy T2ZUYXJnZXRzID4gMCAmJiB0YWJsZSkgewogICAgICAgICBzZXR0aW5nQ2xpcGJvYXJkRGF0YU9i amVjdCA9IGRhdGFPYmplY3Q7CiAKLSAgICAgICAgaWYgKGd0a19jbGlwYm9hcmRfc2V0X3dpdGhf ZGF0YShjbGlwYm9hcmQsIHRhYmxlLCBudW1iZXJPZlRhcmdldHMsIGdldENsaXBib2FyZENvbnRl bnRzQ2FsbGJhY2ssIGNsZWFyQ2xpcGJvYXJkQ29udGVudHNDYWxsYmFjaywgZ19jbG9zdXJlX3Jl ZihjYWxsYmFjaykpKQorICAgICAgICBpZiAoZ3RrX2NsaXBib2FyZF9zZXRfd2l0aF9kYXRhKGNs aXBib2FyZCwgdGFibGUsIG51bWJlck9mVGFyZ2V0cywgZ2V0Q2xpcGJvYXJkQ29udGVudHNDYWxs YmFjaywgY2xlYXJDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrLCBjYWxsYmFjayA/IGdfY2xvc3Vy ZV9yZWYoY2FsbGJhY2spIDogbnVsbHB0cikpCiAgICAgICAgICAgICBndGtfY2xpcGJvYXJkX3Nl dF9jYW5fc3RvcmUoY2xpcGJvYXJkLCBudWxscHRyLCAwKTsKICAgICAgICAgZWxzZSB7CiAgICAg ICAgICAgICAvLyBXaGVuIGd0a19jbGlwYm9hcmRfc2V0X3dpdGhfZGF0YSBmYWlscyB0aGUgY2Fs bGJhY2tzIGFyZSBpZ25vcmVkLCBzbyB3ZSBuZWVkIHRvIHJlbGVhc2UgdGhlIHJlZmVyZW5jZSB3 ZSB3ZXJlIHBhc3NpbmcgdG8gY2xlYXJDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrLgotICAgICAg ICAgICAgZ19jbG9zdXJlX3VucmVmKGNhbGxiYWNrKTsKKyAgICAgICAgICAgIGlmIChjYWxsYmFj aykKKyAgICAgICAgICAgICAgICBnX2Nsb3N1cmVfdW5yZWYoY2FsbGJhY2spOwogICAgICAgICB9 CiAKICAgICAgICAgc2V0dGluZ0NsaXBib2FyZERhdGFPYmplY3QgPSBudWxscHRyOwo=