136884 2014-09-17 03:36:34 -0700 Remove unused methods from MediaPlayerClient 2014-09-18 04:17:26 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 21562 1 cgarcia webkit-unassigned eric.carlson pnormand oldest_to_newest 1035697 0 cgarcia 2014-09-17 03:36:34 -0700 It seems that some of the methods that introduce dependencies on WebCore types are actually unused. 1035698 1 238247 cgarcia 2014-09-17 03:39:09 -0700 Created attachment 238247 Patch 1035748 2 238247 eric.carlson 2014-09-17 12:19:18 -0700 Comment on attachment 238247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238247&action=review > Source/WebCore/html/HTMLMediaElement.cpp:5664 > IntRect HTMLMediaElement::mediaPlayerWindowClipRect() > { > - return mediaPlayerOwningDocument()->view()->windowClipRect(); > + return document().view()->windowClipRect(); > } It looks like this can be removed from here and MediaPlayerClient, it isn't called by MediaPlayer. 1035897 3 cgarcia 2014-09-18 04:16:38 -0700 Committed r173719: <http://trac.webkit.org/changeset/173719> 1035898 4 cgarcia 2014-09-18 04:17:26 -0700 (In reply to comment #2) > (From update of attachment 238247 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=238247&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:5664 > > IntRect HTMLMediaElement::mediaPlayerWindowClipRect() > > { > > - return mediaPlayerOwningDocument()->view()->windowClipRect(); > > + return document().view()->windowClipRect(); > > } > > It looks like this can be removed from here and MediaPlayerClient, it isn't called by MediaPlayer. Right, removed it as well. Thanks for the review. 238247 2014-09-17 03:39:09 -0700 2014-09-17 12:19:18 -0700 Patch wcore-media-player-violations.diff text/plain 4641 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYmNlMDhmLi5hMzdlZTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDktMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgbWV0aG9kcyBmcm9tIE1lZGlhUGxheWVyQ2xpZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY4ODQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUg dW51c2VkIG1ldGhvZHMgZnJvbSBNZWRpYVBsYXllckNsaWVudCB0aGF0IGludHJvZHVjZQorICAg ICAgICBkZXBlbmRlbmNpZXMgb24gV2ViQ29yZSB0eXBlcy4KKworICAgICAgICAqIGh0bWwvSFRN TE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhUGxheWVyQ2xpZW50OjptZWRpYVBsYXllck93bmluZ0RvY3VtZW50KTogRGVsZXRl ZC4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyQ2xpZW50OjptZWRpYVBsYXllckhvc3RX aW5kb3cpOiBEZWxldGVkLgorCiAyMDE0LTA5LTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBNb3ZlIERyYWdDb250cm9sbGVyOjpjcmVhdGVG cmFnbWVudEZyb21EcmFnRGF0YSBpbXBsZW1lbnRhdGlvbiB0byB0aGUgZWRpdG9yCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCBjMGRkMjhiLi5iNTE3NzhkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTE4MTIsMTEgKzE4 MTIsNiBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmNhbmNlbFBlbmRpbmdFdmVudHNBbmRDYWxs YmFja3MoKQogICAgICAgICBzb3VyY2UuY2FuY2VsUGVuZGluZ0Vycm9yRXZlbnQoKTsKIH0KIAot RG9jdW1lbnQqIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhUGxheWVyT3duaW5nRG9jdW1lbnQoKQot ewotICAgIHJldHVybiAmZG9jdW1lbnQoKTsKLX0KLQogdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojpt ZWRpYVBsYXllck5ldHdvcmtTdGF0ZUNoYW5nZWQoTWVkaWFQbGF5ZXIqKQogewogICAgIGJlZ2lu UHJvY2Vzc2luZ01lZGlhUGxheWVyQ2FsbGJhY2soKTsKQEAgLTU2NjMsMTkgKzU2NTgsMTQgQEAg Ym9vbCBIVE1MTWVkaWFFbGVtZW50OjptZWRpYVBsYXllcklzTG9vcGluZygpIGNvbnN0CiAgICAg cmV0dXJuIGxvb3AoKTsKIH0KIAotSG9zdFdpbmRvdyogSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQ bGF5ZXJIb3N0V2luZG93KCkKLXsKLSAgICByZXR1cm4gbWVkaWFQbGF5ZXJPd25pbmdEb2N1bWVu dCgpLT52aWV3KCktPmhvc3RXaW5kb3coKTsKLX0KLQogSW50UmVjdCBIVE1MTWVkaWFFbGVtZW50 OjptZWRpYVBsYXllcldpbmRvd0NsaXBSZWN0KCkKIHsKLSAgICByZXR1cm4gbWVkaWFQbGF5ZXJP d25pbmdEb2N1bWVudCgpLT52aWV3KCktPndpbmRvd0NsaXBSZWN0KCk7CisgICAgcmV0dXJuIGRv Y3VtZW50KCkudmlldygpLT53aW5kb3dDbGlwUmVjdCgpOwogfQogCiBDYWNoZWRSZXNvdXJjZUxv YWRlciogSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJDYWNoZWRSZXNvdXJjZUxvYWRlcigp CiB7Ci0gICAgcmV0dXJuIG1lZGlhUGxheWVyT3duaW5nRG9jdW1lbnQoKS0+Y2FjaGVkUmVzb3Vy Y2VMb2FkZXIoKTsKKyAgICByZXR1cm4gZG9jdW1lbnQoKS5jYWNoZWRSZXNvdXJjZUxvYWRlcigp OwogfQogCiBib29sIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhUGxheWVyU2hvdWxkV2FpdEZvclJl c3BvbnNlVG9BdXRoZW50aWNhdGlvbkNoYWxsZW5nZShjb25zdCBBdXRoZW50aWNhdGlvbkNoYWxs ZW5nZSYgY2hhbGxlbmdlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVk aWFFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAppbmRl eCA0ODM0ODE0Li42OTkxMDcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQu aApAQCAtNTE0LDcgKzUxNCw2IEBAIHByaXZhdGU6CiAKICAgICBkb3VibGUgZWZmZWN0aXZlUGxh eWJhY2tSYXRlKCkgY29uc3Q7CiAKLSAgICB2aXJ0dWFsIERvY3VtZW50KiBtZWRpYVBsYXllck93 bmluZ0RvY3VtZW50KCkgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2b2lkIG1lZGlhUGxheWVyTmV0 d29ya1N0YXRlQ2hhbmdlZChNZWRpYVBsYXllciopIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9p ZCBtZWRpYVBsYXllclJlYWR5U3RhdGVDaGFuZ2VkKE1lZGlhUGxheWVyKikgb3ZlcnJpZGU7CiAg ICAgdmlydHVhbCB2b2lkIG1lZGlhUGxheWVyVGltZUNoYW5nZWQoTWVkaWFQbGF5ZXIqKSBvdmVy cmlkZTsKQEAgLTU3MCw3ICs1NjksNiBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgYm9vbCBtZWRp YVBsYXllclBsYXRmb3JtVm9sdW1lQ29uZmlndXJhdGlvblJlcXVpcmVkKCkgY29uc3Qgb3ZlcnJp ZGU7CiAgICAgdmlydHVhbCBib29sIG1lZGlhUGxheWVySXNQYXVzZWQoKSBjb25zdCBvdmVycmlk ZTsKICAgICB2aXJ0dWFsIGJvb2wgbWVkaWFQbGF5ZXJJc0xvb3BpbmcoKSBjb25zdCBvdmVycmlk ZTsKLSAgICB2aXJ0dWFsIEhvc3RXaW5kb3cqIG1lZGlhUGxheWVySG9zdFdpbmRvdygpIG92ZXJy aWRlOwogICAgIHZpcnR1YWwgSW50UmVjdCBtZWRpYVBsYXllcldpbmRvd0NsaXBSZWN0KCkgb3Zl cnJpZGU7CiAgICAgdmlydHVhbCBDYWNoZWRSZXNvdXJjZUxvYWRlciogbWVkaWFQbGF5ZXJDYWNo ZWRSZXNvdXJjZUxvYWRlcigpIG92ZXJyaWRlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaAppbmRleCA1Y2U3NTE0Li43M2JhZTg0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmgKQEAgLTcwLDcg KzcwLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBBdWRpb1NvdXJjZVByb3ZpZGVy OwogY2xhc3MgQXV0aGVudGljYXRpb25DaGFsbGVuZ2U7Ci1jbGFzcyBEb2N1bWVudDsKICNpZiBF TkFCTEUoTUVESUFfU09VUkNFKQogY2xhc3MgTWVkaWFTb3VyY2VQcml2YXRlQ2xpZW50OwogI2Vu ZGlmCkBAIC0xMzMsNyArMTMyLDYgQEAgY2xhc3MgQ29udGVudFR5cGU7CiBjbGFzcyBGcmFtZVZp ZXc7CiBjbGFzcyBHcmFwaGljc0NvbnRleHQ7CiBjbGFzcyBHcmFwaGljc0NvbnRleHQzRDsKLWNs YXNzIEhvc3RXaW5kb3c7CiBjbGFzcyBJbnRSZWN0OwogY2xhc3MgSW50U2l6ZTsKIGNsYXNzIE1l ZGlhUGxheWVyOwpAQCAtMTUwLDkgKzE0OCw2IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgfk1l ZGlhUGxheWVyQ2xpZW50KCkgeyB9CiAKLSAgICAvLyBHZXQgdGhlIGRvY3VtZW50IHdoaWNoIHRo ZSBtZWRpYSBwbGF5ZXIgaXMgb3duZWQgYnkKLSAgICB2aXJ0dWFsIERvY3VtZW50KiBtZWRpYVBs YXllck93bmluZ0RvY3VtZW50KCkgeyByZXR1cm4gMDsgfQotCiAgICAgLy8gdGhlIG5ldHdvcmsg c3RhdGUgaGFzIGNoYW5nZWQKICAgICB2aXJ0dWFsIHZvaWQgbWVkaWFQbGF5ZXJOZXR3b3JrU3Rh dGVDaGFuZ2VkKE1lZGlhUGxheWVyKikgeyB9CiAKQEAgLTI0NCw3ICsyMzksNiBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCBib29sIG1lZGlhUGxheWVyUGxhdGZvcm1Wb2x1bWVDb25maWd1cmF0aW9u UmVxdWlyZWQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1YWwgYm9vbCBtZWRp YVBsYXllcklzUGF1c2VkKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogICAgIHZpcnR1YWwgYm9v bCBtZWRpYVBsYXllcklzTG9vcGluZygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAgdmly dHVhbCBIb3N0V2luZG93KiBtZWRpYVBsYXllckhvc3RXaW5kb3coKSB7IHJldHVybiAwOyB9CiAg ICAgdmlydHVhbCBJbnRSZWN0IG1lZGlhUGxheWVyV2luZG93Q2xpcFJlY3QoKSB7IHJldHVybiBJ bnRSZWN0KCk7IH0KICAgICB2aXJ0dWFsIENhY2hlZFJlc291cmNlTG9hZGVyKiBtZWRpYVBsYXll ckNhY2hlZFJlc291cmNlTG9hZGVyKCkgeyByZXR1cm4gMDsgfQogICAgIHZpcnR1YWwgYm9vbCBk b2VzSGF2ZUF0dHJpYnV0ZShjb25zdCBBdG9taWNTdHJpbmcmLCBBdG9taWNTdHJpbmcqID0gMCkg Y29uc3QgeyByZXR1cm4gZmFsc2U7IH0K